Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update data association in object merger #1001

Merged

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented May 31, 2022

Description

Update object merger

  • delete the overlapped unknown object with the classified object.
  • prioritize classified objects over unknown objects.
  • update data association. It is referenced by multi-object tracker

before : There are two overlapped buses.
Peek 2022-06-23 19-30

after :
Peek 2022-06-24 01-15

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yukkysaito yukkysaito force-pushed the feature/update_object_merger branch 3 times, most recently from 14137f0 to 31262ec Compare May 31, 2022 17:18
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1001 (b381f1c) into main (efe5915) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1001      +/-   ##
========================================
- Coverage   9.14%   9.10%   -0.05%     
========================================
  Files       1036    1039       +3     
  Lines      70676   71024     +348     
  Branches   14776   14776              
========================================
- Hits        6466    6465       -1     
- Misses     58634   58982     +348     
- Partials    5576    5577       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.12% <0.00%> (-0.01%) ⬇️ Carriedforward from 970c134

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/detection_by_tracker/src/utils.cpp 0.00% <0.00%> (ø)
...erception/multi_object_tracker/src/utils/utils.cpp 0.00% <0.00%> (ø)
...ation_merger/data_association/data_association.hpp 0.00% <ø> (ø)
...association/solver/mu_successive_shortest_path.hpp 0.00% <0.00%> (ø)
...ation_merger/data_association/data_association.cpp 0.00% <0.00%> (ø)
...rtest_path/mu_successive_shortest_path_wrapper.cpp 0.00% <0.00%> (ø)
...cessive_shortest_path/successive_shortest_path.cpp 0.00% <0.00%> (ø)
...ject_merger/src/object_association_merger/node.cpp 0.00% <0.00%> (ø)
...rger/src/object_association_merger/utils/utils.cpp 0.00% <0.00%> (ø)
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe5915...b381f1c. Read the comment docs.

@yukke42 yukke42 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 2, 2022
@yukkysaito yukkysaito force-pushed the feature/update_object_merger branch 2 times, most recently from ff6ba6a to 2b9a825 Compare June 4, 2022 15:38
YoheiMishina pushed a commit to YoheiMishina/autoware.universe that referenced this pull request Jun 9, 2022
* release v0.4.0

* add resolution param in lanelet2_extension (autowarefoundation#760)

* Fix/extend drivable area beyond goal (autowarefoundation#781)

* update llt2 extention query func

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* extend drivable area over goal point

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* apply clang

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* update get preeceeding func

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* update preceeding func in lanechange

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* update comment

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Fix intersection preceeding lane query (autowarefoundation#807)

* modified interseciton module to add lanelets in intersection to objective lanelets due to change in getPreceedingLaneletSequences()

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update comment

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Install executables in lanelet2_map_preprocessor (autowarefoundation#834)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 3290a8b.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* port map_tf_generator (autowarefoundation#32)

* port map_tf_generator

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add missing dependency

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix pointor, tf_broadcaster, add compile option

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use ament_auto

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Port lanelet2 extension (autowarefoundation#36)

* remove COLCON_IGNORE

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* port to ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* minor fix

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix CI

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove unnecessary semi-colon

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix library to executable for lanelet2_extension_sample and autoware_lanelet2_validation

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix usage for ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix usage message and parameter declaration

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix getting map_file parameter

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port map loader (autowarefoundation#44)

* port map_loader to ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix unintended change

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Update map/map_loader/CMakeLists.txt

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Add geometry2 to repos (autowarefoundation#76)

* add geometry2 package temporarily until new release

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* trigger-ci

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add tf2 dependency to the packages that use tf2_geometry_msgs

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "Add geometry2 to repos (autowarefoundation#76)" (autowarefoundation#96)

* Revert "Add geometry2 to repos (autowarefoundation#76)"

This reverts commit 7dbe25e.

* Re-add tf2 dependencies

* Revert "Re-add tf2 dependencies"

This reverts commit e23b0c8b0826cf9518924d33349f9de34b4975df.

* Debug CI pipeline

* Revert "Debug CI pipeline"

This reverts commit 58f1eba550360d82c08230552abfb64b33b23e0f.

* Explicitly install known versions of the geometry packages

* No need to skip tf2 packages anymore

Co-authored-by: Esteve Fernandez <esteve@apache.org>

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* fixing trasient_local in ROS2 packages (autowarefoundation#160)

* added linters to lanelet1_extension (autowarefoundation#170)

* adding linters to map_loader (autowarefoundation#171)

* adding linters to map_tf_generator (autowarefoundation#172)

* apply env_var to  use_sim_time (autowarefoundation#222)

* Ros2 v0.8.0 map loader and lanelet2 extension (autowarefoundation#279)

* Ros2 v0.8 fix typo of "preceding" (autowarefoundation#323)

* Fix typo of getPrecedingLaneletSequences

* Fix comment

* Fix rviz2 low FPS (autowarefoundation#390)

* add nullptr check when publish concatenate data (autowarefoundation#369)

* Add warning msg when concat pointcloud is not published (autowarefoundation#388)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change lineString2Marker

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Change trafficLight2TriangleMarker

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Change laneletDirectionAsMarker

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove debug code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix linter problems

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* [map_loader] modify colors for lane markers for better visualization (autowarefoundation#398)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix empty marker (autowarefoundation#423)

* Fix typo in map module (autowarefoundation#437)

* add license (autowarefoundation#443)

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* avoid pushing empty marker (autowarefoundation#441)

* avoid pushing empty marker

* size0 -> empty

* add use_sim-time option (autowarefoundation#454)

* Sync public repo (autowarefoundation#1228)

* [simple_planning_simulator] add readme (autowarefoundation#424)

* add readme of simple_planning_simulator

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update simulator/simple_planning_simulator/README.md

* set transit_margin_time to intersect. planner (autowarefoundation#460)

* Fix pose2twist (autowarefoundation#462)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Ros2 vehicle info param server (autowarefoundation#447)

* add vehicle_info_param_server

* update vehicle info

* apply format

* fix bug

* skip unnecessary search

* delete vehicle param file

* fix bug

* Ros2 fix topic name part2 (autowarefoundation#425)

* Fix topic name of traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of traffic_light_visualization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of traffic_light_map_based_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_recognition

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix issues in hdd_reader (autowarefoundation#466)

* Fix some issues detected by Coverity Scan and Clang-Tidy

* Update launch command

* Add more `close(new_sock)`

* Simplify the definitions of struct

* fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463)

* Rviz overlay render fix (autowarefoundation#461)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* uncrustified

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* back to RTD as superclass

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* Rviz overlay render in update (autowarefoundation#465)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* uncrustified

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* removed unnecessary includes and some dead code

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* Adepted remaining vehicle plugin classes to render-in-update concept. Returned to MFD superclass

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* restored RTD superclass

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>

* Revert "fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463)" (autowarefoundation#1229)

This reverts commit d2ecdfe4c58cb4544c9a3ee84947b36b7ee54421.

* add pcd file check (autowarefoundation#1232)

* add pcd file check

* add space

* add &

* use namespace

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Map components (autowarefoundation#1311)

* Make pointcloud map loader component

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Make lanelet2 map loader component

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Make map tf generator component

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Rename parameter for lanelet2 map path

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix license

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add comment for filesystem

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix variable name for glob

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix dependency for query (autowarefoundation#1519)

* Fix a small bug (autowarefoundation#1644)

* Fix minor flaws detected by Clang-Tidy (autowarefoundation#1647)

- misc-throw-by-value-catch-by-reference
- cppcoreguidelines-init-variables
- readability-isolate-declaration

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Porting traffic light viz (autowarefoundation#1284)

* Feature/traffic light viz (autowarefoundation#1001)

* add tl map viz

* bug fix

* update map visualizer

* add launch

* add install in cmake

* remove unused file

* fix build error

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix topic name and qos

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Replace deprecated duration api

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add markdownlint and prettier (autowarefoundation#1661)

* Add markdownlint and prettier

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Feature/compare elevation map (autowarefoundation#1488)

* suppress warnings for declare parameters (autowarefoundation#1724)

* fix for lanelet2_extension

* fix for traffic light ssd fine detector

* fix for topic_state_monitor

* fix for dummy diag publisher

* fix for remote cmd converter

* fix for vehicle_info_util

* fix for multi object tracker

* fix for freespace planner

* fix for autoware_error_monitor

* add Werror for multi object tracker

* fix for multi object tracker

* add Werror for liraffic light ssd fine detector

* add Werror for topic state monitor

* add Werror

* add Werror

* add Werror

* add Werror

* fix style

* suppress warnings for map (autowarefoundation#1773)

* add compile option

* fix error

* add compile option

* add maybe unused

* fix sign-compare

* delete unused

* add parentheses

* fix for uncrusify

* Fix typo

* use U

* use U

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix clang warnings (autowarefoundation#1859)

* Fix -Wreturn-std-move

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore -Wnonportable-include-path for mussp

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix -Wunused-const-variable

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix "can not be used when making a shared object"

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync v1.3.0 (autowarefoundation#1909)

* Add elevation_map to autoware_state_monitor (autowarefoundation#1907)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Disable saving elevation map temporarily (autowarefoundation#1906)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Fix typos in README of map_loader (autowarefoundation#1923)

* Fix typos in README of map_loader

* Apply Prettier

* fix some typos (autowarefoundation#1941)

* fix some typos

* fix typo

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add autoware api (autowarefoundation#1979)

* Invoke code formatter at pre-commit (autowarefoundation#1935)

* Run ament_uncrustify at pre-commit

* Reformat existing files
* Fix copyright and cpplint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Save elevation_map with pcd md5sum (autowarefoundation#1988)

* Save elevation_map with pcd md5sum

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update sample launch

* Fix cpplint

* Use hash-library instead of openssl

* Use call by reference

* Apply format

* Set CMAKE_CXX_STANDARD 17

* Save input_pcd.json and shorten directory name when loading multiple pcd

* Remove erasing last _

* Modify concatenating file path

* Apply Format

* Add hash_library_vendor to build_depends.repos

* Modify include way

* Change function and variable names

* Use return

* Remove unnecessary input variable

* Use unique_ptr

* Rename digestMd5 to digest_md5

* Modify variable name

* Remove file.close()

* Use hash of json

* Read hash of json directory

* Add newline to package.xml

* Add isPcdFile

* Fix pre-commit

* Use icPcdFile when giving file of pcd

* Feature/add virtual traffic light planner (autowarefoundation#1588)

* Fix deprecated constant of transient local (autowarefoundation#1994)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint errors in lanelet2_extension (autowarefoundation#2028)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Revert "[map_loader] modify colors for lane markers for better visualization (autowarefoundation#398)" (autowarefoundation#2063)

This reverts commit 046dc9a.

* Fix elevation_map_loader downsample (autowarefoundation#2055)

* Add elevation_map data dir (autowarefoundation#2093)

* Minor fixes of map_loader's README (autowarefoundation#2116)

* Minor fixes of map_loader's README

* Fix map_loader run command

Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>

* Fix elevation_map hash due to mutiple slashes of pcd path (autowarefoundation#2192)

* Fix elevation_map hash due to mutiple slashes of pcd path

* Use filesystem lexically_normal

* Fix broken links of images on lanelet2_extension docs (autowarefoundation#2206)

* Add lanelet XML API (autowarefoundation#2262)

* show traffic light id marker (autowarefoundation#1554) (autowarefoundation#1678)

* show traffic light id

* fix typo

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* Feature/porting behavior path planner (autowarefoundation#1645)

* Add behavior path planner pkg with Lane Change (autowarefoundation#1525)

* add lanelet extension funcs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add planning msgs for FOA

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add behavior_path_planner pkg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* apply clang format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add error handling for config load failure

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace word: foa with remote control

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add readme

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* use pointer for return value of path

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix hz

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove debug print

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove shide-shift & avoidance related files

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Clip path by goal

* add build depend for behavior tree cpp

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* temporally disable lint test in lanelet2_extension

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: rej55 <rej55.g@gmail.com>

* Add avoidance module in behavior_path_planner (autowarefoundation#1528)

* Revert "remove shide-shift & avoidance related files"

This reverts commit d819ea0291fca251012e4b9ffd16de3896830aa2.

* refactor findNewShiftPoint func

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove duplicated decleration

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix barkward length issue
 - add clipPathLenght func in avoidance

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* refactor:
 - translate english
 - minor modification for traffic distance

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* support debug marker in behavior_path_planner

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* clean up side shift module

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change topic name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove japanese

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/include/behavior_path_planner/scene_module/side_shift/side_shift_module.hpp

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove unused var

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* adress reviewer comments:
 - add const for variables
 - add comment
 - fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix typo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Replace behavior_path utilities with autoware_utils (autowarefoundation#1532)

* replace calcDistance

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace arange

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replave convertToEigenPt with autoware_utils::fromMsg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* replace normalizeRadian

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* cosmetic change

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* import autowarefoundation#1526 into behavior path planner (autowarefoundation#1531)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix/behavior path empty path output guard (autowarefoundation#1536)

* add guard

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/behavior_path_planner.cpp

* fix lateral jerk calculation (autowarefoundation#1549)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix: error handling on exception in behavior_path_planner (autowarefoundation#1551)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix ignore too steep avoidance path (autowarefoundation#1550)

* ignore too steep path

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

* parametrize lateral jerk limit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* use offsetNoThrow and add error log (autowarefoundation#1615)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Ignore object ahead goal for avoidance (autowarefoundation#1618)

* Ignore object ahead goal for avoidance

* Add flag

* Fix position of definition of goal_pose

* Fix arclength calculation

* Fix position of definition of goal_pose

* fix intersection stop line (autowarefoundation#1636)

* fix intersection stop line

* fix typo

* add document (autowarefoundation#1635)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Port behavior path planner to ros2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix map qos

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* debug slope calculation in behavior (autowarefoundation#1566)

* update

* update

* revert change of autoware_utils

* define getPose in behavior_path_planner

* update

* update

* update

* update

* interpolate z in obstacle_avoidance_planner

* update velocity controller

* fix detection area and scene

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/utilities.cpp

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* update comment in velocity controller

* remove debug print

* update

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Address review: Fix config file name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* pre-commit fixes

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix redeclaring parameters

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add missing tf2 geometry function

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix rclcpp Time initialization

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use now() instead of msg stamp

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use throttle output in getExpandedLanelet

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add missing const

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: rej55 <rej55.g@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

* change type of traffic light marker (SPHERE_LIST->SPHERE) (autowarefoundation#1789)

* fix alpha (autowarefoundation#1797)

* Feature/improve intersection detection area (autowarefoundation#1958)

* exclude ego_lanes from detection_area

* add empty handling

* remove unused function

* Fix for uncrustify

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Apply format (autowarefoundation#1999)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Fix cpplint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Feature/expand drivable area (autowarefoundation#1812)

* check if ego lane has adjacent lane or not

* expand drivable area by using lanelet

* remove unnecessary operator

* use extra drivable area

* fix variable names

* fix indent

* get polygon by id

* fix variable name

* remove redundant logic

* update area name

* disable expand by default

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* add shoulder road lanelets (autowarefoundation#2121)

* add shoulder lanelets

* Update map/lanelet2_extension/lib/query.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update map/lanelet2_extension/lib/visualization.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update map/lanelet2_extension/include/lanelet2_extension/visualization/visualization.hpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update map/lanelet2_extension/include/lanelet2_extension/visualization/visualization.hpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update map/lanelet2_extension/lib/visualization.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Feature/no stopping area reg element (autowarefoundation#2144)

* add no stopping area to ll2

* add no stopping area visualization

* add no stopping area marker to RVIZ

* make no stopping area stop line as optional

* Update map/map_loader/src/lanelet2_map_loader/lanelet2_map_visualization_node.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Add document for new map format (autowarefoundation#1778)

* add roadside lane doc

* fix typo

* fix typo

* fix typo

* fix typo

* Add markdown lint

* add reason for new subtype definition

* fix typo

Co-authored-by: kyoichi <kyoichi.sugahara@tier4.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port lanelet2_extension (autowarefoundation#483)

* port with auto_msgs

* remove COLCON_IGNORE

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* port map loader (autowarefoundation#508)

* remove COLCON_IGNORE in system_packages and map_tf_generator (autowarefoundation#532)

* add readme (autowarefoundation#561)

* fix old description

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: isamu-takagi <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>
Co-authored-by: rej55 <rej55.g@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com>
Co-authored-by: kyoichi <kyoichi.sugahara@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
YoheiMishina added a commit to YoheiMishina/autoware.universe that referenced this pull request Jun 9, 2022
* release v0.4.0

* fixed bug (autowarefoundation#717)

* Add nodelets of tlr nodes (autowarefoundation#715)

* Add classifier nodelet

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Replace boost::shared_ptr into std::shared_ptr

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Add lock guard

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Add detetcor nodelet

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Integrate main into node

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Add SubscriberStatusCallback

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* add image_transport_decompresser nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Add visualizer nodelet

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fixed bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Fix plugin name

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Launch nodelet

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Fix classifier constructor

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* add decompresser node

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix typo

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fixed bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fixed bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add param

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Fix build warning

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* change rgb

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change rgb

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit e884716313c52a9392fe58f3e6a1c95e7515725e.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Port traffic light visualization (autowarefoundation#121)

* Port

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Fix package.xml

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Removed unused mutex

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* support traffic_light_state in traffi_light_visualization (autowarefoundation#1115) (autowarefoundation#339)

* support traffic_light_state in traffi_light_visualization

* support unsynced detection and classification result

* apply clang-format

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* add use_sim-time option (autowarefoundation#454)

* Sync public repo (autowarefoundation#1228)

* [simple_planning_simulator] add readme (autowarefoundation#424)

* add readme of simple_planning_simulator

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update simulator/simple_planning_simulator/README.md

* set transit_margin_time to intersect. planner (autowarefoundation#460)

* Fix pose2twist (autowarefoundation#462)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Ros2 vehicle info param server (autowarefoundation#447)

* add vehicle_info_param_server

* update vehicle info

* apply format

* fix bug

* skip unnecessary search

* delete vehicle param file

* fix bug

* Ros2 fix topic name part2 (autowarefoundation#425)

* Fix topic name of traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of traffic_light_visualization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix topic name of traffic_light_map_based_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_recognition

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_classifier

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix lint traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix issues in hdd_reader (autowarefoundation#466)

* Fix some issues detected by Coverity Scan and Clang-Tidy

* Update launch command

* Add more `close(new_sock)`

* Simplify the definitions of struct

* fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463)

* Rviz overlay render fix (autowarefoundation#461)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* uncrustified

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* back to RTD as superclass

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* Rviz overlay render in update (autowarefoundation#465)

* Moved painiting in SteeringAngle plugin to update()

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* super class now back to MFD

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* uncrustified

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* acquire data in mutex

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* removed unnecessary includes and some dead code

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* Adepted remaining vehicle plugin classes to render-in-update concept. Returned to MFD superclass

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

* restored RTD superclass

Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use sensor data qos for traffic light recognition (autowarefoundation#1440)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Porting traffic light viz (autowarefoundation#1284)

* Feature/traffic light viz (autowarefoundation#1001)

* add tl map viz

* bug fix

* update map visualizer

* add launch

* add install in cmake

* remove unused file

* fix build error

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix typo

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix topic name and qos

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Replace deprecated duration api

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* suppress warnings for traffic light classifier (autowarefoundation#1762)

* add Werror

* fix type

* fix unused

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [traffic_light_visualization] support autoware auto msgs  (autowarefoundation#517)

* doc traffic light visualizer (autowarefoundation#628)

* add readme

* run pre-commit

* add purpose

* fix typo

* run pre-commit

* remove reference

* update descriptions

* Update traffic light topic name (autowarefoundation#729)

* Update traffic light topic name

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Update traffic light topic name in perception

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com>
Co-authored-by: Shinnosuke Hirakawa <8327162+0x126@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com>
Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
@yukkysaito yukkysaito force-pushed the feature/update_object_merger branch from 7b2acbc to 2d5326a Compare June 23, 2022 02:01
yukkysaito and others added 6 commits June 24, 2022 00:03
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito force-pushed the feature/update_object_merger branch from 2d5326a to b7e239a Compare June 23, 2022 15:07
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito marked this pull request as ready for review June 23, 2022 16:25
@yukkysaito
Copy link
Contributor Author

yukkysaito commented Jun 28, 2022

@miursh pls review this PR

@miursh
Copy link
Contributor

miursh commented Jun 29, 2022

@yukkysaito There are some copied source code added. I don't think It is a really good idea to create a copy of the codes. Is there any reason why you should do this?

@yukkysaito
Copy link
Contributor Author

yukkysaito commented Jun 29, 2022

@miursh

There are some copied source code added. I don't think It is a really good idea to create a copy of the codes. Is there any reason why you should do this?

You are right.
I am planning to make a common library in another PR.
But to make the common library, it takes some time since we need to write test codes

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM
Just one question

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito enabled auto-merge (squash) June 30, 2022 05:32
@yukkysaito yukkysaito merged commit ce6ccec into autowarefoundation:main Jun 30, 2022
takayuki5168 referenced this pull request in tier4/autoware.universe Jul 4, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168 referenced this pull request in tier4/autoware.universe Jul 8, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* bug fix

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* backup

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* ci(pre-commit): autofix

* cosmetic change

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* add parameters

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 29, 2023
…ing_fusion_for_far_radar_detection

chore(tier4_perception_launch): use tracking fusion for far radar detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants