Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): make debug.cpp #1773

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 2, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

create debug.cpp for common debug functions.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1773 (9030724) into main (6075e60) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
- Coverage   10.38%   10.32%   -0.07%     
==========================================
  Files        1212     1213       +1     
  Lines       87407    88518    +1111     
  Branches    20282    21103     +821     
==========================================
+ Hits         9080     9139      +59     
- Misses      68846    69808     +962     
- Partials     9481     9571      +90     
Flag Coverage Δ *Carryforward flag
differential 4.29% <0.00%> (?)
total 10.37% <0.00%> (ø) Carriedforward from 22359b1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/include/scene_module/blind_spot/scene.hpp 0.00% <ø> (ø)
...city_planner/src/scene_module/blind_spot/debug.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/detection_area/debug.cpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/no_stopping_area/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/occlusion_spot/debug.cpp 0.00% <0.00%> (ø)
...ehavior_velocity_planner/src/utilization/debug.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/utilization/path_utilization.cpp 18.91% <ø> (ø)
...city_planner/include/utilization/state_machine.hpp 37.93% <0.00%> (-12.07%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3
Copy link
Contributor

@takayuki5168
can you fix this?
image

@taikitanaka3
Copy link
Contributor

for other debug markers LGTM
image
image
image

createPathMarkerArray(debug_data_.path_raw, "path_raw", lane_id_, 0.0, 1.0, 1.0),
&debug_marker_array, current_time);
debug::createPathMarkerArray(
debug_data_.path_raw, "path_raw", lane_id_, now, 0.3, 0.0, 0.0, 0.0, 1.0, 1.0),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takayuki5168
this will cause scale error in rviz please consider this value same as intersection.

Suggested change
debug_data_.path_raw, "path_raw", lane_id_, now, 0.3, 0.0, 0.0, 0.0, 1.0, 1.0),
debug_data_.path_raw, "path_raw", lane_id_, now, 0.6, 0.3, 0.3, 0.0, 1.0, 1.0),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22359b1
DONE

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@taikitanaka3
Copy link
Contributor

@takayuki5168
is this PR ready?

@takayuki5168
Copy link
Contributor Author

@taikitanaka3 Sorry, yes!

…/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
@taikitanaka3
Copy link
Contributor

I found this fix is necessary for generateBlindSpotPolygons L 472

image

  if (!lane_ids.empty()) {
    lane_ids.pop_back();
  }

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:
fix blindspot lane ids

@taikitanaka3 taikitanaka3 merged commit 34bf3ba into autowarefoundation:main Sep 9, 2022
@taikitanaka3 taikitanaka3 deleted the feat/common-behavior-vel-debug branch September 9, 2022 05:33
voltonomous pushed a commit to vautonomous/autoware.universe that referenced this pull request Sep 11, 2022
)

* feat(behavior_velocity_planner): make debug.cpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
)

* feat(behavior_velocity_planner): make debug.cpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

* feat(behavior_velocity_planner): make debug.cpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
)

* feat(behavior_velocity_planner): make debug.cpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
)

* feat(behavior_velocity_planner): make debug.cpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
soblin pushed a commit to soblin/autoware.universe that referenced this pull request Dec 22, 2022
)

* feat(behavior_velocity_planner): make debug.cpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants