-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): make debug.cpp #1773
feat(behavior_velocity_planner): make debug.cpp #1773
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 10.38% 10.32% -0.07%
==========================================
Files 1212 1213 +1
Lines 87407 88518 +1111
Branches 20282 21103 +821
==========================================
+ Hits 9080 9139 +59
- Misses 68846 69808 +962
- Partials 9481 9571 +90
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@takayuki5168 |
createPathMarkerArray(debug_data_.path_raw, "path_raw", lane_id_, 0.0, 1.0, 1.0), | ||
&debug_marker_array, current_time); | ||
debug::createPathMarkerArray( | ||
debug_data_.path_raw, "path_raw", lane_id_, now, 0.3, 0.0, 0.0, 0.0, 1.0, 1.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takayuki5168
this will cause scale error in rviz please consider this value same as intersection.
debug_data_.path_raw, "path_raw", lane_id_, now, 0.3, 0.0, 0.0, 0.0, 1.0, 1.0), | |
debug_data_.path_raw, "path_raw", lane_id_, now, 0.6, 0.3, 0.3, 0.0, 1.0, 1.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22359b1
DONE
@takayuki5168 |
@taikitanaka3 Sorry, yes! |
planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp
Outdated
Show resolved
Hide resolved
…/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO:
fix blindspot lane ids
) * feat(behavior_velocity_planner): make debug.cpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
) * feat(behavior_velocity_planner): make debug.cpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
) * feat(behavior_velocity_planner): make debug.cpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
) * feat(behavior_velocity_planner): make debug.cpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
) * feat(behavior_velocity_planner): make debug.cpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
) * feat(behavior_velocity_planner): make debug.cpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/src/scene_module/blind_spot/debug.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
create debug.cpp for common debug functions.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.