refactor(detected_object_validation): apply util functions defined in the other packages

[ktro2828]

Description

Refactor some parts of package.

• add sturct for parameter named FilterTargetLabel in utils.hpp 23e455b
• apply perception_utils::isCarLikeVehicle() function b595ae2
• apply tier4_autoware_utils::toPolygon2d() function ebf40b8

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 10.78% // Head: 10.76% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (577ce2a) compared to base (272f8a2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
- Coverage   10.78%   10.76%   -0.02%     
==========================================
  Files        1179     1179              
  Lines       84449    84553     +104     
  Branches    19795    19795              
==========================================
  Hits         9104     9104              
- Misses      65853    65957     +104     
  Partials     9492     9492              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.76% <0.00%> (ø)		Carriedforward from 272f8a2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ed_object_validation/src/object_lanelet_filter.cpp	0.00% <0.00%> (ø)
...d_object_validation/src/object_position_filter.cpp	0.00% <0.00%> (ø)
...dation/src/obstacle_pointcloud_based_validator.cpp	0.00% <0.00%> (ø)
..._validation/src/occupancy_grid_based_validator.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[scepter914]

Thank you for well-written refactoring PR.
I just pointed out a bit, so would you confirm these?

[ktro2828]

Updated to divide validation operation in ObjectPositionFilterNode into a method such as ObjectLaneletFilterNode's isPolygonOnverlapLanelets() with b317b81

[scepter914]

LGTM

[yukkysaito]

LGM

[Shin-kyoto]

@ktro2828

1. src/utils.cpp is not written here, so src/utils.cpp is not built and runtime error occurs.
   

   autoware.universe/perception/detected_object_validation/CMakeLists.txt

   Lines 58 to 64 in a197560

   	ament_auto_add_library(object_lanelet_filter SHARED
   	src/object_lanelet_filter.cpp
   	)
   	ament_auto_add_library(object_position_filter SHARED
   	src/object_position_filter.cpp
   	)

2. This is wrong. #include <autoware_auto_perception_msgs/msg/ObjectClassification.hpp> should be #include <autoware_auto_perception_msgs/msg/object_classification.hpp>

autoware.universe/perception/detected_object_validation/src/utils.cpp

Line 17 in a197560

#include <autoware_auto_perception_msgs/msg/ObjectClassification.hpp>

https://github.com/tier4/autoware_auto_msgs/blob/tier4/main/autoware_auto_perception_msgs/msg/ObjectClassification.idl