Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_fusion_to_detected_object): refactor radar_fusion_to_detected_object #1440

Conversation

scepter914
Copy link
Contributor

Description

Refactor radar_fusion_to_detected_object

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@scepter914 scepter914 requested review from yukkysaito and miursh July 27, 2022 03:08
scepter914 and others added 4 commits July 27, 2022 12:12
…etected_object

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the refactor/radar_fusion_to_detected_object branch from 9e1c33e to b77b310 Compare July 27, 2022 03:12
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1440 (b77b310) into main (5fafe9b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
- Coverage   10.12%   10.11%   -0.02%     
==========================================
  Files        1118     1118              
  Lines       77393    77493     +100     
  Branches    17990    17990              
==========================================
  Hits         7835     7835              
- Misses      62095    62195     +100     
  Partials     7463     7463              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.10% <0.00%> (ø) Carriedforward from 5fafe9b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...object/include/radar_fusion_to_detected_object.hpp 0.00% <ø> (ø)
...ted_object/src/radar_fusion_to_detected_object.cpp 0.00% <0.00%> (ø)
...de/radar_object_fusion_to_detected_object_node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fafe9b...b77b310. Read the comment docs.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 04f3575 into autowarefoundation:main Jul 27, 2022
@scepter914 scepter914 deleted the refactor/radar_fusion_to_detected_object branch July 27, 2022 04:32
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…etected_object (tier4#1440)

* refactor(radar_fusion_to_detected_object): refactor radar_fusion_to_detected_object

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix document

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…etected_object (tier4#1440)

* refactor(radar_fusion_to_detected_object): refactor radar_fusion_to_detected_object

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix document

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…etected_object (tier4#1440)

* refactor(radar_fusion_to_detected_object): refactor radar_fusion_to_detected_object

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix document

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…etected_object (autowarefoundation#1440)

* refactor(radar_fusion_to_detected_object): refactor radar_fusion_to_detected_object

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix document

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…etected_object (tier4#1440)

* refactor(radar_fusion_to_detected_object): refactor radar_fusion_to_detected_object

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix document

Signed-off-by: scepter914 <scepter914@gmail.com>

* refactor

Signed-off-by: scepter914 <scepter914@gmail.com>

* ci(pre-commit): autofix

Signed-off-by: scepter914 <scepter914@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants