Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(behavior_planning): use acceleration from localization module #1859

Merged
merged 2 commits into from
Sep 14, 2022
Merged

feat(behavior_planning): use acceleration from localization module #1859

merged 2 commits into from
Sep 14, 2022

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 14, 2022 •
edited
Loading

Description

  • update following module to use acceleration from localization module

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota force-pushed the feat/use-acceleration-from-localization-module branch from aec125b to b398093 Compare September 14, 2022 04:01
@satoshi-ota satoshi-ota mentioned this pull request Sep 14, 2022
Merged
8 tasks
@satoshi-ota satoshi-ota force-pushed the feat/use-acceleration-from-localization-module branch 4 times, most recently from a4f99ea to 0688e0d Compare September 14, 2022 04:16
@codecov
Copy link

codecov bot commented Sep 14, 2022 •
edited
Loading

Codecov Report

Base: 10.42% // Head: 10.36% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (af35a75) compared to base (cf4ae72).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   10.42%   10.36%   -0.07%     
==========================================
  Files        1226     1226              
  Lines       87951    88481     +530     
  Branches    20463    20833     +370     
==========================================
+ Hits         9171     9173       +2     
- Misses      69276    69734     +458     
- Partials     9504     9574      +70
Flag Coverage Δ *Carryforward flag
differential 2.76% <0.00%> (?)
total 10.41% <0.00%> (ø) Carriedforward from cf4ae72

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.32% <0.00%> (+0.10%) ⬆️
...include/behavior_velocity_planner/planner_data.hpp 0.00% <ø> (ø)
...y_planner/include/utilization/trajectory_utils.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.58% <0.00%> (+0.16%) ⬆️
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...module/no_stopping_area/scene_no_stopping_area.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota
Copy link
Contributor Author

@TakaHoribe
This PR : 791/823
Baseline : 791/823

@satoshi-ota satoshi-ota marked this pull request as ready for review September 14, 2022 06:46
@satoshi-ota satoshi-ota marked this pull request as draft September 14, 2022 06:47
@satoshi-ota
feat(behavior_path_planner): subscribe acceleration from localization…
da0232f 
… module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
feat(behavior_velocity_planner): subscribe acceleration from localiza…
af35a75 
…tion module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/use-acceleration-from-localization-module branch from 0688e0d to af35a75 Compare September 14, 2022 06:48
@satoshi-ota satoshi-ota marked this pull request as ready for review September 14, 2022 06:48
TakaHoribe
TakaHoribe approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taikitanaka3
taikitanaka3 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@satoshi-ota
can you link autoware_launcher's PR?

@satoshi-ota
Copy link
Contributor Author

@taikitanaka3 @TakaHoribe

yukkysaito
yukkysaito approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) September 14, 2022 07:25
@satoshi-ota satoshi-ota merged commit 595ee30 into autowarefoundation:main Sep 14, 2022
@satoshi-ota satoshi-ota deleted the feat/use-acceleration-from-localization-module branch September 14, 2022 22:08
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 15, 2022
Merged
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
@satoshi-ota @boyali
feat(behavior_planning): use acceleration from localization module (a…
1a009c9 
…utowarefoundation#1859)

* feat(behavior_path_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(behavior_velocity_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
@satoshi-ota @boyali
feat(behavior_planning): use acceleration from localization module (a…
a6d06eb 
…utowarefoundation#1859)

* feat(behavior_path_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(behavior_velocity_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
@satoshi-ota @boyali
feat(behavior_planning): use acceleration from localization module (a…
f896848 
…utowarefoundation#1859)

* feat(behavior_path_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(behavior_velocity_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
@satoshi-ota @boyali
feat(behavior_planning): use acceleration from localization module (a…
41c5476 
…utowarefoundation#1859)

* feat(behavior_path_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(behavior_velocity_planner): subscribe acceleration from localization module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@scepter914 scepter914 Awaiting requested review from scepter914

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satoshi-ota @yukkysaito @TakaHoribe @taikitanaka3