Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(probabilistic_occupancy_grid): transfer probabilistic_occupancy_grid package from sensing to perception directory #1923

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Sep 21, 2022

Description

Transfer a package from sensing/ directory to perception directory.
See disscussion in #583.

  • No need to change message name and folders
  • Verified with rosbag sample simulation

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi requested a review from yukkysaito as a code owner September 21, 2022 07:21
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 10.41% // Head: 10.23% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (fd594dc) compared to base (d707d2b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
- Coverage   10.41%   10.23%   -0.19%     
==========================================
  Files        1169     1154      -15     
  Lines       83517    82420    -1097     
  Branches    19552    19049     -503     
==========================================
- Hits         8700     8433     -267     
+ Misses      65312    64865     -447     
+ Partials     9505     9122     -383     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.27% <ø> (-0.13%) ⬇️ Carriedforward from d226a11

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...bilistic_occupancy_grid_map/include/cost_value.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...an_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <ø> (ø)
...ud_based_occupancy_grid_map/occupancy_grid_map.cpp 0.00% <ø> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
.../behavior_path_planner/src/turn_signal_decider.cpp 0.00% <0.00%> (-40.97%) ⬇️
...lude/behavior_path_planner/turn_signal_decider.hpp 0.00% <0.00%> (-25.00%) ⬇️
...signal_processing/test/src/lowpass_filter_test.cpp 25.71% <0.00%> (-10.29%) ⬇️
... and 117 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r enabled auto-merge (squash) September 27, 2022 08:30
@mitsudome-r
Copy link
Member

DCO must be resolved before merging. (I could be due to me clicking updating branch button in PR.)

@YoshiRi YoshiRi changed the title Transfer probabilistic_occupancy_grid package from sensing to perception directory refactor: transfer probabilistic_occupancy_grid package from sensing to perception directory Sep 27, 2022
Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
auto-merge was automatically disabled September 27, 2022 10:09

Head branch was pushed to by a user without write access

@YoshiRi YoshiRi force-pushed the transfer-occupancy_grid_map branch from 6a0791f to 4f2f711 Compare September 27, 2022 10:09
Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
…ware.universe into transfer-occupancy_grid_map
@YoshiRi YoshiRi changed the title refactor: transfer probabilistic_occupancy_grid package from sensing to perception directory refactor(probabilistic_occupancy_grid): transfer probabilistic_occupancy_grid package from sensing to perception directory Oct 4, 2022
@miursh miursh enabled auto-merge (squash) October 7, 2022 01:29
@miursh miursh merged commit aa90138 into autowarefoundation:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants