Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(system_monitor/hdd_monitor): rename structs and functions #2144

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Oct 24, 2022

Description

Split from #2142.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake kenji-miyake marked this pull request as ready for review October 24, 2022 23:32
@kenji-miyake kenji-miyake requested a review from ito-san as a code owner October 24, 2022 23:32
@kenji-miyake
Copy link
Contributor Author

  440 |       info.error_code_ = get_ata_SmartData(fd, &info, hdd_device);
      |                          ^~~~~~~~~~~~~~~~~
      |                          get_ata_smart_data

Sorry, there was a mistake. I'll fix it.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kenji Miyake added 2 commits October 25, 2022 08:54
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake enabled auto-merge (squash) October 24, 2022 23:55
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 10.75% // Head: 10.71% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (99eeb78) compared to base (3a4845c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   10.75%   10.71%   -0.04%     
==========================================
  Files        1186     1186              
  Lines       84749    85038     +289     
  Branches    19825    19825              
==========================================
  Hits         9114     9114              
- Misses      66125    66414     +289     
  Partials     9510     9510              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.73% <0.00%> (ø) Carriedforward from 3a4845c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/lidar_apollo_instance_segmentation/cluster2d.hpp 0.00% <ø> (ø)
...dar_apollo_instance_segmentation/src/cluster2d.cpp 0.00% <0.00%> (ø)
...m/system_monitor/include/hdd_reader/hdd_reader.hpp 0.00% <0.00%> (ø)
...include/system_monitor/hdd_monitor/hdd_monitor.hpp 0.00% <0.00%> (ø)
...em/system_monitor/reader/hdd_reader/hdd_reader.cpp 0.00% <0.00%> (ø)
...tem/system_monitor/src/hdd_monitor/hdd_monitor.cpp 0.00% <0.00%> (ø)
...tem/system_monitor/src/net_monitor/net_monitor.cpp 0.00% <0.00%> (ø)
system/system_monitor/src/net_monitor/nl80211.cpp 0.00% <0.00%> (ø)
...em_monitor/src/voltage_monitor/voltage_monitor.cpp 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake kenji-miyake merged commit 253b5b9 into main Oct 25, 2022
@kenji-miyake kenji-miyake deleted the refactor-hdd-monitor branch October 25, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants