Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(planning_debug_tools): rename wlid with with_lane_id #2121

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Oct 20, 2022

Description

To fix spell-check.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenji-miyake
Copy link
Contributor Author

Sorry, refactor would be better for the type. I'll fix it.

@kenji-miyake kenji-miyake changed the title fix(planning_debug_tools): rename wlid with with_lane_id refactor(planning_debug_tools): rename wlid with with_lane_id Oct 20, 2022
@kenji-miyake kenji-miyake enabled auto-merge (squash) October 20, 2022 07:25
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 10.76% // Head: 10.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (61c8bbe) compared to base (206bcdb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   10.76%   10.76%   -0.01%     
==========================================
  Files        1182     1182              
  Lines       84550    84561      +11     
  Branches    19825    19825              
==========================================
  Hits         9104     9104              
- Misses      65825    65836      +11     
  Partials     9621     9621              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.74% <0.00%> (ø) Carriedforward from 206bcdb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/planning_debug_tools/trajectory_analyzer.hpp 0.00% <ø> (ø)
...g/planning_debug_tools/src/trajectory_analyzer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake kenji-miyake merged commit 15d0e83 into main Oct 20, 2022
@kenji-miyake kenji-miyake deleted the rename-parameter branch October 20, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants