-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity): fixed missing initialization in merge_from_private module #1644
fix(behavior_velocity): fixed missing initialization in merge_from_private module #1644
Conversation
…ivate module Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
- Coverage 10.68% 10.39% -0.29%
==========================================
Files 1109 1103 -6
Lines 78629 74664 -3965
Branches 18592 19781 +1189
==========================================
- Hits 8398 7765 -633
+ Misses 61318 58125 -3193
+ Partials 8913 8774 -139
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ivate module (tier4#1644) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ivate module (tier4#1644) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ivate module (tier4#1644) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ivate module (tier4#1644) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ivate module (autowarefoundation#1644) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…trol-evaluator-to-v4.0.0 feat(control_evaluator): cherry pick/control evaluator to v4.0.0
Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp
Description
Some of the parameters were not initialized in merge_from_private module.
Tests performed
Checked if the specified parameters are used.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.