Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception_util): refactor moving unnamed namespace from include file to src file #2028

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Oct 6, 2022

Description

Move unnamed namespace from include file to src file, which is reviewed by #1954 (comment).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 changed the title Refactor/perception util namespace refactor(perception_util): refactor moving unnamed namespace from include file to src file Oct 6, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the refactor/perception_util_namespace branch from 374f58f to d4aa0fd Compare October 6, 2022 05:18
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 10.42% // Head: 10.39% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (c689587) compared to base (d707d2b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   10.42%   10.39%   -0.03%     
==========================================
  Files        1169     1167       -2     
  Lines       83517    83573      +56     
  Branches    19552    19549       -3     
==========================================
- Hits         8705     8690      -15     
- Misses      65308    65381      +73     
+ Partials     9504     9502       -2     
Flag Coverage Δ *Carryforward flag
differential 5.86% <ø> (?)
total 10.41% <ø> (+<0.01%) ⬆️ Carriedforward from 61f3767

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
...autoware_utils/test/src/geometry/test_geometry.cpp 42.87% <0.00%> (-0.47%) ⬇️
...include/tier4_autoware_utils/geometry/geometry.hpp 95.62% <0.00%> (-0.19%) ⬇️
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <0.00%> (ø)
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.hpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% <0.00%> (ø)
...include/obstacle_avoidance_planner/utils/utils.hpp 0.00% <0.00%> (ø)
...lugin_autogen/UVLADIE3JM/moc_rtc_manager_panel.cpp 0.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

scepter914 and others added 2 commits October 6, 2022 15:44
@scepter914 scepter914 merged commit b48b4f5 into autowarefoundation:main Oct 8, 2022
@scepter914 scepter914 deleted the refactor/perception_util_namespace branch October 8, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants