-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception_util): refactor moving unnamed namespace from include file to src file #2028
refactor(perception_util): refactor moving unnamed namespace from include file to src file #2028
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
374f58f
to
d4aa0fd
Compare
Codecov ReportBase: 10.42% // Head: 10.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
- Coverage 10.42% 10.39% -0.03%
==========================================
Files 1169 1167 -2
Lines 83517 83573 +56
Branches 19552 19549 -3
==========================================
- Hits 8705 8690 -15
- Misses 65308 65381 +73
+ Partials 9504 9502 -2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: scepter914 <scepter914@gmail.com>
Description
Move unnamed namespace from include file to src file, which is reviewed by #1954 (comment).
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.