Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(localization packages, etc): modify maintainer and e-mail address #1661

Merged
merged 8 commits into from
Aug 23, 2022
Merged

chore(localization packages, etc): modify maintainer and e-mail address #1661

merged 8 commits into from
Aug 23, 2022

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Aug 23, 2022 •
edited by kenji-miyake
Loading

Description

modify maintainer and e-mail address

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kenji-miyake
kenji-miyake approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 😄

@kenji-miyake
Copy link
Contributor

Related: #1619

@kenji-miyake kenji-miyake enabled auto-merge (squash) August 23, 2022 01:43
@wat-r
Copy link

wat-r commented Aug 23, 2022

Thank you for taking over the maintainer!

kminoda
kminoda approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #1661 (50797d3) into main (50797d3) will not change coverage.
The diff coverage is n/a.

❗ Current head 50797d3 differs from pull request most recent head 01d1dd9. Consider uploading reports for the commit 01d1dd9 to get more accurate results

@@           Coverage Diff           @@
##             main    #1661   +/-   ##
=======================================
  Coverage   10.67%   10.67%           
=======================================
  Files        1106     1106           
  Lines       78580    78580           
  Branches    18640    18640           
=======================================
  Hits         8387     8387           
  Misses      61278    61278           
  Partials     8915     8915
Flag Coverage Δ
total 10.65% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YamatoAndo
Copy link
Contributor Author

@kminoda I have added you to the maintaior of ekf_localizer 😄

YamatoAndo and others added 8 commits August 23, 2022 14:28
@YamatoAndo
chore(localization packages, etc): modify maintainer and e-mail address
afec99e 
Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
@YamatoAndo
remove indent
86d696a 
Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
@YamatoAndo
add authors
1a8aaf4 
Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
@YamatoAndo @yukkysaito
Update localization/ekf_localizer/package.xml
9c4d12b 
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
@YamatoAndo @kminoda
Update localization/localization_error_monitor/package.xml
2c871a7 
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
@YamatoAndo
fix name
765c40b 
Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
@YamatoAndo
add author
de8f52b 
Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
@YamatoAndo
add author
01d1dd9 
Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
@YamatoAndo YamatoAndo force-pushed the chore/modify-maintainer branch from d156d46 to 01d1dd9 Compare August 23, 2022 05:28
@kenji-miyake kenji-miyake disabled auto-merge August 23, 2022 06:06
@kenji-miyake kenji-miyake merged commit aed77f9 into autowarefoundation:main Aug 23, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Aug 24, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@YamatoAndo @yukkysaito
@kminoda @boyali
chore(localization packages, etc): modify maintainer and e-mail addre…
9534878 
…ss (tier4#1661)

* chore(localization packages, etc): modify maintainer and e-mail address

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* remove indent

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add authors

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* Update localization/ekf_localizer/package.xml

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update localization/localization_error_monitor/package.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* fix name

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@YamatoAndo @yukkysaito
@kminoda @boyali
chore(localization packages, etc): modify maintainer and e-mail addre…
e831452 
…ss (tier4#1661)

* chore(localization packages, etc): modify maintainer and e-mail address

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* remove indent

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add authors

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* Update localization/ekf_localizer/package.xml

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update localization/localization_error_monitor/package.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* fix name

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@YamatoAndo @yukkysaito
@kminoda @boyali
chore(localization packages, etc): modify maintainer and e-mail addre…
90c205d 
…ss (tier4#1661)

* chore(localization packages, etc): modify maintainer and e-mail address

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* remove indent

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add authors

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* Update localization/ekf_localizer/package.xml

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update localization/localization_error_monitor/package.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* fix name

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@YamatoAndo @yukkysaito @kminoda
chore(localization packages, etc): modify maintainer and e-mail addre…
8bfcd2b 
…ss (autowarefoundation#1661)

* chore(localization packages, etc): modify maintainer and e-mail address

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* remove indent

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add authors

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* Update localization/ekf_localizer/package.xml

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update localization/localization_error_monitor/package.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* fix name

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@YamatoAndo @yukkysaito
@kminoda @boyali
chore(localization packages, etc): modify maintainer and e-mail addre…
caba43f 
…ss (tier4#1661)

* chore(localization packages, etc): modify maintainer and e-mail address

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* remove indent

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add authors

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* Update localization/ekf_localizer/package.xml

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update localization/localization_error_monitor/package.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* fix name

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* add author

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminoda kminoda kminoda approved these changes

@yukkysaito yukkysaito yukkysaito left review comments

@kenji-miyake kenji-miyake kenji-miyake approved these changes

@taichiH taichiH Awaiting requested review from taichiH

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YamatoAndo @kenji-miyake @wat-r @yukkysaito @kminoda