[pull] main from chromium:main #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://chromium.googlesource.com/openscreen.git/+log/040084e9d194..8620ec89411d 2021-12-14 jophba@chromium.org [Infra] Update Mac OSX version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1085650,chromium:1269913 Tbr: jophba@chromium.org Change-Id: I12f8aaec93a67f8f58447e7764793e2e076d7555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337090 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951374}
This is a reland of c8494f8 The reland updates the lacros toolchain to https://reviews.llvm.org/D115015 so that CFI works with C++17 there too now. Original change's description: > Enable C++17 on linux (including in CFI builds) > > The prerequisite rolled in in > https://chromium-review.googlesource.com/c/chromium/src/+/3315436 > > With this, all platforms use -std=c++17. > Please don't rely on that yet though: > - it's not yet clear that this is going to stick > - we'll send out guidelines on how we'll adopt C++17 features > > Bug: 1273966,752720 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng > Change-Id: Icda9a95b159b8ae6fd1f74095fea7913343d210a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308459 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948345} Bug: 1273966,752720,1276731 Change-Id: Iaf61c355a0a183905c34d14dfb22d034b01807ea Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: luci.chrome.try:lacros-amd64-generic-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316556 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951375}
https://chromium.googlesource.com/angle/angle.git/+log/1fc9b7c6e0e4..42bd4fc29aea 2021-12-14 johncunningham@apple.com Metal: add ANGLE_metal_create_context_ownership_identity. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I8d5b1cb66dfaf55672719f5ae1dd91cbf6d24ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337360 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951376}
This also moves the CustomExtensionProvider. There are no functional changes in this CL. This CL is part of the effort to disentangle the chrome/browser/extension/api directories. Bug: 883570 Change-Id: I4e575f07d3052eb188aac405f8bc4d5b54c829e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315108 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#951377}
On Windows, we should parse the temporal SVC stream to get temproalID, instead of relying on an external state machine. This CL aims to increase code robustness. Bug: 1203743 Change-Id: I6925a71f4a4b3d27db2d14082918446cdf1114a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314901 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#951378}
Bug: b:172340451 Test: tsc compiles Test: tast run <ip> camera.CCAUISmoke* camera.CCAUIStress* camera.CCAUIDocumentScanning* Change-Id: Ic5a6735f86405fe5a5ca84f73ea463404f59c331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295290 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951379}
This CL replaces deprecated RegisterDeprecatedMessageCallback method with RegisterMessageCallback. In order to comply with the signature it replaces base::ListValue* parameter with base::ConstListView. Bug: 1243386 Change-Id: I64907ce9bca60874c1e79c166a9af60252da9a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327847 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/main@{#951380}
https://swiftshader.googlesource.com/SwiftShader.git/+log/1eee6cbcf034..f354daff5a2b 2021-12-14 swiftshader.regress@gmail.com Regres: Update test lists @ 1eee6cbc 2021-12-13 srisser@google.com Regres updates deqp.json before updating testlists If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:201453797 Tbr: swiftshader-eng+autoroll@google.com Change-Id: I3262882ba0d76d1040d245bd3c46278c387c24e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337091 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951381}
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/48bb7e7474f0..738cc02fc3be $ git log 48bb7e747..738cc02fc --date=short --no-merges --format='%ad %ae %s' 2021-11-30 jthies typecd: Send notification on invalid dp cable 2021-11-18 genechang system_api: rmad: Add proto for state transition in sensor calibration 2021-11-21 charleszhao hps: Add average filter and tristate. Created with: roll-dep src/third_party/cros_system_api Bug: 206145370 Change-Id: I8c8263ddc8ea0527f1af698eda5a34ade9e71778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331438 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Jameson Thies <jthies@google.com> Commit-Queue: Jameson Thies <jthies@google.com> Cr-Commit-Position: refs/heads/main@{#951382}
…pps."" This reverts commit 1bc19c7. Reason for revert: Causing test failures of: DesksTemplatesClientArcTest.NativeUILaunchTemplateWithArcApp https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/26838/overview Original change's description: > Reland "desk_templates: Add a browsertest for launching ARC apps." > > This is a reland of 1e46619 > > Original change's description: > > desk_templates: Add a browsertest for launching ARC apps. > > > > While adding, saw two crashses, one regarding the app icon size and the > > other with the cpu usage. > > > > I cleared the first one by adding test resources for 28 and 56 dp. In > > desks templates, we show a preview that consists of app icons of size > > 28, so the test tries to fetch those sizes. > > > > The second one was handled by clearing the probe service when stopping > > CPU usage count. > > > > Test: added > > Change-Id: Ib60961913e992df8f08be0311099c20e88e745ee > > Fixed: 1251403 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319378 > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Jeremy Chinsen <chinsenj@chromium.org> > > Reviewed-by: Yury Khmel <khmel@chromium.org> > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#950300} > > Change-Id: I446bf159aeb345588dde2b681104a70ac239385b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331655 > Reviewed-by: Jeremy Chinsen <chinsenj@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951287} Change-Id: I03569dcd47c9248e2bc23d13747d56764eb489ed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336810 Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Owners-Override: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951383}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28fd42027961..df7c46c625a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: Ib89cf4361501f8a9e9da068add75d9a8a404f778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337356 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951384}
Dark (before): http://shortn/_oI5doTtfs5 Dark (after): http://shortn/_hDuoO2kd38 Light (before): http://shortn/_qDc05ppr9W Light (after): http://shortn/_zEwTRZUGzg Bug: 1279666 Change-Id: Ic1743d22f07ccd86b4a075d47f7e9b949373acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337400 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/main@{#951385}
This CL hooks up feature notification guide to segmentation platform and adds check to schedule notifications only for low engaged users based on segmentation model prediction. Bug: 1277400 Change-Id: I5708fe0c4a838487f8ad0caf2079a16fc2ac7bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327955 Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951386}
This reverts commit 4cb01cb. Reason for revert: Suspicious about causing test failures of: SessionRestoreTest.RestoreAllBrowsers https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/2442/overview Original change's description: > What's New: Fix session restore case > > https://chromium-review.googlesource.com/c/chromium/src/+/3275312 > changed the What's New logic for M98 to only open a tab if the > page exists for a given milestone. However, it missed the case of > session restore, where the startup tabs aren't opened by the startup > browser creator and are instead passed to session restore. This CL > updates the session restore logic to match the startup browser > creator logic, so that no What's New tabs are opened unless there is > a page corresponding to the current milestone. > > Bug: 1271106 > Change-Id: Ibc47ffd21aef42a18a80627d76f7f7fc67ed80cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331237 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951356} Bug: 1271106 Change-Id: I8e5ad5d2ca702235ea2e7ac129917df7ccfbc15b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337645 Owners-Override: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951387}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639439710-4ce88bd362cfc7e18e39dc64fb166eb8bff8bb1b.profdata to chrome-win32-main-1639450747-9674765a801b0ccdb3cdf42a7039da630818498e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I18c2ea9e1ac8b132505f411915887118cedf7b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337362 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951388}
https://skia.googlesource.com/skia.git/+log/ddbf93159f00..33c28b9fa986 2021-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ffb0024a8970 to d3cac111b662 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I1b5cc7d143a0a0098ba68d645b88bc65daf0adb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337365 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951389}
HarfBuzzShaperTest.EmojiPercentage is broken on >= macOS 11; skip appropriately. Bug: 1194323 Change-Id: If08a1f3b2d0f7816bd377fb85199024324d19c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336456 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#951390}
…works. Listing the tests in files or positional args works. Continuing to work on autocomputation in a separate CL. This is Flag protected with '--resultDB' to not block the current rebaseline flow during the migration work. Bug: 1213998 Change-Id: Iba79cdf4f6e5a931ca8283e50ff52de94a995323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313503 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Preethi Mohan <preethim@google.com> Cr-Commit-Position: refs/heads/main@{#951391}
Dark (before): http://shortn/_vxfud4oAu2 Dark (after): http://shortn/_exj8Nqb228 Light (before): http://shortn/_b9BkhxVtbz Light (after): http://shortn/_Sdd1fqnSb1 Bug: 1279660 Change-Id: Id681a742d50dd036bb6893d90a06f13d81678378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337396 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/main@{#951392}
When an album is selected, the photos belonging to that album should be rendered. This results in a data fetch if photos for the album have not previously been fetched. Bug: b:207025665 Change-Id: I5f26ac6ef8d97229b9fc12774a2d39f4835ca483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292164 Reviewed-by: Jeffrey Young <cowmoo@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/main@{#951393}
Bug: 626703 Change-Id: I33b96922631084a30904e297655477378ad2787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337376 Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Owners-Override: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951394}
It restricts the use of WebUI related functionality to only the outermost main frame by replacing all instances of `GetParent` from the WebUI code with `GetParentOrOuterDocument` method. `GetParentOrOuterDocument` determines whether a frame is the outermost main frame of a tab boundary. Bug: 1248452 Change-Id: Ib0b8e1619cfbf250d6dd5afd513d8fcbf0f4577d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211907 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/main@{#951395}
Define it using COMPONENT_EXPORT which is recommended. Change-Id: I79c407d3de532c4b3cd082a78076a711e9a56f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337087 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951396}
This export has been used in places outside mf_initializer.h. So update the name to reflect the current state. Also use COMPONENT_EXPORT to define MF_UTIL_EXPORT which is the new recommended way. Change-Id: Ic654f3c80006bb008008abd8e5ad36eade05c6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336872 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951397}
Bug: b:172340451 Test: tsc compiles Change-Id: I00dfcaffa4f8b7301641bcb816a8609a01365b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295295 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951398}
This CL renames NavigatingFrameType to FrameType and moves the code for the decision of the frame type to FrameTreeNode. It handles shadow-dom based FFs as kSubframe to keep consistency with the other methods such as NH::GetParent. This is a follow-up of https://crrev.com/c/3229285 Bug: 1267506 Change-Id: I17baf85009e2d17bca3c2b597827ed3d06a6fd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301351 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Owners-Override: Alexander Timin <altimin@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/main@{#951399}
Quick view updates this.entries_ array of selected entries on changeSingleSelectModeSelection_ event. Independently of this it reacts to key events. It is possible for quick view to be triggered when no files are selected, which throws an exception. This is reported as a crash by crash.corp.google.com. This CL stops quick view from being displayed if we have no known selected entries. Bug: b/210555438 Change-Id: Ic6bd72877763d9eb677b5aae235d338002f01199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337393 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/main@{#951400}
Speculative fix for flaky behavior seen from with the PrintBackendPrintBrowserTestService.StartPrinting* browser tests. Suspect that this issue is caused by tests exiting before failure handling tasks posted to the UI and worker threads have a chance to complete, leading to a race condition between test shutdown and the DCHECKs within PrintJob dtor. Eliminate this race by making the tests explicitly wait to exit until a PrintJobWorker::Stop() command has been observed. Bug: 1279668 Change-Id: I57cdb63b2b1f3a3316f92b4948c798af447fde80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337496 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/main@{#951401}
Enabled by adding WebAssemblyDynamicTiering trial to chrome-untrusted domain used by ffmpeg web worker. Bug: b:201335131 Test: Manually Change-Id: I912ff91b3d217b50be800d91ba23fea6e52fcc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313079 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/main@{#951402}
ARC ime_mojom_traits.{cc|h} somehow had a separate build target, rather
than being part of the mojom target (like other traits files).
This CL fixes that by making those two files part of
//ash/components/arc/mojom target, and removing the separate traits
targets.
Bug: b:206686476
Test: CI. It fixes a build issue in crrev.com/c/3330797
Change-Id: Ie66fdd11ebd823e2832be3fd5bb79275827be9ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336596
Auto-Submit: Yao Li <yaohuali@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951403}
Change-Id: Iee16638723e40536f58e2d70a1609d2798d88a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330169 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Kevin Radtke <kradtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#951404}
https://android.googlesource.com/platform/external/perfetto.git/+log/86b18b837a45..1357bd132733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7603ae55c6fec3a823bbfe128c2a89a65c4bfffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337590 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951405}
Bug: 1198187 Change-Id: If31eab1bfb38e213bb38721ee974c9bb9056beef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336856 Reviewed-by: Gavin Dodd <gavindodd@google.com> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#951406}
As part of the migration also: - Added type-checking (with Closure) and fix newly found errors. - Replaced chrome.send/CallJavascriptFunctionUnsafe with sendWithPromise/ResolveJavascriptCallback Bug: 1173575 Change-Id: I3e36088a28f2670f07f987c24647e53fe16d527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334564 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#951407}
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/aa6dcde554d6..216e2ff413d3 2021-12-14 84498356+jzm-intel@users.noreply.github.com Implement index buffer OOB validation test for drawIndexed/Indirect (#851) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Iafd101e6984ca4cc30dbe76fdde2eb928333b8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337476 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951408}
This will be needed by LayoutNG printing. Because LayoutView() / LayoutNGView() doesn't take an Element parameter, but rather a Document, we have to change the constructors for all LayoutObject classes that are inherited by LayoutNGMixin. There should be quite a few issues to fix before we can enable this, but for now, just fix the bare minimum to be able to get Chrome to show its startup page without crashing, and also work with most / some (I tested a couple, and they worked) sites. Bug: 1121942 Change-Id: I593b60d3fbceb7e2991347674ae13ac50860b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330276 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951409}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f5c3ecd65d7..ebad3a4739fd 2021-12-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I423c489edfeb10d042279f594b394328e4ca25a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337361 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951410}
Roll Chrome Mac PGO profile from chrome-mac-main-1639439710-20a38fee7caab4075f075df3302a0bee33aa3eeb.profdata to chrome-mac-main-1639461558-6443fe3ccc79dc1da48e31b902402cf517597db1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib3247f721a157951508938700d58ccf315dd5058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337593 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951411}
WebGPU is still at its origin trial till M101. extend this flag to M101 will help unblock current WebGPU devs for their local development Bug: 1279617 Change-Id: I58905a05300c6c34d17f286deb874c121e9c595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337397 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951412}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639439710-ab16c6bb3aaf9e20b4222d08536ac0b4dfa44061.profdata to chrome-win64-main-1639461558-80984e09416d81d1454f0675b107a9864fed7022.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1ac5c13e725f19b140d81f2ef0456177bf8e1ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337677 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951413}
This CL fixes a failing assert in ProfilePickerCreationFlowBrowserTest.CreateSignedInProfileAfterCancellingFirstAttempt The test compares two profile pointers and expects them to be unique whereas the same pointer can be reused for both profiles since the second profile is created after the first one is destroyed. This CL replaces the pointer check with the profile path check. Profile paths are not reused. Bug: 1274997 Change-Id: Id14a080520b08856543a8c5fa14b8130c677ded0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329857 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Jan Krčál <jkrcal@chromium.org> Commit-Queue: Jan Krčál <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/main@{#951414}
All threads in GPU process acquire a common lock whenever calling VA-API functions, because VA-API didn't ensure thread safety. The statement of thread safety has been added since libva 2.10.0 [1]. However, the thread-safety of libva depends on backend implementation. This CL introduces a feature switch |kGlobalVaapiLock| to control whether VaapiWrapper should run without a global lock should be used in VaapiWrapper when the backend implementation is thread-safe and |enforce_sequence_affinity_| is true. Current default value of the switch is ENABLED, this CL doesn't change the lock behavior in VA-API. Instead of removing the locks at once, we are going to experiment disabling the lock via a finch experiment with the switch. The benefits are: - It will reduce the latency as avoiding cpu lock - It will reduce the gpu power as converging jobs for gpu parallel execution - It will optimize the throughput for gpu which has multiple hw decoder/encoder instances Intel iHD driver is thread safe, allowing parallel VA-API calls. [1] intel/libva#347 Bug: 1123429, b:182008564 Co-Authored-By: hiroh@chromium.org Change-Id: I7da8a787d7d48b394921056da64eaa84ebec1377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139873 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951415}
Roll Chrome Linux PGO profile from chrome-linux-main-1639439710-bec2444723f2d24dfd92057d254f475605e38d7b.profdata to chrome-linux-main-1639461558-09e87b99c7a6415f33ca3b3bf190cf5ca548d380.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4726bab26aaddcc1ce2c4dfe6527df9be06d678e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337776 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951416}
This CL adds a skeleton class for a new BurnInRanker. Follow ups will add method implementations. Once implemented, this will be a lightweight ranker at the end of the ranking stack. It will be responsible for two main tasks: (1) Enforcing a "burn-in" period of some fixed number of milliseconds, during which results are collected from providers but are not published to the front-end. The purpose of this is to prevent the rapid and jittery updating of the result list at the beginning of display. (2) Tracking results as belonging to either the pre-burn-in period or the post-burn-in period. Post-burn-in results will have special handling (e.g. append-only within a category), with exact details TBD. Test: builds Bug: 1279686 Change-Id: I7c170ee3791256a1f3d7f0a20493e5ecf775cddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336923 Reviewed-by: Rachel Wong <wrong@chromium.org> Commit-Queue: Amanda Deacon <amandadeacon@chromium.org> Cr-Commit-Position: refs/heads/main@{#951417}
Change-Id: Ib46b64ee416651c13446d9e5db994ab294fc1652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337260 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tony Herre <toprice@chromium.org> Cr-Commit-Position: refs/heads/main@{#951418}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )