[pull] main from chromium:main #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
crrev.com/c/3263868 was not entirely correct. When a remote resource is requested, it has a revision prefix and query params. Those need to be stripped. Bug: none Change-Id: Icb466d11f90baea84d33364d40d3e7a068918d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313104 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/main@{#950961}
Bug: chromedriver:3974 Change-Id: Id74a3c4f01c962cd23165114ee95d61cf338ebfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329845 Reviewed-by: Maksim Sadym <sadym@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/main@{#950962}
Use explicit type casting from blink::FileErrorCode to int for format ‘%d’ for String::Format() to avoid warning from GCC: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘blink::FileErrorCode’ Bug: 819294 Change-Id: Ie4626313bcd082074c64a64b1bb27e01ac064abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329782 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Ivan Murashov <ivan.murashov@lge.com> Cr-Commit-Position: refs/heads/main@{#950963}
This CL moves PWA bottom sheet functionality up from ChromeAppBannerManagerAndroid to AppBannerManagerAndroid. Since the former is the only subclass of the latter, this CL contains no logic changes, but it will allow us to create a WebLayerAppBannerManagerAndroid easily in a follow up CL. Change-Id: I0c471f8084a41c31602a7aa5dd6a199c4f8f78fe Bug: 1101999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329504 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/main@{#950964}
Bug: b/210105045 Change-Id: I321dd2b53629efcdf368575f74effb70e7a79fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329867 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#950965}
ListValue::Set() is deprecated. I will be sending small CLs to avoid merge conflicts. Bug: 1187066 Change-Id: I25c28e517d781623c848bc3627f8cce2c629eb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327425 Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#950966}
With MPArch, we should not be traversing all the frames of a given web_contents, but rather just the frames for the current primary main frame in that web contents, to notify of filter changes. Bug: 1229685 Change-Id: Ic67c1cc0311ee709def403c9f9625538d3cb639f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321543 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Yilkal Abe <yilkal@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@igalia.com> Cr-Commit-Position: refs/heads/main@{#950967}
Remove the |max_num| parameter from the prime search routine, because it has a good default value and should never need to be changed. Note that this value can still be tweaked on a per-device basis in cros_config if necessary. Bug: b:173425436 Change-Id: I77d230e97876f7ff3da9c5791ecac02f4834aaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327208 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/main@{#950968}
Bug: 1272065 Change-Id: I8f3f2cc6cc8bc39259e049e9c6512b6f594cdb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326953 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#950969}
In order to place widgets in the Aura widget tree, NativeWidgetAura requires that either the new widget has a "parent", or that a "context" is specified for it to be positioned under. UI elements such as the Profile Picker view are created with neither of these set, because the Chrome implementation expects that its ViewDelegate implementation will create a DesktopNativeWidgetAura, if necessary, to contain the new view. Fuchsia now implements ChromeViewsDelegate::CreateNativeWidget(), delegating to 'CreateNativeWidget(NativeWidgetType::DESKTOP_NATIVE_WIDGET_AURA' when no parent, no context and no native_widget is provided. Bug: 1276451, 1234748, 1278750 Bug: fuchsia:88142 Change-Id: I94e6d0ddf5ad3342a5c9b0b5a1aa911e13c21f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329612 Auto-Submit: Benjamin Lerman <qsr@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/main@{#950970}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/71d4ca7a34fd..8e6a222bfffc 2021-12-13 alexrudenko@chromium.org Reland "Batch rendering commands and skip rendering if commands are same" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1062574 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If12882cac8406a0555105c5e6920331e70e0bade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334337 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950971}
This cl changes the logic of lock screen network dialog closure. If the dialog is dismissed by clicking the cancel button it should also close the re-auth dialog (it does not make sense to keep it open as the flow will fail without network connectivity). Bug: 1237407 Change-Id: I420d184f1790816985b395ec472fcb063f957bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320225 Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/main@{#950972}
This CL removes the enum video_capture.mojom.DeviceAccessResultCode defined in services/video_capture/public/mojom/device_factory.mojom. We now use media.mojom.VideoCaptureError in CreateDeviceResponse to better define and distinguish between the errors. Bug: 1254269 Change-Id: Id014b79d39e5a72bca858c1bfb0c224bde8e790e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325911 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Tomas Gunnarsson <tommi@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Reviewed-by: danakj chromium <danakj@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/main@{#950973}
https://chromium.googlesource.com/angle/angle.git/+log/a1b9eb68e417..8991bf5460b6 2021-12-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6214b40 to 30aeba8 (473 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I8254b216e85027d882bac4f80e27a7b2765dd60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334129 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950974}
I'm not 100% sure, but the original reported flakiness doesn't seem to related to the test itself (There were GL errors, but the test doesn't touch this). Bug: 1075936 Change-Id: Ifa1bff6497d58d4f4a0636e47ad8a0083838719a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334327 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/main@{#950975}
Since the main binary of the app shim depends on //base, it registers its own malloc zone. Later, when the main framework is loaded, the code in InitializeDefaultMallocZoneWithPartitionAlloc() will find that there is already a zone names "PartitionAlloc", and not register a new one. However, base::UncheckedMalloc() will still go to the library instance of PartitionAlloc, as base::UncheckedMalloc() cannot call malloc() directly, since we configure it to crash rather than return nullptr. If a pointer which has been base::UncheckedMalloc()-ed in the library gets free()-ed, then the system free() does not know the zone it comes from, and panics. The ideal solution is to not depend on //base in the shim. A workaround is to allow the library to also register a zone. The second approach is taken in this CL: we change the zone name so that the library also registers it. We could remove the check for unicity in InitializeDefaultMallocZoneWithPartitionAlloc(), but we want to discourage multiple loading, so isolating the workaround makes more sense. Bug: 1274236 Change-Id: I8f1f7833b016ad877e520d0f9435cfd4661460ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322973 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#950976}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202112130100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/GNNkSm3f-_u5XLEkNk_gDIcdzAc9jLL9kkDHNH94I1kC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I7810f3abd1159755e2a8534e4f5568524c733f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334338 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950977}
This CL fixes a small logic bug in WaylandOzoneUIControlsTestHelper's SendMouseEvent() method that prevented the notification closure from being run for mouse down events. The interactive_ui_tests that now pass, either thanks to this fix or because they pass because of some previous patch, are enabled. Bug: 1192997 Change-Id: I1c58df2af8b036ab2a2b6da393022f3bd11902c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330284 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Max Ihlenfeldt <mihlenfeldt@igalia.com> Cr-Commit-Position: refs/heads/main@{#950978}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639375151-4e967599104d92686ca75270e443cc76445f6e5c.profdata to chrome-win64-main-1639385263-7a9da9848884ecf62c6cceafcf5d6d43b9fe42e3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie9d49091025d3ec8a1ac2465b029a7da766f324a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334519 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950979}
This test is failing on Android as well: See https://ci.chromium.org/ui/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/6989/test-results for example. Bug: 1270981 Change-Id: I289f62da0cc62eae35e17a1f61d5d9632ecfdd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333926 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Owners-Override: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#950980}
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iaf89ab62be896d0128d2e8d637c5efda977448b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334130 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950981}
When updated information about confidential content in Lacros windows is received in Ash, it should be passed and correctly handled by DlpContentManager. It should track these restriction and apply to screenshot, screenshare and privacy screen checks. Bug: 1260467 Change-Id: I364d6d994d0fd652a6cd24f89351d3ed190b63dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314865 Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by: Aida Zolic <aidazolic@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#950982}
This reverts commit 84ce363. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 84ce363 as the culprit for failures in the continuous build including: Sample Failed Build: https://ci.chromium.org/b/8827964525852494017 Sample Failed Step: compile If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2F84ce36326b9e2985278ae1ac8095b4b85a0653a7&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+84ce36326b9e2985278ae1ac8095b4b85a0653a7 Original change's description: > dlp: Process confidential Lacros windows in Ash. > > When updated information about confidential content in Lacros windows > is received in Ash, it should be passed and correctly handled by > DlpContentManager. > It should track these restriction and apply to screenshot, screenshare > and privacy screen checks. > > Bug: 1260467 > Change-Id: I364d6d994d0fd652a6cd24f89351d3ed190b63dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314865 > Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Aida Zolic <aidazolic@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950982} Change-Id: I6fc34b60bd29e9ef2bcfc0dc5c2894114470f97d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1260467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334563 Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Jeroen Dhollander <jeroendh@google.com> Owners-Override: Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/main@{#950983}
Bug: b:172340451 Test: tast run <ip> camera.CCAUISmoke* camera.CCAUIStress* Change-Id: I8225ea8b0bb68b03212078548462e6d5c01064dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292480 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#950984}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e6a222bfffc..784f3c36176c 2021-12-13 alexrudenko@chromium.org Update Puppeteer to v13 2021-12-13 yangguo@chromium.org Replace legacy theme colors in dataGrid.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I872ec2bbab3fd12dc055bdfa284b9d4cdd57f10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334528 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950985}
…lient." This reverts commit 20cd10f. Reason for revert: Suspected cause for https://bugs.chromium.org/p/chromium/issues/detail?id=1278592 Original change's description: > [reclient] Migrate Linux Builder and GPU Linux Builder to reclient. > > Bug: 1268581 > Change-Id: I4cdaa7776c5ad1b1730ac6b16b6bc0f813d25100 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327642 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Michael Savigny <msavigny@google.com> > Cr-Commit-Position: refs/heads/main@{#950148} Bug: 1268581, 1278592 Change-Id: I05afa976cfa0a32bd96890a7c2e723cd6c71ca92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334540 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Benoit Lize <lizeb@chromium.org> Owners-Override: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#950986}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abc29c75000c..316682dcf4f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jeroendh@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jeroendh@google.com Change-Id: I52dd0653850748c5f7e4f447863187651656f9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334530 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950987}
This CL fixes or removes some tests from the sandbox. This includes the following: * Removed tests checking for Windows behaviors, only check mitigations. * Reworked ConvertToLongPath to not need admin access. * Changed desired file access to what's needed rather than everything which can fail depending on the permissions on the temporary directory. Bug: 1270309 Bug: 1278912 Change-Id: Ia53c2c5ba24db1b487be14243cde95b62c3bbd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329667 Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/main@{#950988}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639342255-b07c3352f531634d3e27514a3f576f233cb17a72.profdata to chrome-win32-main-1639385263-132e69032519c664173a3e43823e58cf6fad5904.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I794ff893c09fda88287db8c6f130fbd461213883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334521 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950989}
Bug: 1259920 Change-Id: Ieba61a00f68cd74daea7f7494a394e27ee726a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331156 Auto-Submit: Charles Reis <creis@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#950990}
Bug 1224845 Change-Id: I6d57ec3c2bd7fa9612ddfb6bfd861e9d4e7cdb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334538 Auto-Submit: Olga Sharonova <olka@google.com> Reviewed-by: Johannes Kron <kron@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/main@{#951001}
Chromium configures malloc() to crash rather than returning nullptr, as some callers are not prepared to handle nullptr properly, and crashing is preferable to introducing a security issue. In some cases though, base::UncheckedMalloc() is used to explicitly ask for a nullptr return value. However, it is implicitly assumed that a pointer allocated this way can be passed to free(). This is not the case on all platforms, in all configurations. For instance, on macOS, there are (rare) cases where base::UncheckedMalloc() is PartitionAlloc, while free() isn't necessarily aware of PartitionAlloc. This leads to crashes, which can be hard to diagnose since they are relatively rare. To mitigate that, introduce base::UncheckedFree(). This is not enforced, yet, as call site conversion is split into another CL. Bug: 1274236, 1279371 Change-Id: Ib10d1cc17b8856dd5af03e0724c35b2423a43e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329862 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951002}
When used in the list-style-type property, symbolic markers may be rendered a UA-specific way which ignores the element's font. To avoid this clause, this CL adjusts some WPTs to use @counter-style instead. [1] https://drafts.csswg.org/css-counter-styles-3/#simple-symbolic Fixed: 1270481 Change-Id: Ia5d78f9d4ae30bd00330833dbaefb4c099c28e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295568 Reviewed-by: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#951003}
This reverts commit ff3225f. Reason for revert: A typo was committed. Original change's description: > Temporarily disable Screen Share warning mode > > Adds a flag that enables or disables the WARN path in the > CheckScreenShareRestriction() and CheckRunningScreenShares() methods, > as the integration was not fully completed for M-98. > > Bug: 1259605 > Change-Id: Idd6d24e8f9b1ea07392730d9fbb460ae460e79e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329844 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Aida Zolic <aidazolic@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950773} Bug: 1259605 Change-Id: I2fa80a41d496dfcc7b4729decd04179fb28d9db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330294 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sergey Poromov <poromov@chromium.org> Commit-Queue: Aida Zolic <aidazolic@chromium.org> Cr-Commit-Position: refs/heads/main@{#951004}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ie624b30537ddb3b9862198eba4ac83b80308e20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334533 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951005}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316682dcf4f6..7499f7d4e8b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jeroendh@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1279342 Tbr: jeroendh@google.com Change-Id: I493df0910903e3abb35e6d835c38dee591b7a91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334572 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951006}
https://dawn.googlesource.com/dawn.git/+log/ffb0024a8970..b320f1700059 2021-12-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a1b9eb68e417 to 8991bf5460b6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ide406ced8ae884b172ce5e5735c81e97ffd7f65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334523 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951007}
Change-Id: Ibd448b95fafb1bf48ace6ba377b1214667248532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334497 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951008}
Some includes to compile_resources are real source files rather than read from a build config. Mark those as inputs. Also modify rules.gni where include_resource is being overriden unnecessarily. Bug: None Change-Id: I17dd379c5f6aa17db5eae8519daa42f9cc13d858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330476 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#951009}
Roll Chrome Mac PGO profile from chrome-mac-main-1639375151-2fb1b35b0f3e9d209c342d583362fa801feb58f2.profdata to chrome-mac-main-1639393722-2d03618ce8fda9f6a746ac4c40204c03180aba60.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4aa532c17f49e08eb227ff1180f84133f19102e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334570 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951010}
Bug: 1187026, 1187025 Change-Id: I431b61f7894511fa9a8daac0daaf23fe2e86d4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332867 Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951011}
This change is part of the preparation to enable ChromeApp kiosk in Lacros, but it stands on its own. This change moves a large part of the app installation logic out of StartupAppLauncher into its own class. It is part of a larger refactoring and therefore leaves the codebase in a not-so-great state. Change-Id: If9529c9b5723d3225d741728bf5f8c9a9636f3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301961 Reviewed-by: Anqing Zhao <anqing@chromium.org> Reviewed-by: Jeroen Dhollander <jeroendh@google.com> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Ben Franz <bfranz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951012}
* replace the term "master" with "bucket" which appears to be the correct term (although this is specifically the v1 bucket syntax, which probably doesn't need to be mentioned here) * use an example that is valid today * point out that Gerrit can produce the syntax for you Change-Id: I2f1a8e1bf3a0d57eb99d4fc5c457cd98c60677aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334705 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#951013}
Bug: b:172340451 Test: tsc compile Change-Id: I2afb64965d56914aa8ea338991474150454d957a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292481 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951014}
This required a str vs. bytes fixes. Fixed: chromium:1278407 Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel,dawn-mac-x64-deps-rel,dawn-win10-x64-deps-rel,dawn-win10-x86-deps-rel Change-Id: Ie1ad7ba5b665f7ba99bbdd2db6327ddcc8d56fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330282 Reviewed-by: Weizhong Xia <weizhong@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951015}
https://chromium.googlesource.com/vulkan-deps.git/+log/3841d9d6d316..a0a6270b47e4 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ff07cfd86f..f0351b7bc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,cwallez@google.com Change-Id: I2b207e910e59244360696b927300a6d5000d61f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334560 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951016}
- Extract attribution policy into local variable for readability - Move conversion destination instead of copying Change-Id: Ie49714aeeb16004f0c5b29a80bf4f8fd23c4817f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330561 Auto-Submit: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nan Lin <linnan@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#951017}
Bug: 1187061 Change-Id: I263484290ce76f9a1300c474008166808afeadcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330381 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#951018}
…rce.com/c/chromium/src/+/3330578 Bug: 1278777 Change-Id: Id9162843a39d64eddf7a8b94502cdeef1ef22e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334285 Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Owners-Override: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951019}
A change we missed when updating the Bluetooth permission handling code for Android S is that the BLUETOOTH_CONNECT permission is required before we can enable the Bluetooth adapter. This change avoids a crash when calling BluetoothAdapter.enable() by making sure that the "permission required" help message overrides the "adapter off" help message. Fixed: 1271637 Change-Id: I8afb7e1451627d84f643a38871a7e49a81a23211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315749 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ravjit Uppal <ravjit@chromium.org> Commit-Queue: Ravjit Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/main@{#951020}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639385263-132e69032519c664173a3e43823e58cf6fad5904.profdata to chrome-win32-main-1639393722-9f7cf7f714044de9cb6b63434daf10bcd25530b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5687b0d41a747e77f36e248932acb321e3a5c02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334573 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951021}
This CL fixes a crash in profile creation flow when the user closes the window very quickly after choosing to sign-in (before the new profile for sign in gets created). The CL also adds a regression test. Bug: 1278726 Change-Id: I19dd6100372deaea9d4bdc737423e0afea6e7999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330206 Commit-Queue: Jan Krčál <jkrcal@chromium.org> Auto-Submit: Jan Krčál <jkrcal@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/main@{#951022}
…_all_cookies Now that we have a JS function within testdriver to delete all cookies we should use it instead of the one-off helpers. Bug: 1233305 Change-Id: Ib0ee77a51a3b1bea9d48549a309fdba8116461bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3116120 Reviewed-by: Steven Bingler <bingler@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#951023}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I3a3bfef4a19dadf4f5a6ed1f8c10a66ce09e96ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334699 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951024}
…kies Now that we have a JS function within testdriver to delete all cookies we should use it instead of the one-off helpers. Bug: 1233305 Change-Id: Ifa53b1cf3a392b92f9e1c7cdc84be3001e3a89a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3116688 Reviewed-by: Steven Bingler <bingler@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#951025}
This reverts commit b2dde5b. Reason for revert: Probable cause for https://crbug.com/1279406 (failing interactive_ui_tests related to TabDragging/) Original change's description: > ozone/wayland: fix mouse events in tests > > This CL fixes a small logic bug in WaylandOzoneUIControlsTestHelper's > SendMouseEvent() method that prevented the notification closure from > being run for mouse down events. > > The interactive_ui_tests that now pass, either thanks to this fix or > because they pass because of some previous patch, are enabled. > > Bug: 1192997 > Change-Id: I1c58df2af8b036ab2a2b6da393022f3bd11902c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330284 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Max Ihlenfeldt <mihlenfeldt@igalia.com> > Cr-Commit-Position: refs/heads/main@{#950978} Bug: 1192997 Change-Id: Icea220738f63950721275e881a1e1f4caaa5bb1d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330211 Auto-Submit: Jeroen Dhollander <jeroendh@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/main@{#951026}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639385263-7a9da9848884ecf62c6cceafcf5d6d43b9fe42e3.profdata to chrome-win64-main-1639393722-82dcf221613d7b4d01216e6db3d83371803c5ada.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5c676a9abcc7a92d36f215316fac0ff2ab687ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334569 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951027}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )