[pull] main from chromium:main #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Rename CanvasColorSpace to PredefinedColorSpace, reflecting the names used in the specification. Move the enum and its "to string" and "from string" functions to graphics_types.h, to match the other similar types. Bug: 1274220 Change-Id: I145be370b0543d44707bc20ea1277153db925aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316079 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#951196}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639407500-a1802b7bf664a493b35086ae58fd679d3300265d.profdata to chrome-win32-main-1639418353-3aead5550e61905c9325d12ee4a83149ca362ecb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If8cc3a4dcc8f1deaf49f3ebffa5d07854d78b5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335356 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951197}
https://swiftshader.googlesource.com/SwiftShader.git/+log/592d413edb56..1eee6cbcf034 2021-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ 592d413e 2021-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ 592d413e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: Ia37d60be78d298ce1b1b675756c028c3bf6377ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335137 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951198}
- Update key icon in iOS keyboard suggestions toolbar to use icon with teeth - Update key logo in URL bar to use icon with teeth - Show blue monochrome icon with teeth (2-prong) for the 'Save password?' butter bar Bug: 1267959,1267961,1267962 Change-Id: I3e6bec30669bb2d9be7bf64f5a170e3d5ba3206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313297 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Benjamin Williams <bwwilliams@google.com> Commit-Queue: Benjamin Williams <bwwilliams@google.com> Cr-Commit-Position: refs/heads/main@{#951199}
Bug: 1277783, b/209072323 Change-Id: I7756aa93dbfe9fabe89a73b60947a1daa3fce01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335065 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/main@{#951200}
Bug: 1278420 Change-Id: Iaec014f470f7b345382dab1f09b2503d16ddce13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328623 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951201}
All API stuff is TBD so error messages may need to change, but I want to do the database stuff ASAP, since less schema stuff the better, and it needs this. Change-Id: I060af33f45c090305dc50d7c2920ea81b604b4c0 Bug: 1275638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327790 Reviewed-by: Russ Hamilton <behamilton@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#951202}
…ntrant navigation AppHistory::UpdateForNavigation() (which fires currentchange) is called just before sending IPCs to the browser process for the conclusion of a same document navigation. It should be called after, so that we do not interleave IPCs from different same document navigations. Bug: 1278519 Test: external/wpt/app-history/navigate-event/transitionWhile-and-navigate.html Change-Id: I462fc206fadd9342193cad59b8747cf8879a6eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327957 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#951203}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/fuchsia-internal-sdk-chromium Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I3362db125c19d6621beb1601cfe2cfe356156ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334984 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951204}
If an item in a row completed layout before an earlier item in the same row, we would end up processing the item that had completed layout again in a subsequent fragmentainer, which is incorrect. To fix this, if we run into such a case when iterating over flex items, skip to the next row. Bug: 660611 Change-Id: I714445f001efbab54698bfd0296c85959a2c51a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335316 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951205}
https://chromium.googlesource.com/catapult.git/+log/45fc896c3e1c..1ba82f650c64 2021-12-13 hypan@google.com Add the function to install privileged apps to devices 2021-12-13 wenbinzhang@google.com [pinpoint] use commit hash to look for commit position, and catch notfounderror. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC ddrone@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1278096,chromium:1278382 Tbr: ddrone@google.com Change-Id: I411c4d03bd702145b227f6fce3befcea721b5611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332378 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951206}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: Iec944bdc13e9304f66099f0251c4ff442441a6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332383 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951207}
https://chromium.googlesource.com/angle/angle.git/+log/b365a69edfb9..e8b186c98924 2021-12-13 jmadill@chromium.org Frame Capture: Don't unmap regenned buffers in reset. 2021-12-13 jmadill@chromium.org Frame Capture: Clear array buffer binding in MEC. 2021-12-13 bsheedy@chromium.org Suppress Mac 12 failure 2021-12-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 267fa481ccad to a0a6270b47e4 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Icade6d7f165512485a5a27f7150cc99a9fb4e837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334982 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951208}
This CL moves the implementation of isSubscribed to the concrete class and changes the behavior to only look for id, type and id type matches as opposed to a full object comparison. This makes sense for clients who don't have a reference to a Subscription object returned from the db. Change-Id: Ibd000277a8a36fb275519719ab8a826c6efe8113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330757 Reviewed-by: Zhiyuan Cai <zhiyuancai@chromium.org> Commit-Queue: Ayman Almadhoun <ayman@chromium.org> Cr-Commit-Position: refs/heads/main@{#951209}
There were a few wpt tests added in CL:3328370 where the paragraph element was moved above the style element. Bug: 660611 Change-Id: Iabeb52cc258e73585831a7f71f5df1831f38849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334987 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951210}
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3212767 When there is no focus e.g. with all tabs closed, ChromeVox should return early sometimes when handling selection events. R=rhalavati@chromium.org Bug: none Test: manually and with existing tests. Change-Id: I2c1ee23d5d77e45a1f71223bb167f168bf08aa42 AX-Relnotes: ChromeVox is less noisy about announcing tabs like "untitled, tab 1 of 1" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330707 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#951211}
Do some ui polish for promo and add no thanks card. Will add no thanks functionality in a follow up. Screenshot: crbug.com/1215630#c93 Bug: 1215630 Change-Id: I5392f8c76dc2169d94d1bfa85e1f969820cf9628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327037 Reviewed-by: Rainhard Findling <rainhard@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/main@{#951212}
The bug happens when the |availableScreenSpace| is negative number, and |heightList| is empty in AppMenu#calculateHeightForItems. When the Chrome reaches the line 547(previously 525), spaceForItems += heightList.get(lastItem++); the exception java.lang.IndexOutOfBoundsException will be thrown. |heightList| should never been empty, but it seems happens on some unpopular devices, The bug is rarely happened, only 25 crashes since August. But to make Chrome bulletproof, we can make sure that |availableScreenSpace| is never smaller than zero, so in this condition, line 542 will not be true. if (availableScreenSpace < spaceForFullItems) Bug: 1132258 Change-Id: Ic1f282dadab38e62c693939dd8192b9370cbf086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326063 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951213}
The new test was added in crrev.com/c/2862265. Change-Id: Ia88cfd3ec264967f0a4e0e32e7aaa09d9f5b97c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335067 Auto-Submit: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nan Lin <linnan@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#951214}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/turbine-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I37d5c058924270ae32ebd5fe7aaca80f69a2bf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335178 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951215}
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/fd03dcc12204..0da2a1155ed5 2021-12-13 apodtele@gmail.com [truetype] Upstream the hdmx binary search. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10.20h2-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ic018fb84facfe547f698917870aee1d9f0b445b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334983 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951216}
This patch adds a means of using the new on-demand optimization guide API from bookmarks. To help prevent poor usage of the system, the API takes a list of BookmarkIds rather than URLs to ensure bookmarks are actually being sent (rather than arbitrary URLs). Bug: 1276542 Change-Id: I7d79847b71942f48a698dbfa80fcb62255f9959b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319079 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#951217}
There is no implementation or usage of this function. Fixed: 788813 Change-Id: I0c32ef8246cbca54034e89e7e0599dcee1af82ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331520 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/main@{#951218}
VLOG_IF(verbose_level, condition) takes verbose_level as its first arg and condition as the 2nd arg. Bug: None Change-Id: Iebde794981ea178131516ab59dbed66f39a69530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330864 Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951219}
shell-encryption and private_membership leaked some configs which disable some default warnings. In order to re-enable all these warnings for chrome/browser/* in this CL crrev.com/c/3303510, all warnings need to be fixed. This CL is fixing the comparison between two integers for them to be from the same exact type (i.e. integer). Bug: chromium:1212837, b:201763017 Change-Id: Ic2cfad3c4ccf97e423bdf5f4655de187f6a83ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327145 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/main@{#951220}
This reverts commit c1c9c0c. Reason for revert: causing popup menu visual problem. Original change's description: > [lacros] enables fractional scale support. > > Bug: 1246388 > Change-Id: I07381c8c0f4320e7ea97677f8432918c4c83ff3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3285833 > Commit-Queue: Robert Kroeger <rjkroege@chromium.org> > Auto-Submit: Jun Liu <yjliu@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/main@{#942259} Bug: 1272127 Change-Id: Ie102b294015cc01472a207cea4ddcabd57a9e465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334102 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951221}
Removed RenameReply dependency as its proto is already removed from ChromeOS. (See the build error here crrev.com/c/3329892) Change-Id: I0e011abace2b70020363067e7f9d734b9d001907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332084 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951222}
Adds fuzzy diff parameters images/color-profile-animate.html in order to work around slight rendering differences between NVIDIA and Intel GPUs. The parameters allow a large numbers of pixels to differ by a very small amount. Bug: 1278181 Change-Id: I5ba336ba54b9dc3b4d405b61241f461c7ed6fc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328725 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951223}
We need to know the chrome:// URL that's triggering this. Bug: 1275766 Change-Id: I5d23de0293d8c3c89cff1a75311831ec8bb26b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335189 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#951224}
Although not likely, it is possible for the providers to have an active non-prefetch request when a prefetch request is about to be started. In such scenarios, starting a prefetch request will cause the providers to invalidate their active non-prefetch requests and never get a chance to notify the controller of their status; thus resulting in the controller to remain in an invalid state. Bug: 1262373 Change-Id: Iad1bbd7400063d86067854c40beb2faf76422990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331656 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951225}
`InitAccountsAvailableInArcPref()` doesn't need to use `InitializationState::kInProgress` because it completes synchronously, never calls itself, and is always called on the same thread. Add DCHECK_CALLED_ON_VALID_SEQUENCE to make sure that initialization and all other methods are actually called on the same thread. Bug: 1260909 Change-Id: I0e968cb81b71942c605c7d79c9d88b83945e3e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327203 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#951230}
This CL makes it so when a user exits overview with the desk templates grid open, the desk templates grid first fades out then fades in the overview items and blurs out the overview wallpaper. Bug: 1275232 Change-Id: I8141526cfb55d873586084dc8d4ba83623270b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328303 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951231}
Now that our minSdkVersion is 23, we should be able to safely remove Api21CompatibilityDelegate, WebViewDelegateFactory, and some related code in the initialization path. Since I did some digging through the code history to verify this removal is OK, I thought it would also be helpful to document the history of the initialization path on different OS versions. I added this as class docs to WebViewChromiumFactoryProvider. Fixed: 1276584 Test: launch WebView (system_webview_apk) on Android 23 emulator Test: launch WebView (system_webview_google_apk) on Android 24-28 emulator Test: launch WebView (trichrome_webview_google_apk) on Android 29+ emulator Change-Id: I1724d3bcec944f746b796df3f7453e9d066e05dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315560 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951232}
It was a bit hard to understand the code at first glance. There should be no behaviour change. Bug: none Change-Id: I4a383bb38e909ef4660974b7a3982bf3bd98da7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330474 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/main@{#951233}
https://android.googlesource.com/platform/external/perfetto.git/+log/1302b4259684..86b18b837a45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0acf3a901a8e58ce7d1a595b284d3addf713bb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335364 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951234}
Caching generally doesn't work well when fragmenting, so make sure |allow_first_tier_oof_cache_| is false when inside a fragmentation context. This caused an issue when setting up the OOF node to layout. We would fail to populate |node_to_layout.offset_info.block_estimate| when the cache was allowed, which caused a crash when trying to use the block estimate during layout. Bug: 1278627, 1278879 Change-Id: I69e29646c1b4d4031dd338fce4dd898dc3804a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331522 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951235}
Bug: 1256390 Change-Id: Ie6b5396ccc46012ec18b201b872b01cf694b6dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336340 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Stephanie Kim <kimstephanie@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/main@{#951236}
Bug: 1245834 Change-Id: I2b94ee41c92947f8176a8834af29a28c383a439f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331219 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#951237}
https://skia.googlesource.com/skia.git/+log/e4bccab4ac7c..49cb6d7668d5 2021-12-13 johnstiles@google.com Add a Variables pane to the SkSL debugger. 2021-12-13 johnstiles@google.com Add helper method to get the human-readable value of a slot. 2021-12-13 jvanverth@google.com Add divide-by-zero check to GrGenerateDistanceFieldFromPath 2021-12-13 johnstiles@google.com Report slot updates using a dirty mask. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I0a14bc7aa64ecc7422bcf8d7de2edfa0fe39b896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334992 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951238}
This CL expands the ProtectedBufferManager mojo interface which is exposed by the GPU process to give access to video decoder processes to the dummy handle translation functionality needed to decode protected content. This expanded interface is then used in a MojoProtectedBufferManager allow a GpuArcVideoDecodeAccelerator living outside the GPU process to gain access to the dummy handle translation functionality. Note that the MojoProtectedBufferManager is asynchronous, so GpuArcVideoDecodeAccelerator had to be modified to accommodate this. The existing GetProtectedSharedMemoryFromHandle() method in the mojo interface is deprecated in order to create a variant that returns a nullable value. This is needed in order to be able to handle the clear content path in which there's no protected shared memory buffer region associated with the input FD. Bug: b:195769334 Test: com.google.android.media.gts.WidevineH264PlaybackTests#testCbcsL3With240P30 Change-Id: Icc0f43da92be5af0c63ea2ce2b8e45add386f015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292490 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951239}
Feature is being held back on CrOS due to issues with the reboot process triggering the feature each time. It's disabled by default for that platform through M97, but we should also disable it for M98-99. Bug: 1278393 Change-Id: Ibc48ccb58ce53bd603759036a85d59fbf24a0988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331193 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#951240}
In some scenarios, for example the Ash browser when Lacros web apps are enabled, WebAppProvider::GetForWebApps() returns nullptr. We now allow for such cases. Bug: 1194709 Change-Id: Id99d92f5908e714943cd175a2251c19e3894a4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330380 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/main@{#951241}
Enable 'tab' to access the expandable view. Add a container for expandable view (event_list_), which is used to escape from the focusing on the date cell. The same for the `content_view_`, which is wrapped in the `scroll_view_` (we can see the scroll view is the container). screen record: https://drive.google.com/file/d/1keYIxJtQDxzawhtIM3m_fu5Nql6xDPUu/view?usp=sharing BUG: 1238927, 1277161 Change-Id: I345a8e016689c2e5c7bb9a0f50403dc97f9fe1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329081 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> Cr-Commit-Position: refs/heads/main@{#951242}
Summary of metrics added: - Cookie.PartitionCount: number of distinct partitioned cookie jars - Cookie.PartitionedCookieCount: number of cookies in all partitioned cookie jars - Cookie.PartitionedCookiesInRequest: if partitioned cookies are included in requests - Cookie.PartitionedCookiesInRequestCount: number of partitioned cookies in requests that have at least 1 partitioned cookie - Net.RestrictedCookieManager.PartitionedCookiesInScript: if partitioned cookies are accessed from a script - Net.RestrictedCookieManager.PartitionedCookiesInScriptCount: the number of partitioned cookies a script accesses at one time - Net.RestrictedCookieManager.SetPartitionedCookie: if a cookie created by a script is partitioned Bug: 1225444 Change-Id: I0231bbd486ee57354c9a83cb12122fc5bec40db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318375 Reviewed-by: David Schinazi <dschinazi@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/main@{#951243}
Bug: 1278434 Change-Id: I46d5e4a2ebec3a26d2d62540daf648d3ad6c7edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336177 Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/main@{#951244}
Adding a build time check to prevent them from accidentally being added to the build. Also fixing one last case of an accidental TS file inclusion. Previous violations were fixed at r950682. Bug: 1189595 Change-Id: I74ed2c8f3e6d8d79437c30e5cf32e456a67df324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334557 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#951245}
https://screenshot.googleplex.com/34UHEoMNYsdffmG.png If feature PersonalizationHub is enabled, show link to personalize instead of link to set wallpaper. BUG=b:202851995 TEST=ash_unittests --gtest_filter="*ShelfContextMenuModelTest.OpensPersonalizationHub*" Change-Id: Ic992b02e51c8af38b97b7849bbd718a0f19a06dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328523 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951246}
https://android.googlesource.com/platform/external/perfetto.git/+log/1302b4259684..86b18b837a45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I45eebce7aa537a6294bbc9a648ee048a7c4ab9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335582 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951247}
This CL has no functional changes. Bug: 883570 Change-Id: I529a640dcf950bbe3732e1c633959308b13664e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313485 Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Auto-Submit: David Bertoni <dbertoni@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/main@{#951248}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639418353-b85c5bb26fc53388b63ef45334bb5b09bf1e3292.profdata to chrome-win64-main-1639429114-d0b8799edbb8a39955dddb39410dbf96710071ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib8b522f39312442e6b635d4383d73c5ac0748dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335676 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951249}
Found via lsan. Bug: 1279539 Change-Id: I5376a6acfa0ef796b9c78c2354cf5599e38dd3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335436 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Addison Luh <aluh@chromium.org> Cr-Commit-Position: refs/heads/main@{#951250}
This patch removes the following fields: lost_grouped_mapping_ PaintLayerRareData::squashing_disallowed_reasons PaintLayerRareData::composited_layer_mapping PaintLayerRareData::grouped_mapping Bug: 1277748 Change-Id: I2b49179b8d9499604843820bdfc6bc9f564727a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331371 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951251}
This patch updates the following reference of "WebID": - JS exception description strings - .well-known/webid path - 'Sec-WebID-CSRF' forbidden request header Bug: 1260415 Change-Id: I037e84be418c44aa79531d51b3fc99374c09c0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330583 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951252}
This change was included along with other fixes in https://crrev.com/c/3264758, but unfortunately it resulted in crashes in issue 1279453. Revert this part of the change until we better understand what's going on. Bug: 1279453 Change-Id: I3cbe7b0fd644b536152b699d6e15595f7ee0d702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330760 Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#951253}
…8.0-r1 to 98-4729.0-1638787322-benchmark-98.0.4758.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I842d94ffe6c24f6aeb12ef33e144a12ec3272aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336483 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951254}
Bug: 1278576 Change-Id: I0da9fff585a7cb287329e7b26140eb3991071e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329123 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/main@{#951255}
Change-Id: If991b582320b2020c85701a756a57ef14e29a0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335588 Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org> Auto-Submit: Mohamad Ahmadi <mahmadi@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#951256}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )