HttpStreamPool: Fix NetworkContextTest.Preconnect* tests

When the HappyEyeballsV3 feature is enabled, use HttpStreamPool's
GetInfoAsValue() to inspect the current state of the pool. This
fixes NetworkContextTest.Preconnect* tests.

The NetworkContextTest.PreconnectMax test requests 76 sockets,
which exceeds the maximum number of sockets per group. Change
the CHECK in HttpStreamPool::Preconnect() to std::min() to handle
such cases.

Bug: 346835898
Change-Id: I3993c9ea573b5ea102525a9fffd55d7e46d7b866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826436
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1349943}

net/http/http_stream_pool.cc

@@ -4,6 +4,7 @@
 
 #include "net/http/http_stream_pool.h"
 
+#include <algorithm>
 #include <map>
 #include <memory>
 #include <set>
@@ -196,7 +197,7 @@ int HttpStreamPool::Preconnect(const HttpStreamKey& stream_key,
                                AlternativeServiceInfo alternative_service_info,
                                quic::ParsedQuicVersion quic_version,
                                CompletionOnceCallback callback) {
-  CHECK_GE(kMaxStreamSocketsPerGroup, num_streams);
+  num_streams = std::min(kMaxStreamSocketsPerGroup, num_streams);
   QuicSessionKey quic_session_key = stream_key.ToQuicSessionKey();
   if (CanUseExistingQuicSession(stream_key, quic_session_key,
                                 /*enable_ip_based_pooling=*/true,

services/network/network_context_unittest.cc

@@ -571,6 +571,15 @@ class NetworkContextTest : public testing::Test {
   // Looks up a value with the given name from the NetworkContext's
   // TransportSocketPool info dictionary.
   int GetSocketPoolInfo(NetworkContext* context, std::string_view name) {
+    if (base::FeatureList::IsEnabled(net::features::kHappyEyeballsV3)) {
+      return GetInfoFromHttpStreamPool(context, name);
+    } else {
+      return GetInfoFromClientSocketPool(context, name);
+    }
+  }
+
+  int GetInfoFromClientSocketPool(NetworkContext* context,
+                                  std::string_view name) {
     return context->url_request_context()
         ->http_transaction_factory()
         ->GetSession()
@@ -583,6 +592,17 @@ class NetworkContextTest : public testing::Test {
         .value_or(-1);
   }
 
+  int GetInfoFromHttpStreamPool(NetworkContext* context,
+                                std::string_view name) {
+    return context->url_request_context()
+        ->http_transaction_factory()
+        ->GetSession()
+        ->http_stream_pool()
+        ->GetInfoAsValue()
+        .FindInt(name)
+        .value_or(-1);
+  }
+
   int GetSocketCountForGroup(NetworkContext* context,
                              const net::ClientSocketPool::GroupId& group) {
     if (base::FeatureList::IsEnabled(net::features::kHappyEyeballsV3)) {