[pull] main from chromium:main #105
Merged
Commits on Dec 13, 2021
-
Rename CanvasColorSpace to PredefinedColorSpace, reflecting the names used in the specification. Move the enum and its "to string" and "from string" functions to graphics_types.h, to match the other similar types. Bug: 1274220 Change-Id: I145be370b0543d44707bc20ea1277153db925aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316079 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#951196}
-
Fix crash when an appHistory currentchange event handler starts a ree…
…ntrant navigation AppHistory::UpdateForNavigation() (which fires currentchange) is called just before sending IPCs to the browser process for the conclusion of a same document navigation. It should be called after, so that we do not interleave IPCs from different same document navigations. Bug: 1278519 Test: external/wpt/app-history/navigate-event/transitionWhile-and-navigate.html Change-Id: I462fc206fadd9342193cad59b8747cf8879a6eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327957 Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#951203}
-
If an item in a row completed layout before an earlier item in the same row, we would end up processing the item that had completed layout again in a subsequent fragmentainer, which is incorrect. To fix this, if we run into such a case when iterating over flex items, skip to the next row. Bug: 660611 Change-Id: I714445f001efbab54698bfd0296c85959a2c51a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335316 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951205}
-
There were a few wpt tests added in CL:3328370 where the paragraph element was moved above the style element. Bug: 660611 Change-Id: Iabeb52cc258e73585831a7f71f5df1831f38849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334987 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951210}
-
Catch corner case in preventing extraneous speech about tabs
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3212767 When there is no focus e.g. with all tabs closed, ChromeVox should return early sometimes when handling selection events. R=rhalavati@chromium.org Bug: none Test: manually and with existing tests. Change-Id: I2c1ee23d5d77e45a1f71223bb167f168bf08aa42 AX-Relnotes: ChromeVox is less noisy about announcing tabs like "untitled, tab 1 of 1" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330707 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#951211}
-
[Shopping] Add mechanism for updating price info from bookmarks
This patch adds a means of using the new on-demand optimization guide API from bookmarks. To help prevent poor usage of the system, the API takes a list of BookmarkIds rather than URLs to ensure bookmarks are actually being sent (rather than arbitrary URLs). Bug: 1276542 Change-Id: I7d79847b71942f48a698dbfa80fcb62255f9959b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319079 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#951217}
-
cryptohome: Remove RenameReply proto
Removed RenameReply dependency as its proto is already removed from ChromeOS. (See the build error here crrev.com/c/3329892) Change-Id: I0e011abace2b70020363067e7f9d734b9d001907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332084 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951222}
-
[FedCM] Update web-visible "sub" strings to "account_id"
Per spec [1] we should use "account_id" instead of "sub" for account identifier. [1] https://wicg.github.io/FedCM/#idp-api-id-token-endpoint Bug: 1278905 Change-Id: I567504ed13ae10b9f5a4ebeae96aaa7e5903dcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330584 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951228}
-
URLPattern: Avoid over-generating '{}' for custom names.
This CL fixes a minor issue with a previous change landed to address the problems in: whatwg/urlpattern#145 We previously made a change to produce `{:foo}bar` instead of `:foobar`, etc. That change, however, also emitted the `{}` even when the custom name had a regexp associated with it; e.g. `:foo(baz)`. In that case we don't need the protection of the `{}` since the regexp placement prevents confusion with the following group. This CL fixes this minor issue by checking if the part's type is kSegmentWildcard. It also adds some tests to validate this behavior. Bug: 1263673 Change-Id: I613009c59a621e394ea697611077bf1fc34c5c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328146 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/main@{#951229}
-
AW: remove Api21CompatibilityDelegate and add docs
Now that our minSdkVersion is 23, we should be able to safely remove Api21CompatibilityDelegate, WebViewDelegateFactory, and some related code in the initialization path. Since I did some digging through the code history to verify this removal is OK, I thought it would also be helpful to document the history of the initialization path on different OS versions. I added this as class docs to WebViewChromiumFactoryProvider. Fixed: 1276584 Test: launch WebView (system_webview_apk) on Android 23 emulator Test: launch WebView (system_webview_google_apk) on Android 24-28 emulator Test: launch WebView (trichrome_webview_google_apk) on Android 29+ emulator Change-Id: I1724d3bcec944f746b796df3f7453e9d066e05dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315560 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951232}
-
[css-logical] Use easier to read code for resolving logical values
It was a bit hard to understand the code at first glance. There should be no behaviour change. Bug: none Change-Id: I4a383bb38e909ef4660974b7a3982bf3bd98da7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330474 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/main@{#951233}
-
[LayoutNG] Don't allow first tier OOF cache when fragmenting
Caching generally doesn't work well when fragmenting, so make sure |allow_first_tier_oof_cache_| is false when inside a fragmentation context. This caused an issue when setting up the OOF node to layout. We would fail to populate |node_to_layout.offset_info.block_estimate| when the cache was allowed, which caused a crash when trying to use the block estimate during layout. Bug: 1278627, 1278879 Change-Id: I69e29646c1b4d4031dd338fce4dd898dc3804a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331522 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951235}
-
Use python3 for chromium/orchestrator recipe.
Bug: 1256390 Change-Id: Ie6b5396ccc46012ec18b201b872b01cf694b6dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336340 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Stephanie Kim <kimstephanie@google.com> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/main@{#951236}
-
Give ARC OOP video decoders access to the ProtectedBufferManager.
This CL expands the ProtectedBufferManager mojo interface which is exposed by the GPU process to give access to video decoder processes to the dummy handle translation functionality needed to decode protected content. This expanded interface is then used in a MojoProtectedBufferManager allow a GpuArcVideoDecodeAccelerator living outside the GPU process to gain access to the dummy handle translation functionality. Note that the MojoProtectedBufferManager is asynchronous, so GpuArcVideoDecodeAccelerator had to be modified to accommodate this. The existing GetProtectedSharedMemoryFromHandle() method in the mojo interface is deprecated in order to create a variant that returns a nullable value. This is needed in order to be able to handle the clear content path in which there's no protected shared memory buffer region associated with the input FD. Bug: b:195769334 Test: com.google.android.media.gts.WidevineH264PlaybackTests#testCbcsL3With240P30 Change-Id: Icc0f43da92be5af0c63ea2ce2b8e45add386f015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292490 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951239}
-
apps::GetScope allows for web apps being disabled
In some scenarios, for example the Ash browser when Lacros web apps are enabled, WebAppProvider::GetForWebApps() returns nullptr. We now allow for such cases. Bug: 1194709 Change-Id: Id99d92f5908e714943cd175a2251c19e3894a4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330380 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/main@{#951241}
-
Add UMA metrics for partitioned cookies usage
Summary of metrics added: - Cookie.PartitionCount: number of distinct partitioned cookie jars - Cookie.PartitionedCookieCount: number of cookies in all partitioned cookie jars - Cookie.PartitionedCookiesInRequest: if partitioned cookies are included in requests - Cookie.PartitionedCookiesInRequestCount: number of partitioned cookies in requests that have at least 1 partitioned cookie - Net.RestrictedCookieManager.PartitionedCookiesInScript: if partitioned cookies are accessed from a script - Net.RestrictedCookieManager.PartitionedCookiesInScriptCount: the number of partitioned cookies a script accesses at one time - Net.RestrictedCookieManager.SetPartitionedCookie: if a cookie created by a script is partitioned Bug: 1225444 Change-Id: I0231bbd486ee57354c9a83cb12122fc5bec40db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318375 Reviewed-by: David Schinazi <dschinazi@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/main@{#951243}
-
Grit: Prevent TypeScript files from being added to the final build.
Adding a build time check to prevent them from accidentally being added to the build. Also fixing one last case of an accidental TS file inclusion. Previous violations were fixed at r950682. Bug: 1189595 Change-Id: I74ed2c8f3e6d8d79437c30e5cf32e456a67df324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334557 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#951245}
-
personalization: open hub from right click menu
https://screenshot.googleplex.com/34UHEoMNYsdffmG.png If feature PersonalizationHub is enabled, show link to personalize instead of link to set wallpaper. BUG=b:202851995 TEST=ash_unittests --gtest_filter="*ShelfContextMenuModelTest.OpensPersonalizationHub*" Change-Id: Ic992b02e51c8af38b97b7849bbd718a0f19a06dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328523 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951246}
-
Slimming PaintLayer: remove more pre-CAP code from PaintLayer (3)
This patch removes the following fields: lost_grouped_mapping_ PaintLayerRareData::squashing_disallowed_reasons PaintLayerRareData::composited_layer_mapping PaintLayerRareData::grouped_mapping Bug: 1277748 Change-Id: I2b49179b8d9499604843820bdfc6bc9f564727a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331371 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951251}
-
[FedCM] Update web-visible "WebID" strings to "FedCM"
This patch updates the following reference of "WebID": - JS exception description strings - .well-known/webid path - 'Sec-WebID-CSRF' forbidden request header Bug: 1260415 Change-Id: I037e84be418c44aa79531d51b3fc99374c09c0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330583 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951252}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.