[pull] main from chromium:main #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is a reland of 84ce363 The original CL used C++17 feature that was not caught by CQ. Original change's description: > dlp: Process confidential Lacros windows in Ash. > > When updated information about confidential content in Lacros windows > is received in Ash, it should be passed and correctly handled by > DlpContentManager. > It should track these restriction and apply to screenshot, screenshare > and privacy screen checks. > > Bug: 1260467 > Change-Id: I364d6d994d0fd652a6cd24f89351d3ed190b63dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314865 > Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Aida Zolic <aidazolic@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950982} Bug: 1260467 Change-Id: I1c848ad61441991ea6d78233bb4b9d684c9c81fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329891 Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by: Aida Zolic <aidazolic@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#951419}
Updates the expires_after attribute for 38 histograms that have been used to generate alerts in the past 180 days and do not already have a date later than or within 60 days of 2022-03-14. TBR=chromium-metrics-reviews@google.com Change-Id: Ic904e05e2d5413affa1f930d87b23e4ccccea8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337976 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Bot-Commit: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/main@{#951420}
https://android.googlesource.com/platform/external/perfetto.git/+log/86b18b837a45..1357bd132733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie35d9adb5c7672894549797dab5f7a82d045f47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337137 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951421}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639450747-9674765a801b0ccdb3cdf42a7039da630818498e.profdata to chrome-win32-main-1639461558-d1317f8df3a47076c53ad387642fd817bb433e6b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4069725866c39ddc1c2213532f54c9165ece80b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337680 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951422}
https://android.googlesource.com/platform/external/perfetto.git/+log/86b18b837a45..1357bd132733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7cc01b97eaede7081aa667de9e0fdeb626b77754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337856 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951423}
This reverts commit 55c053c. Reason for revert: CalendarViewTest.ExpandableViewFocusing test consistently failing on builder "Linux ChromiumOS MSan Tests". Please see crbug.com/1279739 for more information Original change's description: > Implement accessibility for expandable view > > Enable 'tab' to access the expandable view. > > Add a container for expandable view (event_list_), which is used to > escape from the focusing on the date cell. The same for the > `content_view_`, which is wrapped in the `scroll_view_` (we can see the > scroll view is the container). > > screen record: > https://drive.google.com/file/d/1keYIxJtQDxzawhtIM3m_fu5Nql6xDPUu/view?usp=sharing > > BUG: 1238927, 1277161 > Change-Id: I345a8e016689c2e5c7bb9a0f50403dc97f9fe1a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329081 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951242} Change-Id: I2c617f454fd5ddedf976449ecaf66089b234bc5c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338039 Auto-Submit: Sreeja Kamishetty <sreejakshetty@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/main@{#951424}
…rOS" This reverts commit 9935e9d. Reason for revert: DCHECK does not fire any more during tests on CrOS. Original change's description: > dcheck-on-cros: Disable DCHECK at slot_assignment.cc:252 on CrOS > > Disable this DCHECK until it is not firing on CrOS (crbug.com/1176575). > See go/chrome-dcheck-on-cros and go/dcheck-cleanup-workflow for more > information. > > Bug: 1176575 > Change-Id: I4b46a6fea0d0ea80c275b11a0d5a905e0f3d8ed6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2686770 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#856183} Bug: 1176575, b:192415828 Change-Id: I66d5ac3ffc85177b8a609b14f98c0d0c550c0422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331073 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/main@{#951425}
also breaks out the different vulkan chipset providers, since they provide numbers for driver versions differently to one another. Bug: 1236697 Change-Id: I6117deceb99fabe08bcc02e933a568bd7c12b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324691 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Auto-Submit: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951426}
Removes IntentHandler Chrome dependency. We are in the process of moving all Autofill Assistant code to //components. For this we need to remove all dependencies on Chrome code. In this cl we pass in a generic interface without dependencies and supply the chrome-specific implementation at the call side. Bug: b/173103628 Change-Id: Ic5dbfd15f512a51cb97efaa1bf04b50fd69b624e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3303813 Reviewed-by: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Florian Gauger <fga@google.com> Auto-Submit: Florian Gauger <fga@google.com> Cr-Commit-Position: refs/heads/main@{#951427}
The Ozone/Wayland implementation had a few places where the Wayland objects were bound without proper checking for their versions. That was part of the technical debt not addressed before, and ended up causing the issue explained in the linked crbug: the compositor terminates the client that binds to the protocol that it does not actually support. This patch fixes the issue by adding the necessary checks in all places where they were missing. Also a convenience macro for validating the version is proposed. Bug: 1279574 Change-Id: I74efa97f64b480bed47372d8d559593ae84eeb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337037 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/main@{#951428}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df7c46c625a3..d49909553bd8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: Id4c3f5e778d14e8a176b03b40c96d31b5e9b3fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337586 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951429}
Before that CL: sync_enabled_or_disabled_cb_ was called only when the Sync Bridge is syncing passwords from the account store. This was sufficient since the callback's main purpose was to clear the store upon signout wasn't required for the fully syncing users (who only have a profile store). After this CL: sync_enabled_or_disabled_cb_ is also called for fully syncing users. This CL is a no-op since PasswordStoreFactory passes base::DoNothing() when initializing PasswordStore [1]. Follow-up CLs will inject a different callback here and renders this CL useful. [1]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/password_manager/password_store_factory.cc;l=122 Bug: 1278748 Change-Id: I63980ddbda83ebf8a8dfa0927d74343bb9ff4aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330286 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/main@{#951430}
Updates the expires_after attribute for 350 histograms that show frequent access in the past 180 days. These are the 99% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2022-03-14. TBR=chromium-metrics-reviews@google.com Change-Id: If4fb6ae79aca960b2bdeed1c35c0f4176b6c08d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338116 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Bot-Commit: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/main@{#951431}
Quick Answers will become a chromeos feature, thus moving the shared vector icons to //components/vector_icons/. DD: go/qa-lacros-alternatives Bug: b/208563257 Change-Id: Ice51cec1657421cbe55467c6f91224c2bf90a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312105 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/main@{#951432}
This script runs under Python3, but failed to restart the emulators with API levels 29 and 30. I suspect this to be an issue with the emulators, and not the script. Fixed: 1223938 Test: Ran against emulators with API levels 21, 28, 29 and 30 Change-Id: I5859b1083a497ac846f3e286ad42ca2089055ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330208 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Peter Pakkenberg <pbirk@chromium.org> Auto-Submit: Peter Pakkenberg <pbirk@chromium.org> Cr-Commit-Position: refs/heads/main@{#951433}
First, the destinations had white space at the ends of the row because the background color didn't extend into the side safe areas. Next, this takes advantage of the sheet controller's prefersEdgeAttachedInCompactHeight and widthFollowsPreferredContentSizeWhenEdgeAttached to stop the sheet from taking up the full width in landscape mode on iPhones and allow dismissal using the grabber/scrolling. Fixed: 1278528, 1278844 Change-Id: If5698bf11b8d326066104112cdcd9c8698adce35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333928 Reviewed-by: David Jean <djean@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#951434}
Bug: b:172340451 Test: tsc compiles Change-Id: I2d9cac412308b06ed715face87bf0e49a9113bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295296 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951435}
This is done to align Grit's variable names with GN's to avoid any confusion. After all usages af chromeos/lacros have been migrated to the new names, the old names should be deleted. Bug: 1230488 Change-Id: Ia7a0a976ad4c4878319846cdfcecccd45a9b8957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330215 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#951436}
This changes how the AutofillAssistantAgent gets the driver from using browser interface broker to the associated interfaces, adding a binding for the frame to the list in |ChromeContentBrowserClient|. This used to crash (DCHECK) when it tried to actually get the driver in a non-test setting. Bug: b/204841212 Change-Id: I20babb27ed2be487eb4ef102494ef854d1e4e8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326384 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/main@{#951437}
Bug: chromium:1263538 Change-Id: I8f39a5af6f2cb621ff5fb46ae3dd348b14d2f150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326341 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#951438}
A previous CL added a parameter to content::MediaStreamRequest()'s constructor. That CL left the parameter with a default value. This reduced the noise in the CL by avoiding technical changes in multiple tests. However, such a default value is problematic long-term, as it makes it difficult to introduce yet more parameters. This CL removes the default value. Bug: 1276822 Change-Id: I26536aed651123724e3469cff0c279e652ae3f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317977 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Auto-Submit: Elad Alon <eladalon@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#951439}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639461558-80984e09416d81d1454f0675b107a9864fed7022.profdata to chrome-win64-main-1639472251-f506982ae1e519a3e12d88863ff7ac127968c0f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic154a0bde117bb53b9306effb5cf7d0937f0d94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338201 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951440}
This reverts commit d8bceba. Reason for revert: Suspected CL for failing tests on linux-chromeos-chrome. Please see crbug.com/1279761 for more information. Original change's description: > Properly close Lens and open link after LRP press > > Bug: 1234532 > Change-Id: I79b624112787aedb1efd3ef6978b7d034bb2fc89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331543 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Jason Hu <hujasonx@google.com> > Cr-Commit-Position: refs/heads/main@{#951144} Bug: 1234532 Change-Id: I54306f568cfd6e08546b716a2222cba98a51f8b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338498 Auto-Submit: Sreeja Kamishetty <sreejakshetty@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Owners-Override: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/main@{#951441}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ebad3a4739fd..a84185e6b5be 2021-12-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie752e49b631d733b95a4397985630064b49fe208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338076 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951442}
https://dawn.googlesource.com/dawn.git/+log/b7e2f3654264..4682ae0034e7 2021-12-14 hao.x.li@intel.com Get counterSets and counters using Objective-C style 2021-12-14 shaobo.yan@intel.com CopyTextureForBrowser: Support display p3 to Srgb color space conversion 2021-12-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 654149fd6938 to 9b9132c71522 (2 revisions) 2021-12-14 junwei.fu@intel.com Template hardcode functions in webgpu_cpp.cpp 2021-12-14 shrekshao@google.com Further api.h license issue fixes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: If87572c9ebbe48b2c54e7278b118926ddce0085e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338197 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951443}
Since composite after paint was enabled we've noticed that one of Vewd's internal webuis often hits this DCHECK. This webui is pretty complex and hard to minimize into standalone TC. The problem can however be demonstrated using simple unittest. In problematic case the canvas_playback_rect needs to be outside of content rect. It only needs to have overlapping top edge with content rect bottom edge. To trigger the problem translation vector also needs to have non 0 Y component. Fix this problem by replacing DCHECK with explicit handler for such case. Change-Id: Id99d38aa7bcd1a93829d360080c118dae4581621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326944 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/main@{#951444}
In many cases, replication state and proxy hosts are updated at the same time. Excluding frame name and frame policy, most of these updates occur when there is an existing RenderFrameHost associated with the FrameTreeNode/RenderFrameHost. As proxy_hosts_ and replication_state_ exist in BrowsingContextState, the functionality to update both in the simple cases has been migrated so that it is stored in BrowsingContextState instead. Bug: 1270671 Change-Id: I273ea80f53945596309c8313492f0bfb86eea45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320249 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Cr-Commit-Position: refs/heads/main@{#951445}
https://skia.googlesource.com/skia.git/+log/33c28b9fa986..d26057a2c0e1 2021-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a1b9eb68e417 to 42bd4fc29aea (14 revisions) 2021-12-14 emaxx@chromium.org Fix use-after-move in SkPDFDocument 2021-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 97fa68d to 2a828cd (441 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1122844 Tbr: bungeman@google.com Change-Id: I60aa8fa587fdee356eaba23107eb3c28b2f63919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337588 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951446}
The //ios/chrome code needs an identifier that is stable across application restart to identify uniquely a WebState (e.g. it is used to create the name of the snapshot). This identifier was managed by TabIdTabHelper which is complex. Move it to WebState directly which allow to simplify how it is saved or loaded. This will allow using the identifier in the serialisation code. To avoid this CL from getting too large, the class TabIdTabHelper is not removed and instead is converted to return the value from WebState::GetStableIdentifier(). Bug: 1276776 Change-Id: I1fba68aa49406c0aa2da0d825caed53e79442f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324543 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#951447}
Also add correct type for window.appWindow. Bug: b:172340451 Test: tsc compiles Change-Id: I138bb0a98bfc3815450bcbc9323b0d0128a5a86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295622 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951448}
This is a reland of b2dde5b Original change's description: > ozone/wayland: fix mouse events in tests > > This CL fixes a small logic bug in WaylandOzoneUIControlsTestHelper's > SendMouseEvent() method that prevented the notification closure from > being run for mouse down events. > > The interactive_ui_tests that now pass, either thanks to this fix or > because they pass because of some previous patch, are enabled. > > Bug: 1192997 > Change-Id: I1c58df2af8b036ab2a2b6da393022f3bd11902c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330284 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Max Ihlenfeldt <mihlenfeldt@igalia.com> > Cr-Commit-Position: refs/heads/main@{#950978} Bug: 1192997 Change-Id: I8e961576ca841da79d8719b7545ed9ac888b4afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338338 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Max Ihlenfeldt <mihlenfeldt@igalia.com> Cr-Commit-Position: refs/heads/main@{#951449}
…k-98.0.4758.5-r1 to 98-4744.1-1639397847-benchmark-98.0.4758.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5506821afacd3a634f003158ccf1fa7e019fce18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338722 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951450}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )