[pull] main from chromium:main #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Without this, requests will get dropped if multiple come in without the previous one finishing. The limit of max requests is finch-able similarly to the page navigation fetches. Bug: 1279536 Change-Id: I582a987024f8fb3bbb381a9e5e09c785a84b76ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337086 Reviewed-by: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952581}
Forgot to propagate this change to Blink when finishing up this work in Dawn. Bug: 1279848 Change-Id: I5b25e66780e79d2b2e0d29bffa20fa2e864e56b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345962 Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/main@{#952582}
In tablet mode, we want to have the margin of the separator, which locates between continue section and apps grid view, be 8 pixels when using the dense AppListConfig instead of 16 pixels. Bug: 1280345 Change-Id: I8552e1d6a5982ea97ec23be5bac50b8c478f0ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345976 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wen-Chien Wang <wcwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952583}
If wallpaper sync completes when the productivity launcher is visible, but the fullscreen launcher has not been created, it can cause a crash on a null AppListView. I think this is the cause of flakiness in the tast launcher.BubbleSmoke test. Bug: 1254420 Test: added to ash_unittests Change-Id: I34ea2079fb337a1e5246a8cfa7bae252048c4821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346101 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#952584}
This was disabled in https://chromium-review.googlesource.com/c/chromium/src/+/2693314. With SpawnedTestServer moved to Python 3, we have TLS 1.2 available. Bug: 1248530 Change-Id: Ief9a8b6419c06cb1a9b8170ca57fc52dc3f904f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344777 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/main@{#952585}
Perf test regression was reported after a CL merged. - CL commit : a3beacb - Regression Bug: https://crbug.com/1279044 - TC : blink_perf.css/PseudoClassSelectors/PseudoClassSelectors.html The regression was from the changes in the CSSSelectorParser. - CSSSelectorParser::ConsumePseudo To fix the performance regression, removed the changes of adding flags to CSSSelector, CSSSelectorParser, SelectorCheckingContext. To set the computed style flags, iterate has argument selector to check whether it contains pseudo in the argument when matching ':has'. This is the perf test result with this change. - pinpoint: https://pinpoint-dot-chromeperf.appspot.com/job/106a0b0ef20000 - result: (8,194.124 -> 8,404.958 : +2.6%) Bug: 1279044 Change-Id: If2cadf3323aac6af59bf39728d691c4f74feba25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338229 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Byungwoo Lee <blee@igalia.com> Cr-Commit-Position: refs/heads/main@{#952586}
https://android.googlesource.com/platform/external/perfetto.git/+log/9c674c8ed684..cefb3e0ec3a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib99a5a1936e8206e156252d317da855db2236697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345977 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952587}
https://quiche.googlesource.com/quiche.git/+log/66b78407d91d..ed970f7c3838 $ git log 66b78407d..ed970f7c3 --date=short --no-merges --format='%ad %ae %s' 2021-12-14 quiche-dev Allow visitor_.OnFrameSent() to propagate a fatal send error, and do not retry sending on fatal send errors. 2021-12-14 quiche-dev Adds validation for 204 responses, which should carry no body. 2021-12-14 vasilvv Add public_key_type() accessor to quic::CertificateView. 2021-12-14 quiche-dev Return an nghttp2-compatible error value for OgHttp2Session::Send(). 2021-12-14 quiche-dev Simplifies HeaderValidator error codes. 2021-12-14 quiche-dev Supports the `:protocol` pseudo-header for connect requests if SETTINGS_ENABLE_CONNECT_PROTOCOL is sent. 2021-12-13 quiche-dev Fix use-after-move in TlsConnection 2021-12-13 quiche-dev Don't crash if QuicServerConfigProtobuf is invalid. 2021-12-13 quiche-dev Return the vector of config ids by value, not via an output parameter. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Idc4985b77d31ebd138da3633acbda099fc6434e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345624 Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by: David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/main@{#952588}
- Added boolean histogram "Feedback.ReportSending.Online" to track
whether the user is online when the feedback report was submitted.
- Added enum histogram "Feedback.ReportSending.Result" where the enum is
defined as the following:
<enum name="FeedbackReportSendingResult">
<int value="0"
label="The report was uploaded successfully without retry"/>
<int value="1"
label="The report was uploaded successfully after retry"/>
<int value="2"
label="The report is corrupt or invalid and was dropped"/>
</enum>
Bug: b:201334144
Change-Id: Iacede645898146c2bf8281f4067db06ba2d541c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346020
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Xiangdong Kong <xiangdongkong@google.com>
Cr-Commit-Position: refs/heads/main@{#952589}
Adds myself to the OWNERS file for the PDF viewer's JavaScript code. I've been making a lot of changes in this directory, and our team needs additional OWNERS coverage. Change-Id: Idb5512e829e7b2ad653bc8eda241847456a1ec24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346261 Auto-Submit: K. Moon <kmoon@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/main@{#952590}
Adds a boolean success metric to log the success or failure from creating a Gatt connection. Change-Id: Ie36b6a8c220b4f4617bab7237d027be02a4b9763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331622 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#952591}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639677539-d3b89857331ec31b3fb9a2f0baec586c99a0d583.profdata to chrome-win32-main-1639688280-ba821917029425b878fa80c2307eb31d28fa7e99.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I12902393d07ebd2b0aeb47dbcaff37034a9e6ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346040 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952592}
Screencast: http://shortn/_dTIckx5o3z b: 205776059 Change-Id: I186300354c7cb1f16af3449b9c055f7c955a1872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330217 Reviewed-by: Li Lin <llin@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Courtney Wong <courtneywong@chromium.org> Cr-Commit-Position: refs/heads/main@{#952593}
https://crrev.com/c/3315346 introduced a fallback to ReadYUVPixelsAsync if CopyRGBATextureToVideoFrame fails, but this causes a use-after-free since the FrameReadyCallback is consumed in case of failure and cannot be reused. Morever, the fallback already happens in |blit_done_lambda| in case of failure. Bug: 1278727 Change-Id: Ibbc9fc389da52a31f67f3b3d159cf21b6a0521db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343217 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/main@{#952594}
Also, add some comments to values.h and json_file_value_serializer.h about persisting enum values to logs because a histogram being added in this change, Variations.ExtendedSafeMode.BeaconFileDeserializationError, relies on the enums in those files. Also, tweak the Deserialize() function comments as they were stale. Bug: 1280728 Change-Id: Id7406e2af5100f25e76a8c0db5f30ca9d22c1aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344167 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#952595}
In H264, max_num_ref_frames is the maximum of sum of the l0 and l1 picture lists. Since we don't use picture list 1, max_num_ref_frames is max_ref_pic_list0_size. Therefore, kMaxNumReferenceFrames is unnecessary. This removes it and makes the code understand easily. Bug: b:194265793 Test: video.EncodeAccel.h264* Change-Id: Id30d308e2d9f7ec708b3066dd004b58bd1a134a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288507 Reviewed-by: Miguel Casas-Sanchez <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/main@{#952596}
Similar to CL:3331522, we were hitting a case where |allow_first_tier_oof_cache_| was true when handling fragmentation, because |has_block_fragmentation_| was false. To fix this, make sure that |allow_first_tier_oof_cache_| is always false when we handle fragmentation. Bug: 1280620 Change-Id: I86236f1bd21e184d19825a64c873448a90806e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345485 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952597}
We got a kOutOfFragmentainerSpace status, and then there'll be no fragment generated. Bug: 1278880 Change-Id: Iafaa6ec72b0adf19794acca3b4b05b837f3d11f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344660 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#952598}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I1960c0ce65045e4a1133dddf07ded1cbf777ed1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345739 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952599}
With Floss, device list filtering is still unstable. We disable filtering it first so that Floss testing of other features can be unblocked. Bug: b:202335393 Change-Id: I741d910efe5059f55e7ae21cece0a2695eaf66f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342921 Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/main@{#952600}
https://chromium.googlesource.com/catapult.git/+log/d6ef4a8af654..22e558b5843a 2021-12-16 fdegans@google.com [code-health] Migrate tracing to python3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1262294 Tbr: wenbinzhang@google.com Change-Id: Ib0de4cd4e45740ee0daa634538b7a6cab24e68fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346044 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952601}
https://skia.googlesource.com/skia.git/+log/44a839262076..0f244e5c73c7 2021-12-16 erikrose@google.com [infra] Retire iPhone 6 phones. 2021-12-16 herb@google.com add max dimension to the glyphs digest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I2dc3ded0f0219d5cfb4200ede35af41a8e062684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346080 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952602}
I'm not sure yet what's going on with TestWSSClientCert, but this seems the likely cause for TestCertDBChangedFlushesClientAuthCache. The network service may not necessarily have picked up the CertDatabase signal without a flush. Speculative because I was unable to reproduce the flake locally. Bug: 1279930 Change-Id: Ic77ce69f55e6a7c6fbdd82c784f6124adf5a3b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344776 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952603}
This reverts commit 16fdb84. Reason for revert: Speculative fix for android-pie-x86-rel failures org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#searchEngineLogo_onTextChanged_noGlobeReplacementWhenUrlBarTextIsEmpty org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#testTemplateUrlServiceChanged org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#searchEngineLogo_isGoogleLogo org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#searchEngineLogo_isGoogleLogo_whenScrolled ...3 more failure(s) (7 total)... Original change's description: > [GMNext] Update ThemeColorProvider to use OmniboxTheme > > This CL updates the icon tint in some classes to follow OmniboxTheme > instead of the simple light/dark tint. It also moves OmniboxTheme out > of chrome/browser/omnibox to be able to use it in classes outside > omnibox/. > > Bug: 1233725, 1114183 > Change-Id: I479854127613ca4bf3f28bf9ad6c79b8d127b877 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307187 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Theresa Sullivan <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/main@{#952457} Bug: 1233725, 1114183, 1280789 Change-Id: I9ee6322d23794cbe961920fd2e2e7975aa316c14 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346112 Owners-Override: Justin DeWitt <dewittj@chromium.org> Auto-Submit: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952604}
Bug: 1187091 Change-Id: Ifcd49791c1ceebb6430d8fb09cfae6d281c4327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297469 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#952605}
Bug: 1273485 Change-Id: I391e5c245c4cd98bc603297f287eb2aabb75eaf2 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346006 Owners-Override: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952606}
This occured on GTK4 with the following log spam: [1658612:1658612:1216/155521.116133:ERROR:browser_main_loop.cc(267)] GLib-GObject: g_type_class_unref: assertion 'g_class != NULL' failed R=sky Change-Id: Ifcafcee7fc39503b2ae09c6689e49341200de72e Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346118 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952607}
These methods were related to overlay interstitials, which have been removed, so they were dead code at this point. Bug: 1077074 Change-Id: I7eb1a6c367552430cf80915b7682d78a81ca9a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342152 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#952608}
This enables NetworkService::SetEncryptionKey() for Linux. See the referenced bug for details on why this is necessary. This will call OSCrypt::GetRawEncryptionKey() in the browser process, send it to the network service via NetworkService::SetEncryptionKey() and finally call OSCrypt::SetRawEncryptionKey() in the network service. This way the network service doesn't require access to KeyStorage, implemented by third party libraries (libsecret, kwallet, etc.), which makes it more easily and reliably sandboxable. This means that starting the network service requires the encrypted key to be retrieved from the platform-specific KeyStorage. So, an os_crypt::Config must already have been set before ever starting the network service. This means modifying the BrowserMainParts of chrome and headless to initialize the config early enough. This also allows us to remove some extra code that initialized os_crypt in the network service with a config, which now is unnecessary. Bug: 1277463 Change-Id: I47c45a818fc579e094520ffbd1368af6a479b37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320484 Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/main@{#952609}
Before this CL, if device details changes while PageState in device details subpage is CONNECTION_FAILED, it gets reset. This CL ensures the PageState is only reset when the new device connection state value is not kNotConnected Bug: b/210364495 Change-Id: I5548c2c06a64bb285e426bf503997581db30070f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342742 Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Theo Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/main@{#952610}
Roll Chrome Mac PGO profile from chrome-mac-main-1639677539-997cb311ab2c03187a535e6bd85a4c81ef7ed1a7.profdata to chrome-mac-main-1639699149-d99607dd6ede6953e9a8a370b4b194cf85698800.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id45f80de8eabb1a5a692aaa6747abbd8fa1b3e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346263 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952625}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f5e412a1..a9438004 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie98b67f111ff72cb058a2d199463d7f8c8850040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343916 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952626}
The tests were flaky due to the order of the following: PASS successfullyParsed is true See: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=fast%2Fanimation%2Frequest-animation This patch deflakes the directory by converting from js-test to testharness which no longer depends on the successfullyParsed timing. This timing difference may have started with the synchronous html parser (crbug.com/1254921). Bug: 1279124, 1278108, 1275479, 1269956, 1272058 Change-Id: I137f19de17c194640bc0443395f47f1311e4ff95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335322 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#952627}
The class web::FakeWebState supports settings the BrowserState returned by GetBrowserState() so the sub-class is not needed. The test was also incorrectly configuring the mock to return a pointer to a deallocated object (as it was stored in a stack allocated std::unique_ptr<T> that was destroyed by the end of the SetUp() method). Since the test do not require GetBrowserState() to return a specific value anyway, just use a web::FakeWebState and do not set the BrowserState. Bug: none Change-Id: Iad9db1661104c0bdeed52473bd24e7724d2c71e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344757 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952628}
This is a sub-class of web::FakeWebState that only define one method set_loading_progress() which is never called. So replace usage by direct uses of web::FakeWebState and delete the obsolete code. Bug: none Change-Id: I9877674f905f4b885b61fa58cc2660b16898c7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345241 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952629}
Small changes to IDL to match the spec. All changes are non-breaking because the impl was already doing the right thing in spite of the IDL. These issues were discovered after my full audit of all webcodecs IDL. There is one lingering issue (EncodedVideoChunkMetadata.temporalLayerId) that is a breaking change and requires an intent to deprecate (will send shortly). Change-Id: I55da3158726a79493e46af9ed862656e655f8e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346324 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#952630}
mojo::core::AtomicFlag was a lightweight wrapper around a boolean- valued atomic word; it was implemented using base::subtle's atomics. Convert from C++ atomics - they're broadly supported and are even used in mojo already. Bug: 1194917 Change-Id: If211f2e1553b8cbcbe7f9541a80b5bcea9bfd21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334956 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Venkatesh Srinivas <venkateshs@chromium.org> Cr-Commit-Position: refs/heads/main@{#952631}
…rity prompts This CL adds a pref that will track if unconsented users have seen a tailored security prompt, and won't show the prompt if - They are syncing users - They have seen the prompt before It also fixes two quick bugs - The consented message on Android didn't enable ESB - The out-of-flow UX for unconsented users wasn't being triggered. Bug: 1280348 Change-Id: I8186ba64a94eaa755e034844ad1a32ffbebc45c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342490 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#952632}
Currently most of devices support VideoDecoder at ARC++. This CL
enables arc::VideoDecoder feature by default. After this CL, we should
use `arc_disable_cros_video_decoder` USE flag to disable the feature
at a certain chipset or board.
BUG=b:196321553
TEST=Remove `arc_disable_cros_video_decoder` and
`arc_uses_cros_video_decoder` from /etc/ui_use_flags.txt and
check arc::kVideoDecoder is enabled
Change-Id: I9e441403d06adba0290e577ae2e2c5a48532a780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3089305
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952633}
Computes the upload progress of a pending screencast. Notifies the pending screencast status change whenever the delta of transferred bytes greater than 0.6mb. Bug: b/199421317 Change-Id: I1f00d6cc7937236503bc51fa9534d52f64e0fddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261089 Reviewed-by: Li Lin <llin@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Cr-Commit-Position: refs/heads/main@{#952634}
g_message_count is a counter used to track the number of messages inflight; it is used in OnMemoryDump for allocator dump data. Convert from base::subtle atomics to std::atomics, which are typed and broadly available. This removes the last user of base::subtle::Atomic* in mojo Bug: 1194917 Change-Id: Ib2c4ba4141554e57e0fc8e7f42c7dd7fb2fad4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345520 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Venkatesh Srinivas <venkateshs@chromium.org> Cr-Commit-Position: refs/heads/main@{#952635}
Change-Id: I819b8add0c299d1a28fc4f64e92f42ad6fc393a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345922 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952636}
* Added load_time_data.m.d.ts since untrusted does not have access to the trusted chrome:// files. * Changed `validateReceivedData` to return boolean instead of various event data types to allow for better type checking. Bug: b:205290219 Test: locally build and run Change-Id: I787c48342a9403e040962fdbfb53fbdccdb0c0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323722 Reviewed-by: Jeffrey Young <cowmoo@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/main@{#952637}
This CL remove the ntp/app_launcher_handler from Chrome OS build. chrome://apps page is not supported on Chrome OS, therefore the App Launcher Handler is not used in Chrome OS. This is part of the BrowserAppLauncher refactoring effort, the usage of this API will be removed from Chrome OS, and replace with an interface with async return value in Chrome OS. BUG=1244506 Change-Id: Id2ca4b90a42c05dbbddbf085aadc06670568ebad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334439 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#952638}
…cking No proper clipping is the main reason why there is an integer overflow on the damage rect when dest_pass->transform_to_root_target matrix is weird and produces a huge output rect size. Changes in this CL. (1) The current |clip_rect| is lost when copying quads to a non-merge pass. Add a new |root_target_clip_rect|, which is on the same space as |root_damage_rect_|, to ensure all clip rects are passed down to the child passes an child surfaces. This might help the case of multiple surface embedding (2) In SurfaceAggregator::AddRenderPassFilterDamageToDamageList(), take |root_target_clip_rect| and clip the surface damage rect. Clipping was not handled for filters before this CL. Bug:1257765 Change-Id: I96e4e4f3ef857d6cfd9a72741c71dea284a03b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289997 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952639}
This CL exposes selectmenu.labels by marking selectmenu as a labelable element and using HTMLElement::labels. Bug: 1121840 Change-Id: Id7f20d04a340adcbe46d31b0fa1027be8f7c2531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346106 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952640}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639688280-ba821917029425b878fa80c2307eb31d28fa7e99.profdata to chrome-win32-main-1639699149-21d03dd9629015aa4c6c0780ad4efa7b76563a12.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I129a44a2d230247949292b70f821da079460d846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343479 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952641}
All histograms are still relevant to monitor Dev Ui usage and are beneficial for developing any new DevUi features in the future. Fixed: 1265714 Test: N/A Change-Id: I672292d66f13ca885cfa7b02914f3dbaac3100aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345681 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/main@{#952642}
When launch chrome with --list-apps switch, we can output open/installed web apps for each profile to a file without launching a new browser window or tab. Pass a absolute file path to --list-apps switch to specify where to output the information. We can also use a optional --profile-base-name switch together to output open/installed web apps only for a given profile. Pass the basename of the profile directory to --profile-base-name switch to specify which profile to get information. Bug: 1259516 Design-Doc: https://docs.google.com/document/d/1fzj-F_exyQxd2mkda5rt9nkI6S4nKeP74wJK5sLB5FI Change-Id: I00f73db43e3b5989850c3bfff743e9312ba5394c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3255221 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/main@{#952643}
FuchsiaMediaResourceProvider is used only in WebEngine. Move it to //fuchsia/engine and rename it to WebEngineMediaResourceProvider. Bug: 1271250 Change-Id: I7b617278de965e6831066575848724a68144efd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337399 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952644}
https://dawn.googlesource.com/dawn.git/+log/3649af2486cd..fc38f7d87901 2021-12-17 junwei.fu@intel.com Make dawn_platform.h template flexible 2021-12-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9360046a86f6 to 11d9a0828781 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I16253ba6b73dfa2572bd4d0d6965bf2b6cbfd742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346500 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952645}
https://chromium.googlesource.com/openscreen.git/+log/8620ec89411d..499acfd92975 2021-12-17 jophba@chromium.org [Cast Streaming] Support multiple senders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: If14715b6e2d7ae5ba6d277b80f9dede0bb369bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346481 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952646}
The reset algorithm for selectmenu elements is to go through all the option elements in the element's list of options, set their selectedness to true if the option element has a selected attribute, and false otherwise, set their dirtiness to false, and run the steps to reset the selected option for the selectmenu. To reset the default selected option: - if no option is selected, set the selection to the first non-disabled option if it exists, or null otherwise - if two or more options are selected, set the selection to the last selected option Bug: 1121840 Change-Id: I5fa981c869a75cd933e60d0f0dbc5999ff3223c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343646 Reviewed-by: Dan Clark <daniec@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952647}
https://chromium.googlesource.com/angle/angle.git/+log/543f5750f70e..b9f2d9cc1455 2021-12-16 gman@chromium.org Use text expectations to skip a test 2021-12-16 cclao@google.com Vulkan: Replace BufferVk::getBufferAndOffset() with getBuffer() 2021-12-16 lubosz.sarnecki@collabora.com Tests: Add My Talking Tom Friends trace. 2021-12-16 lfy@google.com Vulkan: Track enabled in VertexArray 2021-12-16 cclao@google.com Vulkan: Implement BufferPool using VMA's virtual allocator 2021-12-16 lfy@google.com Vulkan: Dirty vertex buffers if default attrib values changed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter="*my_talking_tom_friends*" Change-Id: Ia710a30acacda28f3a9904a79d95d01f8dc96b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344723 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952648}
Change-Id: Ie5e2a94c195e9a583b386768938c24dc6951e710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338098 Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#952649}
https://skia.googlesource.com/skia.git/+log/0f244e5c73c7..20981e308a4b 2021-12-16 fdegans@google.com [fuchsia] Implement SkFontMgr::onMakeFromData() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1260529 Tbr: bungeman@google.com Change-Id: Ibd176059e6d5cfbf54011d87ecbd94542a7521d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343477 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952650}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I28f828868a08290de5e904405de2ed45be378b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346544 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952651}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )