[pull] main from chromium:main #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Update DeviceConversionUtil to only provide battery information for a device if it's connected. Fixed: b/209520332 Change-Id: If93c9922af0921177bf45399c2b358e777b8efd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339190 Auto-Submit: Gordon Seto <gordonseto@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#951654}
Change-Id: I3f5eb54a1d3be97e64bf2ffb3927a0cbb4c11e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339295 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951655}
This removes NonSFI support from components/nacl/zygote. The remaining parameter passed to nacl_helper_listener will be removed in a following CL. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: If18e612e2017bb4d7d2959b665ccfa5dc78a0aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337280 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Derek Schuff <dschuff@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/main@{#951656}
We need to encapsulate the store icon in omnibox with a white circle background like permission icons. Bug: 1279658 Change-Id: I1c047ba7200d9f3e7d149a82651d8fac5e2c7bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336840 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Ayman Almadhoun <ayman@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@chromium.org> Cr-Commit-Position: refs/heads/main@{#951657}
Likely rebase hiccoughs @ https://crrev.com/c/3251802 after cleanup refactoring of https://crrev.com/c/3312500. __SIMPLE_REVIEW__ Bug: None Change-Id: I7e2eb6eb638fa5b153a3644d473a4bdf5d830abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337717 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by: Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951658}
Also set ownership of those histograms to the chrome-brapp-loading team. Change-Id: If8fc66e626f3601850a5a75b91f7ff3ee2cd7219 BUG: 1268039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339152 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/main@{#951659}
…ngs" This reverts commit 293ef66. Reason for revert: Caused PasswordSettingsTest#testManageAccountLinkSyncing() to start failing. See crbug.com/1279940 Original change's description: > [Passwords] Fix assertion failure when opening password settings > > Method SyncService.isUsingExplicitPassphrase() has the precondition that > the sync engine must have initialized, as per isEngineInitialized(). To > avoiding running into assertion failures, PasswordManagerHelper must > first rule out ongoing initialization before invoking > isUsingExplicitPassphrase(). > > Change-Id: I8f519953c6d37aa4d9d54e6b043c24054fb46b45 > Fixed: 1276532 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336879 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951464} Change-Id: Iffaaeffcfc0d0a2b6d13017abc9220d3a81529fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338974 Owners-Override: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951660}
Bug: 1268555 Change-Id: Icc44369983f09d986a36e678e9b0bd5dc632eaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339034 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951661}
This helps bring crbug/1148157 (test cleanups) to closure, without blocking on the more elaborate, widespread, and complex issue of "stateful globals in CrOS IMF" (crbug/1279743). Bug: 1148157, 1279743 Change-Id: I271b02bda9ce62090aa23894348010ae6a38d894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338537 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by: Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951662}
This is a three part change: 1) copy fyi to CI: crrev.com/c/3339137 2) move builder in src: crrev.com/c/3339620 3) delete fyi: crrev.com/c/3339535 Bug: 1186823 Change-Id: I786f0514208e7ef6e78b3c67bd79bb151040fdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339620 Reviewed-by: Garrett Beaty <gbeaty@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#951663}
Flaky on bot: Win10 FYI x64 Release (Intel HD 630) Bug: 1274796 Change-Id: I53cceeebea5909fa8d6281e8880b733c0fe2ddda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339534 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Shrek Shao <shrekshao@google.com> Owners-Override: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#951664}
This removes NonSFI support from components/nacl/loader. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I38acee6ef1174c991ce5eb8e99c7c2a135688443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336825 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Derek Schuff <dschuff@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/main@{#951665}
This should eliminate races between VEA::Flush() completion callback and VEAClient::BitstreamBufferReady(). Flush should never return before all pending outputs were given to the client. This magic is called "Associated Interfaces" and it's described here https://chromium.googlesource.com/chromium/src/+/HEAD/mojo/public/cpp/bindings/README.md#Associated-Interfaces Bug: 1275474 Change-Id: Ia384c42d9ca6eb25288e19cf22271df0cc30ad9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336495 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#951666}
The ccrev.com/948993 introduced a simpler and faster way to find the RELRO region. It had to be reverted (crbug.com/1278078) because the new logic has the additional requirement for the |load_address_| to point to a valid address of the loaded library. On not-so-rare occasion this condition is not met: when the first attempt to load the native library fails, and the |mRemoteLibInfo.mLoadAddress| is zeroed out before making the next attempt. Detect this condition and give up earlier. Also count (in UMA) the number of remaining cases where an invalid address propagates to the modern_linker_jni.cc - these should hopefully be at absolute zero. If so, re-landing the ccrev.com/948993 would be safer. Bug: 1154224 Change-Id: I9cacf240d198e22c93583192803582b0f4bdd491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338747 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951667}
Damage will still be broken for now. Bug: 1274161 Change-Id: I20bc10a79046f478723ff6c4cf722ed82a3b9bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304273 Reviewed-by: Peter McNeeley <petermcneeley@google.com> Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Kevin Haslett <khaslett@chromium.org> Cr-Commit-Position: refs/heads/main@{#951668}
This should fix some instances of memory leak, which were uncovered by lsan in tests like DisplayOverlayControllerTest. Bug: 1278965 Change-Id: Ia1f4c48b622f256dd5ff23ad47604114c3221096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339652 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Addison Luh <aluh@chromium.org> Cr-Commit-Position: refs/heads/main@{#951669}
Bug: 1278435 Change-Id: I491ac7a1903fb7e2ce83d8b205ecb841915afa82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328769 Reviewed-by: Gary Tong <gatong@chromium.org> Commit-Queue: Kuan Huang <kuanhuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951670}
All other profile types should not use session restore. BUG=1267034 TEST=none Change-Id: I1016c7340baea646da06462b0fcfa51abda581a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334872 Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#951671}
As the first part of the implementation of partitioned WebLocks, modified RenderProcessHostImpl::CreateLockManager() to convert the Origin passed in to a BucketId before calling LockManager::BindReceiver() and changed all references to Origin in LockManager to use BucketId instead. Bug: 1258860 Change-Id: I75bd3d74ed5d7bbcf63a8c8c643927b9431b8580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270364 Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Joshua Hood <jdh@chromium.org> Cr-Commit-Position: refs/heads/main@{#951672}
When there is no internet connection, Wallpaper app shows a default error page regardless of whether local images are available. To fix, when a user has local images but no internet connection, show local images thumbnail and an error toast indicating the network error. If no local images available, show the original error page. BUG=b/199445801 TEST=Manually - Download a few wallpapers. - With the internet on, open Wallpaper app, both local image and online collections are loaded. - Turn off the internet connection, refresh/reopen Wallpaper app, only local image collection is available, an error toast displays on the bottom left corner. - Remove all the downloaded images, refresh/reopen Wallpaper app, only an error page is shown. TEST=browser_tests --gtest_filter="*PersonalizationAppController*" TEST=browser_tests --gtest_filter="*PersonalizationAppComponent*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ibe91459e90b04861e97b89aa85c38479e225b32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325744 Reviewed-by: Jeffrey Young <cowmoo@chromium.org> Commit-Queue: Thuong Phan <thuongphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#951673}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/fuchsia-internal-sdk-chromium Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ibcd84a238002a6a9f35ccbe4c512b7e717765ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339745 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951674}
Abort RMA reports RMAD_ERROR_RMA_NOT_REQUIRED on success
Run unit tests for shimless_rma_service
Run local build and confirm that cancelling restarts Chrome.
Bug: 1198187
Test: Run browser tests for Shimless*
Change-Id: I2ae44440d0e9eec58b76b4e10f5e819375c6b8af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321793
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Gavin Dodd <gavindodd@google.com>
Cr-Commit-Position: refs/heads/main@{#951675}
This eliminates a lot of redundant code. Previously for adding a new file to the build it had to be listed 3 times, and any platform specific conditions would have to match across each reference. After this change each file is listed only once either in - web_component_files or - non_web_component_files and these lists are reused across html_to_js(), preprocess_if_expr() and ts_library() targets. Bug: 1189595 Change-Id: Iad2bbe43c95adbb63c81136922f3b7f2bd728efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330216 Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#951676}
Screenshot on https://drive.google.com/file/d/1nvpCSDtYNJ5ZlN55Oc45ii9exkFGBDoo/view?usp=sharing Fixed: 1279927 Change-Id: I7cd214497a325fcfa58b910c93db84e2e69b4df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338746 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Arthur Milchior <arthurmilchior@google.com> Auto-Submit: Arthur Milchior <arthurmilchior@google.com> Cr-Commit-Position: refs/heads/main@{#951677}
This CL fixes that Autofill.CreditCard.SeamlessFills was recorded for all and not just the autofilled fields, and that emitted incomplete fills if no credit card field at all was filled. Bug: 1275953, 1187842 Change-Id: If8f3549d5b18c81493d800ce24829f92d3d24d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329800 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#951678}
This is a follow up for crrev.com/c/3330870. It's more correct and realistic for the toplevel windows to have a container window as parent. Bug: 1278868 Change-Id: I498b3ef47265c173dc66c72ee55267c4e1d510d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339813 Commit-Queue: Addison Luh <aluh@chromium.org> Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/main@{#951679}
Bug: b:207588508 Change-Id: I174dd3ec5afe16cd1efd145f9d682dc761d3ea22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331194 Reviewed-by: Gordon Seto <gordonseto@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Theo Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/main@{#951680}
Bug: b:210127896 Test: Local testing Change-Id: I559a46a6cbce4cb66c1160097ad36d9ff7f90b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336480 Reviewed-by: Ryan Keane <rwkeane@google.com> Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951681}
Roll Chrome Mac PGO profile from chrome-mac-main-1639483122-e06fa0da191d06543cc2bbb3b3801d304c46d5b0.profdata to chrome-mac-main-1639504726-fb9e43adc0e4760052265cf82e7db19c61befe33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia6920eb48d8393f378f0e09a8d6ba8cdda0080f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339554 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951682}
Docs with screenshots of different settings pages: https://docs.google.com/document/d/1eMg8m2hsd6dkJd1xsENaGpQqkUhmteTZOcWKOSkyV3g/edit?usp=sharing Video with patchset#6: http://shortn/_2Jp0He4r9V Video with patchset#9: http://shortn/_s60adVSjG1 Bug: 1270133 Change-Id: Ie7f20b6f394d57c7b8fb42b40b29d356aa101699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288768 Reviewed-by: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sirisha Kavuluru <skavuluru@google.com> Cr-Commit-Position: refs/heads/main@{#951683}
On desktop, when we click, the input event sequence would be pointerdown ,mousedown, pointerup, mouseup. The first input should be the pointerdown. But our current FID computation would regard the mousedown as the first input. And the input delay for the mousedown and pointerdown can be different. This CL is to fix the web-exposed FID by delaying reporting the mousedown until we receive a mouseup. Bug: 1159951 Change-Id: I04f32745558885c6200f779570b6975ca1f4663a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308556 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/main@{#951697}
Fix a use-after-move issue in BrokerHost, as found by clang-tidy: mojo/core/broker_host.cc:39: 'client_process' used after it was moved mojo/core/broker_host.cc:30: move occurred here Bug: 1122844 Change-Id: I298a5b6ce88096605ca004e84cf8321b14afbdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336877 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951698}
Remove unneeded targets and consolidate browser and renderer source code in 2 targets. Bug: b:210127896 Test: CQ Change-Id: Ia7f04c356a0581c1ba8f70d02c216c92a56a6b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337084 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951699}
The leak was identified via lsan. Bug: 1278414 Change-Id: I2485ae33877bbd3ac52e279f57cc38923c3ebc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328739 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951700}
When customizing the app menu for Reading List the bookmark button was dropped from the app menu list for custom tabs. Bug: 1265745 Change-Id: Icca4c013b795752924d11977c4001b7393bf7413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296726 Reviewed-by: bttk - <bttk@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951701}
Bug: 1261158 Change-Id: Ic2a4dd12927772b263c27b60a5d71bd385750e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321429 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/main@{#951702}
ScopedDirTest.CloseOutOfScope consistently fails on this builder. Bug: 1260440 Change-Id: I0b33292a2d116cfbc4b48c92a98f7f24336ec162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339918 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by: Benjamin Joyce <bjoyce@chromium.org> Commit-Queue: Benjamin Joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/main@{#951703}
…ching logic. - CastRuntimeService became a pure virtual interface. - CastRuntimeServiceImpl has the basic implementation. - cast_runtime_service_dummy.cc provides an empty impl for testing. - Targets dispatcher and service targets are consolidated under cast_runtime_service_impl Bug: b:210127896 Test: Local testing Change-Id: Icd0046912ebab1f3cb372725b6f172c6398d9a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337085 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951704}
…s grid open" This is a reland of 4768602 Original change's description: > desk_templates: Animation for exiting overview while templates grid open > > This CL makes it so when a user exits overview with the desk templates > grid open, the desk templates grid first fades out then fades in the > overview items and blurs out the overview wallpaper. > > Bug: 1275232 > Change-Id: I8141526cfb55d873586084dc8d4ba83623270b48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328303 > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951231} Bug: 1275232 Change-Id: I37c47dda33dfb5084a40a7d8e7fe6cc70bb9a3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338892 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951705}
Message is an alternative UI to InfoBar UI on Android. Temporarily disable message UI on AppBannerManagerTest which is using infobar for testing. Will add message-related UI test in AppBannerManagerTest in a follow-up CL if necessary. Bug: 1247374 Change-Id: Iabaa6c607516f496896c3ddfcd2e0dc1bd737990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327951 Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Mike Wasserman <msw@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/main@{#951706}
Bug: 1277692 Change-Id: I17da7e4282e0c77e310d2b63111815b3ea9d4acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337217 Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: Ayman Almadhoun <ayman@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@chromium.org> Cr-Commit-Position: refs/heads/main@{#951707}
This change removes the old prototyped UI in favor of the new views-based bubble UI. Dictation uses the accessibility private API to control the visibility and content of the bubble UI. AX-Relnotes: N/A Bug: 1252037 Change-Id: Ib1e049b1750ebe301ac767a55e5b8c32f92c1d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315517 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#951708}
Instead of hiding the header image, reduce the image size to 36dp when showing as popup. Bug: 1278877, 1261249 Change-Id: Ie91172d1accff2fb2aa9273b3b79a9c886b124b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331367 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951709}
RenderFrameHostManager::CommitPending can re-use an existing
RenderViewHostImpl, which can have a Fallback Surface from previous
navigations. When swapping it is possible that the current
RenderWidgetHostView* was deleted, such as for a Renderer crash. This
leaves us with no current Surface to take as a new Fallback Surface.
It is possible for CommitPending to be for invalid target, effectively
failing. RenderFrameHostManager::CommitPendingIfNecessary can also
cancel on-going navigations.
Previously RenderWidgetHostView* would set a timeout at the start of
navigation, so that if navigation fails we could clear any Fallback
Surface. However when the above occurs there is no navigation, but we
have the Fallback Surface from a previous navigation.
This change updates RenderFrameHostManager::CommitPending to notify its
Delegate of this impending inability to swap Fallback Surfaces.
RenderWidgetHostView* will then clear the previous Fallback Surfaces.
TEST= content_browsertests
NoCompositingRenderWidgetHostViewBrowserTest.NoFallbackIfSwapFailedBeforeNavigation
content_unittests
All/RenderFrameHostManagerTestWithSiteIsolation.TwoTabsOneNavigatesAndCrashesThenNavigatesBack/{0,1}
*CrossOriginOpenerPolicyBrowserTest.CoopPageCrashIntoNonCoop*
Bug: 1258363, 1072817
Change-Id: Id545767366843ab607db925e0e4815668a4f7ab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307264
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951710}
The current asset fetching helper for thumbnails and GIFs cannot actually detect fetch errors. It always returns an array of the correct size (with potentially null entries in case of errors), and the Coordinator only looks at the array size to determine whether some assets failed to fetch. This CL makes it so a null asset causes the helper to return a null array, which the Coordinator detects. This CL also fixes a bug where the helper was fetching the thumbnails a second time instead of the GIF asset. This means that the GIFs were not properly being downloaded on feature launch, but rather when they were being added to the scene for the first time. Bug: 1279935 Change-Id: I197aa52848e14cdc68c1e0f210e62ad8c245fd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339103 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by: Sophey Dong <sophey@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951711}
This is a reland of 55c053c Fix the UAF issue by removing the event list child view in calendar view destructor. (See diff between patchset 1 and 2) Original change's description: > Implement accessibility for expandable view > > Enable 'tab' to access the expandable view. > > Add a container for expandable view (event_list_), which is used to > escape from the focusing on the date cell. The same for the > `content_view_`, which is wrapped in the `scroll_view_` (we can see the > scroll view is the container). > > screen record: > https://drive.google.com/file/d/1keYIxJtQDxzawhtIM3m_fu5Nql6xDPUu/view?usp=sharing > > BUG: 1238927, 1277161 > Change-Id: I345a8e016689c2e5c7bb9a0f50403dc97f9fe1a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329081 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951242} Change-Id: I57ed8e82bd773f71e0927a31d2965e997e438561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339402 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> Cr-Commit-Position: refs/heads/main@{#951712}
PoweredStateOperationResult was not included in test because SetPowered() result callbacks are mocked. It was manually verified instead. Bug: b:207588508 Change-Id: I1d50087d2309a2f11f68bf082be4fd1d232b4e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331185 Reviewed-by: Gordon Seto <gordonseto@google.com> Commit-Queue: Theo Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/main@{#951713}
Add PredefinedColorSpace enums for rec2100-hlg, rec2100-pq, and srgb-linear. Add serialization as well. Bug: 1274220 Change-Id: I798d2d2f769f4303755603d60fd9f379f5233477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330816 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#951714}
Bug: 829689 Change-Id: I68e78631d5881648038b061fdc7097fb285b95a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339377 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/main@{#951715}
Remove #sharing-hub-desktop-omnibox and #sharing-hub-desktop-app-menu flags. #sharing-hub-desktop-omnibox was fully launched. Bug: 1279503 Change-Id: I41179c849bb7d635ec7c7feaea2f0b25c4533bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335440 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/main@{#951716}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I3d0e56633fd93e54842148dc65423445128d1197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339740 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951717}
Found via lsan. Bug: 1280018 Change-Id: I51d282ba445a04fa41e8fab2a98a77c0a4020553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340093 Commit-Queue: Addison Luh <aluh@chromium.org> Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951718}
This is a speculative fix for the crash mentioned in the bug. This added a nullptr check for a variable inside the function. Bug: 1279412 Change-Id: I5d67d9c7a5122c78f46fe80c7e5199fcb75a46ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339105 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/main@{#951719}
This should hopefully fix a crash in component builds where GTK pulls in the system harfbuzz for hb_ot_color_glyph_get_layers because it was not included in our own. Change-Id: I9f326f5a5f73fdf5782b6e0e2656eaa3781ab91d Bug: 1269346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336506 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#951720}
This allows a RP to cancel a pending get, e.g. when a user clicks a different sign in button. The dialog will close when abort is called. Bug: 1272025 Change-Id: Ibcc92189f493f2b148c1d473a8a836a06a406b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318279 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951721}
This adds missing manifest fragments for this test suite and modifies test expectations due to having no system-wide font list implementation on Fuchsia. In addition, that same test is enabled on Android with the same set of expectations as on Fuchsia since it was disabled for the same reason. Bug: 1260529 Change-Id: I2f0bc79a1fb7d75fb9b7491f122363815f23ffe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339815 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Commit-Queue: Fabrice de Gans <fdegans@chromium.org> Cr-Commit-Position: refs/heads/main@{#951722}
https://chromium.googlesource.com/vulkan-deps.git/+log/c03890076954..2ec74208b030 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f0351b7bc6..4322c4b5a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,enga@google.com Change-Id: I609face8e308080bc95ef90daa903dcf34dedede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339151 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951723}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )