[pull] main from chromium:main #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I92631c7d2be36b37356b3276f4b8f044742b802a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344767 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952389}
Replace ScanResult enum with FingerprintMessage union which
will better capture errors. Also change BiodClient observer class
interface to FingerprintMessage protobuf.
For now, FingerprintMessage will be converted to ScanResult due
to compatibility with upper layers. Passing FingerprintMessage
to upper layers will be implemented in next commits.
BUG=b:184843581 b:197959527
TEST=autoninja -C out/Debug_chromeos/ services_unittests
./out/Debug_chromeos/services_unittests
TEST=autoninja -C out/Debug_chromeos/ browser_tests
./out/Debug_chromeos/browser_tests
TEST=autoninja -C out/Debug_chromeos/ chromeos_unittests
./out/Debug_chromeos/chromeos_unittests
Change-Id: I9b3b3c620887c6d3aae6348932d3ef823cea8335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304059
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Patryk Duda <patrykd@google.com>
Cr-Commit-Position: refs/heads/main@{#952390}
No behavior is changed. Note: - We rely on the fact that default constructing base::Value::ConstListView() is equivalent to the underlying container being empty. This avoids declaring a temporary empty list then calling GetList(). https://source.chromium.org/chromium/chromium/src/+/main:base/values.h;l=115;drc=78c732528f041ae775ead234a467a4146baaefa8 https://source.chromium.org/chromium/chromium/src/+/main:base/containers/checked_range.h;l=75;drc=0c486499f16137c84cec56d8e711991875d81230 - It's sad that list base::Value-s can't be directly declared as `base::Value list({base::Value(1), base::Value(false)})`, even though there is a constructor taking vector<>&& which should fit this purpose. The problem is std::initializer_list<> always copies, but base::Value isn't copyable. https://source.chromium.org/chromium/chromium/src/+/main:base/values.h;l=174;drc=78c732528f041ae775ead234a467a4146baaefa8 https://source.chromium.org/chromium/chromium/src/+/main:base/values.h;l=107;drc=78c732528f041ae775ead234a467a4146baaefa8 Bug: 1243386, 1187062 Change-Id: I274b0803c04ccfd0c2b175be993c5c6f10bdc215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344654 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/main@{#952391}
shell-encryption and private_membership leaked some configs which disable some default warnings. In order to re-enable all these warnings for chrome/browser/* in this CL crrev.com/c/3303510, all warnings need to be fixed. This CL is fixing the unused function warnings by removing them from input_method/* to re-enable the warning. Bug: chromium:1212837, b:201763017 Change-Id: I8d572483ffe88034186eeef9cfd32326af24fd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329029 Reviewed-by: Keith Lee <keithlee@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/main@{#952392}
Remove the code that was showing details for the primary account in the accounts list on Account Manager page. The primary account is not shown in the account list anymore and the strings/messages can be removed. Bug: 1152711 Change-Id: Ie167423ca6726a255cf8c1d8d3799fb9b1ccb7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338517 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#952393}
Uploaded by https://ci.chromium.org/b/8827825923146050337 This build will remain in WIP until both master-full and master-release builds for this version are finished. This CL should not be submitted to the CQ until that happens. CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome R=chrome-os-gardeners-reviews@google.com Change-Id: I4b34f7ca6295e4acc4f068b625251bee44e33a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341656 Reviewed-by: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/main@{#952394}
This CL: - Moves the frontchannel API from navigator.id.logout() to FederatedCredentials.logout() - Renames WebIdLogoutRequest to FederatedCredentialLogoutRequest to match spec (https://wicg.github.io/FedCM/) Bug:1270477 Change-Id: I8de29f97a28d410658e30db11ac5977f1b48709c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306687 Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#952395}
Automatic update for 2021-12-16 UTC Change-Id: I2f9aca28ffd8ee24d80410c86363a89cc73f302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344478 Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Cr-Commit-Position: refs/heads/main@{#952396}
This reverts commit 7af0fb4. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1280652 ManifestUpdateManagerBrowserTest List of failed builders: Builder: Mac10.11 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/b8827681640061704705 -------------------- Builder: Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/b8827682375527764417 -------------------- Builder: Mac10.14 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/b8827682075102471649 -------------------- Builder: Mac11 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests/b8827680686731514657 -------------------- Builder: mac11-arm64-rel-tests https://ci.chromium.org/p/chromium/builders/ci/mac11-arm64-rel-tests First failing build: https://ci.chromium.org/p/chromium/builders/ci/mac11-arm64-rel-tests/b8827684490484709729 Original change's description: > [dPWA AppIdentity] Support multiple icons updating. > > AppIdentity Dialog is now only shown if the install icon > or launcher icon is changing (the sizes of each are > platform-specific). If a change is made to an > unimportant icon, it goes through. > > The above behaviour is gated by a feature flag. > > BUG: 1267287 > > Change-Id: I2d15d86d0d4f1e5f95a985e93668fcfab762bb96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320224 > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/main@{#952336} Change-Id: I2228f0431b62d918eeea6f2a77377f8407443834 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344770 Owners-Override: Roger McFarlane <rogerm@chromium.org> Auto-Submit: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952397}
…m access module. This update is part of work on replacing the old ToV8 interface with new ToV8Traits<IDLType>::ToV8 interface. Issue: Replace ToV8 with ToV8Traits<IDLType>::ToV8 Bug: 1199627 Change-Id: I10278f13c1f7a5907649e67036e3b05e6f5e1e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336896 Reviewed-by: Austin Sullivan <asully@chromium.org> Commit-Queue: Vadym Kargin <vadym.kargin@accenture.com> Cr-Commit-Position: refs/heads/main@{#952398}
Logs in a new metric the fast pair failure, and the pairing result. Change-Id: I2c1cf9f0e76f51b9dc29b7d4850d874102b4fdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323133 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#952399}
Replace ScanResult enum with FingerprintMessage union in
OnAuthScanDone interface method to better capture information about
failures.
BUG=b:184843581 b:197959527
TEST=autoninja -C out/Debug_chromeos/ services_unittests
./out/Debug_chromeos/services_unittests
Files services/device/fingerprint/fingerprint_chromeos.cc
services/device/fingerprint/fingerprint_chromeos_unittest.cc
services/device/public/mojom/fingerprint.mojom
TEST=autoninja -C out/Debug_chromeos/ ash_unittests
./out/Debug_chromeos/ash_unittests
Files ash/ambient/ambient_controller.cc
ash/ambient/ambient_controller.h
TEST=autoninja -C out/Debug_chromeos/ browser_tests
./out/Debug_chromeos/browser_tests
Files chrome/browser/ash/login/lock/screen_locker.cc
chrome/browser/ash/login/lock/screen_locker.h
chrome/browser/ash/login/screens/fingerprint_setup_screen.cc
chrome/browser/ash/login/screens/fingerprint_setup_screen.h
chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.cc
chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.h
ui/chromeos/user_activity_power_manager_notifier.cc
ui/chromeos/user_activity_power_manager_notifier.h
TEST=autoninja -C out/Debug_chromeos/ unit_tests
./out/Debug_chromeos/unit_tests
Files chrome/browser/ash/login/quick_unlock/fingerprint_storage.cc
chrome/browser/ash/login/quick_unlock/fingerprint_storage.h
Change-Id: Ia52417257959bb5252571251b0cbc25dee485b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304060
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Patryk Duda <patrykd@google.com>
Auto-Submit: Patryk Duda <patrykd@google.com>
Cr-Commit-Position: refs/heads/main@{#952400}
The current PrivacySandboxSettings service, located in chrome/ serves two high level purposes: 1) Determine whether APIs are allowed or not 2) Support Privacy Sandbox user facing controls Consumers of the logic for (1) are heavily component based. With planned API launches this will only increase, and so having this functionality available in components/ is very desirable. The logic for (2) however is tightly bound to the chrome/ UI on Desktop + Android. It also has significant reconciliation logic, touching many parts of sync & identity. (2) is of questionable value for other embedders, and attempting to componetize it introduces a large set of dependencies. This CL is the first of achieving componetization of (1), which is the splitting of functionality into two separate services, both of which remain in chrome/ for now. *No* new or changed functionality is introduced by this change. Functions and tests are simply moved, with only minor adjustments to reflect the new separation. Bug: 1154686, 1210405 Change-Id: Iafb16a182a4429082fd72d5ed6c063bc4ade00fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341515 Reviewed-by: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/main@{#952401}
- Retries after provisioning fails - Implemented in upstream CL Bug: 1198187 Change-Id: I7d0c34f40db17736bf2a6a8cb04cee1355d55671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343213 Reviewed-by: Gavin Dodd <gavindodd@google.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#952402}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12bcadba3580..d3307fe8ab11 2021-12-16 aerotwist@chromium.org Remove patchColorText from Performance Monitor 2021-12-16 aerotwist@chromium.org Add tests for getComputedValue in ThemeSupport 2021-12-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-12-16 aerotwist@chromium.org Add per-target caching to theme support 2021-12-16 tvanderlippe@chromium.org Remove unused scripts 2021-12-16 arichiv@chromium.org [Client Hint Issue] (3) Implement devtools issue {DEVTOOLS} 2021-12-16 tvanderlippe@chromium.org Remove all_devtools_files.gni 2021-12-16 tvanderlippe@chromium.org Cleanup legacy-defs.d.ts 2021-12-16 dsv@chromium.org Load source maps via chrome-extension:// on the frontend. 2021-12-16 tvanderlippe@chromium.org Replace Runtime.assert with Platform.DCHECK 2021-12-16 wolfi@chromium.org Improve hover text for cells in DataGrid and Protocol Monitor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1219359,chromium:1278738,chromium:212374 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1aedce9cd262c75c2a9014fe3e557e4091d42853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345183 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952403}
FingerprintMessage returned by biod contains either ScanResult or
FingerprintError. ScanResult is recorded by Fingerprint.Auth.ScanResult,
so it would be good to create Fingerprint.Auth.Error to record errors.
BUG=b:184843581 b:197959527
TEST=Generate Fingerprint.Auth.Error (try to authenticate after FPMCU
reboot, it should generate NO_TEMPLATES error codes). Check if
chrome://histograms contains that information.
Change-Id: I426d77dfb3a64913301f5241c5bee0edbf7fad02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327237
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Patryk Duda <patrykd@google.com>
Cr-Commit-Position: refs/heads/main@{#952404}
CanvasContextCreationAttributesCore uses strings to hold values for PredefinedColorSpace and CanvasPixelFormat. Use enum values directly, instead of converting back and forth between strings. Change the function ColorSpaceNameIsValid, which previously checked string names to ValidateAndConvertColorSpace, which converts from the V8 enums to blink enums. Move the CanvasPixelFormat enum to graphics_types.h, whether similar enums are, and remove the adjacent DataU8ColorType, which was unused. Bug: 1274220 Change-Id: Id013346d62a052f436283433acca0d63ba9f8457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336491 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#952405}
The hasDefaultHandler method was doing something weird so has been replaced by the willShowDisambiguationPrompt function, which is hopefully easier to understand and is more correct. Some variables have been renamed in the calling function to make the logic a bit easier to follow. Change-Id: I13a235c4f652e4325ca20063f06a2aad96edbc6d Bug: 1251722, 1278017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261929 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#952406}
Change-Id: I72f6639c9ac4713e1a13d4a2e0e56e4411423e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343695 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#952407}
base::FeatureList::IsEnabled() is somewhat expensive, as each call looks into the override map (with string, not pointer comparison), which can contain hundreds of entries. From field data, this call in the task scheduler is responsible for >1% of all main thread CPU usage in renderers on Windows (and a similar figure in other processes). See for instance (Google-internal): https://uma.googleplex.com/p/chrome/callstacks?sid=ea1b1d0e9303312911ed3bff46e02572 Cache it in a per-instance bool instead, removing the overhead. Bug: 1262205 Change-Id: I14114ad959cb3e09d78dd757b78ee2b56cda229f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341060 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#952408}
… unittests This AshDisplayUtil helper class serves to abstract away all display related Ash calls from the remoting code, to simplify the code and to allow unittests to inject fake displays. It is currently a bit overkill for the AuraDesktopCapturer, but in a follow-up CL I will also start using this to support all displays in AuraDesktopCapturer and DesktopDisplayInfoLoaderChromeOS. Bug: b/208370410 Test: New unittests remoting_unittest. Test: Manually started a CRD connection. Change-Id: Ieef8d43e1f162ffe7bfb94b1949d43d6a4339d2e Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314558 Reviewed-by: Joe Downing <joedow@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/main@{#952409}
Addressing post-commit comments from gab for the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/3342029 R=sky@chromium.org CC=gab@chromium.org Bug: 1279860 Change-Id: I0d8379fa103186f661178a22a34431b58ee477cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345226 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#952410}
So that window can restore from the current window state to any previous applicable window state. Please see go/window-state-restore-history for design doc. Bug: 939031, 990494 Test: fixed existing tests and added new tests Change-Id: Ie6623f70c8c1f0c7e7e84743f746848c4649382d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314057 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/main@{#952411}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: Iebaace79e57cc83cdc263c46e8b65df35a42303d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345164 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952412}
This change adds IDs for pseudo elements created during a DocumentTransition and the style parsing code to apply style rules to these elements. R=futhark@chromium.org Bug: 1277009 Change-Id: I74894a2d21e2665d4343805d3f4148b95c0df323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340491 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/main@{#952413}
This is a workaround to avoid breaking Clank. After landing the implementation in Clank, the added methods should be made abstract. Bug: 1278767 Change-Id: I8ae31631e5aa981859798a849e0b5a90bfae2f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344752 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#952414}
Add presubmit warnings for adding new Android InfoBars 1. Check whether a new id is appended in infobar_delegate.h 2. Check whether new files are created under android infobar related folders Bug: 1233156 Change-Id: I0e9b0800cb806196e4432b0fbd5439c1d0dd937d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328682 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/main@{#952415}
The part of logic that can be shared with Lacros is being extracted from DlpContentManagerAsh to the base DlpContentManager class. Bug: 1254326 Test: Trybots passing so Ash logic still works, tests to be adapted for Lacros Change-Id: I98e00cac1f598fc33573faff4001b6045e0d1613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317978 Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#952416}
No behavior is changed. In the unit test we use base::Value::DictStorage rather than base::Value in some helper functions according to the recommendation [1] that type safety should be kept when possible. [1] https://source.chromium.org/chromium/chromium/src/+/main:base/values.h;l=17;drc=78c732528f041ae775ead234a467a4146baaefa8 Bug: 1187061 Change-Id: I05d61181905d1d0aa8d663878301600326ade251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344661 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/main@{#952417}
net/cert/ev_root_ca_metadata.cc and codegen it in a fashion similar to what is done with the Chrome Root Store. Bug: 1271177 Change-Id: Ieb92d5bb5cbd21d830fa051f4a0d77700b3c0fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330334 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Hubert Chao <hchao@chromium.org> Cr-Commit-Position: refs/heads/main@{#952418}
This CL is a noop and a simplified replacement for https://crrev.com/c/3327209. Before this CL, all modifying operations would rely on a list of changes that occurred because of the operation. With GMS storing passwords, deletions can't be reliably computed. Therefore, modifying operations should alternatively return a nullopt that allows to rerequest all logins (will be done in follow-ups). To realize the support for retained logins, all interface accept an absl::optional<PasswordStoreChangeList> as a callback reply which allows to respond as before. Unrelatedly, this CL increase test coverage for delegating methods to backend (save/update/delete). Advantages over https://crrev.com/c/3327209: * rerequesting full list can happen exactly once after all operations succeeded and won't be done for each modifying op (esp. for chained) * simpler interface (for async methods and job helper) Bug: 1267912 Change-Id: I44c8cbe5aa9c0b2edad34bdea10e4e77b85492f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327209 Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/main@{#952419}
Increase WebEngine size limit from 39MiB to 39.19MiB (200KiB) to provide some room for growth while developers are out of office and not actively monitoring. Change-Id: Iac2af327fa7099058152ff4a1359f38323d9c536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345192 Reviewed-by: Benjamin Lerman <qsr@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/main@{#952420}
Because the bubble widget and view are now cached between shows focus was left on the most recently launched app item view when the launcher was opened more than once. Explicitly focus the search box whenever the apps page is shown. Likewise, explicitly close any open folder when closing the launcher. Bug: 1280453, 1280473 Test: added to ash_unittests Change-Id: Icb9c874dacc482ed6b769ad1df06733e18976f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343628 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#952421}
To be better aligned with the way other platforms capture and visualize their web vitals metrics in UMA, this CL now uses the CustomTimes function to specify the Web Performance Metrics histograms' time range (10ms - 10mins) and bucket number (100). Bug: 1267902 Change-Id: I8a02091b648a005363708e4ae6f06dfb684f4734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342167 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Daniel White <danieltwhite@google.com> Cr-Commit-Position: refs/heads/main@{#952422}
Adds a metric to log the result of account key writes (success or failure) and adds a metric to log the account key failures. Change-Id: I8f4de33f62af1e7b13b95635df6bb93716a38d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324521 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#952423}
Bug: 1229305, b/193073480 Change-Id: I346ccc2931a2ebf6010f7aed0b5a0782f5bc16f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292373 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/main@{#952424}
Bug: 1278578 Change-Id: Id3e72c3c1631855d1abf9243967ce9677ba8476c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329126 Reviewed-by: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Chris Bookholt <bookholt@chromium.org> Cr-Commit-Position: refs/heads/main@{#952425}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639655564-d026ceb91a231de8d6a03514285e6e87b8f8c916.profdata to chrome-win32-main-1639666549-84a7c26e97b827581984ac991aa2569f15b40ef8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I44bff6feb09bea6221734e2fcb719f9eb7075a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345184 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952426}
Previously it was only used for a few local schemes. In a future CL, the appHistory API will use its referrer policy for a policy check of its own. Bug: 1280010 Change-Id: I68a1e706f3f900f91fdafd0a5c5a1c632a3ae897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339611 Reviewed-by: Charles Reis <creis@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#952427}
We are looking to move histograms out of metadata/others/histograms.xml into more appropriate directories. This CL moves the CompositorLatency.* metrics out and into metadata/compositing/histograms.xml to be alongside the Compositing.* and Graphics.Smoothness.* metrics that measure other aspects of the compositing pipeline. This only leaves a few Aura/Blink histograms that reference the compositor without measuring it. Change-Id: I4f6a2f90b0f6ce9a92c3b3e179e6e24f9544f3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343247 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#952428}
When the Passwords in Other Apps modal is triggered via Settings > Passwords > Passwords in Other Apps, it will now display a new header image (light & dark mode), as well as instructional text below informing the user on Google Password Manager best practices. Importantly, the instructional text changes, depending on whether the user is syncing passwords or not. You can learn more about this task and the expected UI changes here (navigate to section 2, task 4): http://shortn/_i1n8nDmtoH Screen recordings: Light mode (syncing): https://drive.google.com/file/d/1Nf8MRYDObOJTofZwUo1xMNl1m-tmIjVP/view?usp=sharing&resourcekey=0-cJbbhcnmPCfCmGlFss1Xig Dark mode (syncing): https://drive.google.com/file/d/1YWOQ7jUTN2TlzqnzBk-xE0hs4lS03EgX/view?usp=sharing&resourcekey=0-BzcHXFODlkxN7y9tkGAe7w Light mode (not syncing): https://drive.google.com/file/d/11AcCOznVUqZRLZYp6bwaxm0gNTR7b0nn/view?usp=sharing&resourcekey=0-tFA17RerHm0cqKXoOfzcgA Bug: 1267958 Change-Id: Ied12c33b2caca0d30fd18c165371cb31c54bcf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309056 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Benjamin Williams <bwwilliams@google.com> Auto-Submit: Benjamin Williams <bwwilliams@google.com> Cr-Commit-Position: refs/heads/main@{#952429}
Those files were recently moved from tools/mac/power/ to components/power_metrics/ and the namespaces were not updated. Change-Id: I7392e2802ae8663e435ce6c7b2dfff50471d223a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335018 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#952430}
https://webrtc.googlesource.com/src.git/+log/8d87c463d9de..9754a43403e0 2021-12-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7eb1999..389e3b2 (952228:952342) 2021-12-16 cschuldt@google.com Optimize the three band filter bank. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I61d7e1bbf154363dbac42768582af232a5b5cb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345185 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952431}
Bug: 1277166 Change-Id: I71d2d68ea275e028b7f3db04c2aada3781d06e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342409 Reviewed-by: Guillaume Jenkins <gujen@google.com> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/main@{#952432}
This patch ensures that we overflow:scroll and overflow:hidden do not expand the bounds of the clip, even if we have contain: paint (which clips to overflow clip edge). R=ikilpatrick@chromium.org, chrishtr@chromium.org Fixed: 1252885 Change-Id: Ie52be3b9201a70e3de014f190cbd3ce00b170d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330347 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#952433}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
pull bot
pushed a commit
that referenced
this pull request
Jan 8, 2023
(cherry picked from commit da543cb) Bug: 1402113 Change-Id: Ie04d5e603c7f0e8f33ad88705187a80fe16e3c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117069 Reviewed-by: Sergey Poromov <poromov@chromium.org> Commit-Queue: Daniel Brinkers <brinky@google.com> Cr-Original-Original-Commit-Position: refs/heads/main@{#1085416} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134065 Auto-Submit: Daniel Brinkers <brinky@google.com> Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/5481@{#122} Cr-Original-Branched-From: 130f3e4-refs/heads/main@{#1084008} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134171 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1090085}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )