forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing scheduler order number DCHECK when called from ShouldYield.
Fixes https://crbug.com/1400202. The unit test's code is the simplest explanation: ShouldYield is called from a task that hasn't released its fence, FindNextTaskFromRoot asserts because the sequence's next task order_num is greater than the wait fence's order number. This is harmless if there is only scheduler thread (because the recursion into FindNextFromRoot immediately terminates because the sequence is already running). Leaving the check until I find the root cause of https://crbug.com/1400203. Bug: 1400202 Change-Id: I459a06c0725552df3855dbad6db67833bfeafcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4110028 Auto-Submit: Ramy El Garawany <elgarawany@google.com> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084008}
- Loading branch information
Ramy El Garawany
authored and
Chromium LUCI CQ
committed
Dec 15, 2022
1 parent
6d6df64
commit 130f3e4
Showing
2 changed files
with
64 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters