forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from chromium:main #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by one pixel off when converting between DIP and pixels. Window geometry is not sent to the server when the visual size update doesn't match the bounds in pending configure. The off-pixel comes from the implementation difference in the gfx APIs ScaleToRoundedRect and ScaleToRoundedSize. It is possible that gfx::ScaleToRoundedRect(rect).size() != gfx::ScaleToRoundedSize(rect.size()). When setting the window bounds, the former is used, while in ProcessVisualSizeUpdate the latter is used. I have changed the conversion to use the same function. Bug: 1272127 Change-Id: Ibc9b908c62688d61cec0c71b9788ba489dc2d558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336510 Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/main@{#951502}
Fix a use-after-move issue in GpuHostImpl, as found by clang-tidy: components/viz/host/gpu_host_impl.cc:111: 'params' used after it was moved components/viz/host/gpu_host_impl.cc:107: move occurred here Bug: 1122844 Change-Id: I6f1e3aff9eb8c2dc8b49320b8837dbcf558e444d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337097 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/main@{#951503}
Bug: none Change-Id: I1634131046b3130e17c9e2dd2dd00c20c6f7de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338779 Auto-Submit: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/main@{#951504}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I415d2a93f844f0f5c3dadad937e0db52b684cc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338942 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951505}
Change-Id: I71d53dd162eb064ed4561aabcf64427e5e2f6c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329858 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/main@{#951506}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I6beb80f5e10ac4d22887c553a09d75902f4d983c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338941 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951507}
v8::Object::CreationContext is deprecated, replace users with one of the two following alternatives: - MaybeLocal<Context> v8::Object::GetCreationContext() - Local<Context> v8::Object::GetCreationContextChecked() Bug: v8:11165 Change-Id: I1ebfc6948dc0c1d289d31d07fca7d940b2fa9073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275976 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#951508}
Bug: 1260245 Change-Id: If6ecaf5309f6fe48789776ffe6bf39d1b4ccaeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335175 Auto-Submit: Fabrice de Gans <fdegans@chromium.org> Reviewed-by: Benjamin Lerman <qsr@chromium.org> Commit-Queue: Benjamin Lerman <qsr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951509}
According to the spec, this is a reserved name, so simply demand that every CSS variable is at least three characters instead of two. Bug: 1220145 Change-Id: I9930b9c4f364d20aedc21496b2488d80ecde9b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338991 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#951510}
Implement `AccountAppsAvailability::OnAccountRemoved`. Bug: 1260909 Change-Id: I3025d79db96dada448003304818445a48806cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310598 Reviewed-by: Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#951511}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: Ibb22196f056502a5477fea8909dd5d47de1c4187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339271 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951512}
Bug: 1256405 Change-Id: I329705b753a0acab6f48836b527737842a741d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336858 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@google.com> Cr-Commit-Position: refs/heads/main@{#951513}
"cannonicalUUI" => "cannonicalUUID". Bug: none Change-Id: Ieed062f25fcf8d1cf4ac811803a115ceb82c484f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335139 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951514}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202112140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/OEszP2fR0fctn9Qr3fnIElqnNLPxHyhTUfWfaiiLVckC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/154430508,b/201610516,b/208717940,b/209348713 Tbr: media-app@grotations.appspotmail.com Change-Id: Icfc332c110e92c301f36752152935519083b1811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338943 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951515}
This reverts commit b6f385e. Reason for revert: Lens-specific latency issues Original change's description: > Launch Lens image search on desktop at ToT. > > Also disables the image search URL change if on a non-desktop platform. > > Bug: 1168677, 1222313 > Change-Id: I855e3838e344ba260b8829a2f8cc355f2c31e2da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328902 > Reviewed-by: Ben Goldberger <benwgold@google.com> > Reviewed-by: Orin Jaworski <orinj@chromium.org> > Commit-Queue: Juan Mojica <juanmojica@google.com> > Cr-Commit-Position: refs/heads/main@{#951102} Bug: 1168677, 1222313 Change-Id: I04fef9927042441202d6a32657177da285d78226 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335318 Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Owners-Override: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951516}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202112140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/RcDM8Mq_LrCGiuxfQto-gkDVFbqCRy6FE8lzPeHsNEwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I49a0f44493d3de2379a9f8dcb6f21f04fcdca8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338945 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951517}
fold large SDP (10+ sections) by default. With unified-plan the sdp can become huge and scrolling becomes a problem. The mid attribute is added to the summary which allows searching for a media section by mid BUG=None Change-Id: If079b012721df2809baec6064ee1ff73d6c532f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298812 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#951518}
This is a reland of dabe981 The only change is in resource_ids.spec. The previous CL ran out of ids, so this CL takes the ids of the recently removed telemetry resources. Original change's description: > system-extensions: Add system-extensions-internals > > chrome://system-extensions-internals is behind the kSystemExtensions > feature flag and will allow users to sideload a System Extensions. > > For now it just has a button that shows a dialog when pressed. > > Bug: 1192426 > Change-Id: Ib3717bc5fe390de1813612a5fdd75e70c8a65ed0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301576 > Reviewed-by: Christopher Lam <calamity@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949849} Bug: 1192426 Change-Id: Ibb7338e436856ebb397e41343eb8ef9e39726953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329045 Auto-Submit: Giovanni Ortuno Urquidi <ortuno@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#951519}
To include --api feature added here: https://chromium-review.googlesource.com/c/chromium/src/+/3260556 Change-Id: Iaa647b8ae65c8a21eb60b45715b536b191f8d74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336296 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#951520}
…rtup" This is a reland of 51e414a It introduced a flaky test. This updated patch changes the way we wait for the page to be rendered, avoiding the race condition between load stop and first non empty render at the origin of the failures. Original change's description: > Record new metric for first render time on profile picker startup > > This will allow covering a blind spot in startup performance > monitoring introduced by the rollout of showing the profile picker > on startup. (which happens when users have 2+ profiles and the > option to show the picker enabled) > > ProfilePicker.FirstProfileTime.FirstWebContentsNonEmptyPaint and > ProfilePicker.FirstProfileTime.FirstWebContentsFinishReason > are the 2 new metrics added for this. > > To record them, we are following a very similar pattern to the one > used for the affected metric,Startup.FirstWebContents.NonEmptyPaint3. > This CL refactors the profiler used to record it to cover both use > cases. > > > Bug: 1273909 > Change-Id: Id25f3e94cf77b5562067304425ebe45c255f0a97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295409 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949499} Bug: 1273909, 1278012 Change-Id: I1263a35d8e8e48af49cfb30cefe08d94fd529912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326461 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/main@{#951521}
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/738cc02fc3be..188fb4eba05a $ git log 738cc02fc..188fb4eba --date=short --no-merges --format='%ad %ae %s' 2021-09-22 pdk system_api: Introduce FingerprintMessage protobuf 2021-12-07 charleszhao hps: add HpsResultProto for hps dbus. 2021-11-11 kimjae system_api: Add update_engine toggle feature constant 2021-12-05 genechang rmad: Change index type of region/sku/WL list from unsigned to int 2021-11-23 dlunev cryptohome: Add dbus and CLI endpoints for new mount calls. 2021-11-18 dlunev cryptohome: add UDA handlers for direct Mount ops Created with: roll-dep src/third_party/cros_system_api Also pdate ScanResult enum in fingerprint.mojom to match definition in third_party/cros_system_api/dbus/biod/constants.proto and avoid compilation issues. BUG=b:184843581 b:197959527 TEST=autoninja -C out/Debug_chromeos/ services_unittests ./out/Debug_chromeos/services_unittests TEST=autoninja -C out/Debug_chromeos/ browser_tests ./out/Debug_chromeos/browser_tests Change-Id: I680570128bbdde7d2513378d51cc0523905dc94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327236 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com> Cr-Commit-Position: refs/heads/main@{#951522}
The existing non-configurable Chromium extensions are now individually configurable, with a flag JSON_PARSE_CHROMIUM that enables them all. This also adds metrics to record the non-standard extension usage, to see if any of these can be dropped. In order to avoid breaking the numerous callers of the JSONReader, the parse options default to the Chromium-style. Bug: 1269888 Change-Id: Ib9a79ec11c457e61e3f88e82f5569e2864655b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289910 Reviewed-by: danakj chromium <danakj@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Tien Mai <tienmai@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/main@{#951523}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d49909553bd8..241290db3761 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sreejakshetty@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sreejakshetty@google.com,tmartino@google.com Change-Id: Ied5601602ffb87ac4381bbe1db3d5298e5ddddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338947 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Owners-Override: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/main@{#951524}
Fix a use-after-move issue in FuchsiaCdmManager, as found by clang-tidy: media/fuchsia/cdm/service/fuchsia_cdm_manager.cc:279: 'cdm_data_quota_bytes' used after it was moved media/fuchsia/cdm/service/fuchsia_cdm_manager.cc:272: move occurred here Bug: 1122844 Change-Id: Id7f292e61bffc837d0e1db8adba49c1544a57334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337256 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951525}
When enumerating device services support kBluetoothSDPDataElementTypeUUID in addition to kBluetoothSDPDataElementTypeDataElementSequence. Devices with only one DSP entry return this record type. Bug: 1261555 Change-Id: I297ed995cdcbc822ea74ff975513a8c5becf28fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331525 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951526}
I've been working/changing on that directory for almost a year. Finished the context menus and bulk actions projects and working currently on the Tab search project. Sample CLs: https://chromium-review.googlesource.com/c/chromium/src/+/3025364 https://chromium-review.googlesource.com/c/chromium/src/+/2904466 https://chromium-review.googlesource.com/c/chromium/src/+/2993158 https://chromium-review.googlesource.com/c/chromium/src/+/2852444 Change-Id: I16570c126b956b5175cc4428f463c81708fde690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335456 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/main@{#951527}
Minor fix to removed variable in BluetoothSerialPortImpl::OpenSocket(). Bug: none Change-Id: I9d99be1aea2b9b5a353e4287c5fb6647282ec810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330920 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951528}
When compiling with GCC the compiler warns about it: warning: 'warn_unused_result' attribute only applies to function types [-Wattributes] Bug: 819294 Change-Id: Ia522e6743f5e0591efce2e5060c4e0aa0a4fb92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338342 Reviewed-by: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Ivan Murashov <ivan.murashov@lge.com> Cr-Commit-Position: refs/heads/main@{#951529}
From the crash report, we can see the crash increases from 98.0.4729.0, and guess the potential reason might be related with CL:3295763. From the call stack, it looks like windows are added to arc_window_candidates_, but not removed when the window is destroyed. One guessing is at the very early stage, OnWindowInitialized, the window might haven't beed added to the browserlist yet, so IgnoreWindow returns false. But when the window is destroyed, IgnoreWindow returns true, because the window has been added to the browserlist, and FindBrowserWithWindow in IgnoreWindow returns true. This might cause the window is added to arc_window_candidates_, but not removed from arc_window_candidates_. This CL removes the checking of IgnoreWindow in OnWindowDestroying, because if IgnoreWindow returns true in OnWindowInitialized, then OnWindowDestroying should not be called. Otherwise, we can still go through the code in OnWindowDestroying. BUG=1278231 Change-Id: I28d4067c2572fde05b8b9b12fbc3b6e7ff622c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337279 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951530}
Storing bootstrap token during SyncServiceCrypto::SetDecryptionPassphrase() is safe, because passphrase is verified against pending keys and storing wrong key (in extreme rare cases, when passphrase is changed before it reaches the sync engine) is harmless anyway. This CL adds the code to store bootstrap token during SetDecryptionPassphrase() and cleans up SyncEncryptionHandler::OnBootstrapTokenUpdated(). Bug: 1276958 Change-Id: Ic17bf63aed75b6507de51e398af681c52679f12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322914 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/main@{#951531}
In cases where the GPU/browser crash often (or early on) it is possible to get multiple display state updates in succession. Discard old events to de-dupe them and only update state related to the latest event. Bug: b/210004562 Test: None Change-Id: I60c892d128f9be52fb498a001328d2f23e9ac20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330324 Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/main@{#951627}
https://android.googlesource.com/platform/external/perfetto.git/+log/1357bd132733..f9abf9948a18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3c99ea5a5590ecf8643326783e8f82295f4528d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339651 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951628}
https://skia.googlesource.com/skia.git/+log/16d3cc04cc85..f74c7893fc17 2021-12-14 jlavrova@google.com Introduce SkVM Op::duplicate to localize visualization code 2021-12-14 djsollen@google.com Add Android Framework specific logging to SkSurface::MakeFromBackendTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: If0c8c135e68b48f80ad19b173097d5b8fd680791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339559 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951629}
With this change, when a template is launched, we create a new desk and switch to it (without animation). Apps are then launched and the overview grid is populated. This change makes it so that windows that are opened while in overview will be inserted into the overview grid. Previously, such windows would just appear as normal windows. This is done by having OverviewSession observe the desk root windows for new children. Bug: 1234855 Change-Id: Ifc0bc752e150535d88f846351a184a11cec8a26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299199 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Daniel Andersson <dandersson@chromium.org> Cr-Commit-Position: refs/heads/main@{#951630}
Found via lsan. Bug: 1279543 Change-Id: Id276502b193df7f8cdf5330f1bcc24c8978fceea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335438 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951631}
At this stage it's very likely that the given url will be requested. There is still ~60ms at median time between when a navigations starts and when the request is made. At the same time, DNS resolution & TCP connection latency has a median of 130ms. So preconnect at the constructor to parallelize some of this. Bug: 1276493 Change-Id: Ia467befc9536c1c1794e298574b77a5a656b563a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330926 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/main@{#951632}
…nt unlock disabled from num attempts Fix string for fingerprint unlock disabled from attempts Change-Id: Ibcd9d99ed07e958c2d1a245b2d93d42b604cb0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335367 Reviewed-by: Thomas Tellier <tellier@google.com> Commit-Queue: Jason Rhee <jasonrhee@google.com> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/main@{#951633}
Fix use-after-move in a debug assertion in WebRequestInfoInitParams, as found by clang-tidy: extensions/browser/api/web_request/web_request_info.cc:184: 'navigation_id' used after it was moved extensions/browser/api/web_request/web_request_info.cc:180: move occurred here Bug: 1122844 Change-Id: Idb2aedf94250e8fadf36b5d2b474478250f96f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335917 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951634}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639483122-b852875a95ce2ee39f0bd733dae39836e0f19b13.profdata to chrome-win64-main-1639504726-a5cec93f623091d76267247a1ff888db818a2b02.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I01aae8df850d120241824c7e22ea2f3b7590dffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339555 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951635}
This removes nonsfi support from chrome/. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I1cf7a72bd7b8c68a12c09a4ef974c4092357d78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338140 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951636}
When switching tabs the tab strip redraws all tabs in the top chrome. When a window has many tabs the time to generate a Skia path for each tab becomes noticeable. This time comes down to mallocs - each operation added to the path results in a realloc of the verb and point buffers inside the path. This cl sizes those buffers large enough at the start to avoid the successive reallocs. Bug: 1278509 Change-Id: I4eed9749e3fa1e7195e916cb6abfde1fd36387d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328883 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/main@{#951637}
These parameters were used to support ConnectRouteByRouteId, which was deprecated long ago and removed in https://crrev.com/948740. As part of this change the following other code was removed: - Tracking media routes by source_id in the MediaRouter. - Tracking joinable_route_ids in the MediaRouter. - MediaRouteProvider::UnregisterMediaRoutesObserver became a no-op and can be removed from the MediaRouteProvider mojo interface. Some changes were required to the browser test fixture to handle route observer updates happening at an earlier time in some tests. This also rewrites some of the test cases for MediaRouterMojoImpl to stop instantiating an additional mock media router (which looks like a bug). There are some followup cleanups noted but this change is large enough that I don't want to take them on right now. Bug: 882481 Change-Id: Iedf85958024ddee60268d823f41fbae2317cd80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315876 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951638}
This CL moves a common header+impl to the new base folder as it will be referenced in a follow-up IPC macro conversion CL. As part of this change I am removing the Windows dependency that class has as it calls IsD3DAvailable() in the c'tor which is a blocking call. It doesn't seem right that creating an instance should spin up another process and block on the results (especially for what appears to be a simple struct-like class). Change-Id: I01d1aea8ae6ee99df1f14bf7186dbabd8becf841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336416 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/main@{#951639}
- Rename target from "build" to "build_ts" - Changed output folder to "tsc" instead of re-using the input folder as output. Bug: 1189595 Change-Id: I36dfe216befa89e3b4001b6a4a13b27e98d3438e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327461 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951640}
This patch implements some row break avoidance. Specifically we might encounter a breakpoint which is unappealing, and want to move the grid item into the next fragmentainer. However the row might also have an "avoid" break-between. In these cases we can get a slightly better result by searching if there are any rows within the current fragmentainer with an "auto" break-between. Bug: 614667 Change-Id: I6f59bda158ce7536e78da296809efd884feb10a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336514 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#951641}
Report the new PercentDroppedFrames2 metrics in the rendering benchmark. The purpose is to find stories that report different values for the new and old metrics, and collect their trace to do deeper analysis. BUG=1256879 Change-Id: Ie1f6a7054326dd7b565034de04a605d36366cd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339411 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#951642}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f761f4e3351..c258c1267440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jarhar@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jarhar@google.com,tmartino@google.com Change-Id: Ib7c5c94e18823ad4b5fe2348bce559d5fd229be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339560 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951643}
Logs the successful and failure retroactive pairing count after a account writing for devices with the retroactive pairing scenario. Change-Id: I09a35f20e95c0a988721d7321829279b70e3e726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321584 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#951644}
MediaTek SoC have a Build.HARDWARE that starts with "mt" [1]. This CL plumbs Build.HARDWARE to the place where we make the decision about using Vulkan. It also adds a new finch param BlockListByHardware to default disable on all MediaTek GPU. We previously blocked MediaTek SoC with Mali GPU by looking for MP or MC in the GL renderer string. Some SoC don't have that. Hopefully this proves more reliable. [1] https://source.chromium.org/chromium/chromium/src/+/main:media/base/android/java/src/org/chromium/media/MediaCodecUtil.java;drc=3f2c552f85487cb39511229ae529e12ea5dcf21d;l=427 Bug: 1235978#c20 Change-Id: Idda2e658737b05abed3ee47d16821a8e92091f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338765 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951645}
This is to add haptic feedback to drag-to-drop operations in following three cases in overview mode: 1. Tick effect when a window starts to be dragged. 2. Tick effect when a desk starts to be dragged. 3. Tick effect when the window being dragged reaches a desks. Test: Manual Bug: 1277322 Change-Id: I7666c60af5bf5a2de768bc5135a58fdeeba82de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331239 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Yongshun Liu <yongshun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951646}
This CL adds QueryTileSection to start surface and the feature is disabled by default. Will work with UX on follow up CLs to fix margins, tile sizes etc. Bug: 1269921 Change-Id: I1b4c2e523c53fa0bba9ba79f2cb112d61eea54f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318763 Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Wei-Yin Chen <wychen@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951647}
See two kinds of failures in the log: 1. path error due to duplicate layout-test-results in the path. 2. trying to upload files that does not exist, e.g. /b/s/w/ir/out/Release/layout-test-results/OK Change-Id: I6f6df9559a18807dbe2c676297f79651a71bba94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333755 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#951648}
The ReportRequest is a type alias based on Operating system. It's enterprise_management::ChromeOsUserReportRequest for Chrome OS and enterprise_management::ChromeDesktopReportRequest for other platforms. However, this is no longer work when adding the third proto which is available on all platforms. This CL create a new ReportRequest class to wrap the proto and use absl::variant to store the request proto. This class is used to pass request instance between report generator, uploader and scheduler. Bug: 1261945 Change-Id: I0944fc2b82489523f3a1a6030f0c1daa6feab5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324322 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951649}
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fff14ebdcbb0..7f13e5c5ff2d 2021-12-14 juahurta@google.com config: Disable unittests on skyrim 2021-12-14 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-14 shaochuan@chromium.org Reland "Enable android_update_lkgb for master-vmsc-android-pfq" 2021-12-14 shaochuan@chromium.org cros_mark_android_as_stable: handle missing/invalid LKGB file 2021-12-13 briannorris@chromium.org gerrit_unittest: Fix test bitrot 2021-12-13 jaredloucks@google.com paygen: double test suite timeout 2021-12-13 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3e0d0b3268a69251032050c53bf6f62d933366c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339389 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951650}
Roll Chrome Linux PGO profile from chrome-linux-main-1639483122-20e6b9acc183f41a276a93022da6f201498b4d81.profdata to chrome-linux-main-1639504726-00818556d27ae6f0ca222d22829579a009d0b826.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I430a64bb921f2e1d20e0376d18cfe42b5790ea71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339734 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951651}
The two histograms' expiry is extended by six months as these metrics are still useful, but this part of the codebase is experimental. Bug: 1277106 Change-Id: I654ee696ce4db688300425cfdd58d4148152c684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337016 Auto-Submit: Alex Turner <alexmt@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/main@{#951652}
… Linux" This reverts commit 3ce540b. Reason for revert: Fixed in crbug.com/1273568 Original change's description: > sheriff: Disable failing WebAppIntegrationBrowserTest test on Linux > > The tests are flaky on Linux causing CI builder failures. > > Bug: 1277870 > Change-Id: Id27ff02e966d302875ed86c45273a76b9328e72d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320396 > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Owners-Override: Swapnil Gupta <swapnilgupta@google.com> > Auto-Submit: Swapnil Gupta <swapnilgupta@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949456} Bug: 1277870, 1273568 Change-Id: I319a0038823d85a0f3272e373e755158b4aeb0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339398 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951653}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )