Skip to content

Commit

Permalink
Revert "sheriff: Disable failing WebAppIntegrationBrowserTest test on…
Browse files Browse the repository at this point in the history
… Linux"

This reverts commit 3ce540b.

Reason for revert: Fixed in crbug.com/1273568

Original change's description:
> sheriff: Disable failing WebAppIntegrationBrowserTest test on Linux
>
> The tests are flaky on Linux causing CI builder failures.
>
> Bug: 1277870
> Change-Id: Id27ff02e966d302875ed86c45273a76b9328e72d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320396
> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
> Owners-Override: Swapnil Gupta <swapnilgupta@google.com>
> Auto-Submit: Swapnil Gupta <swapnilgupta@google.com>
> Reviewed-by: Pavol Marko <pmarko@chromium.org>
> Commit-Queue: Pavol Marko <pmarko@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#949456}

Bug: 1277870, 1273568
Change-Id: I319a0038823d85a0f3272e373e755158b4aeb0e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339398
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951653}
  • Loading branch information
dmurph authored and Chromium LUCI CQ committed Dec 14, 2021
1 parent 1330dd1 commit 9398d16
Showing 1 changed file with 2 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1575,17 +1575,9 @@ IN_PROC_BROWSER_TEST_F(
helper_.CheckWindowCreated();
}

// TODO(https://crbug.com/1277870): Flaky on Linux builders.
#if defined(OS_LINUX)
#define MAYBE_WebAppIntegration_InstOmniboxSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated \
DISABLED_WebAppIntegration_InstOmniboxSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated
#else
#define MAYBE_WebAppIntegration_InstOmniboxSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated \
WebAppIntegration_InstOmniboxSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated
#endif
IN_PROC_BROWSER_TEST_F(
WebAppIntegrationBrowserTest,
MAYBE_WebAppIntegration_InstOmniboxSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated) {
WebAppIntegration_InstOmniboxSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated) {
// Test contents are generated by script. Please do not modify!
// See `chrome/test/webapps/README.md` for more info.
// Sheriffs: Disabling this test is supported.
Expand Down Expand Up @@ -1642,17 +1634,9 @@ IN_PROC_BROWSER_TEST_F(
helper_.CheckWindowCreated();
}

// TODO(https://crbug.com/1277870): Flaky on Linux builders.
#if defined(OS_LINUX)
#define MAYBE_WebAppIntegration_InstMenuOptionSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated \
DISABLED_WebAppIntegration_InstMenuOptionSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated
#else
#define MAYBE_WebAppIntegration_InstMenuOptionSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated \
WebAppIntegration_InstMenuOptionSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated
#endif
IN_PROC_BROWSER_TEST_F(
WebAppIntegrationBrowserTest,
MAYBE_WebAppIntegration_InstMenuOptionSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated) {
WebAppIntegration_InstMenuOptionSiteA_WindowCreated_InListWinSiteA_InstPlcyTabShctSiteA_InListWinSiteA_LaunchFromIconSiteA_WindowCreated) {
// Test contents are generated by script. Please do not modify!
// See `chrome/test/webapps/README.md` for more info.
// Sheriffs: Disabling this test is supported.
Expand Down

0 comments on commit 9398d16

Please sign in to comment.