forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from chromium:main #113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the proposed CT policy changes behind a default off feature flag (CertificateTransparencyUpdatedPolicy), and also adds a feature flag (CertificateTransparencyUpdatedPolicyAllCerts) that causes changes to apply to all certificates (instead of only to those issued after February 1, 2022). Changes are: -One Google log requirement is removed. -A log operator diversity requirement is added (each certificate needs SCTs from at least 2 logs with different operators). -Embedded SCTs requirement is increased to 3 for certificates with a lifetime between 180 days and 15 months. -Lifetime calculations are now done directly in days instead of months. Bug: 1267104 Change-Id: I7b4a46de421437b0dd621b221fc7e62fa7efeb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306682 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/main@{#951724}
Ensure the error callback to BluetoothSocketMac::Connect() will be called if the success callback is not. Bug: 1261555 Change-Id: I2d5878fbd7f34ac48b0f7b2d6d6f0515cc7375c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331523 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951725}
Bug: 1187061 Change-Id: I931c65283a49ae3cda640cff934e71c691da37f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330387 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951726}
Bug: 1187061 Change-Id: I228a32001622b89a749eb447e1f95bea2138643d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334438 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951727}
Convert BluetoothUUID::PrintTo() to Bluetooth::operator<<(...). This still still allows gtest() macros to work, and also makes it easier to do other debugging-type things like: LOG(INFO) << "UUID is: " << uuid; This was tested by intentionally introducing this test failure: BluetoothUUID invalid; EXPECT_EQ(uuid5, invalid); Without the operator the test output was: Expected equality of these values: uuid5 Which is: 56-byte object <01-00 00-00 AA-AA AA-AA 08-31 31-30 ... 00-00> invalid Which is: 56-byte object <00-00 00-00 AA-AA AA-AA 00-00 00-00 ... 00-00> With the operator this is the output: Expected equality of these values: uuid5 Which is: 00001101-0000-1000-8000-00805f9b34fb invalid Which is: Bug: none Change-Id: If2287e8619950adc57bca64300c3188f5fa92ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330919 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951728}
This change implements a library that manages the connection with the Fuchsia Semantics API. This allows clients to just add / delete semantic nodes, leaving the tree life cycle management up to the library. Clients can register handlers to be notified of specific Semantic events. Please see .h for more documentation. Test: SemanticProviderTest.* Bug: fuchsia:86654 Change-Id: I025ec894a23a6e13812d3642e91ac800cae51eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261610 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/main@{#951729}
https://chromium.googlesource.com/angle/angle.git/+log/fefd7ae66ad9..36fcf80b1f2a 2021-12-14 m.maiya@samsung.com Vulkan: Consolidate SamplerYcbcrConversionCache 2021-12-14 jmadill@chromium.org Upgrade restricted traces to new trace format. 2021-12-14 hailinzhang@google.com Vulkan: Fix dynamic partial update buffer data issue. 2021-12-14 penghuang@chromium.org Support creating EGLImage from VkImage 2021-12-14 jmadill@chromium.org Capture/Replay: Update process for trace upgrading. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1264439 Tbr: timvp@google.com Test: Test: Texture2DTestES3.*Yuv*Vulkan Change-Id: I0caefd8d58db53a43fab7b555119a94b3f76ce12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339766 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951730}
Bug: 1233703, 1241971 Change-Id: I48f754855b6ae462637daf152b279707a0ff3039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331374 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#951731}
- Using an observer because the `on-change` event only fires when the input loses focus. Bug: 1198187 Change-Id: Icdbbcd1848da65d008dd2cc39924691aef2125fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335158 Reviewed-by: Gavin Dodd <gavindodd@google.com> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#951732}
These are powerful permissions that may be important for a page to function at all but also have considerable privacy implications. Normally, their use is indicated by an animated icon in the right side of the omnibox. This change: 1. Has the animated icon announce itself for those two permissions only 2. Adds instructions telling the user how to get to the chip For (1), we considered announcing all such chips instead, but some sites have several of these and doing so produces a deluge of text on page load, which makes it hard to sort the critical permissions (location, etc) out from things like "this page has a PWA available". The set of permissions that get announced is subject to future reconsideration. For (2), the string this change uses comes from UXW. Fixed: 1186399 Change-Id: I3ce216ec9ca433c8ed83540db0916950f7f4fa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336507 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#951733}
Several bubbles use "unified tray" constants, even though they are not part of the system tray. Move these constants into //ash/bubble to make it clear it's OK to use them for non-system-tray bubbles. Bug: 1239825 Test: compiles Change-Id: Iafb7d1736f26f81e48c3779969f4c2b0f582ff3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339811 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#951734}
This feature is default disabled Bug: 1279603 Change-Id: Ib4a60a51fb9aa2c42d306950a04c871412f82300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339403 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Commit-Queue: Marlon Facey <mfacey@chromium.org> Cr-Commit-Position: refs/heads/main@{#951735}
This CL integrates several kinds of GetExpectedTestData*() methods into one helper function. The VerifySession() is also moved to the helper file. These two functions will be used for all types of tests in content capture. This CL also removes unnecessary include files in content_capture_receiver_test.cc. Bug: 1276849 Change-Id: I51b48cf73f0bdeeb0993a18104941e9cd110425c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337880 Reviewed-by: Michael Bai <michaelbai@chromium.org> Commit-Queue: Hyowon Kim <hyowon@igalia.com> Cr-Commit-Position: refs/heads/main@{#951736}
An opt out will be added for our feature where we display price drop annotations where they exist for a URL in the Tab Switching UI. This CL contains the strings for the opt out. This CL is being submitted first to string translations can commence. Bug: 1279950 Change-Id: I18c3dc8d15e7677bbfaadec0049a4e51594bc90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339629 Reviewed-by: Ayman Almadhoun <ayman@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/main@{#951737}
Bug: 1277448 Bug: 1276906 Change-Id: I4fa956e8d30b5a42b3edc65801752d5afce4ee9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331697 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Anunoy Ghosh <anunoy@chromium.org> Cr-Commit-Position: refs/heads/main@{#951738}
Mock HttpProxyClientSockets are only used in proxy error handling tests, introduced in issue #826570, to account for the tests not testing the expected code. The error used to be injected in the TCP connection to the proxy, where almost everything is mapped to ERR_PROXY_CONNECTION_FAILED. It was switched to being injected in a mock HttpProxyClientSocket::Connect. But that ossifies implementation details of how we happen to model parts of HTTP proxies. (E.g. that non-tunnel requests use an HttpProxyClientSocket.) It also then fails to test other mapping effects, for instance that ERR_CONNECTION_CLOSED is very hard to reach in HTTP/1.1 proxy. Moreover, the mock didn't actually help with the original issue. The error mapping lives in HttpProxyConnectJob, which wasn't mocked out. The actual test fix was moving the error from TCP setup to the tunnel setup. This CL switches the test to do that without mocks. In doing so, it turns out ERR_CONNECTION_CLOSED is all but unreachable. I've removed it for now, but we should probably either remove ERR_CONNECTION_CLOSED from the list or add its subtypes. This deletes a lot of code and lets us rework the HttpProxyConnectJob / HttpProxyClientSocket split without affecting as many tests or callers. Bug: 1277656 Change-Id: I0b92fd703670af13c191ce04b24d49c33285d917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318084 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#951739}
Based on UX feedback, this CL makes two updates to the notification: - String updates - Use a grey "Gpp Maybe" icon instead of a red "Gpp Bad" Screenshot: https://screenshot.googleplex.com/74pMnqR9hJPg3Pd.png Bug: 1257621 Change-Id: I89ad53433b42b144ae6767dd76edebadffa4e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328189 Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#951740}
Update TableViewDetailIconCell to support correctly: * one line and 2 lines * big fonts and small fonts * detail text and no detail text The 2 main issue fixed: * With 2 lines, regular/small fonts, the cell is 58pt height. * When the cell has no detail text, the title uses the full cell width. See "Sync" and "Google Services" cell: Big font, one line: before: https://drive.google.com/file/d/11Dn4dWrPA6JH0QE3S_SNABe0pD5fbIN1/view?usp=sharing&resourcekey=0-3uk_3hffKAhFbV3wnfUcUw after (title width and vertical padding fixed): https://drive.google.com/file/d/13o4B90KvDLDfsVRiiOIqt4An8NxsaScY/view?usp=sharing&resourcekey=0-jsrCh9-JsVTwsd-xmsm9RQ Regular font, one line: before: https://drive.google.com/file/d/14TG4rnVRgpik3hJqDaqsvjDNH9_Jtx7p/view?usp=sharing&resourcekey=0-MljdCWep5WBLORjGcSHv-g after (no changes): https://drive.google.com/file/d/1hJufFZx4JtE-1iIz7KPNdum1UDYk1Qxr/view?usp=sharing&resourcekey=0-vlG2bD_j3ig684Y7VJVqJw Small font, one line: before: https://drive.google.com/file/d/1TWDvQcjPiNc2v26mCiULeSoZEOw45Y4N/view?usp=sharing&resourcekey=0-OZPb1ga8MPX0wgHGr41dKQ after (no changes): https://drive.google.com/file/d/1MIJWCxgdlm2HD9JfHfVw8Zv3YKehv8Ag/view?usp=sharing&resourcekey=0-yqVzTjRmg_Hh2TLxxUnMyQ Big font, two lines: before: https://drive.google.com/file/d/1o83B-vV6JQkAaGh1cGs8h3DfPRnYT67E/view?usp=sharing&resourcekey=0-RVMWiea9hkhR7rTgcrtObQ after (title width and vertical padding fixed): https://drive.google.com/file/d/1n_wEQUuJ9oJ73beqXmrFelMxQdcCguLx/view?usp=sharing&resourcekey=0-pxcMwldOfelf12S2e3IJ0Q Regular font, two lines: before: https://drive.google.com/file/d/1pDFDWYDnmy7T3Pwl89bLwoylHofGxkYF/view?usp=sharing&resourcekey=0-QD5W-ZRD5_Vc1hJ7NEaQWg after (height fixed): https://drive.google.com/file/d/1NXVCsdFGgE1yJqM2UKWfWGcZe5L8S6JB/view?usp=sharing&resourcekey=0-iT7tZSpwKhfw6L1YfxB1Ww Small font, two lines: before: https://drive.google.com/file/d/1YG9SwGo0fyiwhDvHDFBGxGfOrxOJQ5dr/view?usp=sharing&resourcekey=0-_rcDX0YgdTnmLip-rlqGKA after (height fixed): https://drive.google.com/file/d/1F91FeZx9_3sepKMW5om6OWFjDpfSZaeV/view?usp=sharing&resourcekey=0-rVobtrIGUMc0Zy9BwU2M2A Fixed: 1224800 Change-Id: I3d1b9ae57f737a62613bae647bdd01421627f80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334583 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951741}
Also adds tests for corner cases of MountPath(). Bug: 1278234 Change-Id: I7a74f78f01247f30f42d3bbf60a43826958b91b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337876 Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/main@{#951742}
Allows users to pass in arbitrary commandline args to the browser when it is launched via the "run_chrome" script. Bug: 1256870 Change-Id: Idac6bf87ce83612a808d313f05970453cd032e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321433 Reviewed-by: Fabrice de Gans <fdegans@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/main@{#951743}
The CWP team continues collecting and using this histogram. BUG=1277112 Change-Id: Iab82255c2bf3998b8bf4faef3618acab6c9e2d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339184 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Tuo Shan <shantuo@google.com> Cr-Commit-Position: refs/heads/main@{#951744}
This CL renames all the newer 'refresh' color variables to have the standard color variable name, and reassigns the 'refresh' names to the new CSS variables. Next step will be to replace all the --google-*-refresh-* usages with the new CSS variable names, and then remove the 'refresh' vars. Bug: 1062154 Change-Id: I0b27efc93011ab5e29933489470c568c50859033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324612 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951745}
Adds a cast2class error message element which handles translating from AddSinkResultCode and RouteRequestResultCode to user-facing messages. Set up so other error messages may be added in the future. Added a test file for the new element and added unit tests for the WebUI. Bug: b/209720173 Change-Id: Id653cafcad1db380cb6be978e14047f7f541bef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335366 Reviewed-by: Brian Malcolm <bmalcolm@chromium.org> Commit-Queue: Benjamin Zielinski <bzielinski@google.com> Cr-Commit-Position: refs/heads/main@{#951746}
https://skia.googlesource.com/skia.git/+log/68e240d9cdb3..fde20db7cab7 2021-12-14 brianosman@google.com Rename SkSL's 2D cross product builtin function 2021-12-14 johnstiles@google.com Add new SkVM trace op 'trace_scope' to track SkSL scope depth. 2021-12-14 egdaniel@google.com Remove workaround for not executing no op discard OpsTask. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1279794 Tbr: bungeman@google.com Change-Id: Ib6bd07556a219773df3c65e84e9c2646c284bcf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339360 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951747}
After I81488239162aea19e4c783461b78d377e14afa1a, which broke kEmbedderTriggeredAndRedirected, we find that many cancellation cases were caused by kEmbedderTriggeredAndCrossOriginRedirected. So this CL continues breaking the metrics down by analyzing the cross-origin redirection cases. Bug: 1274468 Change-Id: I494dd2ed7346963c2c008740b7966de89ad9b90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314413 Reviewed-by: Asami Doi <asamidoi@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951748}
…ector" Original change's description: > [Zenith] Keep the dialog open when clicking on the device selector > > The drop down icon is a little bit small and users might click on the > device selector strip by mistake. > > This CL increase the size of the drop down button's ink drop. It also > stops the MousePressed event from bubbling to the MediaItemUI, which > brings the focus back to the tab that is playing the media. > > Bug: 1279499 > Change-Id: Ib7687023aec1bbf4bdaff760d16fa908aa08ac44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334986 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Muyao Xu <muyaoxu@google.com> > Cr-Commit-Position: refs/heads/main@{#951372} Bug: 1279499 Change-Id: I7e425082902b44d933b334f67c1591f327db5df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338649 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#951749}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639504726-e7cdc104acb454455e958b92ea4ea0702a57e906.profdata to chrome-win32-main-1639515544-3861e0300d09429621942ad80a47946e7c2f9a70.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I52336d72ee153b83f16f0a3c275111f4e046a969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339359 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951750}
Extend the previous CL to allow timeouts too. https://crrev.com/c/3328912 Bug: 1269536 Change-Id: I0adc2a31117136e1d22a990070f73a42542b7dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340098 Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Zijie He <zijiehe@google.com> Cr-Commit-Position: refs/heads/main@{#951751}
The batching logic queues up signals requests until the consumer tells it to issue a network request, and then issues one network request for all batched requests. This doesn't wire up batching, which requires a bit more work (namely, logic to decide when to send requests for scoring signals. Bidder worklets additionally need to be reused before we can meaningfully use it for bidder worklets). Bug: 1276639 Change-Id: Idf23cb9b91ab5e5801e03bc60cff1fc6866922a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334501 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#951752}
This fixes the broken unit test by enabling the feature param directly in the test. This does not fix any aforementioned latency issues. This is a reland of b6f385e Original change's description: > Launch Lens image search on desktop at ToT. > > Also disables the image search URL change if on a non-desktop platform. > > Bug: 1168677, 1222313 > Change-Id: I855e3838e344ba260b8829a2f8cc355f2c31e2da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328902 > Reviewed-by: Ben Goldberger <benwgold@google.com> > Reviewed-by: Orin Jaworski <orinj@chromium.org> > Commit-Queue: Juan Mojica <juanmojica@google.com> > Cr-Commit-Position: refs/heads/main@{#951102} Bug: 1168677, 1222313 Change-Id: I5af7d720dbff2f9ee13422758fa094a03a40b896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338437 Reviewed-by: Orin Jaworski <orinj@chromium.org> Reviewed-by: Ben Goldberger <benwgold@google.com> Commit-Queue: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/main@{#951753}
Bug: 1114183, 1233725 Change-Id: I8d5713f6deffbd54c6f6e8be1600a71f06fb490f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321424 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#951774}
Update <bluetooth-pairing-ui> to handle Bluetooth being disabled and re-enabled while pairing is in progress. Screenshot: https://screenshot.googleplex.com/9YRfgp6Cby9mmwX.png Video: https://drive.google.com/file/d/1YdlQQ_cRqma2w6mBiMsU5Gc-3J06pjUl/view?usp=sharing Fixed: b/209060012 Change-Id: I38a235d5be912d6ba2822ac591adaf7f362e1967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339181 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/main@{#951775}
AppRegistrarObserver::OnWebAppFileHandlerApprovalStateChanged() fires when the API's approval state changes. Bug: none Change-Id: Ib33214f618c2ad6120b1c28f8f3579915a79fa91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338650 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/main@{#951776}
There are some misspellings copied over from the wireless interface result from the healthd mojom. Fix these before they are pushed out to some server binary. Change-Id: I574a7395f3d157e2e370399a869963be5a03d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340095 Reviewed-by: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Tyler Garrett <tylergarrett@chromium.org> Cr-Commit-Position: refs/heads/main@{#951777}
Android 12 emulator uses a different ABI x86_64 The skipped tests are: org.chromium.weblayer.test.TabCallbackTest#testDownloadFromContextMenu org.chromium.weblayer.test.TabCallbackTest#testDownloadFromContextMenuImg Bug: 1201813, 1225851 Change-Id: Iec56e37e20dd0fda3d39efe9568c7d4474b31d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340291 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#951778}
This CL will make notification update less spammy so OEM throttling won't throttle important notification updates like download completion BUG=1258370 Change-Id: Ib549d77e1dd96885e2c263e5c7937897ebca4cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335195 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951779}
https://chromium.googlesource.com/breakpad/breakpad.git/+log/647aa17a7aa8..3846f6d29733 $ git log 647aa17a7..3846f6d29 --date=short --no-merges --format='%ad %ae %s' 2021-10-27 zequanwu Add <call_site_file_id> to INLINE and remove <file_id> from INLINE_ORIGIN 2021-12-13 zequanwu Fix RegisterValidFlag 2021-12-09 ivanpe Fixing issues in the Breakpad symbol file serialization code. Created with: roll-dep src/third_party/breakpad/breakpad Change-Id: Ib637f9beb566e60beeb1f05145f8a6e5d54a12ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339872 Commit-Queue: Zequan Wu <zequanwu@google.com> Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/main@{#951780}
https://skia.googlesource.com/skia.git/+log/fde20db7cab7..d337cf94a077 2021-12-14 rmistry@google.com Add documentation about GPU Gardener and OSS-Fuzz bugs 2021-12-14 johnstiles@google.com Factor out mergeMasks into a helper method. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I911399481836dfdc4c69cf12b96200bf4f147795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339164 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951781}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639504726-a5cec93f623091d76267247a1ff888db818a2b02.profdata to chrome-win64-main-1639526239-4060e250163f1a3b9427ad3b4869e887f9a26e9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I370b94fda76c17668fbd9aacc14eb204761a4658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339162 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951782}
Keystone registration framework interacts with Keystone via ksadmin CLI. Existing registration framework calls ksadmin with arg `--store` thus we have to support that flag. Note this is only a partial support. We will not load the tickets from the store given. Rather, we only use the store path value to determine the updater scope. Hopefully this is enough for all real scenarios. Bug: 1280037 Change-Id: Ib8087d5888b7235e7986d6773a2e026e42ecfb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338085 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/main@{#951783}
This follows the plan outlined in https://docs.google.com/document/d/1HJsFHpvi2V84suIao6WW41TLc36ZoMR6pmSanI6E7rk/edit?usp=sharing Bug: 1073933,1278582 Change-Id: I72f1c80b98fd07eddb8c850539688517e16edc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334757 Reviewed-by: Sergei Glazunov <glazunov@google.com> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#951784}
https://android.googlesource.com/platform/external/perfetto.git/+log/1357bd132733..f9abf9948a18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I58b387f6bbdb77814c20eb1e3eca0b2e9bb850d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339399 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951785}
Codes in //ash/components/tether are a part of the ash-chrome, so namespace is changed to ash. To avoid churn during other namespace transitions in future, this CL has temporary 'using' declarations. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I017c6ce0da2db02efa6d40b1bb6f17ddc67470c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322441 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Owners-Override: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> Cr-Commit-Position: refs/heads/main@{#951786}
Bug: b:204489503 Change-Id: Ib4cefcd8a1b1d0be43e9efba20b980c1d417924a Fixed: b:204489503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339832 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yuki Awano <yawano@google.com> Cr-Commit-Position: refs/heads/main@{#951787}
Instead utilize the callsite in SystemWebAppDelegate::LaunchAndNavigateSystemWebApp(). This is required to support upcoming refactoring in WebLaunchFilesHelper. Bug: 1250225 Change-Id: Ic78675fbcdbaddc54cefb5bb8143826bca19576b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327605 Reviewed-by: Wei Lee <wtlee@chromium.org> Reviewed-by: Dominic Schulz <dominicschulz@google.com> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/main@{#951788}
There are currently two mostly redundant fields used to identify a CDM type. cd_file_system_id was initially used by the CDM running as a pepper plugin, so the ID maps to a pepper plugin MIME type. Its value (the MIME type) is no longer relevant. However, this is used in the codebase to effectively map to the CdmInfo.type, a base::Token which uniquely identifies CDMs (Widevine, ClearKey, etc). This CL combines these fields into a CdmType which contains both a base::Token (CdmInfo.type) and an ID used to access to Plugin Private File System. Once we migrate CDM off of the Plugin Private File System, this ID will no longer be needed and CdmType can be simply aliased to a base::Token. This CL is the first step in the migration of CDM off of the Plugin Private File System. Bug: 1231162 Change-Id: Ic481ffccc5d9b8dfd214b73e17cf649ddd861608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3257089 Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#951789}
… deterministic"" This is a reland of 0004976 The reland does this only on Windows for now, which was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/3332197 (rolled in in https://chromium-review.googlesource.com/c/chromium/src/+/3338994) and which consistently doesn't use goma on the deterministic bot. Original change's description: > Reland "Make deterministic bots check that toolchain.ninja is deterministic" > > This is a reland of 6ee6268 > The reland omits the comparison for build.ninja for now. > > Original change's description: > > Make deterministic bots check that build.ninja and toolchain.ninja are deterministic > > > > Bug: 1278777 > > Change-Id: Ia22f4b5f540353eea002a5e330ab71799dfa3e99 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330558 > > Reviewed-by: Hans Wennborg <hans@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#950650} > > Bug: 1278777 > Change-Id: I13268f9e7c5b8c238398d67e3b9307bbaa35142c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332556 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950792} Bug: 1278777 Change-Id: I11cf324df000744b2bef35bcadbcd9c376bfecf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338758 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951790}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5fec567a800a..895afdf921d3 2021-12-14 jalyn@microsoft.com Shortcuts: Remove Inspect Element from list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I158540e09f39fb913e94d9d25ff8b2dd923f3f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339364 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951791}
IOSBrowsingHistoryDriverDelegate will serve as an intermediate C++ class between IOSBrowsingHistoryDriver and HistoryConsumer. This will allow TabsSearchService (in progress at crrev.com/c/3268525) to directly implement IOSBrowsingHistoryDriverDelegate instead of duplicating logic inside IOSBrowsingHistoryDriver. Bug: 1267978 Change-Id: I86f7979863862095e9f60e6a847357b1aa93d252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330924 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951792}
Roll Chrome Mac PGO profile from chrome-mac-main-1639504726-fb9e43adc0e4760052265cf82e7db19c61befe33.profdata to chrome-mac-main-1639526239-f999c2751396f2d955909c0c12681befd8319247.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I31b997b7d3f12edff9cf26af2f68573631b3d6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339163 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951793}
And notifies observers when it changes. This will be used so that chrome code can record the set of fonts needed to generate fcp and prewarm them later on. BUG=1273276 TEST=none Change-Id: I7366cd550c05914c7ee63342c4ed2817d4c393f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339613 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#951794}
Roll Chrome Linux PGO profile from chrome-linux-main-1639504726-00818556d27ae6f0ca222d22829579a009d0b826.profdata to chrome-linux-main-1639526239-a0d881f0048d045d354f668c449f9cc1d5fb2651.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I29d17f56f41538d2ab8b2d1ee91f4d62552baea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340494 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951795}
Change-Id: I48f649f97c0fb63c98d823ba914ae978e900baac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338981 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951796}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c258c1267440..41781a31dda1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jarhar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1260176,chromium:1277300,chromium:1279609 Tbr: jarhar@google.com Change-Id: Iea485d16ea0b4d8ef77ee0b57f30af82b146edd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339363 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951797}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC clank-library-failures@google.com,mheikal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: clank-library-failures@google.com,mheikal@google.com Change-Id: Ibf949952947cd4e1e5e4df7ac55a849979852d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339891 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951798}
When enabled, Breakpad would produce dumps but only upload them for official builds if no CHROME_HEADLESS environment variable existed. Crashpad maintains this behavior by overriding HeadlessCrashReporterClient::IsRunningUnattended(), and GetCollectStatsConsent(). GetCollectStatsConsent() is implied true by --enable-crash-reporter passed to headless_shell, or --headless passed to chrome. Crashpad will internally also only enable upload for official, google-branded builds. Removes use of kDisableBreakpad which previously would disable Breakpad/Linux or Crashpad/Mac, but not Crashpad/Windows. It is duplicative of --disable-crash-reporter. This patch also causes --disable-crash-reporter to function for mac, but still not windows. Bug: 1176772 Change-Id: I651ae30e3c90ec90652743b92c55c63c84b53fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2893222 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/main@{#951799}
…ontentSettingObserver As a clean-up of fixing long tail of features for MPArch, this CL renames DidFinishNavigation to PrimaryPageChanged in SoundContentSettingObserver, because PrimaryPageChanged is preferred when DidFinishNavigation only handles changes to the document the user sees. Bug: 1269645 Change-Id: Ic56b330cd515b5dfac2b0c8041c374bf311ff8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275869 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/main@{#951800}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )