[pull] main from chromium:main #113
Merged
Commits on Dec 14, 2021
-
This implements the proposed CT policy changes behind a default off feature flag (CertificateTransparencyUpdatedPolicy), and also adds a feature flag (CertificateTransparencyUpdatedPolicyAllCerts) that causes changes to apply to all certificates (instead of only to those issued after February 1, 2022). Changes are: -One Google log requirement is removed. -A log operator diversity requirement is added (each certificate needs SCTs from at least 2 logs with different operators). -Embedded SCTs requirement is increased to 3 for certificates with a lifetime between 180 days and 15 months. -Lifetime calculations are now done directly in days instead of months. Bug: 1267104 Change-Id: I7b4a46de421437b0dd621b221fc7e62fa7efeb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306682 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/main@{#951724}
-
[serial] Running error callback for SDP query.
Ensure the error callback to BluetoothSocketMac::Connect() will be called if the success callback is not. Bug: 1261555 Change-Id: I2d5878fbd7f34ac48b0f7b2d6d6f0515cc7375c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331523 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951725}
-
[Code Health] Modernize Value API in extension_messages_apitest.cc
Bug: 1187061 Change-Id: I931c65283a49ae3cda640cff934e71c691da37f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330387 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951726}
-
[Code Health] Modernize Value API in debugger_api.h
Bug: 1187061 Change-Id: I228a32001622b89a749eb447e1f95bea2138643d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334438 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951727}
-
[bluetooth] Add BluetoothUUID operator<<.
Convert BluetoothUUID::PrintTo() to Bluetooth::operator<<(...). This still still allows gtest() macros to work, and also makes it easier to do other debugging-type things like: LOG(INFO) << "UUID is: " << uuid; This was tested by intentionally introducing this test failure: BluetoothUUID invalid; EXPECT_EQ(uuid5, invalid); Without the operator the test output was: Expected equality of these values: uuid5 Which is: 56-byte object <01-00 00-00 AA-AA AA-AA 08-31 31-30 ... 00-00> invalid Which is: 56-byte object <00-00 00-00 AA-AA AA-AA 00-00 00-00 ... 00-00> With the operator this is the output: Expected equality of these values: uuid5 Which is: 00001101-0000-1000-8000-00805f9b34fb invalid Which is: Bug: none Change-Id: If2287e8619950adc57bca64300c3188f5fa92ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330919 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951728} -
[fuchsia][a11y] Implements Semantic Provider library.
This change implements a library that manages the connection with the Fuchsia Semantics API. This allows clients to just add / delete semantic nodes, leaving the tree life cycle management up to the library. Clients can register handlers to be notified of specific Semantic events. Please see .h for more documentation. Test: SemanticProviderTest.* Bug: fuchsia:86654 Change-Id: I025ec894a23a6e13812d3642e91ac800cae51eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261610 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/main@{#951729}
-
[GMNext] Make primary inverse text colors dynamic
Bug: 1233703, 1241971 Change-Id: I48f754855b6ae462637daf152b279707a0ff3039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331374 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#951731}
Commits on Dec 15, 2021
-
Refactor GetExpectedTestData*() methods in content capture.
This CL integrates several kinds of GetExpectedTestData*() methods into one helper function. The VerifySession() is also moved to the helper file. These two functions will be used for all types of tests in content capture. This CL also removes unnecessary include files in content_capture_receiver_test.cc. Bug: 1276849 Change-Id: I51b48cf73f0bdeeb0993a18104941e9cd110425c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337880 Reviewed-by: Michael Bai <michaelbai@chromium.org> Commit-Queue: Hyowon Kim <hyowon@igalia.com> Cr-Commit-Position: refs/heads/main@{#951736}
-
Remove HttpProxyClientSocket mocking
Mock HttpProxyClientSockets are only used in proxy error handling tests, introduced in issue #826570, to account for the tests not testing the expected code. The error used to be injected in the TCP connection to the proxy, where almost everything is mapped to ERR_PROXY_CONNECTION_FAILED. It was switched to being injected in a mock HttpProxyClientSocket::Connect. But that ossifies implementation details of how we happen to model parts of HTTP proxies. (E.g. that non-tunnel requests use an HttpProxyClientSocket.) It also then fails to test other mapping effects, for instance that ERR_CONNECTION_CLOSED is very hard to reach in HTTP/1.1 proxy. Moreover, the mock didn't actually help with the original issue. The error mapping lives in HttpProxyConnectJob, which wasn't mocked out. The actual test fix was moving the error from TCP setup to the tunnel setup. This CL switches the test to do that without mocks. In doing so, it turns out ERR_CONNECTION_CLOSED is all but unreachable. I've removed it for now, but we should probably either remove ERR_CONNECTION_CLOSED from the list or add its subtypes. This deletes a lot of code and lets us rework the HttpProxyConnectJob / HttpProxyClientSocket split without affecting as many tests or callers. Bug: 1277656 Change-Id: I0b92fd703670af13c191ce04b24d49c33285d917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318084 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#951739}
-
[CWP] Extend CollectProcessTypes histogram collection
The CWP team continues collecting and using this histogram. BUG=1277112 Change-Id: Iab82255c2bf3998b8bf4faef3618acab6c9e2d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339184 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Tuo Shan <shantuo@google.com> Cr-Commit-Position: refs/heads/main@{#951744}
-
Prerender: Break kEmbedderTriggeredAndCrossOriginRedirected down
After I81488239162aea19e4c783461b78d377e14afa1a, which broke kEmbedderTriggeredAndRedirected, we find that many cancellation cases were caused by kEmbedderTriggeredAndCrossOriginRedirected. So this CL continues breaking the metrics down by analyzing the cross-origin redirection cases. Bug: 1274468 Change-Id: I494dd2ed7346963c2c008740b7966de89ad9b90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314413 Reviewed-by: Asami Doi <asamidoi@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951748}
-
Reland "[Zenith] Keep the dialog open when clicking on the device sel…
…ector" Original change's description: > [Zenith] Keep the dialog open when clicking on the device selector > > The drop down icon is a little bit small and users might click on the > device selector strip by mistake. > > This CL increase the size of the drop down button's ink drop. It also > stops the MousePressed event from bubbling to the MediaItemUI, which > brings the focus back to the tab that is playing the media. > > Bug: 1279499 > Change-Id: Ib7687023aec1bbf4bdaff760d16fa908aa08ac44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334986 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Muyao Xu <muyaoxu@google.com> > Cr-Commit-Position: refs/heads/main@{#951372} Bug: 1279499 Change-Id: I7e425082902b44d933b334f67c1591f327db5df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338649 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#951749}
-
Allow dynamic-modify-transform-without-baseval.html to timeout
Extend the previous CL to allow timeouts too. https://crrev.com/c/3328912 Bug: 1269536 Change-Id: I0adc2a31117136e1d22a990070f73a42542b7dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340098 Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Zijie He <zijiehe@google.com> Cr-Commit-Position: refs/heads/main@{#951751}
-
SVG foreignObject should not be treated as stacked in CullRectUpdater
For now LayoutSVGForeignObject's IsStacked() is true, so we need to check !IsReplacedNormalFlowStacking() to exclude foreign objects from stacked children. TODO: We need to let IsStacked() of LayoutSVGForeignObject return false, but we need thorough tests when doing that. Bug: 1275018, 1279797 Change-Id: I82bc7a75dfbe377cd1254c82df33cb896b67aa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338499 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951754}
-
Remove IOS Tab Grid Bulk Actions flag
The BulkActions feature is launching to 100% so the flag can be removed. Change-Id: Ic7ed01a4520a39c81fc74f23bf16d2593a0409b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3248360 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951756}
-
ash: Crash fix for mic mute toggle in login screen
Instead of DCHECK(), return absl::nullopt if reg_cache or cap_cache is nullptr. Bug: 1274440 Change-Id: I12b2adedd319441c7c93b90054aadf1143175b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339812 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Roger Tinkoff <rtinkoff@google.com> Cr-Commit-Position: refs/heads/main@{#951758}
-
PlzDedicatedWorker: early return when the ancestor frame is closed
This CL updates ThrottleWorkerMainScriptFetch() to make it return early because the ancestor RenderFrameHost can have already been closed while DedicatedWorker is alive. See comments at dedicated_worker_host.cc. https://source.chromium.org/chromium/chromium/src/+/main:content/browser/worker_host/dedicated_worker_host.cc;l=699-700;drc=eb7f6bd3fd48714bcc3b6a8b2bf99b6be4d9a9bd;bpv=1;bpt=1 It will fix the null-dereference in `rfh->frame_tree_node()` when the PlzDedicatedWorker feature is enabled. Bug: 1265599 Change-Id: If0040de2c0c2ac7b8ebeff907ed22b79415bb343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338156 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951760}
-
Fire accessible MENU_POPUP_START when menu is created on the fly
AXEventGenerator::OnIgnoredChanged fires MENU_POPUP_START in addition to SUBTREE_CREATED for the ARIA menu role. That does not cover the case where the menu subtree did not already exist in the DOM, but was created on the fly. Fire the missing event in AXEventGenerator::OnNodeCreated, which should also handle the case where the new menu has ancestor elements also being added to the DOM. AX-Relnotes: Assistive technologies are now notified when an ARIA menu is created on the fly. Bug: 1254875 Change-Id: Ie384c19eab0f808bbc4637d0b87764514d76e0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310922 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#951762}
-
Reflect aura::Window's transient parent change in Widget::parent()
An aura::Window may get reparented by TransientWindowManager::AddTransientChild() without updating Widget::parent(). This may result in an UAF when Widget::parent() is dereferenced after destroyed. This CL updates Widget::parent() to reflect the transient parent change. Note that aura::Window may also get reparented, but that is not the widget's logical parent. On ChromeOS, the application windows have a common native parent, but might have different transient(aka. logical) parent. Adds tests to exo_unittests and wm_unittests. The UAF issue seems most prominent on lacros ChromeOS, where exo provides a ShellSurface::SetParentWindow() API. Bug: 1242964 Change-Id: Ie51c7e92ae94e9700aa0c4e158a16d03875aac05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324727 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951765}
-
Fix intersection ratio with pixel snapping and a root
Bug: 1278897 Change-Id: Ib26c094d3c3dc33fa1f8f9303d07b1b49acc7592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340057 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951767}
-
Extend subresource filter evaluation performance metrics
Extends their expiry by a year. These metrics continue to be used to analyze the performance impact of upcoming changes to subresource filter list evaluation (e.g. crbug.com/1227873). Bug: 1274712, 1274713 Change-Id: Ia7697b8a3fcb1ca1c1278cc04ff8e4bd3833419e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337176 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/main@{#951770}
-
Add CertificateTransparencyAndroid to field trial testing config
Bug: 1264628 Change-Id: Ie45ba4fa5f27cc6499318b6bfe567a65bc17367d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338977 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/main@{#951772}
-
[GMNext] Move OmniboxTheme to chrome/browser/ui/theme and rename
Bug: 1114183, 1233725 Change-Id: I8d5713f6deffbd54c6f6e8be1600a71f06fb490f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321424 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#951774}
-
Roll src/third_party/breakpad/breakpad/ 647aa17a7..3846f6d29 (3 commits)
https://chromium.googlesource.com/breakpad/breakpad.git/+log/647aa17a7aa8..3846f6d29733 $ git log 647aa17a7..3846f6d29 --date=short --no-merges --format='%ad %ae %s' 2021-10-27 zequanwu Add <call_site_file_id> to INLINE and remove <file_id> from INLINE_ORIGIN 2021-12-13 zequanwu Fix RegisterValidFlag 2021-12-09 ivanpe Fixing issues in the Breakpad symbol file serialization code. Created with: roll-dep src/third_party/breakpad/breakpad Change-Id: Ib637f9beb566e60beeb1f05145f8a6e5d54a12ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339872 Commit-Queue: Zequan Wu <zequanwu@google.com> Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/main@{#951780}
-
Make ksadmin support --store flag.
Keystone registration framework interacts with Keystone via ksadmin CLI. Existing registration framework calls ksadmin with arg `--store` thus we have to support that flag. Note this is only a partial support. We will not load the tickets from the store given. Rather, we only use the store path value to determine the updater scope. Hopefully this is enough for all real scenarios. Bug: 1280037 Change-Id: Ib8087d5888b7235e7986d6773a2e026e42ecfb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338085 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/main@{#951783}
-
[BRP] Switch to "previous slot" variant in M99
This follows the plan outlined in https://docs.google.com/document/d/1HJsFHpvi2V84suIao6WW41TLc36ZoMR6pmSanI6E7rk/edit?usp=sharing Bug: 1073933,1278582 Change-Id: I72f1c80b98fd07eddb8c850539688517e16edc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334757 Reviewed-by: Sergei Glazunov <glazunov@google.com> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#951784}
-
Change namespace to ash for //ash/components/tether
Codes in //ash/components/tether are a part of the ash-chrome, so namespace is changed to ash. To avoid churn during other namespace transitions in future, this CL has temporary 'using' declarations. This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I017c6ce0da2db02efa6d40b1bb6f17ddc67470c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322441 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Owners-Override: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> Cr-Commit-Position: refs/heads/main@{#951786}
-
FS: Consolidate cdm_file_system_id and cdm_type into CdmType
There are currently two mostly redundant fields used to identify a CDM type. cd_file_system_id was initially used by the CDM running as a pepper plugin, so the ID maps to a pepper plugin MIME type. Its value (the MIME type) is no longer relevant. However, this is used in the codebase to effectively map to the CdmInfo.type, a base::Token which uniquely identifies CDMs (Widevine, ClearKey, etc). This CL combines these fields into a CdmType which contains both a base::Token (CdmInfo.type) and an ID used to access to Plugin Private File System. Once we migrate CDM off of the Plugin Private File System, this ID will no longer be needed and CdmType can be simply aliased to a base::Token. This CL is the first step in the migration of CDM off of the Plugin Private File System. Bug: 1231162 Change-Id: Ic481ffccc5d9b8dfd214b73e17cf649ddd861608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3257089 Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#951789}
-
Reland "Reland "Make deterministic bots check that toolchain.ninja is…
… deterministic"" This is a reland of 0004976 The reland does this only on Windows for now, which was fixed in https://chromium-review.googlesource.com/c/v8/v8/+/3332197 (rolled in in https://chromium-review.googlesource.com/c/chromium/src/+/3338994) and which consistently doesn't use goma on the deterministic bot. Original change's description: > Reland "Make deterministic bots check that toolchain.ninja is deterministic" > > This is a reland of 6ee6268 > The reland omits the comparison for build.ninja for now. > > Original change's description: > > Make deterministic bots check that build.ninja and toolchain.ninja are deterministic > > > > Bug: 1278777 > > Change-Id: Ia22f4b5f540353eea002a5e330ab71799dfa3e99 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330558 > > Reviewed-by: Hans Wennborg <hans@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#950650} > > Bug: 1278777 > Change-Id: I13268f9e7c5b8c238398d67e3b9307bbaa35142c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332556 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950792} Bug: 1278777 Change-Id: I11cf324df000744b2bef35bcadbcd9c376bfecf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338758 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951790}
-
Add generic IOSBrowsingHistoryDriverDelegate
IOSBrowsingHistoryDriverDelegate will serve as an intermediate C++ class between IOSBrowsingHistoryDriver and HistoryConsumer. This will allow TabsSearchService (in progress at crrev.com/c/3268525) to directly implement IOSBrowsingHistoryDriverDelegate instead of duplicating logic inside IOSBrowsingHistoryDriver. Bug: 1267978 Change-Id: I86f7979863862095e9f60e6a847357b1aa93d252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330924 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951792}
-
MPArch: Replace DidFinishNavigation with PrimaryPageChanged in SoundC…
…ontentSettingObserver As a clean-up of fixing long tail of features for MPArch, this CL renames DidFinishNavigation to PrimaryPageChanged in SoundContentSettingObserver, because PrimaryPageChanged is preferred when DidFinishNavigation only handles changes to the document the user sees. Bug: 1269645 Change-Id: Ic56b330cd515b5dfac2b0c8041c374bf311ff8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275869 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/main@{#951800}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.