[pull] main from chromium:main #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fd41e488b72e..168ca4d812a0 2021-12-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: I20602598b5371f1afd6c8b6e2e6d2fe91b5be8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343273 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952157}
This change has two advantages. One is to make it easier to create unit tests, which this CL adds. Another one is that we no longer will have to bug metrics OWNERS for approval. No behavior change is expected. If you compare diff between code removed from chrome_browser_main_extra_parts_metrics.cc and code added to partition_alloc_support.cc, you'll see the differences are purely mechanical. Bug: 1278582 Change-Id: I42a5aa121c01c2e2a43ed822679c02095ef724e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334334 Reviewed-by: Sergei Glazunov <glazunov@google.com> Reviewed-by: Benoit Lize <lizeb@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/main@{#952158}
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I844ef0d06317a78c658279d740582295d4ac335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343127 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952159}
Fixed: 1280455 Change-Id: Ib190a704e04688ac10824747f893cb5c35337a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343446 Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Sorin Jianu <sorin@chromium.org> Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/main@{#952160}
Hide widget when message center is invisible. Remove border drawn around the message center in the new UI. Bug: 1268182 Change-Id: I688df35fa3cdfa102edd8878b10abefa87fcecdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329082 Reviewed-by: Andre Le <leandre@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/main@{#952161}
https://android.googlesource.com/platform/external/perfetto.git/+log/22467673a50f..15e3467297c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71de78ab252dd6bc64128abee9bdc2cca5204ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343215 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952162}
Which is a windows specific struct to return the font family names used at any given point. This will be used to get get the fonts used at the time of fcp so that they can be prewarmed. BUG=1273276 TEST=none Change-Id: I158f373a3d685dd9dcf813375c519b6dc16cd4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337404 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952163}
wpt_uploader will fetch such report from CI, merge the reports from each shard, and populate the report to wpt.fyi. Bug: 1190323 Change-Id: I99e1da99d14de9c97a4a717277ac8c17908f05f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321506 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#952164}
This CL enables to create pedals data on Android, and bring the data to java side. For reduce binary size, in omnibox_pedal_implementations.cc, we used "#if !defined(OS_ANDROID)" to confine unused Omnibox Pedals. Also, for the binary size increasing, a lot more GRIT data is being included on Android because the code uses many IDS_* strings. Bug:1277006 Change-Id: Ie733d09ee61d80664a4a3cc143a2f113e66c0415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310201 Reviewed-by: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952165}
It is not interoperable or well-specced and changes depending on some Blink parser experiments that are currently ongoing. For now, we should disable it, until we get spec clarity. Bug: 1254926 Change-Id: I444c2981d8c1eb7b6c1c0fbe5db3972c40de27a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341394 Auto-Submit: Domenic Denicola <domenic@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#952166}
The CL https://chromium-review.googlesource.com/c/chromium/src/+/3163396 uploaded by mistake an apk. This CL does clean-up of that apk file. Bug: 1249189 Change-Id: I651d97af063fa97409f1bf253b803e2a97b07d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342907 Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#952167}
This line does nothing, because ScopedRootWindowForNewWindows was replaced with ScopedDisplayForNewWindows in https://chromium-review.googlesource.com/c/chromium/src/+/2208883 Bug: None Test: CQ Change-Id: I077a12d060e86f3713a8fccd0c7f43822a6682fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343387 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#952168}
Cleans up stale pixel expectations as determined by the unexpected pass finder using 200 samples. Bug: 1008450, 1157136, 1176918, 1209344, 1215747 Bug: 805739, 1155766 Change-Id: I444218614c9411b12de22948f4c4905d41f84127 Fixed: 1029389, 1121476, 1200504, 1220766, 1221258 Fixed: 1275741, 976861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342504 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#952169}
Clean up of build dependencies allows to remove the static factory method in favor of creation CastRuntimeService instance in a particular browser client. Bug: b:210127896 Test: unit test and local runs Change-Id: Ia72e4fceff784d5bc361f21073bb7c71dc9623e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340081 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#952170}
https://android.googlesource.com/platform/external/perfetto.git/+log/22467673a50f..15e3467297c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I011ef1af76754159ff9495cc786fbe14227232ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343223 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952171}
No matter the state of Smart Lock, we want to announce the accessibility label so that ChromeVox users can learn what is wrong from error messages. Change-Id: Ica99f0d0d60d6144fd55363f9d2045471445a218 Bug: 1233614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338457 Reviewed-by: Thomas Tellier <tellier@google.com> Commit-Queue: Brittany Hartmire <bhartmire@google.com> Cr-Commit-Position: refs/heads/main@{#952172}
The check was not updated after changing the function name in https://crrev.com/c/3335440. Bug: 1279503 Change-Id: Ia294cf05cf35d9de9d9a8aa1ebaf9403e6b88392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343280 Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952173}
Update schedule to run every 6 hours at the 0th minute. The query is set to update every 6 hours starting at 5:30, which gives 30 minutes for the query to complete and this builder to utilize the table data. Bug: 1233132 Change-Id: I6043d6c73b8f71dc0dbf6a995105ebd468be2146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342918 Auto-Submit: Jeff Yoon <jeffyoon@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/main@{#952174}
…8.5-r1 to 98-4744.1-1639393599-benchmark-98.0.4758.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic4c4f5a830591df93d337ba8648785407cf03687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343708 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952175}
Bug: 1277117 Change-Id: Id84df306e3acf7f3d4ef7d6a841bf6a279e9762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320564 Reviewed-by: Glen Robertson <glenrob@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#952176}
https://skia.googlesource.com/skia.git/+log/dc60ca197e02..fec9a3027c9e 2021-12-15 egdaniel@google.com [graphite] Add support for creating wrapped SkSurfaces. 2021-12-15 johnstiles@google.com Highlight reached/unreached lines differently in Debugger. 2021-12-15 michaelludwig@google.com [graphite] Disable color writes for ShaderType::kNone 2021-12-15 herb@google.com better handling of atlas size constraints 2021-12-15 johnstiles@google.com Hide variables which fall out-of-scope in SkSL debugger. 2021-12-15 brianosman@google.com Do some renaming of "intrinsic" throughout SkSL 2021-12-15 michaelludwig@google.com [graphite] Manage sort key bit packing explicitly 2021-12-15 johnstiles@google.com Show the variables pane even when it is empty. 2021-12-15 kjlubick@google.com [canvaskit] Release 0.32.0 2021-12-15 egdaniel@google.com When loading resolve in vulkan make to we give color attachment read access. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1280180,chromium:1280232 Tbr: bungeman@google.com Change-Id: I6fb79bb9107fbbad4150a6e5ecabc8acc084d6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343167 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952177}
Going forward we will be adding a lot more feature checks to the borealis features, so in this CL we clean up the feature check in a few ways: 1) move the code to a static helper, which will help with b/172178036, 2) add a string reason, so that we can introspect why borealis was disallowed in the logs. Bug: b/210066769 Change-Id: Ifc179c16cf6440c66e44df18a1d7d8517fa093d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340132 Reviewed-by: Chloe Pelling <cpelling@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/main@{#952178}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I13f549e5190dcd3da23ae4bc77b2dd3e0677a58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343269 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952179}
https://webrtc.googlesource.com/src.git/+log/d525e2d9f71f..f8e160e1c9f8 2021-12-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fe99486..864bf70 (951956:952110) 2021-12-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03bde11..fe99486 (951854:951956) 2021-12-15 handellm@webrtc.org ZeroHertzAdapterMode: delay & repeat frames. 2021-12-15 daniel.l@hpcnt.com Remove unused 4-argument version of OnIceCandidateError. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1255737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I42fb27745fe418ad1d3166f3014b34b810e612d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343408 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952180}
Currently, calling GetRelatedSiteInstance() on a guest SiteInstance results in creating a related SiteInstance that's not actually a guest (its SiteInfo::is_guest() is false, and StoragePartition information may be wrong). In practice, with the current implementation, content within a guest should always stay in a single SiteInstance and BrowsingInstance, and even different guests created in the same app and partition need to stay in that SiteInstance [1]. We usually avoid calling GetRelatedSiteInstance() for guests, but while working on crbug.com/1267977 and trying to enforce that a BrowsingInstance can't mix guest and non-guest SiteInstances, I discovered that one way this can happen is through NavigationRequest's SetSourceSiteInstanceToInitiatorIfNeeded(), which calls GetRelatedSiteInstance() [2]. So far, I saw this happen in a narrow case where a guest opens a new about:blank window with the opener suppressed (i.e., with noopener/noreferrer), which satisfies RequiresInitiatorBasedSourceSiteInstance() requirements, and, unlike typical noopener cases, also (currently) stays in the same BrowsingInstance due to lack of site isolation in guests (see above) [3]. To fix this, this CL tweaks GetRelatedSiteInstance() to return back the same SiteInstance when called from a guest SiteInstance. This obeys the current expected semantics and guards against other potential calls to GetRelatedSiteInstance() from guest SiteInstances. It also modifies the test which exercises this scenario to verify that the source SiteInstance is a guest SiteInstance in this case. Once site isolation for guests is implemented, this will be changed to actually return a related SiteInstance that's still marked as a guest and preserves the same StoragePartition. I also expect that with site isolation for guests, we will be able to actually swap BrowsingInstances when opening new noopener windows from guests (while again staying in the same StoragePartition and a guest SiteInstance). [1] https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/guest_view/web_view/web_view_guest.cc;l=350-352;drc=3906812a532650fb5f8185caf372f5c5f5c319d0 [2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/navigation_request.cc;l=6656;drc=0c486499f16137c84cec56d8e711991875d81230 [3] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/web_contents/web_contents_impl.cc;l=3830-3837;drc=0c486499f16137c84cec56d8e711991875d81230 Bug: 1267977 Change-Id: I469fef493154df15577624c3dc9f246ed4ae0001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339776 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/main@{#952181}
Also, fix a bug where the Windows sandbox would return SBOX_ALL_OK even if base::LaunchProcess failed, and launch_result was not being set for elevated processes. Add reporting of GetLastError on Windows in the ChildProcessTerminationInfo for failed launches. Also, clean up some switch statements to remove default cases. BUG=1280005 Change-Id: I1001fc950b8456b78ef1a9a985ca07cf288e8a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340072 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/main@{#952182}
This CL is adding the trace events for NTP metrics. These events will be visible in trace collected from Chrometto (in the field) and be used to speedup NTP load time. R=gab@chromium.org CC=tiborg@chromium.org,dpapad@chromium.org Bug: 1279860 Change-Id: I2042679e24e39c1323d962ebec54a19d7036c017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342029 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952183}
These would be very helpful when looking at traces from Chrometto. The full trace events aren't available because MOJO_TRACE_ENABLED is false in our released builds. Change-Id: I2ae5f3beb485e66b591badda80309c0cc54f9c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343221 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#952184}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I5e85ef977caa31027ae9b4bb53a4619990e11f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343274 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952185}
ModuleSystem had a lot of cruft. Clean some of it up.
- Native lazy fields are no longer a thing. This lets us:
* Remove NativeLazyFieldGetter()
* Combine LazyFieldGetter() and LazyFieldGetterInner(), getting rid of
the RequireFunction typedef
* Remove SetNativeLazyField()
* Simplify SetLazyField() to not take a custom
AccessorNameGetterCallback
- void Require() is not defined. Remove the declaration
- RunString() is only used internally. Move it to private:.
- Setting lazy fields are only used internally and in tests. Move it
to private and expose a helper method on ModuleSystemTestEnvironment
(which is already a friend class).
Change-Id: Idb1225b553c0614e94659107da921efc98d32b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312112
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952186}
Bug: 1187036 Change-Id: I5ddbb53d37c71df9f67466547a1bf3b89f0500ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320986 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#952225}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639580383-b8027ac27b70be2c1132df9ac8ecd76a61e2f927.profdata to chrome-win32-main-1639612728-e8e64734f8e5716007ad68e2c4ef4d5f158d480a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iec0a00048b508a206b4295a22f7a2a6ce0ef48aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343948 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952226}
This patch makes beforematch only fire on elements with the hidden=until-found attribute. Bug: 1250851 Change-Id: I08b354f724ae085073ce80f16467f76e15ca8e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307131 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#952227}
When an app has an exsiting window, select the 'new window' item from the search box menu, AppServiceContextMenu calls AppServiceAppSearch to select the existing window and active the existing window. That process is sync, and it actives the existing window, then AppServiceContextMenu object is destroyed. However, full restore still uses the profile in AppServiceContextMenu after the AppServiceContextMenu is destroyed. This may cause the system crash. This CL modified the AppServiceContextMenu to call AppServiceAppSearch's ExecuteLaunchCommand async, so prevent AppServiceContextMenu to be destroyed before calling the full restore interface. BUG=1280467 Change-Id: Ia4f5f971f28f7fa1caf262b22a4cab353daa0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343546 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952228}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I410665bf47af8e5e70116cdcbe35a9a6e3c7fe41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344366 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952229}
Update <os-settings-paired-bluetooth-list-item>'s subpage button to not be focusable. This was causing a redundant tab stop, as clicking the subpage button and clicking the item perform the same action. Fixed: b/210740192 Change-Id: Ib013ec0584569a5f64ade21177739e87a37a84a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343454 Auto-Submit: Gordon Seto <gordonseto@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#952230}
This only changes how package names are recorded for apps that use WebView and not other content embedders. It only change the behaviour when the allowlist of apps package names is enabled. Bug: 1273635 Test: run_android_webview_unittests -f "*AwMetricsServiceClientTest*" Change-Id: I932fffe6b3295367c6ecbf61ae0ce5d14cc4d5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340723 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/main@{#952231}
Change the SelectFileDialogExtension to pass on the profile to SystemFilesAppDialogDelegate, because the SelectFileDialogExtension already handles the multi-profile correctly. This fixes the issue where the File Picker was showing the files from the active user instead of the profile that started the pick action. Fixed: 1276464 Change-Id: Ibf270c375b7ee71afbb2d0658d3b1c9c7c6a70c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343810 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/main@{#952232}
So it can be reused in other contexts going forward. Change-Id: Ib397ac2353c226c32b3fa0b54f34c6a9d2643aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342698 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#952233}
Arc.FirstAppLaunchRequest.TimeDelta measures only the time between
app launch request and boot completed. Boot completed does not lead to
app launch and we don't have currently metric to measure this. This
introduces the new metric that measures time in deferred mode.
BUG=b:208274055
TEST=tast run ${DUT} arc.RegularBoot with new metric captured. Octopus
device shows:
app_launch_time: 7.8s
app_shown_time (the new metric): 10.5s
boot_progress_enable_screen: 6.6s
Change-Id: I67dc11b0ccd34c1788e7e9bb43844d3a29f82b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307774
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952234}
The generic sensor test suite can take a long time. This change splits the tests for the three accelerometer interfaces (Accelerometer, GravitySensor and LinearAccelerationSensor) into separate test files to avoid the likelihood that they time out. Fixed: 833215 Change-Id: I406e71b9da08c36c3495de5029b322c9de039e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344186 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#952235}
There is an edge case that server can return permanent/temporary error after user clicks on the "Get new code" link. In this case the otp input dialog should be dismissed so that the error dialog can be shown correctly. Applied the fix. Bug: 1243475 Change-Id: I509e6873e8edbfbe38028a568c529e45ab3e59fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338080 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/main@{#952236}
Using wpt-import in Chromium 4abe91d. With Chromium commits locally applied on WPT: 6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies" 7cd9af9 "Always assume that non-auto 'columns' might create a multicol." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Ib7088497153cbca675488f278a82784ef570ef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343910 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952237}
This CL moves icon resources in //ui/chromeos/ui_chromeos_resources to //chrome/browser/resources. Icon resources are only used from //chrome/browser, and only used for ash-chrome, so //chrome/browser/resource/chromeos is an appropriate place to put resources to make them close to where they are used. The behavior is not modified by this change. Change-Id: I375c6602e94c56c9cfde0613f344c4a7ad86a4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338038 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952238}
Previously, we report "Internal Error" if mlservice fails to create a recognizer, even for unsupported languages. This CL changes so we always report the "model constraints aren't supported" for these cases. Bug: 1183652 Change-Id: I2e6f0c13964fde5643851acbad62e3daacb627ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336799 Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by: Honglin Yu <honglinyu@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952239}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d692cac31ffe..de5ebd0ec8b1 2021-12-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-12-16 tmathmeyer@gmail.com Fix player title UI issues 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/webauthn 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/issues/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/css_overview/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in models/issues_manager/ 2021-12-15 aerotwist@chromium.org Remove patchColor* from PerformanceMonitor.ts 2021-12-15 tvanderlippe@chromium.org Enforce usage of private class members in components 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/css_overview/components 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/application/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/emulation/components/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1181179,chromium:1222126,chromium:1278738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If1d87da10e5111548a23d487cd7642aa5a005282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344273 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952240}
https://chromium.googlesource.com/angle/angle.git/+log/89e11878b275..670679918668 2021-12-16 kpiddington@apple.com Metal: Fix Webkit warnings in ANGLE build 2021-12-16 gman@chromium.org Add guards for 64 bit types on 32bit systems 2021-12-16 ynovikov@chromium.org Skip SimpleStateChangeTestES3.OutOfBoundsByteAttribute on Pixel4 GLES If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I033f113939816da53e2bcc6a614135cc707a1180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344267 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952241}
This allows an alignment of target arguments across blink_web_tests and gtests invoked via test_runner.py, avoiding the need to constantly update both locations when new arguments are added. Fixes a bug where DeviceTarget was not usable in blink_web_tests due to system_image_dir not initialized. Bug: 1279435 Change-Id: Ia160459f202004bd0ca508b9fdde0b1b2c3286be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335248 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/main@{#952242}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7b514b75b96..6d21a3cb937a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1266935 Tbr: tasak@google.com Change-Id: I0b92d645aac559e4096cfdfd50751feb22d5d6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343833 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952243}
Bug: 1272992 Change-Id: I12dfd819163b9d6a96355789ba42cceea9d86262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339387 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#952244}
This extension API calls a callback with an object containing ChromeOS settings that affect the Terminal. For now, it's just exposing whether the tmux integration is enabled via chrome://flags. We're going to use this to feature-gate the new tmux functionality. Bug: 1252271 Change-Id: I47d04104cbabb8fe42e388bdb2bf395e65980b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340360 Reviewed-by: Jason Lin <lxj@google.com> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Emil Mikulic <easy@google.com> Cr-Commit-Position: refs/heads/main@{#952245}
This CL adds a new test for the case to confirm the playback state change w/o playing any media doesn't affect the back/forward cache usage under the current kBackForwardCacheMediaSessionPlaybackStateChange flag. There were some pages that changed the playback state but without playing any media. By this test, we can confirm this case even after we allow the playback state change for back/forward cache by default. Bug: 1246240 Change-Id: Ifedd1a6618e57bd4bec07d84aee661f7c9a93832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341134 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/main@{#952246}
We're seeing some crashes when calling MatchesFrame() on a null TreeNode. This CL adds a check to not crash in that case and also log some more information + DumpWithoutCrashing to understand what's happening. Bug: 1279628 Change-Id: Ic69cfa39ea1076b6c0bee0ccc2dbf11e7f9d2852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340139 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#952247}
Fix use-after-move issue in a debug assertion in extensions::csp_validator::Directive, as found by clang-tidy: extensions/common/csp_validator.cc:543: 'directive_name' used after it was moved extensions/common/csp_validator.cc:540: move occurred here Bug: 1122844 Change-Id: I8c3c58836ec322f65c3b380936af647e6df1468b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335737 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#952248}
As a part of the Service Worker Onion Soup, this CL moves ServiceWorkerFetchContextImpl from content/renderer/service_worker/ to third_party/blink/renderer/modules/service_worker/. Along with that, the class is renamed to WebServiceWorkerFetchContextImpl to be aligned with other classes implementing Blink's public interfaces. Bug: 789857 Change-Id: I32b3e8551ffe87bbea70f1e8a9f4d4eb18910859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296044 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Asami Doi <asamidoi@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#952249}
webrtc would parse the encoded frame QP if not provided by the encoder, this CL reports the frame QP info for Vp8VaapiVED and Vp9VaapiVED and propagate QP through BitstreamBufferMetadata qp field. Bug: 1276221 Change-Id: I6f1343352cddcd998fe154c02b65dcf07c939d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313005 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/main@{#952250}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639612728-e8e64734f8e5716007ad68e2c4ef4d5f158d480a.profdata to chrome-win32-main-1639623365-4a58a889fdbaddffab410e90a85547617b4d2607.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1cb74cf94b2e9f559edc973c0cf031e677ccd236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344272 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952251}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )