[pull] main from chromium:main #119
Merged
Commits on Dec 16, 2021
-
[PA][BRP] Make PA responsible for choosing its synthetic Finch trials
This change has two advantages. One is to make it easier to create unit tests, which this CL adds. Another one is that we no longer will have to bug metrics OWNERS for approval. No behavior change is expected. If you compare diff between code removed from chrome_browser_main_extra_parts_metrics.cc and code added to partition_alloc_support.cc, you'll see the differences are purely mechanical. Bug: 1278582 Change-Id: I42a5aa121c01c2e2a43ed822679c02095ef724e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334334 Reviewed-by: Sergei Glazunov <glazunov@google.com> Reviewed-by: Benoit Lize <lizeb@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/main@{#952158}
-
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I844ef0d06317a78c658279d740582295d4ac335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343127 Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952159}
-
Replace head scratcher std::hash<IID> implementation.
Fixed: 1280455 Change-Id: Ib190a704e04688ac10824747f893cb5c35337a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343446 Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Sorin Jianu <sorin@chromium.org> Reviewed-by: Xiaoling Bao <xiaolingbao@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/main@{#952160}
-
Fix message center artifacts when empty
Hide widget when message center is invisible. Remove border drawn around the message center in the new UI. Bug: 1268182 Change-Id: I688df35fa3cdfa102edd8878b10abefa87fcecdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329082 Reviewed-by: Andre Le <leandre@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/main@{#952161}
-
upload report.json to result db as invocation level artifact
wpt_uploader will fetch such report from CI, merge the reports from each shard, and populate the report to wpt.fyi. Bug: 1190323 Change-Id: I99e1da99d14de9c97a4a717277ac8c17908f05f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321506 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#952164}
-
App history: don't test popstate/hashchange event ordering
It is not interoperable or well-specced and changes depending on some Blink parser experiments that are currently ongoing. For now, we should disable it, until we get spec clarity. Bug: 1254926 Change-Id: I444c2981d8c1eb7b6c1c0fbe5db3972c40de27a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341394 Auto-Submit: Domenic Denicola <domenic@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#952166}
-
Removing apk uploaded by mistake
The CL https://chromium-review.googlesource.com/c/chromium/src/+/3163396 uploaded by mistake an apk. This CL does clean-up of that apk file. Bug: 1249189 Change-Id: I651d97af063fa97409f1bf253b803e2a97b07d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342907 Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#952167}
-
[cast_core] Remove CastRuntimeService::Create static factory.
Clean up of build dependencies allows to remove the static factory method in favor of creation CastRuntimeService instance in a particular browser client. Bug: b:210127896 Test: unit test and local runs Change-Id: Ia72e4fceff784d5bc361f21073bb7c71dc9623e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340081 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#952170}
-
Extend expiry of DirectSockets.PermissionDeniedFailures
Bug: 1277117 Change-Id: Id84df306e3acf7f3d4ef7d6a841bf6a279e9762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320564 Reviewed-by: Glen Robertson <glenrob@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#952176}
-
Add launch failure notifications to BrowserChildProcessObserver
Also, fix a bug where the Windows sandbox would return SBOX_ALL_OK even if base::LaunchProcess failed, and launch_result was not being set for elevated processes. Add reporting of GetLastError on Windows in the ChildProcessTerminationInfo for failed launches. Also, clean up some switch statements to remove default cases. BUG=1280005 Change-Id: I1001fc950b8456b78ef1a9a985ca07cf288e8a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340072 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/main@{#952182}
-
Add trace events for NTP metrics
This CL is adding the trace events for NTP metrics. These events will be visible in trace collected from Chrometto (in the field) and be used to speedup NTP load time. R=gab@chromium.org CC=tiborg@chromium.org,dpapad@chromium.org Bug: 1279860 Change-Id: I2042679e24e39c1323d962ebec54a19d7036c017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342029 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952183}
-
Add minimal trace events for sync mojo calls
These would be very helpful when looking at traces from Chrometto. The full trace events aren't available because MOJO_TRACE_ENABLED is false in our released builds. Change-Id: I2ae5f3beb485e66b591badda80309c0cc54f9c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343221 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#952184}
-
[Extensions] Clean up ModuleSystem a bit
ModuleSystem had a lot of cruft. Clean some of it up. - Native lazy fields are no longer a thing. This lets us: * Remove NativeLazyFieldGetter() * Combine LazyFieldGetter() and LazyFieldGetterInner(), getting rid of the RequireFunction typedef * Remove SetNativeLazyField() * Simplify SetLazyField() to not take a custom AccessorNameGetterCallback - void Require() is not defined. Remove the declaration - RunString() is only used internally. Move it to private:. - Setting lazy fields are only used internally and in tests. Move it to private and expose a helper method on ModuleSystemTestEnvironment (which is already a friend class). Change-Id: Idb1225b553c0614e94659107da921efc98d32b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312112 Reviewed-by: Tim <tjudkins@chromium.org> Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952186} -
Reland: "Add remaining html accessibility static tree tests on Android"
This CL relands: crrev.com/c/3309668 Reverted here: crrev.com/c/3338480 To sheriffs: If a test fails/flakes, consider adding the "@DisabledTest" annotation to the test in lieu of a full revert. Thanks! For this reland, we have removed all instances of "offscreen", which can create flakes/failures in some cases. All failing tests had this in common, so (hopefully) this fixes all remaining issues. Original CL description: ------------------------------------------------- This CL adds the remaining static tree dump tests to Android that are part of the content/test/data/accessibility/html directory, to continue the work on closing the gap on the "missing layer". We add a batch of tests with the generated output for each test as a txt file. We only include tests that are being run on another platform already (i.e., not a blink-exclusive test), and we skip all tests which have <script>'s as those could cause flakiness, and we skip any trivial tests that produce only a one-line output, such as a test with nodes that aren't important on Android. We batch the test suite for quicker run time. ------------------------------------------------- AX-Relnotes: N/A Bug: 1258230 Change-Id: I4472ac80827a41bd1646f4dc9a6d9bc77621feb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342212 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/main@{#952187} -
[Extensions Bindings] Move handleRequestWithPromiseDoNotUse
handleRequestWithPromiseDoNotUse() is (unsurprisingly, from the name) deprecated. it's only used from mime_handler_private_custom_bindings.js. Move the function there and out of utils.js to make it less tempting. Bug: None Change-Id: Ic4891f9b23cf967cf909acee379e9258e926e62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342924 Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Tim <tjudkins@chromium.org> Commit-Queue: Tim <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/main@{#952188}
-
Revert "Print Preview: Finish migrating tests to TypeScript"
This reverts commit 34e4973. Reason for revert: Suspect causing PrintPreviewSystemDialogBrowserTest.LinkTriggersLocalPrint failure on mac bots. https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/21019/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.11%20Tests/67937/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.12%20Tests/48457/overview Original change's description: > Print Preview: Finish migrating tests to TypeScript > > Bug: 1245834 > Change-Id: Ica070a83ab3c9d9435a71a4222798400e166fd63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331661 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/main@{#952091} Bug: 1245834 Change-Id: Iff541eecf113cdd10a292db0db35aa8b430e49d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343907 Owners-Override: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/main@{#952190}
-
[FedCM] Temporarily reuse "sub" in account endpoint
Changing the account endpoint accidentally broke some partners. Temporarily restores the name "sub" until deployment is in place. Bug: None Change-Id: Ia864e4a1b028d6bd2cdc82c87e34883064e18678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342131 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952192}
-
MPArch: Replace DidFinishNavigation with PrimaryPageChanged in Chrome…
…PasswordManagerClient As a clean-up of fixing long tail of features for MPArch, this CL renames DidStartNavigation to PrimaryPageChanged in ChromePasswordManagerClient, because PrimaryPageChanged is preferred when DidFinishNavigation only handles changes to the document the user sees. Bug: 1218946 Change-Id: Ia046aa499b9b31d5d6807b9d3fbba1f0fed98bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211459 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/main@{#952193}
-
Move //{chromeos => ash/components}/login/auth
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Change-Id: Ied32c2c1cc9e0303e3906e67a47804390727f78f Bug: 1164001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329598 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Owners-Override: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> Cr-Commit-Position: refs/heads/main@{#952194}
-
Write .isolates as JSON literals, not Python literals.
This fixes a bug with `mb run` and anything else that needed to be able to run the `isolate` command against an isolate generated by MB. It looks like there may be a newer version of the isolate binary that is expecting .isolate files to be JSON, not Python literals. Bug: 1280069 Change-Id: I97e7235e087a28aa3c3657c80de6306bf3d63ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342248 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#952195}
-
[ArcMigration: Lacros to ARC] Implement LinkHandlerModel for Lacros
ArcMigration: Lacros to ARC aims to implement right-click and smart handling for ARC apps in Lacros. This CL implements LinkHandlerModel for Lacros. It also implements crosapi RequestUrlHandlerList called from LinkHandlerModel::Init. This CL doesn't affect the behavior. LinkerHandlerModel will be called from OpenWithMenu which will be implemented in the next CL. Bug: 1268687 Change-Id: I90d5a746f17cf80cf90dcd363764df21c57218ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308303 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952197}
-
Revert "input: Add keyboard details, top row, to input diagnostics"
This reverts commit de046eb. Reason for revert: Suspect browser_tests failure on linux-chromeos-rel. browser_tests failed because of: - DiagnosticsAppWithInput.BrowserTest First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/53430/overview Original change's description: > input: Add keyboard details, top row, to input diagnostics > > Additions to input diagnostics backend, increasing detail > for keyboards, particularly information about the top row > key assignments, plus tweaks to number-pads. > > Bug: 1207678 > Test: ./out/Debug/ash_webui_unittests --gtest_filter=*InputDataProviderTest* > Test: ./out/Debug/browser_tests --gtest_filter='DiagnosticsAppWithInput.*' > Test: tested with subsequent patches on Jinlon, for internal and external keyboards > Change-Id: I88d4e1051227d3226d51f88a58c0fc903a6d4975 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299112 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Harry Cutts <hcutts@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Kenneth Albanowski <kenalba@google.com> > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Commit-Queue: Kenneth Albanowski <kenalba@google.com> > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Cr-Commit-Position: refs/heads/main@{#952129} Bug: 1207678 Change-Id: I007067450df7588610887f20a76e7e94f6395576 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343911 Owners-Override: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/main@{#952198}
-
[Sharesheet] Remove obsolete FileBrowser.Share.FileType metric.
This metric is being replaced with ChromeOS.Sharesheet.Invocation.MimeType. Bug: 1257857 Change-Id: I4d4b724f43e1c1b142212058b3bd2d22a95e5dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329043 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Nigel Tao <nigeltao@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952199}
-
[ULP] Add Java-side ULP initiation histogram.
Bug: 1258261 Change-Id: I5e3ab7aa86d342d0fa101b46ed67c1aac8a3808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324695 Reviewed-by: Megan Jablonski <megjablon@chromium.org> Reviewed-by: Max Curran <curranmax@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/main@{#952202}
-
bluetooth: bluetooth server tests to standalone tests
This change updates some of the tests in wpt/bluetooth/service to be standalone window tests. This change allows the tests to be formatted with clang-format. Additionally, fix wpt/bluetooth/service/device-same-object.https.window.js to compare with the correct device object. Bug: 994756 Change-Id: I97a50d2727427d91ba8856f79c5d39336f4b8479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339771 Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Jack Hsieh <chengweih@chromium.org> Cr-Commit-Position: refs/heads/main@{#952204}
-
webcodecs: Avoid GPU crash in basic_video_encoding.https.any.js test
Unfortunately this doesn't address the underlying problem, just avoids usage of VT video decoder in web tests. Bug: 1276334 Change-Id: I881aec92c29cfb14531c23e7aa7b3da87b1b91fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343946 Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#952209}
-
[Extensions c2s] Create Site Access sections in menu and populate
This change creates the sections in the site access tab and inserts extensions items in the correct section only at the tabbed menu's creation. Next cls will listen for changes (extension added, removed, updated) when the menu is open, and add the permissions dropdown to the extension menu item. Bug: 1263310 Change-Id: I0f41da0f0ddc29e5a6629dfe59bb186a80b5fb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340094 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#952210}
-
Clipboard: Read non-PNG images as bitmaps on Android
https://crrev.com/c/2982584 introduced a new way to read images from the Android clipboard, by reading raw PNG bytes rather than decoding the image to a bitmap, then re-encoding to a PNG (losing metadata along the way). However, this only allowed for reading images as PNGs. Support for non-PNG images was overlooked. This CL adds support for reading non-PNG images using ImageDecoder by decoding the image to a bitmap, then encoding as a PNG. https://developer.android.com/reference/android/graphics/ImageDecoder Tested manually using repro described in the bug. Bug: 1250269 Change-Id: I00d34df9673b1a9dc4e15d1a26b7e731f8fedbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329668 Reviewed-by: Gang Wu <gangwu@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#952211}
-
[Snooping protection] Don't cache stale daemon state.
Since we weren't clearing the cached daemon state, we would erroneously report any previous execution's state while we were waiting for a new execution to respond. This was easy to miss in tests (where DBus calls return instantly) but very obvious on-device. Bug: chromium:1241704 Change-Id: I63e7066d214ff3334a937ab825598e522e4ded6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341171 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/main@{#952212}
-
[wpt] Fix expectation of WPT test.
The test-expectation for: css-sizing/table-child-percentage-height-with-border-box.html is incorrect. From: web-platform-tests/wpt#32026 Specifically it is incorrect about how table-cell children resolve their percentages, as defined by: https://drafts.csswg.org/css-tables-3/#table-cell-content-relayout (it was asserting that content-box behaves as border-box for table-cell children where the table-cell is auto height which is incorrect). Bug: 1280198 Change-Id: I8d9e1f17a0e647425aeaa169f8849ba76df663a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342920 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#952215}
-
Add Search mode in remote tabs panel in tab grid
Applying the new proposal of having search in remote tab panels instead of showing their results on the active normal tabs panel. Also disable sideswiping between panels when the search mode is active. Bug: 1279561 Change-Id: If91bf9630a2afe984b39e0b7117be64b792d9307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335368 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/main@{#952216}
-
[ArcMigration: Lacros to ARC] Implement HandleUrl
ArcMigration: Lacros to ARC aims to implement right-click and smart selection handling for ARC apps in Lacros. This CL adds crosapi interface of HandleUrl and implements it. HandleUrl calls IntentHelperInstance::HandleUrl which launches the suitable activity+package from ARC. This crosapi is required for ARC apps since intent handling is delegated to ARC for some activities specific to ARC apps. This CL doesn't affect hte behavior since OpenLinkWithHandler is not called from Lacros yet. Bug: 1268687 Change-Id: Iacf1cc19c744b1f270c44a6aaf6dae8c106a2d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3303230 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952219}
-
Prerender: extend PageLoad.Clients.Prerender.PaintTiming.* histograms
These metrics are used for the Prerender project, which is actively under the development. This CL extends the expire date of these metrics. Bug: 1279472, 1279473, 1279474, 1279475, 1279476, 1279477, 1279478 Change-Id: Id5a73f8e52eedec987bb479d029837e9e4e167e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341091 Auto-Submit: Asami Doi <asamidoi@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/main@{#952220}
-
CCA: Migrate barcode_chip.js to TypeScript
Bug: b:172340451 Test: tsc compiles Change-Id: I81a4f412d9a46e105729109f345ba5bc74883bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299884 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#952221}
-
[Extensions] Clean up a couple build files
A few build files are conflating `enable_extensions` with specific platforms. Clean up a few smatterings of these. Bug: 731689 Change-Id: I8c7dee842f9d22e370ffb7afe440d3b4956c693d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331529 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952222}
-
[GMNext] Make control_highlight_color dynamic
Bug: 1228454 Change-Id: Ibc5bdec72843ffa122c5687e4819a09a0742801b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327572 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952223}
-
Slimming PaintLayer: remove more pre-CAP code from PaintLayer (4)
This patch removes the following fields: should_isolate_composited_descendants_ descendant_has_direct_or_scrolling_compositing_reason_ needs_compositing_layer_assignment_ descendant_needs_compositing_layer_assignment_ needs_check_raster_invalidation_ PaintLayerRareData::subpixel_accumulation And the following static variables: g_compositing_query_mode Bug: 1277748 Change-Id: I5dbd18ab682139b09dddcae0ca49d10d19d846e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343277 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952224}
-
CodeHealth: Refactor extensions::Manifest::{GetString => FindStringPath}
Bug: 1187036 Change-Id: I5ddbb53d37c71df9f67466547a1bf3b89f0500ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320986 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#952225}
-
Update beforematch for hidden=until-found
This patch makes beforematch only fire on elements with the hidden=until-found attribute. Bug: 1250851 Change-Id: I08b354f724ae085073ce80f16467f76e15ca8e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307131 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#952227}
-
[AW] Always record system apps package in WebView metrics
This only changes how package names are recorded for apps that use WebView and not other content embedders. It only change the behaviour when the allowlist of apps package names is enabled. Bug: 1273635 Test: run_android_webview_unittests -f "*AwMetricsServiceClientTest*" Change-Id: I932fffe6b3295367c6ecbf61ae0ce5d14cc4d5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340723 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/main@{#952231}
-
sensors: Split accelerometer tests to avoid flake
The generic sensor test suite can take a long time. This change splits the tests for the three accelerometer interfaces (Accelerometer, GravitySensor and LinearAccelerationSensor) into separate test files to avoid the likelihood that they time out. Fixed: 833215 Change-Id: I406e71b9da08c36c3495de5029b322c9de039e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344186 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/main@{#952235}
-
Refactor: Move mask/badge icon resources to //chrome/browser/resources
This CL moves icon resources in //ui/chromeos/ui_chromeos_resources to //chrome/browser/resources. Icon resources are only used from //chrome/browser, and only used for ash-chrome, so //chrome/browser/resource/chromeos is an appropriate place to put resources to make them close to where they are used. The behavior is not modified by this change. Change-Id: I375c6602e94c56c9cfde0613f344c4a7ad86a4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338038 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952238}
-
blink/handwriting: correctly report unsupported languages
Previously, we report "Internal Error" if mlservice fails to create a recognizer, even for unsupported languages. This CL changes so we always report the "model constraints aren't supported" for these cases. Bug: 1183652 Change-Id: I2e6f0c13964fde5643851acbad62e3daacb627ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336799 Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by: Honglin Yu <honglinyu@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952239}
-
Track theme correctly for light/dark header images.
Bug: 1272992 Change-Id: I12dfd819163b9d6a96355789ba42cceea9d86262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339387 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#952244}
-
terminal: Add chrome.terminalPrivate.getOSInfo().
This extension API calls a callback with an object containing ChromeOS settings that affect the Terminal. For now, it's just exposing whether the tmux integration is enabled via chrome://flags. We're going to use this to feature-gate the new tmux functionality. Bug: 1252271 Change-Id: I47d04104cbabb8fe42e388bdb2bf395e65980b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340360 Reviewed-by: Jason Lin <lxj@google.com> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Emil Mikulic <easy@google.com> Cr-Commit-Position: refs/heads/main@{#952245}
-
Add DumpWithoutCrashing to NavigationEntryImpl::GetTreeNode()
We're seeing some crashes when calling MatchesFrame() on a null TreeNode. This CL adds a check to not crash in that case and also log some more information + DumpWithoutCrashing to understand what's happening. Bug: 1279628 Change-Id: Ic69cfa39ea1076b6c0bee0ccc2dbf11e7f9d2852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340139 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#952247}
-
ServiceWorker: Move ServiceWorkerFetchContextImpl for Onion Soup
As a part of the Service Worker Onion Soup, this CL moves ServiceWorkerFetchContextImpl from content/renderer/service_worker/ to third_party/blink/renderer/modules/service_worker/. Along with that, the class is renamed to WebServiceWorkerFetchContextImpl to be aligned with other classes implementing Blink's public interfaces. Bug: 789857 Change-Id: I32b3e8551ffe87bbea70f1e8a9f4d4eb18910859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3296044 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Asami Doi <asamidoi@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#952249}
-
media/gpu/VEA: provide frame QP by VEA through BitstreamBufferMetadata
webrtc would parse the encoded frame QP if not provided by the encoder, this CL reports the frame QP info for Vp8VaapiVED and Vp9VaapiVED and propagate QP through BitstreamBufferMetadata qp field. Bug: 1276221 Change-Id: I6f1343352cddcd998fe154c02b65dcf07c939d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313005 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/main@{#952250}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.