[pull] main from chromium:main #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bug: 1279460 Change-Id: I7b0b93b370b624bb7f06c8f509517025c68fdcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341517 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/main@{#951998}
This CL creates a new class that will allow to record metrics that are not bound to single asynchronous jobs without using JobReturnHandler (that can be misleading). This is a mechanical change that does not change any behavior. Bug: 1229655 Change-Id: I1a64a6a94c32a32d340b575ef12fe1a71a0c3fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330289 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#951999}
Bug: None Change-Id: I830c4bf2e947e002b50565306effb66c9b02bac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340527 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952000}
In PDFiumFormFiller::Form_OnFocusChange(), defer unloading to avoid triggering code that would unload the page that PDFium still has a pointer to. Bug: 1279147 Change-Id: I294b75e6fc9484056c7aba4dbea2457a978041b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340453 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#952001}
Focus rings have the advantage of not creating a inset like a border would. This is needed for DeskTemplatesNameView as the text is indented by a couple pixels due to a border. Making it would mean we would have to deviate from the current box layout(s) and add logic to layout the view such that the border is accounted for. Makes focus rings to work for DeskNames as part of the CL. Test: manual Change-Id: I545239b32445700ed70eb4ab752c813bb8e843dd Fixed: 1276202, 1280073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339774 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/main@{#952002}
PaymentRequest::DidStartMainFrameNavigationToDifferentDocument()'s implementation has been removed[1]. The method declaration should be removed as well. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3311758 Change-Id: Icbfec520c1b8a82aefb43446ed87c4fa1d5c27d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340753 Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#952003}
Break apart some tests from site_per_process_browsertests into a separate file. Change-Id: Ifcfaa5ad082db122be8da0bfe90f58e059c0adde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309890 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/main@{#952004}
Hide the privacy page entry row to privacy review when users become managed or sign in to a child account. Bug: 1215630 Change-Id: Id9deb60b05e7fbe1e7917519f76837ee8c202aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339311 Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#952005}
https://chromium.googlesource.com/angle/angle.git/+log/8419f4fcd1ec..cac81f0772cc 2021-12-15 sugoi@google.com Return full error info when opening a library with dlopen 2021-12-15 syoussefi@chromium.org Vulkan: Fix desc set updates with Vulkan SCBs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1246171 Tbr: timvp@google.com Change-Id: If755380a983314c7feff2f8ee6a198690a6813f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342092 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952006}
Now that the SpeechRecognitionPrivate API has been fully implemented, we can promote it to the stable channel. This must be done in order to launch the dictation extension, which uses the API. This change also resolves a permissions TODO by adding a permission string for the API. AX-Relnotes: N/A Bug: 1220107 Skip-Translation-Screenshots-Check: True Change-Id: I8672ad3e0eb9e51434ea9ffa00080139b94f76cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327565 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#952007}
This fixes TabPersistentStoreUnitTest#testNtpSaveBehavior. StatusMediatorUnitTest sets a mock LibraryLoader for testing and did not restore the original before this CL. This caused GURL instantiations, like in TabPersistentStoreUnitTest#testNtpSaveBehavior, to crash. Bug: 1278039 Change-Id: I5af32a97b3902819344b3fee6329a79039fa74da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337986 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/main@{#952008}
Two startup time histograms are expiring soon: - ProfilePicker.StartupTime.MainViewInitialized - ProfilePicker.StartupTime.WebViewCreated These are not the main profile picker startup metrics, but it'd be nice to keep them for the upcoming experiment with not loading guest profile on startup. Bug: 1270392 Change-Id: I855c1a3b11a022cb99c2ab0a8c09853e45c071d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338702 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/main@{#952009}
This will be needed for creating a temporary HarfBuzz hb_face_t when inspecting CPAL palette information when instantiating color fonts with palette overrides. No functional change. Bug: 1170794 Change-Id: Ifeeb3d2cebe70e39b0ffe1db86170549b0f24cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341911 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#952010}
Bug: 1278011 Change-Id: I8afa869626da353d49bac5b6925c1f4cda55379a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338999 Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952011}
Bug: 1279492 Change-Id: I6297a4005c566eded96ed31d5bc958bdc19d812b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339099 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Ali Beyad <abeyad@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org> Cr-Commit-Position: refs/heads/main@{#952012}
Bug: 1278994, 1279323 Change-Id: I193532d83c892c8aac436fe81adfcec6f207a8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341912 Reviewed-by: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#952013}
https://android.googlesource.com/platform/external/perfetto.git/+log/f9abf9948a18..22467673a50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I19e62d24c9cdfdc4e85146b938c54adbf4ddf015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342210 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952014}
Bug: 1278011 Change-Id: I1d0bbdd2011bee5bf28215f47eef4be226ba9d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339075 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#952015}
Crash keys are not yet supported on Fuchsia. Bug: 961457, 1186718 Change-Id: I85de2be7223bd8e907cf6c8def1805b29587d619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330868 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Bryant Chandler <bryantchandler@chromium.org> Cr-Commit-Position: refs/heads/main@{#952016}
In old days, we use alphaOp attribute in copyTextureForBrowserOptions to guide how to do premultiply/unpremultiply work. But this attribute has been deprecated when we landed supporting of color space conversion for CopyTextureForBrowser. Instead we providing srcAlphaMode and dstAlphaMode to copyTextureForBrowserOptions. This CL uses srcAlphaMode/dstAlphaMode to replace deprecated alphaOp. Bug: dawn:1140 Change-Id: I95dfc727746a76eaea8bf7fd0a751b54ba5d436b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341251 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#952017}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/fuchsia-internal-sdk-chromium Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I930ff5969f1aa55c14cec2e7872be858091bb07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342357 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952018}
- Includes capping the number of reactions when adding from the toolbar - Duplicates is already capped, but the error message was added. Fixed: 1263022, 1277166 Change-Id: I76fc4fba1fe2d0907854103a035298160cffa53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339833 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Guillaume Jenkins <gujen@google.com> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/main@{#952019}
Bug: 1264439 Change-Id: I05229f4cd0882c59a4ff15815f5a2c0fc0a18651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341153 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/main@{#952020}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639569614-95b758b6040b003c163872523f690d81e16cfff4.profdata to chrome-win32-main-1639580383-b8027ac27b70be2c1132df9ac8ecd76a61e2f927.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I99331789cc854a7b70b23f30a27b0a15efdbd933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342094 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952021}
The license issue on https://pspdfkit.com/webassembly-benchmark has been fixed. Update wprgo files for the benchmark and enable the tests. Bug: 1275969 Change-Id: Iee58f94395d66962252c0748c958c8d867ba2e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329047 Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Stephen Nusko <nuskos@chromium.org> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Chisoon Jeong <chisoon.jeong@lge.com> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952022}
This patch fixes a remoting crash caused by not running callbacks on the correct task runner. It also includes some minor move semantics changes to the remoting callbacks. Change-Id: Ia9c6e678ada2db6782f6c61b71c4c710479bacca Bug: 1277754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336489 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/main@{#952023}
Change-Id: Id19cdbecf27078e70c1741f18a5d922d9283a513 BUG=b/210452436 BUG=1279997 Change-Id: Id19cdbecf27078e70c1741f18a5d922d9283a513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339779 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Ross Gibb <rossgibb@google.com> Auto-Submit: Ross Gibb <rossgibb@google.com> Cr-Commit-Position: refs/heads/main@{#952024}
…thCallback" This reverts commit ffa8fb0. Reason for revert: chromium:1280367 Original change's description: > ExternalVkImageBacking: Shim WritePixelsWithData on top of WithCallback > > This avoids using Skia to upload CPU data to the Vulkan texture and > instead reuses an existing path. Also removes the unused stride argument > of WritePixelsWithCallback and inlines WritePixels in its only call > site. > > Bug: chromium:1279419 > Change-Id: I847db28dbf59618ff9bd05c0af010693f5a53293 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332719 > Auto-Submit: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951934} Bug: chromium:1279419 Change-Id: I424c91faf073f1844ac8c947a772a32ad30a6bfe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342505 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Owners-Override: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#952025}
After uploading the `FromEnumBitmaskIgnoresExtraBits` test that
exercises `ToEnumBitmask()` and `FromEnumBitmask()`, danakj@ pointed out
that silently ignoring out-of-range enum values may be incorrect.
It dawned on me how confusing that is when I saw that a test like the
following passes:
````
enum class SomeEnum {
Min,
Foo,
Max,
AfterMax,
};
using SomeEnumSet = EnumSet<SomeEnum, SomeEnum::Min, SomeEnum::Max>;
SomeEnumSet enums(SomeEnum::Foo, SomeEnum::AfterMax);
SomeEnumSet reconstructed;
for (SomeEnum val : enums)
reconstructed.Put(val);
EXPECT_EQ(enums, reconstructed);
````
The above test only passes because `SomeEnum::AfterMax` was ignored by
the constructor. Technically, `enums` and `reconstructed` are equal, but
neither contains `AfterMax`!
With this CL, the following methods crash when they receive out-of-range
enum values:
* The variadic constructor
* single_val_bitstring()
* Put()
* FromRange()
I'm intentionally leaving Remove() and Has() as no-ops when the input is
out of range. It seems reasonable that a caller may want to explicitly
check that their EnumSet does not contain Foo, even though Foo is out of
range.
Change-Id: I4c46059df206a789bfccd1bd7ab89aa8ca21a682
Bug: 1278383, 1278484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327788
Reviewed-by: danakj chromium <danakj@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#952026}
This removes NonSFI related paths and switches. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I1d508882d3b452923b435821ba4605817d1322b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341176 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Derek Schuff <dschuff@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/main@{#952027}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/48b35e123dff..e88997a2613a 2021-12-15 olivierrobin@google.com Add default XCode for iOS11.3+ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,gavinmak@google.com,sokcevic@google.com Change-Id: Id57889f8d510d872009150db4aaec3b0089afce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342499 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952077}
https://chromium.googlesource.com/catapult.git/+log/b759738dea9a..58f3a92099a0 2021-12-15 heiserya@google.com Add Speedometer2 RunsPerMinute to BigQuery Chrome Health export If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1279889 Tbr: skyostil@google.com Change-Id: I23d8525185591d10674c8e1f43c9ce1454284881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342095 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952078}
https://chromium.googlesource.com/angle/angle.git/+log/cac81f0772cc..feb599ad894b 2021-12-15 m.maiya@samsung.com Invalidate EGL handles during eglTerminate 2021-12-15 lexa.knyazev@gmail.com Expand WebGLCompressedTextureAvailabilityTest 2021-12-15 jmadill@chromium.org end2end_tests: Add SwS + AsyncQueue testing. 2021-12-15 gman@chromium.org Update warning message for invalid include If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1048244,chromium:1279908 Tbr: timvp@google.com Test: Test: Android CTS WrapperTest.testThreadCleanup Test: Test: EGLMultiContextTest.NegativeTestAfterEglTerminate* Test: Test: EGLMultiContextTest.RepeatedEglInitAndTerminate* Change-Id: I2ccf24d8077ece41b839c2ca9478a2b4523b5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342728 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952079}
The size was previously computed using a recursive function and would only visit children. Change computation to consider inner frame trees. BUG=1258196 Change-Id: I56bf6e9cc88e2d99542da205bc8b25001f11c735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330964 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#952080}
Updated according to latest Sherlock builder run: https://ci.chromium.org/ui/p/chrome/builders/ci/fuchsia-fyi-sherlock/2419/test-results After this CL, the builder should be green and ready to be tracked for regressions. Change-Id: I375d855aeb23bc2515258b8c7cbd6707df8a1b4a Bug: 1261867, 1145861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342733 Auto-Submit: David Song <wintermelons@google.com> Reviewed-by: Chong Gu <chonggu@google.com> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#952081}
Roll Chrome Mac PGO profile from chrome-mac-main-1639569614-d251f83da686019cc9a1332b1064979740a5536b.profdata to chrome-mac-main-1639591173-0244749f96275593dcee7f94bfec65b371fce288.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14b9749c0b69ef13cd55180b5f8193ff0b11e02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342498 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952082}
Make TrustedSignalsRequestManager use raw_ptrs instead of...um...raw pointers. It still uses std::sets<ptr*>'s, since raw_ptrs currently are never used in sets. Bug: 1276639 Change-Id: I6968a7b56a16131276440735c9e5cb8692038c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342427 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#952083}
This UMA histogram was recently added, but unfortunately it is only returning "RUNNING". This should fix this by only returning "RUNNING" once the AsyncTask's "doInBackground" function actually begins. Change-Id: I876c2827abbd467fc2bb00e48a63d5162a031ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341641 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/main@{#952084}
This is the final DNS Addresses CL to implement the corresponding private API attribute as described in go/webprotect-caa-attributes-dd and go/webprotect-caa-dns. This CL mostly implements this by unifying the new Posix implementation with the existing Linux implementation by reusing ResolvReader. Bug: 1169237 Change-Id: Ie15d9b6176831a289009f4a52b439a1ff5e9d188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314732 Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/main@{#952085}
Add a link from the top-level style guide list. Mark each item in the set of features as banned/allowed since it's hard to go backward from an item you searched for back to its status currently. Update the timeline for C++17. R=jbroman@chromium.org Change-Id: I46ea8c7e086a93b1878dcd396186977938c4ae6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341807 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: danakj chromium <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#952086}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b52ee54b2a18..cc4f8ef12d74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1196641 Tbr: jianli@google.com,pmonette@google.com Change-Id: I08d7e47e24ac3a841969b9212e8a9556453842dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342732 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952087}
Bug: 1277823 Change-Id: I2e2e71930fc256d4855ebf06a34191480b87944b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342467 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Tom Burgin <bur@chromium.org> Cr-Commit-Position: refs/heads/main@{#952088}
When enabled via policy, this will display a list item at the bottom of the cast menu that, when clicked, will take users to the access code casting dialog (so that they can enter the access code displayed on a chromecast to begin casting). BUG=b:201437799 Change-Id: If644787c5b0c4247e7aabf52caf5934ffb0bdb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339189 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/main@{#952089}
https://skia.googlesource.com/skia.git/+log/e17fd4fea551..dc60ca197e02 2021-12-15 herb@google.com cleanup TODOs, and warnings 2021-12-15 kjlubick@google.com [bazel] Move cache location to bigger disk for CI tasks 2021-12-15 kjlubick@google.com [canvaskit] Reset GrContext after lazy-loading image from texture 2021-12-15 rmistry@google.com Add oss-fuzz related documentation for the GPU Gardener 2021-12-15 johnstiles@google.com Add variable falling-out-of-scope case to SkVM trace tests. 2021-12-15 herb@google.com Remove SkRemoteGlyphCache.h 2021-12-15 brianosman@google.com Clean up intrinsics slightly If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I4e94d613268b58ec3b36c6319c986c13afa7f92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342352 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952090}
Bug: 1245834 Change-Id: Ica070a83ab3c9d9435a71a4222798400e166fd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331661 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#952091}
This enables the video decoding path in Chrome for the HWDRM system in ChromeOS on AMD platforms when used with ARC. In this mode, there is a special marker at the beginning of the video data that is followed by a size and protobuf. The protobuf contains additional details needed to handle the decoding. This then feeds into the normal VideoDecoderPipeline which will handle everything else. There will be a follow up CL which handles setting the quads to be for HW protected video. This feature is not enabled until we turn on USE_ARC_PROTECTED_MEDIA in the Chrome build config for ChromeOS. BUG=b:203821839 TEST=Works with full prototype, existing playback still works Change-Id: I76006d37cb7454e9f6ac560858ac9c772ce35225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331180 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/main@{#952092}
Suppresses several web tests that are failing on Linux when running with SkiaRenderer Vulkan. Bug: 1278181 Change-Id: I86d35fbf24daf1cffd182b60e43b7b14e36144b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342915 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#952093}
Refactored java_test_utils.py to perform reads and parsing of Java test source code files. This encapsulates the use of the javalang Python module to this file. Added a JavaSyntaxError subclass of SyntaxError to avoid exposing the custom javalang.parser.JavaSyntaxError exception to callers. Bug: 1254072 Change-Id: I2d29115b94effb9c9ece452b261fb09f5d52f128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337436 Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Fred Mello <fredmello@chromium.org> Commit-Queue: Andrew Heard <andrewheard@google.com> Cr-Commit-Position: refs/heads/main@{#952094}
Moves two internal-only methods from webxr-test.js to the internal-only script (xr-internal-device-mocking.js). Sorts webxr-test.js methods to match the webxr test api spec, and adds comments about which methods are "extension" methods. Group and explicitly call out Mojo methods (which cannot be renamed). Renames helper methods (e.g. methods that should not be called outside of this file or the internal-only files), so that all are prefaced with an _ where possible. Additionally, implements two trivial methods for WebXR Hit Test extensions. Note that one of these is currently unused while the other simply encapsulates some existing logic. Fixed: 985163 Change-Id: I62cd6a73a9a77d12d95b3734c861ac6d3947fc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342867 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#952095}
It is an unused feature plus it enables some additional code required to handle PAC enabled binaries. Finally, it should fix the failing Stacktrace tests in WebRTC. Bug: 919548, webrtc:13383 Change-Id: I5e49b6daa89bda4c6997e0c18de89237ae38356d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297439 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/main@{#952096}
The crash is because fSupportBilerpFromGlyphAtlas is need for the fuzzer test. Enable it will increase memory usage for glyphs altas, however GrContextForGLES2Interface is only used by GLRenderer, Accelerated Canvas and some tests. GLRenderer is deprecated. Accelerated Canvas should not use too much text, and it could be replaced with OOPR Canvas. So it should be fine. Bug: 1280270 Change-Id: Ia7f1ced7377a599598927331bdd3624d9ca7b024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342468 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952097}
Remove the hard-coded assumption that the buffer format is always DRM_FORMAT_RGBX8888, and the modifier is always DRM_FORMAT_MOD_LINEAR (0). On some ChromeOS targets, the Android processes were allocating a buffer with a different format, such Trogdor using DRM_FORMAT_MOD_VENDOR_QCOM. The mismatch led to the buffer being decoded incorrectly on the Android side. Bug: b:208686337 Test: Screen captures look correct on Trogor Change-Id: I0c3c922a90b4f7dfd0547eed71e56c2b71aef8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330921 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/main@{#952098}
Bug: 1238197 Change-Id: Ie6fd4af851af5f373ecb6c4663dc394d28e251ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329627 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Jong Ahn <jongahn@chromium.org> Cr-Commit-Position: refs/heads/main@{#952099}
Bug: 1280387 Change-Id: I74ce845293dd1f7b94dbbb3aab38fbde311ca6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342946 Auto-Submit: Jian Li <jianli@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/main@{#952100}
The Trusted Tester rollout plan is to enable Projector for managed user guarded by an Admin policy. This CL added a new admin policy to control the Trusted Tester rollout. It will be disabled by default for now and will only be visible to domains that participate in the Truste Test. Bug: b/209675088 Change-Id: I8b3a81f740d8540c782754c80a1c676764e587cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324417 Reviewed-by: Yilkal Abe <yilkal@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952101}
Binary-Size: This is already being paid in downstream. Bug: 1279417 Change-Id: Ib6d1bdf4f13ad9b06e077dc853ca9da2a4106075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335441 Reviewed-by: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#952102}
Fixed: 1280401 Change-Id: Ifad83da026676f339e4db8e0ebf23a1dd2bf95e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340087 Auto-Submit: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#952103}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )