[pull] main from chromium:main #117
Merged
Commits on Dec 15, 2021
-
CookieSettings: Extend 3p cookie histograms
Bug: 1279460 Change-Id: I7b0b93b370b624bb7f06c8f509517025c68fdcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341517 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/main@{#951998}
-
fix x11_window.cc ref in input events docs
Bug: None Change-Id: I830c4bf2e947e002b50565306effb66c9b02bac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340527 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952000}
-
Speculatively defer page unloading in a PDFiumFormFiller callback.
In PDFiumFormFiller::Form_OnFocusChange(), defer unloading to avoid triggering code that would unload the page that PDFium still has a pointer to. Bug: 1279147 Change-Id: I294b75e6fc9484056c7aba4dbea2457a978041b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340453 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#952001}
-
Remove unused method declaration
PaymentRequest::DidStartMainFrameNavigationToDifferentDocument()'s implementation has been removed[1]. The method declaration should be removed as well. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3311758 Change-Id: Icbfec520c1b8a82aefb43446ed87c4fa1d5c27d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340753 Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#952003}
-
Move cert error related tests to separate file
Break apart some tests from site_per_process_browsertests into a separate file. Change-Id: Ifcfaa5ad082db122be8da0bfe90f58e059c0adde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309890 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/main@{#952004}
-
SpeechRecognitionPrivate: Resolve blocking TODOs
Now that the SpeechRecognitionPrivate API has been fully implemented, we can promote it to the stable channel. This must be done in order to launch the dictation extension, which uses the API. This change also resolves a permissions TODO by adding a permission string for the API. AX-Relnotes: N/A Bug: 1220107 Skip-Translation-Screenshots-Check: True Change-Id: I8672ad3e0eb9e51434ea9ffa00080139b94f76cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327565 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#952007}
-
Factor out creating a HarfBuzz hb_face_t from SkTypeface
This will be needed for creating a temporary HarfBuzz hb_face_t when inspecting CPAL palette information when instantiating color fonts with palette overrides. No functional change. Bug: 1170794 Change-Id: Ifeeb3d2cebe70e39b0ffe1db86170549b0f24cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341911 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#952010}
-
Enable dynamic refresh of updated GREASE policy
Bug: 1279492 Change-Id: I6297a4005c566eded96ed31d5bc958bdc19d812b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339099 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Ali Beyad <abeyad@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org> Cr-Commit-Position: refs/heads/main@{#952012}
-
Replace deprecated AlphaOp with src/dst AlphaMode
In old days, we use alphaOp attribute in copyTextureForBrowserOptions to guide how to do premultiply/unpremultiply work. But this attribute has been deprecated when we landed supporting of color space conversion for CopyTextureForBrowser. Instead we providing srcAlphaMode and dstAlphaMode to copyTextureForBrowserOptions. This CL uses srcAlphaMode/dstAlphaMode to replace deprecated alphaOp. Bug: dawn:1140 Change-Id: I95dfc727746a76eaea8bf7fd0a751b54ba5d436b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341251 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#952017}
-
AngleVulkan: refine the function and variable names in GLSurfaceEGL
Bug: 1264439 Change-Id: I05229f4cd0882c59a4ff15815f5a2c0fc0a18651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341153 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/main@{#952020}
-
[telemetry][wasm] Refresh PSPDFKit benchmark.
The license issue on https://pspdfkit.com/webassembly-benchmark has been fixed. Update wprgo files for the benchmark and enable the tests. Bug: 1275969 Change-Id: Iee58f94395d66962252c0748c958c8d867ba2e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329047 Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Stephen Nusko <nuskos@chromium.org> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Chisoon Jeong <chisoon.jeong@lge.com> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952022}
-
[Cast Streaming] Fix remoting crash
This patch fixes a remoting crash caused by not running callbacks on the correct task runner. It also includes some minor move semantics changes to the remoting callbacks. Change-Id: Ia9c6e678ada2db6782f6c61b71c4c710479bacca Bug: 1277754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336489 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/main@{#952023}
-
Adding .wll file extension to
DOCUMENTtype.Change-Id: Id19cdbecf27078e70c1741f18a5d922d9283a513 BUG=b/210452436 BUG=1279997 Change-Id: Id19cdbecf27078e70c1741f18a5d922d9283a513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339779 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Ross Gibb <rossgibb@google.com> Auto-Submit: Ross Gibb <rossgibb@google.com> Cr-Commit-Position: refs/heads/main@{#952024}
-
Revert "ExternalVkImageBacking: Shim WritePixelsWithData on top of Wi…
…thCallback" This reverts commit ffa8fb0. Reason for revert: chromium:1280367 Original change's description: > ExternalVkImageBacking: Shim WritePixelsWithData on top of WithCallback > > This avoids using Skia to upload CPU data to the Vulkan texture and > instead reuses an existing path. Also removes the unused stride argument > of WritePixelsWithCallback and inlines WritePixels in its only call > site. > > Bug: chromium:1279419 > Change-Id: I847db28dbf59618ff9bd05c0af010693f5a53293 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332719 > Auto-Submit: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951934} Bug: chromium:1279419 Change-Id: I424c91faf073f1844ac8c947a772a32ad30a6bfe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342505 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Owners-Override: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#952025}
-
EnumSet: crash various methods when given out-of-range enum values
After uploading the `FromEnumBitmaskIgnoresExtraBits` test that exercises `ToEnumBitmask()` and `FromEnumBitmask()`, danakj@ pointed out that silently ignoring out-of-range enum values may be incorrect. It dawned on me how confusing that is when I saw that a test like the following passes: ```` enum class SomeEnum { Min, Foo, Max, AfterMax, }; using SomeEnumSet = EnumSet<SomeEnum, SomeEnum::Min, SomeEnum::Max>; SomeEnumSet enums(SomeEnum::Foo, SomeEnum::AfterMax); SomeEnumSet reconstructed; for (SomeEnum val : enums) reconstructed.Put(val); EXPECT_EQ(enums, reconstructed); ```` The above test only passes because `SomeEnum::AfterMax` was ignored by the constructor. Technically, `enums` and `reconstructed` are equal, but neither contains `AfterMax`! With this CL, the following methods crash when they receive out-of-range enum values: * The variadic constructor * single_val_bitstring() * Put() * FromRange() I'm intentionally leaving Remove() and Has() as no-ops when the input is out of range. It seems reasonable that a caller may want to explicitly check that their EnumSet does not contain Foo, even though Foo is out of range. Change-Id: I4c46059df206a789bfccd1bd7ab89aa8ca21a682 Bug: 1278383, 1278484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327788 Reviewed-by: danakj chromium <danakj@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/main@{#952026} -
Add union CreatePushSubscriptionResultCode to replace enum
To propagate the right VideoCaptureError error_code, the enum CreatePushSubscriptionResultCode in CreatePushSubscriptionCallback is replaced by a union of the enum and VideoCaptureError. Bug: 1254269 Change-Id: If3f826329caedefd44f6d1b619cd1abbbf327b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325102 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: danakj chromium <danakj@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/main@{#952030}
-
StorageBuckets: Consistently check if QuotaDatabase is disabled
This change updates QuotaManager to count QuotaDatabase errors, and to disable the database after observing 3 QuotaError::KDatabaseError. This also adds db_disable_ checks consistently throughout methods that query the QuotaDatabase. This is to ensure that we do not continuously query the DB even after knowing it is not in a good state. Bug: 1267036 Change-Id: I434680df544ec32255736693c32f46e0999621e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292228 Reviewed-by: Austin Sullivan <asully@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/main@{#952031}
-
webcodecs: Fix frame resizing bug after reconfiguring sw h264 encoder
Bug: 1280086 Change-Id: I5b0a2a25ec494798e9c5d219e34559663ca72f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340250 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#952034}
-
[Sheriff] Further disable flaky test for mac.
Bug: 1115106 Change-Id: Ia7634de62629d890bba72f24e67cd178818368b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342686 Owners-Override: Patrick Monette <pmonette@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Reviewed-by: Jian Li <jianli@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/main@{#952036}
-
Revert "Referrer policy: Try re-enabling mac tests"
This reverts commit edc6c31. Reason for revert: caused failures on https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/45601/overview Original change's description: > Referrer policy: Try re-enabling mac tests > > The test > `external/wpt/referrer-policy/gen/srcdoc.meta/strict-origin/iframe-tag.http.html` > started failing on Mac a short while ago. Of course it passes for me > locally, and I have no good ideas as to how to fix this, so I'm going to > start by re-enabling to see if I can reproduce it that way. > > R=hiroshige@chromium.org > > Bug: 1264753 > Change-Id: Ib93719803a7c2131794d50d6cd55816f80d1fba3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341636 > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951994} Bug: 1264753 Change-Id: I5673c5fc8670babc61df077f9318250ca8f7e8ea No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342906 Auto-Submit: Jian Li <jianli@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952037}
-
[selectmenu] Update input/change firing
Update input/change firing behavior when listbox is open to match the new OpenUI resolution at [1]. That is, input is fired as the user arrow keys through the options, and change is fired when the listbox is closed if a new value was selected. [1] openui/open-ui#429 Bug: 1121840 Change-Id: I8686ad245f8d2623dec62c95dc79772519304ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336485 Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952042}
-
This bumps the expiration of various SCTAuditing histograms and updates owners to a new mailing list. Bug: 1265521 Change-Id: Idd43207cac71030fa5aea3d6e7fc87a5040487fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342355 Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/main@{#952045}
-
gpu infra: Remove ANGLE tests from Linux Debug/TSAN.
These tests are now run in ANGLE standalone and the Chrome CI can provide for differences that cause extra work for Chrome sheriffs. Bug: angleproject:6037 Change-Id: Ie760795e5a4229dddef91ae0ef9f84658162827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342429 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#952046}
-
Clean up some DEPS entries inside third_party/blink/renderer/.
- Delete unused entries. - Remove entries in third_party/blink/renderer/core/DEPS that are already in third_party/blink/renderer/DEPS. - Sort entries. Change-Id: I8fa93c8d44d17b2bc7923aa178c61254894715e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342648 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#952048}
-
[GMNext] Prepare link text for dynamic color experiment
Bug: 1241971 Change-Id: I0a5a2009a12a5dc7bf33ecc55cf9c6d8077551f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337092 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Auto-Submit: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952057}
-
[iOS] Fix multiwindow landscape rotation animation with thumb strip
The root cause was that a view was being added to the hierarchy as part of traitCollectionDidChange messing up the built-in animation. The view was added as part of installing the thumb strip because the view reveal methods are called when adding new animatees. However, this wasn't actually necessary in this case because no view reveal animations are actually occurring. The state is going from Hidden -> Hidden. Bug: 1213427 Change-Id: Iff5ff09b002c4c174c50f70f96798aaea4aefadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341527 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/main@{#952058}
-
When triggering paymentRequest.show() on a preview page on Android phone, before the change, it fails with the error "Cannot show PaymentRequest UI in a background tab." After the change, the error becomes "Cannot show PaymentRequest UI in a preview page or a background tab." Bug: 1047468 Change-Id: Icb6ec085245de711227a14a4e5cefa4bd7fed9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327982 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/main@{#952059}
-
Remove unused NTPUserDataLogger from search_tab_helper
The variable was introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/2586281/12/chrome/browser/ui/search/search_tab_helper.cc#280 But the function using the logger got removed here: https://chromium-review.googlesource.com/c/chromium/src/+/3193032/5/chrome/browser/ui/search/search_tab_helper.cc#b322 This function no longer exists: SearchTabHelper::OnLogEvent(...) { if (logger_) logger_->LogEvent(event, time); } R=tiborg@chromium.org,aee@chromium.org R=gab@chromium.org Bug: 1279860 Change-Id: Ia6046515d2b6229133795b2492679d32a7ddd0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340012 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/main@{#952064}
-
[Client Hint Issue] (1) Implement devtools issue {CHROMIUM}
Now that third-party delegation via markup for client hints is in M99, we need to start alerting developers where they use unsupported features. These features will be expanded and extended as more client hint features launch. https://docs.google.com/document/d/1lDEvj8tMeuvUs1HTTqL-44YiI-7ljeQkusM_WhUfIeE/edit This CL is a part of a series: (1) Implement devtools issue {CHROMIUM} (2) Update devtools protocol {DEVTOOLS} (3) Implement devtools issue {DEVTOOLS} Bug: 1219359 Change-Id: I8b38284fe9071399a17465f7013a9436fe7d9d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330709 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#952069}
-
[webcodecs] Disable reclamation for foreground codecs.
Bug: 1279707 Change-Id: Iad9c31d1e16379b39e094dbad9a7c12c3e9a1da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335363 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/main@{#952070}
-
[Extensions Refactor] Migrate ExtensionsMenuView unit tests
crbug.com/1263311 is introducing a new tabbed extensions menu. This CL finish migrating the ExtensionsMenuView unit tests to the appropriate test classes: * ExtensionsTabbedMenuViewUnitTests: test that the new menu behaves the same for reloading, enable and disable. * (new) ExtensionToolbarContainerUnitTests: moved here the tests that check toolbar functionality and shouldn't be affected by the menu Bug: 1279986 Change-Id: Ifeb37f3fa41caf5481e59aa8fec31e737be7c5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339775 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#952071} -
Fix cpplint issues in blink xr
Fixes cpplint issues under the blink xr module. After this git cl lint should run clean for all files in this directory. Issues were identified via running: cpplint.py --filter=-runtime/references *.h *.cc under third_party/blink/renderer/modules/xr. Note that issues matching runtime/references were ignored, since the C++ styleguide officially allows mutable references. No lint suppression was added to these as 'git cl lint' did not flag the issue. These issues were quickly scanned and most of them were flagging methods that accepted an ExceptionState&. Usernames were added to TODOs based on latest git blame for the comment. Fixed: 976796 Change-Id: I7b36e7eff7054a8cbec41e5fe348dafdfb6e6368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340236 Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#952072}
-
Compute FrameTree size using an full tree iteration.
The size was previously computed using a recursive function and would only visit children. Change computation to consider inner frame trees. BUG=1258196 Change-Id: I56bf6e9cc88e2d99542da205bc8b25001f11c735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330964 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#952080}
-
Update GPU test expectations for Sherlock
Updated according to latest Sherlock builder run: https://ci.chromium.org/ui/p/chrome/builders/ci/fuchsia-fyi-sherlock/2419/test-results After this CL, the builder should be green and ready to be tracked for regressions. Change-Id: I375d855aeb23bc2515258b8c7cbd6707df8a1b4a Bug: 1261867, 1145861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342733 Auto-Submit: David Song <wintermelons@google.com> Reviewed-by: Chong Gu <chonggu@google.com> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#952081}
-
Implementation of the dnsServers attribute for remaining Posix platforms
This is the final DNS Addresses CL to implement the corresponding private API attribute as described in go/webprotect-caa-attributes-dd and go/webprotect-caa-dns. This CL mostly implements this by unifying the new Posix implementation with the existing Linux implementation by reusing ResolvReader. Bug: 1169237 Change-Id: Ie15d9b6176831a289009f4a52b439a1ff5e9d188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314732 Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/main@{#952085}
-
Improve visibility of allowed/banned C++ stuff
Add a link from the top-level style guide list. Mark each item in the set of features as banned/allowed since it's hard to go backward from an item you searched for back to its status currently. Update the timeline for C++17. R=jbroman@chromium.org Change-Id: I46ea8c7e086a93b1878dcd396186977938c4ae6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341807 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: danakj chromium <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#952086}
-
Add ARC HW protected video decoding support for AMD
This enables the video decoding path in Chrome for the HWDRM system in ChromeOS on AMD platforms when used with ARC. In this mode, there is a special marker at the beginning of the video data that is followed by a size and protobuf. The protobuf contains additional details needed to handle the decoding. This then feeds into the normal VideoDecoderPipeline which will handle everything else. There will be a follow up CL which handles setting the quads to be for HW protected video. This feature is not enabled until we turn on USE_ARC_PROTECTED_MEDIA in the Chrome build config for ChromeOS. BUG=b:203821839 TEST=Works with full prototype, existing playback still works Change-Id: I76006d37cb7454e9f6ac560858ac9c772ce35225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331180 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/main@{#952092}
-
Android: Read Java files in test health module
Refactored java_test_utils.py to perform reads and parsing of Java test source code files. This encapsulates the use of the javalang Python module to this file. Added a JavaSyntaxError subclass of SyntaxError to avoid exposing the custom javalang.parser.JavaSyntaxError exception to callers. Bug: 1254072 Change-Id: I2d29115b94effb9c9ece452b261fb09f5d52f128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337436 Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Fred Mello <fredmello@chromium.org> Commit-Queue: Andrew Heard <andrewheard@google.com> Cr-Commit-Position: refs/heads/main@{#952094}
-
Moves two internal-only methods from webxr-test.js to the internal-only script (xr-internal-device-mocking.js). Sorts webxr-test.js methods to match the webxr test api spec, and adds comments about which methods are "extension" methods. Group and explicitly call out Mojo methods (which cannot be renamed). Renames helper methods (e.g. methods that should not be called outside of this file or the internal-only files), so that all are prefaced with an _ where possible. Additionally, implements two trivial methods for WebXR Hit Test extensions. Note that one of these is currently unused while the other simply encapsulates some existing logic. Fixed: 985163 Change-Id: I62cd6a73a9a77d12d95b3734c861ac6d3947fc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342867 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#952095}
-
Fix crash in paint_op_buffer_fuzzer
The crash is because fSupportBilerpFromGlyphAtlas is need for the fuzzer test. Enable it will increase memory usage for glyphs altas, however GrContextForGLES2Interface is only used by GLRenderer, Accelerated Canvas and some tests. GLRenderer is deprecated. Accelerated Canvas should not use too much text, and it could be replaced with OOPR Canvas. So it should be fine. Bug: 1280270 Change-Id: Ia7f1ced7377a599598927331bdd3624d9ca7b024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342468 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952097}
-
Disable some failing WPT tests
Bug: 1280387 Change-Id: I74ce845293dd1f7b94dbbb3aab38fbde311ca6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342946 Auto-Submit: Jian Li <jianli@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/main@{#952100}
-
Avoid nested loops when committing updater prefs.
Fixed: 1280401 Change-Id: Ifad83da026676f339e4db8e0ebf23a1dd2bf95e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340087 Auto-Submit: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#952103}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.