-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from chromium:main #111
Commits on Dec 14, 2021
-
[lacros] fixed popup window size problem.
This is caused by one pixel off when converting between DIP and pixels. Window geometry is not sent to the server when the visual size update doesn't match the bounds in pending configure. The off-pixel comes from the implementation difference in the gfx APIs ScaleToRoundedRect and ScaleToRoundedSize. It is possible that gfx::ScaleToRoundedRect(rect).size() != gfx::ScaleToRoundedSize(rect.size()). When setting the window bounds, the former is used, while in ProcessVisualSizeUpdate the latter is used. I have changed the conversion to use the same function. Bug: 1272127 Change-Id: Ibc9b908c62688d61cec0c71b9788ba489dc2d558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336510 Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/main@{#951502}
yjliu authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 452e43d - Browse repository at this point
Copy the full SHA 452e43dView commit details -
Fix use-after-move in GpuHostImpl
Fix a use-after-move issue in GpuHostImpl, as found by clang-tidy: components/viz/host/gpu_host_impl.cc:111: 'params' used after it was moved components/viz/host/gpu_host_impl.cc:107: move occurred here Bug: 1122844 Change-Id: I6f1e3aff9eb8c2dc8b49320b8837dbcf558e444d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337097 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/main@{#951503}
Maksim Ivanov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for f6207eb - Browse repository at this point
Copy the full SHA f6207ebView commit details -
[ChromeOS]Start OnboardingUserActivityCounter for primary users only
Bug: none Change-Id: I1634131046b3130e17c9e2dd2dd00c20c6f7de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338779 Auto-Submit: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/main@{#951504}
Roman Sorokin authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 3c8d9f2 - Browse repository at this point
Copy the full SHA 3c8d9f2View commit details -
Roll RTS model from yVc-vTWsY... to ST_XL0WVE...
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I415d2a93f844f0f5c3dadad937e0db52b684cc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338942 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951505}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for dff044a - Browse repository at this point
Copy the full SHA dff044aView commit details -
[page info] Add strings for history section
Change-Id: I71d53dd162eb064ed4561aabcf64427e5e2f6c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329858 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/main@{#951506}
Olesia Marukhno authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 98e1c5a - Browse repository at this point
Copy the full SHA 98e1c5aView commit details -
Roll RTS model from tI4WdYbci... to K9BP5YhVb...
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I6beb80f5e10ac4d22887c553a09d75902f4d983c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338941 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951507}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 83b9521 - Browse repository at this point
Copy the full SHA 83b9521View commit details -
[v8][api] Update users of v8::Object::CreationContext
v8::Object::CreationContext is deprecated, replace users with one of the two following alternatives: - MaybeLocal<Context> v8::Object::GetCreationContext() - Local<Context> v8::Object::GetCreationContextChecked() Bug: v8:11165 Change-Id: I1ebfc6948dc0c1d289d31d07fca7d940b2fa9073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275976 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#951508}
Configuration menu - View commit details
-
Copy full SHA for 1109e28 - Browse repository at this point
Copy the full SHA 1109e28View commit details -
[fuchsia] Group jitless-related failures in content_browsertests
Bug: 1260245 Change-Id: If6ecaf5309f6fe48789776ffe6bf39d1b4ccaeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335175 Auto-Submit: Fabrice de Gans <fdegans@chromium.org> Reviewed-by: Benjamin Lerman <qsr@chromium.org> Commit-Queue: Benjamin Lerman <qsr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951509}
Configuration menu - View commit details
-
Copy full SHA for d5d7fa3 - Browse repository at this point
Copy the full SHA d5d7fa3View commit details -
Disallow “--” as CSS variable name.
According to the spec, this is a reserved name, so simply demand that every CSS variable is at least three characters instead of two. Bug: 1220145 Change-Id: I9930b9c4f364d20aedc21496b2488d80ecde9b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338991 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#951510}
Steinar H. Gunderson authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 70f44a0 - Browse repository at this point
Copy the full SHA 70f44a0View commit details -
Handle account removal in AccountAppsAvailability
Implement `AccountAppsAvailability::OnAccountRemoved`. Bug: 1260909 Change-Id: I3025d79db96dada448003304818445a48806cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310598 Reviewed-by: Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#951511}
Anastasiia N authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 34c6b23 - Browse repository at this point
Copy the full SHA 34c6b23View commit details -
Updating trunk VERSION from 4766.0 to 4767.0
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: Ibb22196f056502a5477fea8909dd5d47de1c4187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339271 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951512}
Chrome Release Bot (LUCI) committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 9277181 - Browse repository at this point
Copy the full SHA 9277181View commit details -
Use python3 for chromium_trybot recipe.
Bug: 1256405 Change-Id: I329705b753a0acab6f48836b527737842a741d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336858 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@google.com> Cr-Commit-Position: refs/heads/main@{#951513}
Configuration menu - View commit details
-
Copy full SHA for be941a8 - Browse repository at this point
Copy the full SHA be941a8View commit details -
[bluetooth] Minor comment typo fix.
"cannonicalUUI" => "cannonicalUUID". Bug: none Change-Id: Ieed062f25fcf8d1cf4ac811803a115ceb82c484f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335139 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951514}
Configuration menu - View commit details
-
Copy full SHA for d2ce916 - Browse repository at this point
Copy the full SHA d2ce916View commit details -
Roll Media App from Hm4ipUPiX... to OEszP2fR0...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202112140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/OEszP2fR0fctn9Qr3fnIElqnNLPxHyhTUfWfaiiLVckC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/154430508,b/201610516,b/208717940,b/209348713 Tbr: media-app@grotations.appspotmail.com Change-Id: Icfc332c110e92c301f36752152935519083b1811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338943 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951515}
chromium-internal-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 4b3b169 - Browse repository at this point
Copy the full SHA 4b3b169View commit details -
Revert "Launch Lens image search on desktop at ToT."
This reverts commit b6f385e. Reason for revert: Lens-specific latency issues Original change's description: > Launch Lens image search on desktop at ToT. > > Also disables the image search URL change if on a non-desktop platform. > > Bug: 1168677, 1222313 > Change-Id: I855e3838e344ba260b8829a2f8cc355f2c31e2da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328902 > Reviewed-by: Ben Goldberger <benwgold@google.com> > Reviewed-by: Orin Jaworski <orinj@chromium.org> > Commit-Queue: Juan Mojica <juanmojica@google.com> > Cr-Commit-Position: refs/heads/main@{#951102} Bug: 1168677, 1222313 Change-Id: I04fef9927042441202d6a32657177da285d78226 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335318 Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Owners-Override: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951516}
Juan Mojica authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 338a64b - Browse repository at this point
Copy the full SHA 338a64bView commit details -
Roll Help App from uwAu1UD0o... to RcDM8Mq_L...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202112140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/RcDM8Mq_LrCGiuxfQto-gkDVFbqCRy6FE8lzPeHsNEwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I49a0f44493d3de2379a9f8dcb6f21f04fcdca8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338945 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951517}
chromium-internal-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for f41b732 - Browse repository at this point
Copy the full SHA f41b732View commit details -
webrtc-internals: fold large SDP by default
fold large SDP (10+ sections) by default. With unified-plan the sdp can become huge and scrolling becomes a problem. The mid attribute is added to the summary which allows searching for a media section by mid BUG=None Change-Id: If079b012721df2809baec6064ee1ff73d6c532f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3298812 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#951518}
Configuration menu - View commit details
-
Copy full SHA for 3d493d3 - Browse repository at this point
Copy the full SHA 3d493d3View commit details -
Reland "system-extensions: Add system-extensions-internals"
This is a reland of dabe981 The only change is in resource_ids.spec. The previous CL ran out of ids, so this CL takes the ids of the recently removed telemetry resources. Original change's description: > system-extensions: Add system-extensions-internals > > chrome://system-extensions-internals is behind the kSystemExtensions > feature flag and will allow users to sideload a System Extensions. > > For now it just has a button that shows a dialog when pressed. > > Bug: 1192426 > Change-Id: Ib3717bc5fe390de1813612a5fdd75e70c8a65ed0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301576 > Reviewed-by: Christopher Lam <calamity@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949849} Bug: 1192426 Change-Id: Ibb7338e436856ebb397e41343eb8ef9e39726953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329045 Auto-Submit: Giovanni Ortuno Urquidi <ortuno@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#951519}
Giovanni Ortuño Urquidi authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for af90282 - Browse repository at this point
Copy the full SHA af90282View commit details -
ax_dump_tree: update documentation
To include --api feature added here: https://chromium-review.googlesource.com/c/chromium/src/+/3260556 Change-Id: Iaa647b8ae65c8a21eb60b45715b536b191f8d74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336296 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#951520}
Configuration menu - View commit details
-
Copy full SHA for 36fd2f8 - Browse repository at this point
Copy the full SHA 36fd2f8View commit details -
Reland "Record new metric for first render time on profile picker sta…
…rtup" This is a reland of 51e414a It introduced a flaky test. This updated patch changes the way we wait for the page to be rendered, avoiding the race condition between load stop and first non empty render at the origin of the failures. Original change's description: > Record new metric for first render time on profile picker startup > > This will allow covering a blind spot in startup performance > monitoring introduced by the rollout of showing the profile picker > on startup. (which happens when users have 2+ profiles and the > option to show the picker enabled) > > ProfilePicker.FirstProfileTime.FirstWebContentsNonEmptyPaint and > ProfilePicker.FirstProfileTime.FirstWebContentsFinishReason > are the 2 new metrics added for this. > > To record them, we are following a very similar pattern to the one > used for the affected metric,Startup.FirstWebContents.NonEmptyPaint3. > This CL refactors the profiler used to record it to cover both use > cases. > > > Bug: 1273909 > Change-Id: Id25f3e94cf77b5562067304425ebe45c255f0a97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295409 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949499} Bug: 1273909, 1278012 Change-Id: I1263a35d8e8e48af49cfb30cefe08d94fd529912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326461 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/main@{#951521}
Nicolas Dossou-Gbete authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for dfcddb4 - Browse repository at this point
Copy the full SHA dfcddb4View commit details -
Roll src/third_party/cros_system_api/ 738cc02fc..188fb4eba (6 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/738cc02fc3be..188fb4eba05a $ git log 738cc02fc..188fb4eba --date=short --no-merges --format='%ad %ae %s' 2021-09-22 pdk system_api: Introduce FingerprintMessage protobuf 2021-12-07 charleszhao hps: add HpsResultProto for hps dbus. 2021-11-11 kimjae system_api: Add update_engine toggle feature constant 2021-12-05 genechang rmad: Change index type of region/sku/WL list from unsigned to int 2021-11-23 dlunev cryptohome: Add dbus and CLI endpoints for new mount calls. 2021-11-18 dlunev cryptohome: add UDA handlers for direct Mount ops Created with: roll-dep src/third_party/cros_system_api Also pdate ScanResult enum in fingerprint.mojom to match definition in third_party/cros_system_api/dbus/biod/constants.proto and avoid compilation issues. BUG=b:184843581 b:197959527 TEST=autoninja -C out/Debug_chromeos/ services_unittests ./out/Debug_chromeos/services_unittests TEST=autoninja -C out/Debug_chromeos/ browser_tests ./out/Debug_chromeos/browser_tests Change-Id: I680570128bbdde7d2513378d51cc0523905dc94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327236 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com> Cr-Commit-Position: refs/heads/main@{#951522}
Configuration menu - View commit details
-
Copy full SHA for 0e39ece - Browse repository at this point
Copy the full SHA 0e39eceView commit details -
base: Make JSON_PARSE_RFC optionally strictly compliant with RFC 8259.
The existing non-configurable Chromium extensions are now individually configurable, with a flag JSON_PARSE_CHROMIUM that enables them all. This also adds metrics to record the non-standard extension usage, to see if any of these can be dropped. In order to avoid breaking the numerous callers of the JSONReader, the parse options default to the Chromium-style. Bug: 1269888 Change-Id: Ib9a79ec11c457e61e3f88e82f5569e2864655b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289910 Reviewed-by: danakj chromium <danakj@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Tien Mai <tienmai@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/main@{#951523}
Configuration menu - View commit details
-
Copy full SHA for 115268f - Browse repository at this point
Copy the full SHA 115268fView commit details -
Roll src-internal from d49909553bd8 to 241290db3761 (6 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d49909553bd8..241290db3761 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sreejakshetty@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sreejakshetty@google.com,tmartino@google.com Change-Id: Ied5601602ffb87ac4381bbe1db3d5298e5ddddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338947 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Owners-Override: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/main@{#951524}
chromium-internal-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 976e4a5 - Browse repository at this point
Copy the full SHA 976e4a5View commit details -
[fuchsia] Fix use-after-move in FuchsiaCdmManager
Fix a use-after-move issue in FuchsiaCdmManager, as found by clang-tidy: media/fuchsia/cdm/service/fuchsia_cdm_manager.cc:279: 'cdm_data_quota_bytes' used after it was moved media/fuchsia/cdm/service/fuchsia_cdm_manager.cc:272: move occurred here Bug: 1122844 Change-Id: Id7f292e61bffc837d0e1db8adba49c1544a57334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337256 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951525}
Maksim Ivanov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for e92937f - Browse repository at this point
Copy the full SHA e92937fView commit details -
[bluetooth] Add support for single SDP entry when enumerating services.
When enumerating device services support kBluetoothSDPDataElementTypeUUID in addition to kBluetoothSDPDataElementTypeDataElementSequence. Devices with only one DSP entry return this record type. Bug: 1261555 Change-Id: I297ed995cdcbc822ea74ff975513a8c5becf28fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331525 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951526}
Configuration menu - View commit details
-
Copy full SHA for a030f52 - Browse repository at this point
Copy the full SHA a030f52View commit details -
Add mrefaat@ as owner for ios tabgrid
I've been working/changing on that directory for almost a year. Finished the context menus and bulk actions projects and working currently on the Tab search project. Sample CLs: https://chromium-review.googlesource.com/c/chromium/src/+/3025364 https://chromium-review.googlesource.com/c/chromium/src/+/2904466 https://chromium-review.googlesource.com/c/chromium/src/+/2993158 https://chromium-review.googlesource.com/c/chromium/src/+/2852444 Change-Id: I16570c126b956b5175cc4428f463c81708fde690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335456 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/main@{#951527}
Configuration menu - View commit details
-
Copy full SHA for d16c29c - Browse repository at this point
Copy the full SHA d16c29cView commit details -
[serial] Removed unnecessary
device_uuids
variable.Minor fix to removed variable in BluetoothSerialPortImpl::OpenSocket(). Bug: none Change-Id: I9d99be1aea2b9b5a353e4287c5fb6647282ec810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330920 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951528}
Configuration menu - View commit details
-
Copy full SHA for 78a59dd - Browse repository at this point
Copy the full SHA 78a59ddView commit details -
GCC: Don't use 'warn_unused_result' attribute for class type
When compiling with GCC the compiler warns about it: warning: 'warn_unused_result' attribute only applies to function types [-Wattributes] Bug: 819294 Change-Id: Ia522e6743f5e0591efce2e5060c4e0aa0a4fb92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338342 Reviewed-by: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Ivan Murashov <ivan.murashov@lge.com> Cr-Commit-Position: refs/heads/main@{#951529}
Ivan Murashov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for eea225b - Browse repository at this point
Copy the full SHA eea225bView commit details -
Fix the arc::GetWindowTaskOrSessionId crash issue.
From the crash report, we can see the crash increases from 98.0.4729.0, and guess the potential reason might be related with CL:3295763. From the call stack, it looks like windows are added to arc_window_candidates_, but not removed when the window is destroyed. One guessing is at the very early stage, OnWindowInitialized, the window might haven't beed added to the browserlist yet, so IgnoreWindow returns false. But when the window is destroyed, IgnoreWindow returns true, because the window has been added to the browserlist, and FindBrowserWithWindow in IgnoreWindow returns true. This might cause the window is added to arc_window_candidates_, but not removed from arc_window_candidates_. This CL removes the checking of IgnoreWindow in OnWindowDestroying, because if IgnoreWindow returns true in OnWindowInitialized, then OnWindowDestroying should not be called. Otherwise, we can still go through the code in OnWindowDestroying. BUG=1278231 Change-Id: I28d4067c2572fde05b8b9b12fbc3b6e7ff622c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337279 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951530}
Nancy Wang authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for d390b2b - Browse repository at this point
Copy the full SHA d390b2bView commit details -
[Sync] Store bootstrap token immediately
Storing bootstrap token during SyncServiceCrypto::SetDecryptionPassphrase() is safe, because passphrase is verified against pending keys and storing wrong key (in extreme rare cases, when passphrase is changed before it reaches the sync engine) is harmless anyway. This CL adds the code to store bootstrap token during SetDecryptionPassphrase() and cleans up SyncEncryptionHandler::OnBootstrapTokenUpdated(). Bug: 1276958 Change-Id: Ic17bf63aed75b6507de51e398af681c52679f12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322914 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/main@{#951531}
Maksim Moskvitin authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 417d42a - Browse repository at this point
Copy the full SHA 417d42aView commit details -
[page info] Add history feature flag
Change-Id: Ie13fc14380570fe20553136a9f7f7c20a5da27c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332080 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/main@{#951532}
Olesia Marukhno authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 4f39c7f - Browse repository at this point
Copy the full SHA 4f39c7fView commit details -
[serial] Ignore duplicate devices in PortAdded().
Bug: 1261555. Change-Id: I65a1345e9a6f2969f1c1c83bb43269eeab492667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331531 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/main@{#951533}
Configuration menu - View commit details
-
Copy full SHA for 29cda9c - Browse repository at this point
Copy the full SHA 29cda9cView commit details -
Set color attributes on DialogWhenLarge theme.
Bug: 1279417 Change-Id: Ib706a4a27f7529b28a7ac34cc678468479295853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335538 Reviewed-by: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#951534}
Sky Malice authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for ad05b5e - Browse repository at this point
Copy the full SHA ad05b5eView commit details -
Lower mac11-arm64-rel exp percentage
Turn down this builder to avoid pending times, while we're figuring out how to fix the cache evictions. Bug: 1271287 Change-Id: I19ac21ee2a1f0311dd78d4281f6bdf6eac3d8583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336511 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/main@{#951535}
Stephanie Kim authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 47d0284 - Browse repository at this point
Copy the full SHA 47d0284View commit details -
[Android] Change Java BOOTSTRAP tasks back to USER_VISIBLE priority
We need to determine whether changing these tasks to have USER_BLOCKING priority was the cause of a regression in startup performance on Android that we are observing. Since landing the original CL [1], we have not added any conceptual or technical dependencies on the change. Hence, we can simply change these tasks back to having USER_VISIBLE priority. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3225938 Bug: 1279756 Change-Id: I4f6e62ab64bbd03d0ecfddd2074b67a8caed0dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329602 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#951536}
Configuration menu - View commit details
-
Copy full SHA for b78b12a - Browse repository at this point
Copy the full SHA b78b12aView commit details -
Add profile picker trace events
This CL adds trace events to profile picker related classes that would help debugging issues like - profile picker fails to display - profile picker fails to open a new profile window. Bug: 1275324 Change-Id: Icf476b001383729f1b75501ef11d73c1c93fceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338481 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/main@{#951537}
Alex Ilin authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 949da86 - Browse repository at this point
Copy the full SHA 949da86View commit details -
[Android][Passwords] Remove LoginsResult as JobReturnHandler callback
JobReturnHandler is a class that replies to ongoing backend jobs. We currently repurpose it to also record metrics for jobs that behave similar to backend jobs but cannot fail. That is suboptimal and we introduced an additional callback type specifically to that (LoginsReply) although this type is already covered by a more general one (LoginsOrErrorReply). This CL removes LoginsReply and introduces an adapter. That code also should only be temporary until the metrics recording method is independent from the Job-Handling. Bug: 1229655 Change-Id: I6d9bdb916985233cf3ca0d8b739413d32d824ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339312 Reviewed-by: Maria Kazinova <kazinova@google.com> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/main@{#951538}
Configuration menu - View commit details
-
Copy full SHA for 3695711 - Browse repository at this point
Copy the full SHA 3695711View commit details -
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a05d7ad..84f18f4e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5eea7c0004c9277868eb9e783c9195430e0c9a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338994 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951539}
v8-ci-autoroll-builder authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 9eb1612 - Browse repository at this point
Copy the full SHA 9eb1612View commit details -
Roll DevTools Frontend from a1121f966ce5 to 5fec567a800a (5 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1121f966ce5..5fec567a800a 2021-12-14 aerotwist@chromium.org Remove patchColorText in ConsoleViewMessage 2021-12-14 tvanderlippe@chromium.org Replace any in return values for void 2021-12-14 dsv@chromium.org Test for source maps loading via chrome-extension:// 2021-12-14 szuend@chromium.org [cleanup] Remove unnecessary @interface comments 2021-12-14 marijnh@gmail.com Hide argument tooltip in editor when the content changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1172300,chromium:1278738,chromium:1279782,chromium:212374 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iad7168942f76927183cafc858b517e1c03869e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339231 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951540}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 0a98c2e - Browse repository at this point
Copy the full SHA 0a98c2eView commit details -
Updater: Eliminate global prefs from --update command.
The prefs can never be acquired, because --update is run by the server, which is holding them. Furthermore, it seems they are unused in the first place. Change-Id: I1923f3d24f87c96dc3a2287c0fb1888cc3c737bb Fixed: 1279859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339274 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951541}
Joshua Pawlicki authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 335ebb5 - Browse repository at this point
Copy the full SHA 335ebb5View commit details -
[Android] Extend Android.PackageStats.* histograms.
The histograms are still in use for various package and disk space related investigations. R=mthiesse@chromium.org Bug: 1270368 Change-Id: I3a6805fecfa3b48eaf9a0e60b4ef38f6b9a58aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335180 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/main@{#951542}
Configuration menu - View commit details
-
Copy full SHA for 9b7eca0 - Browse repository at this point
Copy the full SHA 9b7eca0View commit details -
Fix null dereference error in BackForwardMenuModel::GetHistoryItemCount
TabStripModel::GetActiveWebContents can return nullptr. Bug: 1279645 Change-Id: If5a71bba2ca3112c7d05dff43a2969d851d3391e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338519 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#951543}
Configuration menu - View commit details
-
Copy full SHA for 8634ed0 - Browse repository at this point
Copy the full SHA 8634ed0View commit details -
[CrOS Network] Add checking if dbus object path is empty to avoid crash
This CL adds a check in NetworkSmsHandler::DevicePropertiesCallback to make sure that the dbus object path from the returned device properties is not empty. Otherwise, it will cause a crash when constructing a new ModemManager1NetworkSmsDeviceHandler. Change-Id: Idec2a519f886cbea699d0847e77406b134fc1436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330697 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jason Zhang <jiajunz@google.com> Cr-Commit-Position: refs/heads/main@{#951544}
Jason Zhang authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 80eddb7 - Browse repository at this point
Copy the full SHA 80eddb7View commit details -
[Fast Pair] Add engagement funnel metric for Retroactive Pairing.
Adds an engagement funnel metric for the retroactive pairing scenario, which is logged when the Associate Account UI is shown, dismissed, and when either the save or the learn more button is pressed. Change-Id: I7549e05a6b7e4159ab7a930f13716dd83f73d2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317838 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#951545}
Configuration menu - View commit details
-
Copy full SHA for 9a3e5a6 - Browse repository at this point
Copy the full SHA 9a3e5a6View commit details -
Add histogram to track EstableGpuChannelSync
Bug: 1278147 Change-Id: Iaf699abf19f07393ad7f84dca07d18d7e1d08691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335439 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/main@{#951546}
Configuration menu - View commit details
-
Copy full SHA for 9b7c338 - Browse repository at this point
Copy the full SHA 9b7c338View commit details -
Delete policy WebRestrictionsAuthority
The policy WebRestrictionsAuthority is a policy for a feature that hasn't been launched. Most of the related codes have been deleted but the policy definition has been left over by accident. Bug: 1276551 Change-Id: I996b201a6ff7205fb9d16037967eecf7985e3fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329599 Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951547}
Configuration menu - View commit details
-
Copy full SHA for c44d448 - Browse repository at this point
Copy the full SHA c44d448View commit details -
[ios] Support "unrealized" WebState in WebStateDependencyInstallation…
…Observer Delay the installation of dependencies on "unrealized" WebStates (as the dependency may require the WebState to be fully realized). Bug: 1278981, 1264453 Change-Id: Ia24b6e2ef9b4b69cc04c40892acf7bb4ff7c21f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333927 Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#951548}
Configuration menu - View commit details
-
Copy full SHA for 7c61fdb - Browse repository at this point
Copy the full SHA 7c61fdbView commit details -
Link pdfium pdf_xfa_xdp_fdp_fuzzer in Chromium
Bug: 1276950 Change-Id: I88ea5f4c2f630ca6b8eac2497151a6436d0d96de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336776 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#951549}
Configuration menu - View commit details
-
Copy full SHA for 994347c - Browse repository at this point
Copy the full SHA 994347cView commit details -
WebNFC: Add experimental NDEFReader.makeReadOnly()
This CL adds a way for web developers to make NFC tags permanently read-only with Web NFC. It does so with a new `makeReadOnly()` method on NDEFReader. Its behaviour is similar to the `write()` method. Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/iyljeGnIct8 Binary-Size: Uses Mojo in Java (crbug.com/1062647) Demo: https://make-read-only.glitch.me/ Spec: w3c/web-nfc#632 Change-Id: I2a9841d969cced22aea469e2eb0e065381706184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3302801 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#951550}
Configuration menu - View commit details
-
Copy full SHA for 711c3ce - Browse repository at this point
Copy the full SHA 711c3ceView commit details -
exo: Implement basic color management features for surfaces
In this CL: - Clients can set color spaces for surfaces - Clients will be notified that a surface's preferred color space may have changed Other features, such as custom extended dynamic ranges and render intends, are left to be implemented in the future. BUG=b:192562912 TESTED=wayland_hdr_client connects and we can see the color space change. Otherwise, this is all hidden behind a build flag Change-Id: I9bc04810506c7d0dd3898994248e9a86b77a2367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3288009 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jim Shargo <jshargo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951551}
Jim Shargo authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for f1ae918 - Browse repository at this point
Copy the full SHA f1ae918View commit details -
Reland "Remove use of GridLayout for the payment sheet view."
This is a reland of e8e475a Original change's description: > Remove use of GridLayout for the payment sheet view. > > Bug: 1261301 > Change-Id: Icfe752ca849f1aee29a411aaa70a0385db9f63e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3300682 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948727} Bug: 1261301, 1279367 Change-Id: I0f561fdb9848fc333f373bb358d36953c43eeb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335417 Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/main@{#951552}
Allen Bauer authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for db69c33 - Browse repository at this point
Copy the full SHA db69c33View commit details -
These tests were disabled due to flakiness back in october, but recent runs show them passing fully, so re-enabling for monitoring and fresher logs in case of flakes coming back. Bug: 1261770 Change-Id: I4243954f181de770e704441be251635f1be2f29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336828 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Miras Myrzakerey <myrzakereyms@google.com> Cr-Commit-Position: refs/heads/main@{#951553}
Configuration menu - View commit details
-
Copy full SHA for d0ff520 - Browse repository at this point
Copy the full SHA d0ff520View commit details -
WebLayer: Run skew tests with python3
Bug: None Change-Id: Ia80f524b3a0a94fc6f172f2119d5ee11bc738bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336866 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/main@{#951554}
Rakib M. Hasan authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for eb54096 - Browse repository at this point
Copy the full SHA eb54096View commit details -
Revert "[sheriff]: Disable TwoClientWebApps tests."
This reverts commit 0c5ce39. Reason for revert: Seems fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=1260897 Original change's description: > [sheriff]: Disable TwoClientWebApps tests. > > Disable TwoClientWebAppsIntegrationTestMacWinLinux tests as they're > flaky. > > Bug: 1273666 > Change-Id: Ibebc1deb1d0714974a1550cfe3235ac0253f3888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309921 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Owners-Override: Nina Satragno <nsatragno@chromium.org> > Auto-Submit: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#947063} Bug: 1273666 Change-Id: I0e8f777e88d5719ed9ef3292ca8e2092cc8680c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339378 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/main@{#951555}
Configuration menu - View commit details
-
Copy full SHA for c2f72a1 - Browse repository at this point
Copy the full SHA c2f72a1View commit details -
Fix use-after-move issues in debug assertions in CdmInfo, as found by clang-tidy: content/common/media/cdm_info.cc:29: 'capability' used after it was moved content/common/media/cdm_info.cc:22: move occurred here content/common/media/cdm_info.cc:40: 'capability' used after it was moved content/common/media/cdm_info.cc:38: move occurred here Bug: 1122844 Change-Id: If41e1af08cc38652ac3772c9051f2b1c2aadbf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336056 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951556}
Maksim Ivanov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 731e7e0 - Browse repository at this point
Copy the full SHA 731e7e0View commit details -
[undecryptable sync data] Also log counts metrics w/o ModelType suffix
2 more histograms are recorded, apart from that no behavior is changed. This CL starts recording Sync.ModelTypeTimeUntilEncryptionKeyFound2 and Sync.ModelTypeUndecryptablePendingUpdatesDropped on top of their siblings suffixed by ModelType. This will make it easier to analyse the number of unique clients which run into those events, see the linked bug. Note the CL doesn't do the above for Sync.ModelTypeUpdateDrop.DecryptionPendingForTooLong. For that one, ModelType-s are the buckets, not the suffix. It's possible to count unique clients for this kind of histogram with __usercount__Sync.ModelTypeUpdateDrop.DecryptionPendingForTooLong::*. Fixed: 1279765 Change-Id: I0b8aee23317ef1438d53b3d97a0f50a0fa94240d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338736 Reviewed-by: Rushan Suleymanov <rushans@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/main@{#951557}
Victor Hugo Vianna Silva authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for e8f73a6 - Browse repository at this point
Copy the full SHA e8f73a6View commit details -
[Android] Send dismissal signal from Blink to browser for DateTimeCho…
…oser On Android, the DateTimeChooser is a browser side Android native popup window, which is an external DateTimeChooser from Blink's perspective. When Blink wants to dismiss the DateTimePicker, it will send a EndChooser() signal. Previously, we didn't wire this signal to browser process for Android, therefore, when blink wants to dismiss the popup window, e.g. before navigating away from the current URL, the popup window will still remain there. We also guard the Java DateTimeChooser to use the native pointer when the corresponding native object is gone. Bug: 1275438 Change-Id: I07f7ca95ed3c39fbb27b1439d3129d91a77a5892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334126 Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/main@{#951558}
Shimi Zhang authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 9404000 - Browse repository at this point
Copy the full SHA 9404000View commit details -
Fix use-after-move in RuleBasedHostResolverProc
Fix a use-after-move issue in a debug assertion in RuleBasedHostResolverProc::Rule, as found by clang-tidy: net/dns/mock_host_resolver.cc:1115: 'dns_aliases' used after it was moved net/dns/mock_host_resolver.cc:1113: move occurred here Bug: 1122844 Change-Id: Iddbcf535b60589aafb09c2a4f716a3530074a8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335640 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/main@{#951559}
Maksim Ivanov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 5d74106 - Browse repository at this point
Copy the full SHA 5d74106View commit details -
Bug: none Change-Id: I5cac85f92c585126076af0ece5d74f4fa1170fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334581 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/main@{#951560}
Configuration menu - View commit details
-
Copy full SHA for 3b2e879 - Browse repository at this point
Copy the full SHA 3b2e879View commit details -
[iOS] Add device restore metrics
This patch adds histograms related to iOS device restore. This is based on the function: IsFirstSessionAfterDeviceRestore(), implemented in: crrev.com/c/3320241 The following histograms are added: * Startup.IOSColdStartType Records session type for a cold start. * Signin.IOSDeviceRestoreSignedinState Records the sign-in state before and after an iOS device restore. * Signin.IOSDeviceRestoreIdentityCountBeforeUpgrade Records the number of identities before iOS device restore. * Signin.IOSDeviceRestoreIdentityCountAfterUpgrade Records the number of identities before iOS device restore. SigninSignoutProfile enum is updated to add: Sign-out forced because the account was removed from the device after a device restore. Fixed: 1266358 Change-Id: I82992d9f0571fbbb2b5b8111b7f6764df6b68e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320276 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Hao Dong <spdonghao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951561}
Jérôme Lebel authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for d68b853 - Browse repository at this point
Copy the full SHA d68b853View commit details -
Fix use-after-move in ReportingEndpointGroupKey
Fix a use-after-move issue in a debug assertion in ReportingEndpointGroupKey, as found by clang-tidy: net/reporting/reporting_endpoint.cc:37: 'reporting_source' used after it was moved net/reporting/reporting_endpoint.cc:33: move occurred here Bug: 1122844 Change-Id: Ia7c5e96d1683c3a8d5fddd8e8c4fac897308e68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335738 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951562}
Maksim Ivanov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 678f024 - Browse repository at this point
Copy the full SHA 678f024View commit details -
Migrate MutationRecord to use AsyncTaskContext
Doc: https://docs.google.com/document/d/1zxAw2SgBslG-aE8itQWhCYz3nqm3yACSYuPYscQX-tU/edit?usp=sharing Bug: 1275875 Change-Id: I6d5ac73257d451a75ad4f08028ba80a6226162a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338662 Auto-Submit: Changhao Han <changhaohan@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951563}
Configuration menu - View commit details
-
Copy full SHA for 3d90900 - Browse repository at this point
Copy the full SHA 3d90900View commit details -
Build mac installer on mac-chrome trybot
Seem comment 9 on the linked bug for motivation. This would've caught a recent official build breakage. Bug: 1279316 Cq-Include-Trybots: luci.chrome.try:mac-chrome Change-Id: I724c1a9d19b9b4ba465d36523eaa365d50fba4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338760 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#951564}
Configuration menu - View commit details
-
Copy full SHA for 61e84ad - Browse repository at this point
Copy the full SHA 61e84adView commit details -
Fix files_to_skip in tools/mb pylint check.
files_to_skip should be a sequence of strings, passing in a single string results in each character being turned into an element in a tuple. It's unclear how this silenced the warning that was resulting from PRESUBMIT_test.py. Bug: 1279609 Change-Id: Ied23ec71e1a4babb4f2cf459cbbb07f22d55bf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339351 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#951565}
Configuration menu - View commit details
-
Copy full SHA for 140c211 - Browse repository at this point
Copy the full SHA 140c211View commit details -
[Autofill Assistant] Enable CUP support in ServiceRequestSender
Bug: b/203031699 Change-Id: I94fddb54e6dc7e12de8ecc50f51da56e4e895b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310643 Reviewed-by: Luca Hunkeler <hluca@google.com> Commit-Queue: Sergio Vila Prado <sergiovila@google.com> Cr-Commit-Position: refs/heads/main@{#951566}
Configuration menu - View commit details
-
Copy full SHA for 01394c3 - Browse repository at this point
Copy the full SHA 01394c3View commit details -
[ios] Remove TabIdTabHelper class
As the WebState exposes a stable identifier, and this is the value returned by TabIdTabHelper::tab_id(), change client code to use this getter and remove TabIdTabHelper as it is obsolete. Fixed: 1276776 Change-Id: I71059fb3f22e79a3de98c40c71a79b0d3fb41d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329030 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#951567}
Configuration menu - View commit details
-
Copy full SHA for 17c6318 - Browse repository at this point
Copy the full SHA 17c6318View commit details -
Sheriff: Disable failing Linux TSan Test
Bug: 1279844 Change-Id: Ia00bb7e5f9d55ec475b8333b37a247440e1ac87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339251 Auto-Submit: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Owners-Override: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951568}
Configuration menu - View commit details
-
Copy full SHA for 101acc1 - Browse repository at this point
Copy the full SHA 101acc1View commit details -
Roll ANGLE from 42bd4fc29aea to fefd7ae66ad9 (8 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/42bd4fc29aea..fefd7ae66ad9 2021-12-14 bpastene@chromium.org Revert "Enable the chromium recipe RDB results experiment for all builds." 2021-12-14 lubosz.sarnecki@collabora.com BufferDataTest: Add more coherent buffer storage tests. 2021-12-14 lubosz.sarnecki@collabora.com BufferDataTest: Do not require GL_EXT_map_buffer_range. 2021-12-14 lubosz.sarnecki@collabora.com FrameCapture: Implement capture of coherent bufferstorages. 2021-12-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a0a6270b47e4 to c03890076954 (1 revision) 2021-12-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 592d413edb56 to f354daff5a2b (4 revisions) 2021-12-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 30aeba8 to 0c0a365 (457 revisions) 2021-12-14 abdolrashidi@google.com Vulkan: Fix the offset issue in multiDrawIndirect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1135718 Tbr: timvp@google.com Test: Test: angle_end2end_tests --gtest_filter="BufferStorageTestES3.*" Change-Id: Id9b059ac5f3e93d68a3fb8ae0477831fba6fde22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339132 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951569}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 9af929a - Browse repository at this point
Copy the full SHA 9af929aView commit details -
Roll Chrome Win32 PGO profile from chrome-win32-main-1639483122-6c64e4735696edd79f94e428f8b51a0056079d88.profdata to chrome-win32-main-1639493922-9a45d06329fbed3e310b5994955083e355361eb8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87bed54050ae7d9c26b15fe36b34e99cf35a2c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338644 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951570}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 868554d - Browse repository at this point
Copy the full SHA 868554dView commit details -
Roll androidx from juajBfBlq... to Cd5XvW44K...
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: Ida12f9b5747e898539c570b6673026b113a22d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338944 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951571}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 00c5667 - Browse repository at this point
Copy the full SHA 00c5667View commit details -
[Smart Lock] Extend smart-lock-ui-revamp feature flag expiry
The feature flag for enabling the Smart Lock UI revamp was set to expire after M98, and this was never updated when the release was retargeted for M99. This change pushes that expiration to M101, which should afford enough time even if the launch gets pushed back again. Change-Id: Ie94a542e58a2321c7e7745088852d9f4f090cc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337080 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/main@{#951572}
Curt Clemens authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for f11d8c5 - Browse repository at this point
Copy the full SHA f11d8c5View commit details -
Consider paddings that cause MessageCenter to surpass its max height
Consider two padding values added to the new notification UI when calculating MaxHeight for the UnifiedMessageCenter that caused the bubble to appear on top of the SystemTray. Added unit tests to ensure MessageCenterBubble gets displayed above the SystemTrayBubble in normal conditions, tablet mode and overview mode. Bug: 1252949 Change-Id: I25a3de0ef7c0616c6b5089a45ec111ca716452be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308228 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Kevin Radtke <kradtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#951573}
Kevin Radtke authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 0079b14 - Browse repository at this point
Copy the full SHA 0079b14View commit details -
Add shown metrics for tailored security UX
In order to be consistent between different surfaces, log the kShown bucket on all places. Bug: 1257622 Change-Id: I4b9f094a2e68b64bbfbadf751b7fce80d710c154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337398 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#951574}
Daniel Rubery authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 5ea2331 - Browse repository at this point
Copy the full SHA 5ea2331View commit details -
It's possible that expand_or_collapsing_container_ does not exist when the animation is started. Use a default duration in that case. Bug: 1279592 Change-Id: I92edbc5544081be27bf138b89287a2fb508560ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336862 Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951575}
Alex Newcomer authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 544a0b1 - Browse repository at this point
Copy the full SHA 544a0b1View commit details -
Revert "[Zenith] Keep the dialog open when clicking on the device sel…
…ector" This reverts commit 3b0c762. Reason for revert: line 171 in media_item_ui_device_selector_view is added by mistake and should be removed. Original change's description: > [Zenith] Keep the dialog open when clicking on the device selector > > The drop down icon is a little bit small and users might click on the > device selector strip by mistake. > > This CL increase the size of the drop down button's ink drop. It also > stops the MousePressed event from bubbling to the MediaItemUI, which > brings the focus back to the tab that is playing the media. > > Bug: 1279499 > Change-Id: Ib7687023aec1bbf4bdaff760d16fa908aa08ac44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334986 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Muyao Xu <muyaoxu@google.com> > Cr-Commit-Position: refs/heads/main@{#951372} Bug: 1279499 Change-Id: Iecded599a4d7c65e5126e1b43b979476b07034e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339241 Auto-Submit: Muyao Xu <muyaoxu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951576}
Configuration menu - View commit details
-
Copy full SHA for 64071dc - Browse repository at this point
Copy the full SHA 64071dcView commit details -
Ensure slot element with display:contents are included
A performance fix landed in version 96 which determined whether or not a slot and its subtree were "relevant" to accessibility. Irrelevant slot subtrees stopped being included in the accessibility tree, firing events, etc., improving performance during slot updates. There are two instances where a slot will lack a layout object but is still "relevant" in terms of the accessibility tree: canvas fallback content and slots with a computed style of display:contents. We were correctly handling the former, but failing to handle the latter. This change checks the computed style of non-fallback-content slots and treats them as relevant for accessibility if they have a style with display:contents. AX-Relnotes: Fixes regression which caused descendants inside slots with display:contents to be pruned from the accessibility tree. Bug: 1278446 Change-Id: I6cd255caa61d5ad58a61fc72e42eb5d0baea3109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338349 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#951577}
Configuration menu - View commit details
-
Copy full SHA for 96ec3ff - Browse repository at this point
Copy the full SHA 96ec3ffView commit details -
What's New: Update pref when running ShouldShowForState
Update the pref just after reading it, in the event the page should be shown for the current milestone. This should reduce the chance of a race where multiple profiles check the pref, all see that the page should be shown, and each show a copy of it. Bug: 1274313 Change-Id: I7e356856d54dac6b468a05f6d5cca5421494f0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312624 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#951578}
rbpotter authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for ed14586 - Browse repository at this point
Copy the full SHA ed14586View commit details -
Roll Perfetto from 1357bd132733 to f9abf9948a18 (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/1357bd132733..f9abf9948a18 2021-12-14 lalitm@google.com Merge "metric: Add net_rx action statistic to network performance metric" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I791238ce43e9057123726f0f39af2ab65d041ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338646 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951579}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 7054c4e - Browse repository at this point
Copy the full SHA 7054c4eView commit details -
[Refactor] Style guide CredentialManagerProxy::FedCMGetRequest()
This CL renames CredentialManagerProxy::FedCMGetRequest() to match the Google C++ style guide https://google.github.io/styleguide/cppguide.html#General_Naming_Rules BUG=None Change-Id: Ibb09ed69c08d85ffd2b3a37b8814d1779c525c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336279 Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951580}
Configuration menu - View commit details
-
Copy full SHA for c1c3df2 - Browse repository at this point
Copy the full SHA c1c3df2View commit details -
Roll Skia from d26057a2c0e1 to 16d3cc04cc85 (6 revisions)
https://skia.googlesource.com/skia.git/+log/d26057a2c0e1..16d3cc04cc85 2021-12-14 emaxx@chromium.org Fix use-after-move in GrVkRenderTarget 2021-12-14 jvanverth@google.com Add missing comment. 2021-12-14 johnstiles@google.com Show the stack trace in the Debugger slide. 2021-12-14 johnstiles@google.com Move newly-updated variables to the top of the Variable list. 2021-12-14 emaxx@chromium.org Fix use-after-move in GrResourceAllocator 2021-12-14 emaxx@chromium.org Fix use-after-move in GrPixmapBase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1122844 Tbr: bungeman@google.com Change-Id: Ic18d6479b31494712e8dc12bf65a2a8b45e3035e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338415 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951581}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for bd31d2e - Browse repository at this point
Copy the full SHA bd31d2eView commit details -
media: Report Media.MediaFoundationRenderer.ErrorReason UMA
Add code to report this new UMA so we can better understand error causes of MediaFoundationRenderer and MediaFoundationRendererClient. Bug: 1206737 Change-Id: I7424ee50fb2d3f0f5bb5ec25d356ea466f707a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337076 Reviewed-by: John Rummell <jrummell@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Evan Liu <evliu@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/main@{#951582}
Configuration menu - View commit details
-
Copy full SHA for 6f13305 - Browse repository at this point
Copy the full SHA 6f13305View commit details -
Roll src-internal from 241290db3761 to 3f761f4e3351 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/241290db3761..3f761f4e3351 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1196641 Tbr: tmartino@google.com Change-Id: I482fd5f4b76f4b9aac73a1434a465cb801393d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338277 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951583}
chromium-internal-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for c2813db - Browse repository at this point
Copy the full SHA c2813dbView commit details -
[flakiness] Enable flaky checks on ios-simulator
Turn on check_for_flakiness for ios-simulator, which should enable the flake endorser workflow. Bug: 1204163 Change-Id: I7ee42b45afa74ec580a983434620dceafcb9dac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338648 Reviewed-by: Garrett Beaty <gbeaty@google.com> Commit-Queue: Jeff Yoon <jeffyoon@google.com> Cr-Commit-Position: refs/heads/main@{#951584}
Jeff Yoon authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for b84b77c - Browse repository at this point
Copy the full SHA b84b77cView commit details -
[Net][Android] Add and use ChromiumNetworkAdapter
This is a wrapper around URL#openConnection() that requires a NetworkTrafficAnnotationTag, which is used for static analysis. A future change will add compile-time checks to prevent direct usage of URL#openConnection(). Replace all URL#openConnection() calls with ChromiumNetworkAdapter#openConnection(). More blocklisted methods are likely to be added in the future. Bug: 1231780 Change-Id: Ic6ff9968cfea0508c5bdaf4bf6900db16b692eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321445 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/main@{#951585}
Nicolas Ouellet-Payeur authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 0478b25 - Browse repository at this point
Copy the full SHA 0478b25View commit details -
Roll RTS model from vdD8aHXAy... to h4OErwvGM...
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I729cd869c9ff26d886fa2a51582e4b4a80c2a661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338940 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951586}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 0a9d09f - Browse repository at this point
Copy the full SHA 0a9d09fView commit details -
AngleVulkan: using eglCreateImageKHR
Make AngleVulkan sharing backing to create VkImabe and then use eglCreateImageKHR API to import the VkImage to ANGLE. Bug: 1278571 Change-Id: Ie44379776ea3e8e9b61dc74d6242542d5119dfba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333636 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951587}
Configuration menu - View commit details
-
Copy full SHA for 3419a98 - Browse repository at this point
Copy the full SHA 3419a98View commit details -
Add support for dark mode icon in Lens side panel.
Bug: 1278504, b:202204708 Change-Id: Ie06987389715f843b3bf0f82a75e30260f26cd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328915 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Ben Goldberger <benwgold@google.com> Commit-Queue: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/main@{#951588}
Juan Mojica authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 6eecdb5 - Browse repository at this point
Copy the full SHA 6eecdb5View commit details -
[Fast Pair] Add alternative pair metric.
Records the number of devices paired via classic Bluetooth and not via Fast Pair. Change-Id: I08453aaeca6b508cb3596a89a3fd5510963eaa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320474 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#951589}
Configuration menu - View commit details
-
Copy full SHA for b06fb5c - Browse repository at this point
Copy the full SHA b06fb5cView commit details -
#LensChrome Region search side panel - add loading indicator
- demo: https://drive.google.com/file/d/1R2d3ZU8MqgBsl4ugs7IMBXHCXmQdRCDs/view?resourcekey=0-A9V83nzuDTU9sRg0PxvfFw https://drive.google.com/file/d/1e20SbRi2GETvU-X7Dv27X_CdiQZW2Rv0/view?usp=sharing&resourcekey=0-UyPtlXHpVRSxTgA_IDGf6Q - mock: https://drive.google.com/file/d/1T_LhbsO247ZAdNhmFuAmmuMo321nra85/view?usp=sharing Bug: b/201796008 Change-Id: Id07a4a38a872abe13ec3b300cf591983cea1efda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324425 Reviewed-by: Connie Wan <connily@chromium.org> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/main@{#951590}
Yu Su authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 876bdc6 - Browse repository at this point
Copy the full SHA 876bdc6View commit details -
Add media_unittests filter dep to media/BUILD.gn
Bug: 1250013, 1269213 Change-Id: I2a73dd759806aa7b289cb329f56b2eb1227a3427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322198 Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: James Shen <zhiyuans@google.com> Cr-Commit-Position: refs/heads/main@{#951591}
Configuration menu - View commit details
-
Copy full SHA for e432e9c - Browse repository at this point
Copy the full SHA e432e9cView commit details -
[LR] Add fieldtrial config entry
Adds a fieldtriel testing config entry for Lightweight Reactions in preparation for ramping up the experiment to Beta. Change-Id: I97be1f7233637c5e4b316ddbb32ae39d7a93890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331121 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/main@{#951592}
Configuration menu - View commit details
-
Copy full SHA for b3dbfd3 - Browse repository at this point
Copy the full SHA b3dbfd3View commit details -
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84f18f4e..b5bf62da Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99604dc7bb23b2f54dcbef4a9a6d912a5a76be86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338388 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951593}
v8-ci-autoroll-builder authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 0802baf - Browse repository at this point
Copy the full SHA 0802bafView commit details -
Reland "Reland "Mac: enable ThinLTO (without unit splitting)""
This reverts commit 8f1d535. Reason for revert: Turned off LTO for ARM installer Original change's description: > Revert "Reland "Mac: enable ThinLTO (without unit splitting)"" > > This reverts commit af0abed. > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1279316 > > Original change's description: > > Reland "Mac: enable ThinLTO (without unit splitting)" > > > > This reverts commit 397efe0. > > > > Reason for revert: Timeout on bot was increased > > > > Original change's description: > > > Revert "Mac: enable ThinLTO (without unit splitting)" > > > > > > This reverts commit 810d213. > > > > > > Reason for revert: Suspecting causing infra failure. > > > > > > Original change's description: > > > > Mac: enable ThinLTO (without unit splitting) > > > > > > > > Splitting is currently blocked on supporting N_INDR symbols in lld. > > > > > > > > Bug: 471146 > > > > Change-Id: Iacc2288d8307fdf730d92d0bfc7f3286d0162b92 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328741 > > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > > Commit-Queue: Nico Weber <thakis@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#950412} > > > > > > Bug: 1279290 > > > Change-Id: If82f13cf72eb7a42430dbda9d5af534efd77f5f6 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332866 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: My Nguyen <myy@chromium.org> > > > Owners-Override: My Nguyen <myy@chromium.org> > > > Reviewed-by: Darren Shen <shend@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#950944} > > > > Bug: 1279290 > > Change-Id: I42d2f45910992dcd02912a10e080d4392253b31e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334918 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#951187} > > Bug: 1279290 > Change-Id: I60ca717f12e620ecd1ea38944714feeee244e7f5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336736 > Auto-Submit: Leonard Grey <lgrey@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Owners-Override: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Reviewed-by: My Nguyen <myy@chromium.org> > Commit-Queue: My Nguyen <myy@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951260} Bug: 471146 Change-Id: Ide0a3b124736513871afa9e7be81faa611072847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338759 Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951594}
Configuration menu - View commit details
-
Copy full SHA for bc7e870 - Browse repository at this point
Copy the full SHA bc7e870View commit details -
Migrate signin_view's background to dynamic colors.
Bug: 1270915 Change-Id: Iec25b0ccf07b78d2f7ef2a4f833df1e36b924527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335365 Reviewed-by: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#951595}
Sky Malice authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for b0f10ed - Browse repository at this point
Copy the full SHA b0f10edView commit details -
Fenced Frames: Add unit test support
This CL adds a method to create fenced frames in TestRenderFrameHost, and a utility method to create a navigation request to successfully navigate a fenced frame in NavigationSimulator. It also adds a basic fenced frame unit test that uses these new methods. Change-Id: Id0bfb536ab348c8ac876c874524f7ba8efc16026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324821 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/main@{#951596}
Configuration menu - View commit details
-
Copy full SHA for 041ba57 - Browse repository at this point
Copy the full SHA 041ba57View commit details -
Roll WebRTC from 699d1a242ecd to 63b97de330fe (8 revisions)
https://webrtc.googlesource.com/src.git/+log/699d1a242ecd..63b97de330fe 2021-12-14 emaxx@chromium.org Fix use-after-move in VideoReceiveStream2 2021-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6656b1d..637713d (951261:951378) 2021-12-14 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-12-14T04:04:40). 2021-12-14 grulja@gmail.com Reland "Linux capturers: organize X11 and Wayland implementations into separate folders" 2021-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 97fa68d..6656b1d (950914:951261) 2021-12-13 eshr@webrtc.org Delete video/video_receive_stream.cc 2021-12-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision afd5c73..97fa68d (950813:950914) 2021-12-12 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-12-12T04:04:39). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1122844 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icc1312008c38557d1c0e385ae7eee2f45cb52049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338623 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951597}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 6d79e72 - Browse repository at this point
Copy the full SHA 6d79e72View commit details -
Disabling two PageContentAnnotations test files on CrOS
Bug: 1279884 Change-Id: Ib57dbd9cde1cafe909013ccfa8b2a1e54362d246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339332 Commit-Queue: Tommy Martino <tmartino@chromium.org> Owners-Override: Tommy Martino <tmartino@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951598}
Tommy Martino authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 57c1a8f - Browse repository at this point
Copy the full SHA 57c1a8fView commit details -
[Media Tabs] Filter alert states in TabSearchPageHandler.
This prevents needing to filter in multiple places on the JS side. Bug: 1261515 Change-Id: Ieb94749ccb169c17bbc88731602538cc4d644733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337089 Reviewed-by: Roman Arora <romanarora@chromium.org> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/heads/main@{#951599}
Elaine Chien authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for bbc52aa - Browse repository at this point
Copy the full SHA bbc52aaView commit details -
[CrOS Bluetooth] Hide unknown devices from discovered device list.
Update DeviceCache to omit adding devices with a device type of UNKNOWN to the list of unpaired devices. Fixed: b/209075547 Change-Id: I8e66c3e36da7242322b8dc6a9e90da4560405c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331186 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/main@{#951600}
Gordon Seto authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for c130899 - Browse repository at this point
Copy the full SHA c130899View commit details -
[OptGuide] Enable models for guest profiles if a loaded profile exists.
This change enables guest profiles to access models from a regular, loaded profile. We only allow loaded profiles as the profile initialization can be costly and create browser regressions, particularly at start up. Bug: 1274115 Change-Id: I556debc63e666338b79a0956dd8f4028b0d24912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337088 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#951601}
Configuration menu - View commit details
-
Copy full SHA for f6d184b - Browse repository at this point
Copy the full SHA f6d184bView commit details -
haptics: Add feedback for continuous desks swipe.
There are two cases, edge (different from when trying to start a desk switch on the edge) and regular. For the regular case, this CL just piggy backs on the existing visible desk change metric. For the edge case during a continuous desks swipe, introduce a new variable which tracks if we are at the edge. If a swipe event causes us to hit the edge, send a haptic event. Test: added tests Bug: 1278944 Change-Id: I1c5bdc5582ab293f84f3feec09d3490069088c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331518 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/main@{#951602}
Sammie Quon authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 787d866 - Browse repository at this point
Copy the full SHA 787d866View commit details -
Better layout for productivity launcher in tablet mode
Removes internal padding (added as empty borders) from continue section view, and lets the parent container handle margins between the continue section and other elements in the UI - for clamshell mode UI, the container was already setting appropriate margins, which meant that continue section borders were adding up to too much space around continue section. In tablet, the margin from continue section to search box was correct, but mainly because there was no margin added between the search box and the scrollable content (and there was not enough space between the apps grid and the search box on second launcher page, which was more prominent while dragging items when the peeking first page background showed up). With removal of continue section padding, the margin added to scrollable container needs to be increased. This is done by removing apps grid view empty border when productivity launcher is enabled - container margin was getting set to ensure that total margin between the search box and apps grid content is 24 (which is intended margin for productivity launcher), removing border moves the whole margin outside the scrollable container, which makes it work both when the apps container only has apps grid, and when it starts with continue section. Note that this also fixes an issue where margin between the recent apps separator and the apps grid was too big (as both the separator and the grid were adding intended 16 dip of padding). Also, explicitly call apps grid view layout in AppsContainer::Layout() if the apps grid view's first page offset changes to ensure the grid gets laid out even if it bounds remain the same. While here, update background card bounds to ensure a minimum size that fits app list items without overlapping their bounds. BUG=1276256 Change-Id: Ied91309d4f937e5b35273905187437faf0d91804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329386 Reviewed-by: Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#951603}
Toni Barzic authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 0e996f5 - Browse repository at this point
Copy the full SHA 0e996f5View commit details -
Reland "Properly close Lens and open link after LRP press"
This reverts commit 6d44280. Reason for revert: Wrongly reverted for a possible suspect of crbug.com/1279761 Original change's description: > Revert "Properly close Lens and open link after LRP press" > > This reverts commit d8bceba. > > Reason for revert: Suspected CL for failing tests on linux-chromeos-chrome. Please see crbug.com/1279761 for more information. > > Original change's description: > > Properly close Lens and open link after LRP press > > > > Bug: 1234532 > > Change-Id: I79b624112787aedb1efd3ef6978b7d034bb2fc89 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331543 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Commit-Queue: Jason Hu <hujasonx@google.com> > > Cr-Commit-Position: refs/heads/main@{#951144} > > Bug: 1234532 > Change-Id: I54306f568cfd6e08546b716a2222cba98a51f8b8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338498 > Auto-Submit: Sreeja Kamishetty <sreejakshetty@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> > Owners-Override: Sreeja Kamishetty <sreejakshetty@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951441} Bug: 1234532 Change-Id: I53373ff7d646ae2465bea109089166bffd6395ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338500 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Owners-Override: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/main@{#951604}
Configuration menu - View commit details
-
Copy full SHA for 6be68d3 - Browse repository at this point
Copy the full SHA 6be68d3View commit details -
Roll ChromeOS Orderfiles from 98-4729.0-1638787322-benchmark-98.0.475…
…8.3-r1 to 98-4729.0-1638787322-benchmark-98.0.4758.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic8dd2b24d278927b346eab262e17a39738f5ae47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339565 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951605}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for acb83a0 - Browse repository at this point
Copy the full SHA acb83a0View commit details -
[Extensions] Promisify a couple chrome.extension methods
chrome.extension.isAllowedIncognitoAccess() and chrome.extension.isAllowedFileSchemeAccess() are both relatively simple API methods with no custom hooks. Update them to support promise-based calls in MV3+. Bug: 328932 Change-Id: I869c1ebc17fba086f1e4be8d99612051c4a21e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331495 Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Tim <tjudkins@chromium.org> Commit-Queue: Tim <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/main@{#951606}
Configuration menu - View commit details
-
Copy full SHA for 591e0a6 - Browse repository at this point
Copy the full SHA 591e0a6View commit details -
Revert "Updater: eliminate sleeps in integration tests."
This reverts commit fe4e8ad. Reason for revert: Introduces flakiness. :( Original change's description: > Updater: eliminate sleeps in integration tests. > > Fixed: 1217765 > Change-Id: Ifa06cdb31b26f7c6332d95f877957c39ffb000b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330675 > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951501} Change-Id: Ia760dd8380746de337c593cdd8222d64fdfcc30c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339197 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#951607}
Joshua Pawlicki authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 1e31e25 - Browse repository at this point
Copy the full SHA 1e31e25View commit details -
[realbox] Added tail suggest feature
Currently the tail suggest feature is not implemented on the realbox. This CL adds the feature by overlapping a span with an invisible tail suggest prefix and visible ellipses (positioned to the right/left). Before: screenshot/3zBj5bRB4a3jmRw After: screenshot/QXwoB8r4yoXDZaT Bug: 1039357 Change-Id: Iab7d453396c76ebde566cda101e556ccda689a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321790 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Marlon Facey <mfacey@chromium.org> Cr-Commit-Position: refs/heads/main@{#951608}
Marlon Facey authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 148cdb2 - Browse repository at this point
Copy the full SHA 148cdb2View commit details -
Revert "Adding flag to enable/disable 'X' to dismiss the signin promo…
… so it can be" This reverts commit 6a5b32c. Reason for revert: This experiment is no longer needed (we already collected all necessary metrics). Original change's description: > Adding flag to enable/disable 'X' to dismiss the signin promo so it can be > rolled out via Finch. > > Note: the flag is default enabled. > > Bug: 1248630 > Change-Id: I311ae52f03fa55f8e9f7d0dab61834e173155f8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190922 > Commit-Queue: Jonathan Freed <freedjm@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926454} Bug: 1248630 Change-Id: I623b2befc8a662bc44b642782d72c8e286802b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329617 Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Jonathan Freed <freedjm@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/main@{#951609}
Mihai Sardarescu authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for d9b6116 - Browse repository at this point
Copy the full SHA d9b6116View commit details -
[Chromecast] Fix a missing dependency in chromecast/app/BUILD.gn
Bug: b:191090206 Test: build Change-Id: Ic0db518e4fad8301bad1e2c7b20a444f9ee69b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337236 Auto-Submit: Junbo Ke <juke@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/main@{#951610}
Junbo Ke authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 2c15db2 - Browse repository at this point
Copy the full SHA 2c15db2View commit details -
[realbox] Align Search Bar Text and Match Text
Adding blue focus indicator shifted match contents and icon by 8px. This CL removes the added 8px. Before: screenshot/5NW3so7JGfjwA33 After: screenshot/7VurTxmMSmzHAwo Bug: 1278089 Change-Id: I6f8e3644f42cd15e7d3fc2c549f4bdd19736afdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328265 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951611}
Marlon Facey authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 5b01393 - Browse repository at this point
Copy the full SHA 5b01393View commit details -
Adds new toolchain lacros_clang
This toolchain will be used to build Lacros in a subfolder using alternate toolchain. Test: Tested locally. We can build Lacros in lacros_clang folder. Bug: 1278152 Change-Id: Ie872414a6029145cdf31ca5d7271a82b86a1b712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325290 Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#951612}
Sven Zheng authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for d02ff77 - Browse repository at this point
Copy the full SHA d02ff77View commit details -
[Magnifier] Extend FullscreenMagnifierMouseFollowingMode histogram
AX-Relnotes: N/A. Fixed: 1279467 Change-Id: I33b3ed4757dc16838acfe8af13e89df88a108888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335336 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/main@{#951613}
Josiah Krutz authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for a75cac0 - Browse repository at this point
Copy the full SHA a75cac0View commit details -
Android: Allow benchmark.py to use custom targets
Allow `./benchmark.py --target monochrome_public_apk` to create timings for targets other than the default chrome_public_apk and chrome_modern_public_bundle. Despite these targets not using incremental install, this allows us to create a baseline of timings before working on porting incremental install to other targets. Bug: 1254718 Change-Id: I5b34eb10d864a3b21e30f2b40a49e0ec92f190f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338386 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#951614}
Peter Wen authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 3ad064c - Browse repository at this point
Copy the full SHA 3ad064cView commit details -
Roll Dawn from 4682ae0034e7 to f296710f64b6 (3 revisions)
https://dawn.googlesource.com/dawn.git/+log/4682ae0034e7..f296710f64b6 2021-12-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9b9132c71522 to 5ad482744db1 (1 revision) 2021-12-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ea03bf47e50f to f236c8f29bbe (10 revisions) 2021-12-14 cwallez@chromium.org Remove CubeReflection and the dependency on GLM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ic4b9fc691a20c18413680561ea1b0bd54579b74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339512 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951615}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 543f7c6 - Browse repository at this point
Copy the full SHA 543f7c6View commit details -
Both of these tests import certs and immediately navigate. The problem is there are a number of async hops before the certs have actually been imported. As a result, there is no guarantee the cert is used at the time of navigation. These tests need a deterministic signal that the cert has been fully imported before navigating. These tests are made more flaky with removal of an unnecessary browser->renderer->browser IPC (see issue 365039). BUG=1279930,365039 TEST=test only change Change-Id: I15b493dfc3117080bfea9f12bfbdb4e8e2d1d994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339656 Reviewed-by: Adam Langley <agl@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#951616}
Scott Violet authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 891b9de - Browse repository at this point
Copy the full SHA 891b9deView commit details -
This removes nonsfi unittest filters from stable_test_filters, as they are no-longer existing. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: Ia1b67351125302267272131c7277202ebb5403d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336809 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#951617}
Hidehiko Abe authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 45f6156 - Browse repository at this point
Copy the full SHA 45f6156View commit details -
Log visible time spent for more schemes in VisibilityMetricsLogger.
* Add Android.WebView.VisibleScheme.Global metric * Add Android.WebView.VisibleScheme.PerWebView metric * Remove Android.WebView.WebViewOpenWebVisible.Global metric * Remove Android.WebView.WebViewOpenWebVisible.PerWebView metric Bug: 1276392 Change-Id: I0ae2d1c59401054073ebb1dde925d126bb35a5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311287 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/main@{#951618}
Configuration menu - View commit details
-
Copy full SHA for fea0465 - Browse repository at this point
Copy the full SHA fea0465View commit details -
WebGPU CTS: remove --disable-gpu-sandbox
Sandbox permissions have been fixed for NVIDIA drivers Fixed: 1274975 Change-Id: Idc34a608b99fc6b34bcaedafd2e77c362f291e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339616 Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Austin Eng <enga@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#951619}
Configuration menu - View commit details
-
Copy full SHA for 811ca09 - Browse repository at this point
Copy the full SHA 811ca09View commit details -
bluetooth: bluetooth server tests to standalone tests
This change updates some of the tests in wpt/bluetooth/server to be standalone window tests. This change allows the tests to be formatted with clang-format. Additionally, fix wpt/bluetooth/server/device-same-object.https.window.html to compare with the correct device object. Bug: 994756 Change-Id: I3276cdc221fded0c14656c806458096fa1a72093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335577 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Jack Hsieh <chengweih@chromium.org> Cr-Commit-Position: refs/heads/main@{#951620}
Configuration menu - View commit details
-
Copy full SHA for d09632d - Browse repository at this point
Copy the full SHA d09632dView commit details -
Fix active surface reference computation
There are overlapping surface references included in a CompositorFrame when they include SurfaceReference(S1, S1) and SurfaceReference(S1, S2). This situation could happen on navigation and in Chrome OS overview mode. If S2 activated before S1 then the active surface references would no longer include S1. Fix OnChildActivatedForActiveFrame() by recomputing from scratch the full set of active references surface if they are going to change. This handles the overlapping surface references case correctly. Add a test to verify this. Bug: 1275605 Change-Id: Ic3e83af50738a5d94668efdb2f92845b2eff5997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330113 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Kyle Charbonneau <kylechar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951621}
kylechar authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 67d5780 - Browse repository at this point
Copy the full SHA 67d5780View commit details -
[Snooze IPH] update fieldtrial to match finch
Change-Id: I40c3bfd3de68a523ba6d35b3082779f8a4e703cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339619 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/main@{#951622}
Hailey Wang authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 3629e7d - Browse repository at this point
Copy the full SHA 3629e7dView commit details -
Shimless: Add validation to the RSU code input
- The input automatically turns red when more than 8 characters are typed screenshot: http://screen/C7NSiEHrZpMWFxR Bug: 1198187 Change-Id: Ia2e6569b2e502114fa3051d6ba169951f5264b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331372 Reviewed-by: Gavin Dodd <gavindodd@google.com> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#951623}
Gavin Williams authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for f974db2 - Browse repository at this point
Copy the full SHA f974db2View commit details -
add methods that should be pure virtual
Add methods to make methods on the Skia API pure virtual in the future. Change-Id: I0a28774aecd65d4d3131ee74880d5f5ea4a21b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338117 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Herb Derby <herb@google.com> Cr-Commit-Position: refs/heads/main@{#951624}
Configuration menu - View commit details
-
Copy full SHA for 80a19ec - Browse repository at this point
Copy the full SHA 80a19ecView commit details -
[iOS] Update SigninPromoViewConfigurator with different mode
This patch adds DCHECKs and comments to be explicit when |userEmail| and |userImage| should be nil in SigninPromoViewConfigurator. Also, this patch fixes SigninPromoViewConfigurator in TableCellCatalogViewController by adding an image for SigninPromoViewModeSigninWithAccount example. And adds SigninPromoViewModeNoAccounts example. Fixed: 1279790 Change-Id: Ic0673a960c5060da9d8fab852222e602f476bb2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338661 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951625}
Jérôme Lebel authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for e70faa9 - Browse repository at this point
Copy the full SHA e70faa9View commit details -
Roll Catapult from e3f9ae73db51 to 563885e399ba (1 revision)
https://chromium.googlesource.com/catapult.git/+log/e3f9ae73db51..563885e399ba 2021-12-14 sunxiaodi@google.com [Catapult] Testing code coverage config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1266068 Tbr: skyostil@google.com Change-Id: Ic8c2ab986c4dbf13ee76290a74e4fad1d3f316f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339551 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951626}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for cec2492 - Browse repository at this point
Copy the full SHA cec2492View commit details -
cast: Handle race condition in display configuration
In cases where the GPU/browser crash often (or early on) it is possible to get multiple display state updates in succession. Discard old events to de-dupe them and only update state related to the latest event. Bug: b/210004562 Test: None Change-Id: I60c892d128f9be52fb498a001328d2f23e9ac20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330324 Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/main@{#951627}
Daniel Nicoara authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for c75810e - Browse repository at this point
Copy the full SHA c75810eView commit details -
Roll Perfetto Trace Processor Linux from 1357bd132733 to f9abf9948a18
https://android.googlesource.com/platform/external/perfetto.git/+log/1357bd132733..f9abf9948a18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3c99ea5a5590ecf8643326783e8f82295f4528d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339651 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951628}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for a5931df - Browse repository at this point
Copy the full SHA a5931dfView commit details -
Roll Skia from 16d3cc04cc85 to f74c7893fc17 (2 revisions)
https://skia.googlesource.com/skia.git/+log/16d3cc04cc85..f74c7893fc17 2021-12-14 jlavrova@google.com Introduce SkVM Op::duplicate to localize visualization code 2021-12-14 djsollen@google.com Add Android Framework specific logging to SkSurface::MakeFromBackendTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: If0c8c135e68b48f80ad19b173097d5b8fd680791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339559 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951629}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for ea46e23 - Browse repository at this point
Copy the full SHA ea46e23View commit details -
desks_templates: Stay in overview mode when launching a template.
With this change, when a template is launched, we create a new desk and switch to it (without animation). Apps are then launched and the overview grid is populated. This change makes it so that windows that are opened while in overview will be inserted into the overview grid. Previously, such windows would just appear as normal windows. This is done by having OverviewSession observe the desk root windows for new children. Bug: 1234855 Change-Id: Ifc0bc752e150535d88f846351a184a11cec8a26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299199 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Daniel Andersson <dandersson@chromium.org> Cr-Commit-Position: refs/heads/main@{#951630}
Daniel Andersson authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 1ce6b3f - Browse repository at this point
Copy the full SHA 1ce6b3fView commit details -
Fix memory leak in ManagementUIHandlerTests.
Found via lsan. Bug: 1279543 Change-Id: Id276502b193df7f8cdf5330f1bcc24c8978fceea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335438 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951631}
Addison Luh authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for f1eaad5 - Browse repository at this point
Copy the full SHA f1eaad5View commit details -
Preconnect a url in NavigationRequest's constructor.
At this stage it's very likely that the given url will be requested. There is still ~60ms at median time between when a navigations starts and when the request is made. At the same time, DNS resolution & TCP connection latency has a median of 130ms. So preconnect at the constructor to parallelize some of this. Bug: 1276493 Change-Id: Ia467befc9536c1c1794e298574b77a5a656b563a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330926 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/main@{#951632}
John Abd-El-Malek authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for cc6fd8a - Browse repository at this point
Copy the full SHA cc6fd8aView commit details -
[SmartLock] Add detail to string for SmartLockRevampUI when fingerpri…
…nt unlock disabled from num attempts Fix string for fingerprint unlock disabled from attempts Change-Id: Ibcd9d99ed07e958c2d1a245b2d93d42b604cb0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335367 Reviewed-by: Thomas Tellier <tellier@google.com> Commit-Queue: Jason Rhee <jasonrhee@google.com> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/main@{#951633}
Jason Rhee authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 9a817c1 - Browse repository at this point
Copy the full SHA 9a817c1View commit details -
Fix use-after-move in WebRequestInfoInitParams
Fix use-after-move in a debug assertion in WebRequestInfoInitParams, as found by clang-tidy: extensions/browser/api/web_request/web_request_info.cc:184: 'navigation_id' used after it was moved extensions/browser/api/web_request/web_request_info.cc:180: move occurred here Bug: 1122844 Change-Id: Idb2aedf94250e8fadf36b5d2b474478250f96f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335917 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/main@{#951634}
Maksim Ivanov authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 5a12b9d - Browse repository at this point
Copy the full SHA 5a12b9dView commit details -
Roll Chrome Win64 PGO profile from chrome-win64-main-1639483122-b852875a95ce2ee39f0bd733dae39836e0f19b13.profdata to chrome-win64-main-1639504726-a5cec93f623091d76267247a1ff888db818a2b02.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I01aae8df850d120241824c7e22ea2f3b7590dffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339555 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951635}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 6301622 - Browse repository at this point
Copy the full SHA 6301622View commit details -
This removes nonsfi support from chrome/. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I1cf7a72bd7b8c68a12c09a4ef974c4092357d78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338140 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951636}
Hidehiko Abe authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for bc25c85 - Browse repository at this point
Copy the full SHA bc25c85View commit details -
[tab_strip] Preallocate buffer space when generating tab Skia paths
When switching tabs the tab strip redraws all tabs in the top chrome. When a window has many tabs the time to generate a Skia path for each tab becomes noticeable. This time comes down to mallocs - each operation added to the path results in a realloc of the verb and point buffers inside the path. This cl sizes those buffers large enough at the start to avoid the successive reallocs. Bug: 1278509 Change-Id: I4eed9749e3fa1e7195e916cb6abfde1fd36387d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328883 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/main@{#951637}
Jayson Adams authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 87d4de2 - Browse repository at this point
Copy the full SHA 87d4de2View commit details -
[Media Router] Remove unused parameters from OnRoutesUpdated.
These parameters were used to support ConnectRouteByRouteId, which was deprecated long ago and removed in https://crrev.com/948740. As part of this change the following other code was removed: - Tracking media routes by source_id in the MediaRouter. - Tracking joinable_route_ids in the MediaRouter. - MediaRouteProvider::UnregisterMediaRoutesObserver became a no-op and can be removed from the MediaRouteProvider mojo interface. Some changes were required to the browser test fixture to handle route observer updates happening at an earlier time in some tests. This also rewrites some of the test cases for MediaRouterMojoImpl to stop instantiating an additional mock media router (which looks like a bug). There are some followup cleanups noted but this change is large enough that I don't want to take them on right now. Bug: 882481 Change-Id: Iedf85958024ddee60268d823f41fbae2317cd80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315876 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951638}
Configuration menu - View commit details
-
Copy full SHA for 24d492e - Browse repository at this point
Copy the full SHA 24d492eView commit details -
Move DesktopEnvironmentOptions to //remoting/host/base
This CL moves a common header+impl to the new base folder as it will be referenced in a follow-up IPC macro conversion CL. As part of this change I am removing the Windows dependency that class has as it calls IsD3DAvailable() in the c'tor which is a blocking call. It doesn't seem right that creating an instance should spin up another process and block on the results (especially for what appears to be a simple struct-like class). Change-Id: I01d1aea8ae6ee99df1f14bf7186dbabd8becf841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336416 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/main@{#951639}
Configuration menu - View commit details
-
Copy full SHA for 66c5aef - Browse repository at this point
Copy the full SHA 66c5aefView commit details -
Welcome: Make ts_library() usage consistent with other WebUIs.
- Rename target from "build" to "build_ts" - Changed output folder to "tsc" instead of re-using the input folder as output. Bug: 1189595 Change-Id: I36dfe216befa89e3b4001b6a4a13b27e98d3438e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327461 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951640}
Configuration menu - View commit details
-
Copy full SHA for 200b9c3 - Browse repository at this point
Copy the full SHA 200b9c3View commit details -
[GridFragmentation] Prefer a row with "auto" break-between over "avoid"
This patch implements some row break avoidance. Specifically we might encounter a breakpoint which is unappealing, and want to move the grid item into the next fragmentainer. However the row might also have an "avoid" break-between. In these cases we can get a slightly better result by searching if there are any rows within the current fragmentainer with an "auto" break-between. Bug: 614667 Change-Id: I6f59bda158ce7536e78da296809efd884feb10a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336514 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#951641}
Configuration menu - View commit details
-
Copy full SHA for ff1deb5 - Browse repository at this point
Copy the full SHA ff1deb5View commit details -
rendering: Temporary report some more UMA metrics.
Report the new PercentDroppedFrames2 metrics in the rendering benchmark. The purpose is to find stories that report different values for the new and old metrics, and collect their trace to do deeper analysis. BUG=1256879 Change-Id: Ie1f6a7054326dd7b565034de04a605d36366cd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339411 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#951642}
Configuration menu - View commit details
-
Copy full SHA for 3b52d2a - Browse repository at this point
Copy the full SHA 3b52d2aView commit details -
Roll src-internal from 3f761f4e3351 to c258c1267440 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f761f4e3351..c258c1267440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jarhar@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jarhar@google.com,tmartino@google.com Change-Id: Ib7c5c94e18823ad4b5fe2348bce559d5fd229be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339560 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951643}
chromium-internal-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 3a6119b - Browse repository at this point
Copy the full SHA 3a6119bView commit details -
[Fast Pair] Log result of retroactive pairings.
Logs the successful and failure retroactive pairing count after a account writing for devices with the retroactive pairing scenario. Change-Id: I09a35f20e95c0a988721d7321829279b70e3e726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321584 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#951644}
Configuration menu - View commit details
-
Copy full SHA for 69bd52b - Browse repository at this point
Copy the full SHA 69bd52bView commit details -
Disable Vulkan on MediaTek GPU
MediaTek SoC have a Build.HARDWARE that starts with "mt" [1]. This CL plumbs Build.HARDWARE to the place where we make the decision about using Vulkan. It also adds a new finch param BlockListByHardware to default disable on all MediaTek GPU. We previously blocked MediaTek SoC with Mali GPU by looking for MP or MC in the GL renderer string. Some SoC don't have that. Hopefully this proves more reliable. [1] https://source.chromium.org/chromium/chromium/src/+/main:media/base/android/java/src/org/chromium/media/MediaCodecUtil.java;drc=3f2c552f85487cb39511229ae529e12ea5dcf21d;l=427 Bug: 1235978#c20 Change-Id: Idda2e658737b05abed3ee47d16821a8e92091f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338765 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951645}
Jonathan Backer authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for afeb5cf - Browse repository at this point
Copy the full SHA afeb5cfView commit details -
haptics: Add haptic feedback for drag-to-drop operations in overview
This is to add haptic feedback to drag-to-drop operations in following three cases in overview mode: 1. Tick effect when a window starts to be dragged. 2. Tick effect when a desk starts to be dragged. 3. Tick effect when the window being dragged reaches a desks. Test: Manual Bug: 1277322 Change-Id: I7666c60af5bf5a2de768bc5135a58fdeeba82de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331239 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Yongshun Liu <yongshun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951646}
Yongshun Liu authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for e1070a7 - Browse repository at this point
Copy the full SHA e1070a7View commit details -
Add QueryTileSection to start surface
This CL adds QueryTileSection to start surface and the feature is disabled by default. Will work with UX on follow up CLs to fix margins, tile sizes etc. Bug: 1269921 Change-Id: I1b4c2e523c53fa0bba9ba79f2cb112d61eea54f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318763 Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Wei-Yin Chen <wychen@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951647}
Min Qin authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 1d56963 - Browse repository at this point
Copy the full SHA 1d56963View commit details -
Fix failures when upload artifacts for wpt tests
See two kinds of failures in the log: 1. path error due to duplicate layout-test-results in the path. 2. trying to upload files that does not exist, e.g. /b/s/w/ir/out/Release/layout-test-results/OK Change-Id: I6f6df9559a18807dbe2c676297f79651a71bba94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333755 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#951648}
Configuration menu - View commit details
-
Copy full SHA for 68ee2c8 - Browse repository at this point
Copy the full SHA 68ee2c8View commit details -
Refactor ReportRequest definition to use absl::variant
The ReportRequest is a type alias based on Operating system. It's enterprise_management::ChromeOsUserReportRequest for Chrome OS and enterprise_management::ChromeDesktopReportRequest for other platforms. However, this is no longer work when adding the third proto which is available on all platforms. This CL create a new ReportRequest class to wrap the proto and use absl::variant to store the request proto. This class is used to pass request instance between report generator, uploader and scheduler. Bug: 1261945 Change-Id: I0944fc2b82489523f3a1a6030f0c1daa6feab5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324322 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951649}
Owen Min authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 6af348d - Browse repository at this point
Copy the full SHA 6af348dView commit details -
Roll Chromite from fff14ebdcbb0 to 7f13e5c5ff2d (7 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fff14ebdcbb0..7f13e5c5ff2d 2021-12-14 juahurta@google.com config: Disable unittests on skyrim 2021-12-14 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-14 shaochuan@chromium.org Reland "Enable android_update_lkgb for master-vmsc-android-pfq" 2021-12-14 shaochuan@chromium.org cros_mark_android_as_stable: handle missing/invalid LKGB file 2021-12-13 briannorris@chromium.org gerrit_unittest: Fix test bitrot 2021-12-13 jaredloucks@google.com paygen: double test suite timeout 2021-12-13 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3e0d0b3268a69251032050c53bf6f62d933366c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339389 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951650}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 2083ba4 - Browse repository at this point
Copy the full SHA 2083ba4View commit details -
Roll Chrome Linux PGO profile from chrome-linux-main-1639483122-20e6b9acc183f41a276a93022da6f201498b4d81.profdata to chrome-linux-main-1639504726-00818556d27ae6f0ca222d22829579a009d0b826.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I430a64bb921f2e1d20e0376d18cfe42b5790ea71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339734 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951651}
chromium-autoroll authored and Chromium LUCI CQ committedDec 14, 2021 Configuration menu - View commit details
-
Copy full SHA for 488417a - Browse repository at this point
Copy the full SHA 488417aView commit details -
Extend PrivacySandbox.AggregationService.* expiry
The two histograms' expiry is extended by six months as these metrics are still useful, but this part of the codebase is experimental. Bug: 1277106 Change-Id: I654ee696ce4db688300425cfdd58d4148152c684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337016 Auto-Submit: Alex Turner <alexmt@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/main@{#951652}
Configuration menu - View commit details
-
Copy full SHA for 1330dd1 - Browse repository at this point
Copy the full SHA 1330dd1View commit details -
Revert "sheriff: Disable failing WebAppIntegrationBrowserTest test on…
… Linux" This reverts commit 3ce540b. Reason for revert: Fixed in crbug.com/1273568 Original change's description: > sheriff: Disable failing WebAppIntegrationBrowserTest test on Linux > > The tests are flaky on Linux causing CI builder failures. > > Bug: 1277870 > Change-Id: Id27ff02e966d302875ed86c45273a76b9328e72d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320396 > Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> > Owners-Override: Swapnil Gupta <swapnilgupta@google.com> > Auto-Submit: Swapnil Gupta <swapnilgupta@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/main@{#949456} Bug: 1277870, 1273568 Change-Id: I319a0038823d85a0f3272e373e755158b4aeb0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339398 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951653}
Configuration menu - View commit details
-
Copy full SHA for 9398d16 - Browse repository at this point
Copy the full SHA 9398d16View commit details