Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from chromium:main #111

Merged
merged 152 commits into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
452e43d
[lacros] fixed popup window size problem.
Dec 14, 2021
f6207eb
Fix use-after-move in GpuHostImpl
Dec 14, 2021
3c8d9f2
[ChromeOS]Start OnboardingUserActivityCounter for primary users only
Dec 14, 2021
dff044a
Roll RTS model from yVc-vTWsY... to ST_XL0WVE...
Dec 14, 2021
98e1c5a
[page info] Add strings for history section
Dec 14, 2021
83b9521
Roll RTS model from tI4WdYbci... to K9BP5YhVb...
Dec 14, 2021
1109e28
[v8][api] Update users of v8::Object::CreationContext
camillobruni Dec 14, 2021
d5d7fa3
[fuchsia] Group jitless-related failures in content_browsertests
Steelskin Dec 14, 2021
70f44a0
Disallow “--” as CSS variable name.
Dec 14, 2021
34c6b23
Handle account removal in AccountAppsAvailability
Dec 14, 2021
9277181
Updating trunk VERSION from 4766.0 to 4767.0
Dec 14, 2021
be941a8
Use python3 for chromium_trybot recipe.
kleerwater Dec 14, 2021
d2ce916
[bluetooth] Minor comment typo fix.
cmumford Dec 14, 2021
4b3b169
Roll Media App from Hm4ipUPiX... to OEszP2fR0...
Dec 14, 2021
338a64b
Revert "Launch Lens image search on desktop at ToT."
Dec 14, 2021
f41b732
Roll Help App from uwAu1UD0o... to RcDM8Mq_L...
Dec 14, 2021
3d493d3
webrtc-internals: fold large SDP by default
fippo Dec 14, 2021
af90282
Reland "system-extensions: Add system-extensions-internals"
Dec 14, 2021
36fd2f8
ax_dump_tree: update documentation
spectranaut Dec 14, 2021
dfcddb4
Reland "Record new metric for first render time on profile picker sta…
Dec 14, 2021
0e39ece
Roll src/third_party/cros_system_api/ 738cc02fc..188fb4eba (6 commits)
duda-patryk Dec 14, 2021
115268f
base: Make JSON_PARSE_RFC optionally strictly compliant with RFC 8259.
rsesek Dec 14, 2021
976e4a5
Roll src-internal from d49909553bd8 to 241290db3761 (6 revisions)
Dec 14, 2021
e92937f
[fuchsia] Fix use-after-move in FuchsiaCdmManager
Dec 14, 2021
a030f52
[bluetooth] Add support for single SDP entry when enumerating services.
cmumford Dec 14, 2021
d16c29c
Add mrefaat@ as owner for ios tabgrid
mrefaat88 Dec 14, 2021
78a59dd
[serial] Removed unnecessary `device_uuids` variable.
cmumford Dec 14, 2021
eea225b
GCC: Don't use 'warn_unused_result' attribute for class type
Dec 14, 2021
d390b2b
Fix the arc::GetWindowTaskOrSessionId crash issue.
Dec 14, 2021
417d42a
[Sync] Store bootstrap token immediately
Dec 14, 2021
4f39c7f
[page info] Add history feature flag
Dec 14, 2021
29cda9c
[serial] Ignore duplicate devices in PortAdded().
cmumford Dec 14, 2021
ad05b5e
Set color attributes on DialogWhenLarge theme.
Dec 14, 2021
47d0284
Lower mac11-arm64-rel exp percentage
Dec 14, 2021
b78b12a
[Android] Change Java BOOTSTRAP tasks back to USER_VISIBLE priority
colinblundell Dec 14, 2021
949da86
Add profile picker trace events
Dec 14, 2021
3695711
[Android][Passwords] Remove LoginsResult as JobReturnHandler callback
FHorschig Dec 14, 2021
9eb1612
Update V8 to version 9.9.2.
Dec 14, 2021
0a98c2e
Roll DevTools Frontend from a1121f966ce5 to 5fec567a800a (5 revisions)
Dec 14, 2021
335ebb5
Updater: Eliminate global prefs from --update command.
Dec 14, 2021
9b7eca0
[Android] Extend Android.PackageStats.* histograms.
tommynyquist Dec 14, 2021
8634ed0
Fix null dereference error in BackForwardMenuModel::GetHistoryItemCount
joanmarie Dec 14, 2021
80eddb7
[CrOS Network] Add checking if dbus object path is empty to avoid crash
Dec 14, 2021
9a3e5a6
[Fast Pair] Add engagement funnel metric for Retroactive Pairing.
julietlevesque Dec 14, 2021
9b7c338
Add histogram to track EstableGpuChannelSync
clarkduvall Dec 14, 2021
c44d448
Delete policy WebRestrictionsAuthority
negibokken Dec 14, 2021
7c61fdb
[ios] Support "unrealized" WebState in WebStateDependencyInstallation…
sdefresne Dec 14, 2021
994347c
Link pdfium pdf_xfa_xdp_fdp_fuzzer in Chromium
DavidKorczynski Dec 14, 2021
711c3ce
WebNFC: Add experimental NDEFReader.makeReadOnly()
beaufortfrancois Dec 14, 2021
f1ae918
exo: Implement basic color management features for surfaces
Dec 14, 2021
db69c33
Reland "Remove use of GridLayout for the payment sheet view."
Dec 14, 2021
d0ff520
Re-enable 2 WeBbundle WPTs.
myrzakereyms Dec 14, 2021
eb54096
WebLayer: Run skew tests with python3
Dec 14, 2021
c2f72a1
Revert "[sheriff]: Disable TwoClientWebApps tests."
dmurph Dec 14, 2021
731e7e0
Fix use-after-move in CdmInfo
Dec 14, 2021
e8f73a6
[undecryptable sync data] Also log counts metrics w/o ModelType suffix
Dec 14, 2021
9404000
[Android] Send dismissal signal from Blink to browser for DateTimeCho…
Dec 14, 2021
5d74106
Fix use-after-move in RuleBasedHostResolverProc
Dec 14, 2021
3b2e879
CacheStorage: Fix IWYU
stampho Dec 14, 2021
d68b853
[iOS] Add device restore metrics
Dec 14, 2021
678f024
Fix use-after-move in ReportingEndpointGroupKey
Dec 14, 2021
3d90900
Migrate MutationRecord to use AsyncTaskContext
hanselfmu-chromium Dec 14, 2021
61e84ad
Build mac installer on mac-chrome trybot
nico Dec 14, 2021
140c211
Fix files_to_skip in tools/mb pylint check.
kleerwater Dec 14, 2021
01394c3
[Autofill Assistant] Enable CUP support in ServiceRequestSender
Sergio-Vila Dec 14, 2021
17c6318
[ios] Remove TabIdTabHelper class
sdefresne Dec 14, 2021
101acc1
Sheriff: Disable failing Linux TSan Test
sreejakshetty Dec 14, 2021
9af929a
Roll ANGLE from 42bd4fc29aea to fefd7ae66ad9 (8 revisions)
Dec 14, 2021
868554d
Roll Chrome Win32 PGO Profile
Dec 14, 2021
00c5667
Roll androidx from juajBfBlq... to Cd5XvW44K...
Dec 14, 2021
f11d8c5
[Smart Lock] Extend smart-lock-ui-revamp feature flag expiry
Dec 14, 2021
0079b14
Consider paddings that cause MessageCenter to surpass its max height
Dec 14, 2021
5ea2331
Add shown metrics for tailored security UX
Dec 14, 2021
544a0b1
speculative fix for crash
Dec 14, 2021
64071dc
Revert "[Zenith] Keep the dialog open when clicking on the device sel…
muyao-xu Dec 14, 2021
96ec3ff
Ensure slot element with display:contents are included
joanmarie Dec 14, 2021
ed14586
What's New: Update pref when running ShouldShowForState
Dec 14, 2021
7054c4e
Roll Perfetto from 1357bd132733 to f9abf9948a18 (1 revision)
Dec 14, 2021
c1c3df2
[Refactor] Style guide CredentialManagerProxy::FedCMGetRequest()
pkotwicz Dec 14, 2021
bd31d2e
Roll Skia from d26057a2c0e1 to 16d3cc04cc85 (6 revisions)
Dec 14, 2021
6f13305
media: Report Media.MediaFoundationRenderer.ErrorReason UMA
xhwang-chromium Dec 14, 2021
c2813db
Roll src-internal from 241290db3761 to 3f761f4e3351 (1 revision)
Dec 14, 2021
b84b77c
[flakiness] Enable flaky checks on ios-simulator
Dec 14, 2021
0478b25
[Net][Android] Add and use ChromiumNetworkAdapter
Dec 14, 2021
0a9d09f
Roll RTS model from vdD8aHXAy... to h4OErwvGM...
Dec 14, 2021
3419a98
AngleVulkan: using eglCreateImageKHR
phuang Dec 14, 2021
6eecdb5
Add support for dark mode icon in Lens side panel.
Dec 14, 2021
b06fb5c
[Fast Pair] Add alternative pair metric.
julietlevesque Dec 14, 2021
876bdc6
#LensChrome Region search side panel - add loading indicator
Dec 14, 2021
e432e9c
Add media_unittests filter dep to media/BUILD.gn
zhiyuansAtGoogle Dec 14, 2021
b3dbfd3
[LR] Add fieldtrial config entry
guillaumejenkins Dec 14, 2021
0802baf
Update V8 to version 9.9.3.
Dec 14, 2021
bc7e870
Reland "Reland "Mac: enable ThinLTO (without unit splitting)""
speednoisemovement Dec 14, 2021
b0f10ed
Migrate signin_view's background to dynamic colors.
Dec 14, 2021
041ba57
Fenced Frames: Add unit test support
a4sriniv Dec 14, 2021
6d79e72
Roll WebRTC from 699d1a242ecd to 63b97de330fe (8 revisions)
Dec 14, 2021
57c1a8f
Disabling two PageContentAnnotations test files on CrOS
Dec 14, 2021
bbc52aa
[Media Tabs] Filter alert states in TabSearchPageHandler.
Dec 14, 2021
c130899
[CrOS Bluetooth] Hide unknown devices from discovered device list.
Dec 14, 2021
f6d184b
[OptGuide] Enable models for guest profiles if a loaded profile exists.
mcrouse-chrome Dec 14, 2021
787d866
haptics: Add feedback for continuous desks swipe.
Dec 14, 2021
0e996f5
Better layout for productivity launcher in tablet mode
Dec 14, 2021
6be68d3
Reland "Properly close Lens and open link after LRP press"
sreejakshetty Dec 14, 2021
acb83a0
Roll ChromeOS Orderfiles from 98-4729.0-1638787322-benchmark-98.0.475…
Dec 14, 2021
591e0a6
[Extensions] Promisify a couple chrome.extension methods
rdcronin Dec 14, 2021
1e31e25
Revert "Updater: eliminate sleeps in integration tests."
Dec 14, 2021
148cdb2
[realbox] Added tail suggest feature
Dec 14, 2021
d9b6116
Revert "Adding flag to enable/disable 'X' to dismiss the signin promo…
Dec 14, 2021
2c15db2
[Chromecast] Fix a missing dependency in chromecast/app/BUILD.gn
Dec 14, 2021
5b01393
[realbox] Align Search Bar Text and Match Text
Dec 14, 2021
d02ff77
Adds new toolchain lacros_clang
Dec 14, 2021
a75cac0
[Magnifier] Extend FullscreenMagnifierMouseFollowingMode histogram
Dec 14, 2021
3ad064c
Android: Allow benchmark.py to use custom targets
Dec 14, 2021
543f7c6
Roll Dawn from 4682ae0034e7 to f296710f64b6 (3 revisions)
Dec 14, 2021
891b9de
ssl: disables two tests
Dec 14, 2021
45f6156
Remove NonSFI mode part 8.
Dec 14, 2021
fea0465
Log visible time spent for more schemes in VisibilityMetricsLogger.
mvano Dec 14, 2021
811ca09
WebGPU CTS: remove --disable-gpu-sandbox
austinEng Dec 14, 2021
d09632d
bluetooth: bluetooth server tests to standalone tests
chengweih001 Dec 14, 2021
67d5780
Fix active surface reference computation
Dec 14, 2021
3629e7d
[Snooze IPH] update fieldtrial to match finch
Dec 14, 2021
f974db2
Shimless: Add validation to the RSU code input
Dec 14, 2021
80a19ec
add methods that should be pure virtual
herbderby Dec 14, 2021
e70faa9
[iOS] Update SigninPromoViewConfigurator with different mode
Dec 14, 2021
cec2492
Roll Catapult from e3f9ae73db51 to 563885e399ba (1 revision)
Dec 14, 2021
c75810e
cast: Handle race condition in display configuration
Dec 14, 2021
a5931df
Roll Perfetto Trace Processor Linux from 1357bd132733 to f9abf9948a18
Dec 14, 2021
ea46e23
Roll Skia from 16d3cc04cc85 to f74c7893fc17 (2 revisions)
Dec 14, 2021
1ce6b3f
desks_templates: Stay in overview mode when launching a template.
Dec 14, 2021
f1eaad5
Fix memory leak in ManagementUIHandlerTests.
Dec 14, 2021
cc6fd8a
Preconnect a url in NavigationRequest's constructor.
Dec 14, 2021
9a817c1
[SmartLock] Add detail to string for SmartLockRevampUI when fingerpri…
Dec 14, 2021
5a12b9d
Fix use-after-move in WebRequestInfoInitParams
Dec 14, 2021
6301622
Roll Chrome Win64 PGO Profile
Dec 14, 2021
bc25c85
Remove NonSFI mode part 10.
Dec 14, 2021
87d4de2
[tab_strip] Preallocate buffer space when generating tab Skia paths
Dec 14, 2021
24d492e
[Media Router] Remove unused parameters from OnRoutesUpdated.
markafoltz Dec 14, 2021
66c5aef
Move DesktopEnvironmentOptions to //remoting/host/base
joedow-42 Dec 14, 2021
200b9c3
Welcome: Make ts_library() usage consistent with other WebUIs.
freshp86 Dec 14, 2021
ff1deb5
[GridFragmentation] Prefer a row with "auto" break-between over "avoid"
bfgeek Dec 14, 2021
3b52d2a
rendering: Temporary report some more UMA metrics.
sadrulhc Dec 14, 2021
3a6119b
Roll src-internal from 3f761f4e3351 to c258c1267440 (1 revision)
Dec 14, 2021
69bd52b
[Fast Pair] Log result of retroactive pairings.
julietlevesque Dec 14, 2021
afeb5cf
Disable Vulkan on MediaTek GPU
Dec 14, 2021
e1070a7
haptics: Add haptic feedback for drag-to-drop operations in overview
Dec 14, 2021
1d56963
Add QueryTileSection to start surface
Dec 14, 2021
68ee2c8
Fix failures when upload artifacts for wpt tests
WeizhongX Dec 14, 2021
6af348d
Refactor ReportRequest definition to use absl::variant
Dec 14, 2021
2083ba4
Roll Chromite from fff14ebdcbb0 to 7f13e5c5ff2d (7 revisions)
Dec 14, 2021
488417a
Roll Chrome Linux PGO Profile
Dec 14, 2021
1330dd1
Extend PrivacySandbox.AggregationService.* expiry
alexmturner Dec 14, 2021
9398d16
Revert "sheriff: Disable failing WebAppIntegrationBrowserTest test on…
dmurph Dec 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
34 changes: 17 additions & 17 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -239,15 +239,15 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling Skia
# and whatever else without interference from each other.
'skia_revision': 'd26057a2c0e1e35a2f3a498769a27d8f8b6b1e62',
'skia_revision': 'f74c7893fc17685e34089af7c81446e23cfab4ad',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling V8
# and whatever else without interference from each other.
'v8_revision': '8a05d7add33e40e73aac9fc43b4d9cce04adeaca',
'v8_revision': 'b5bf62dafe52d10d65bfd2e378d658b5b3b04a5e',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling ANGLE
# and whatever else without interference from each other.
'angle_revision': '42bd4fc29aea6c0c1722d3604b0eadf7fb1e9aca',
'angle_revision': 'fefd7ae66ad94d8fcb16ef9f5f7304c1b4b9fbf8',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling SwiftShader
# and whatever else without interference from each other.
Expand Down Expand Up @@ -306,15 +306,15 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling catapult
# and whatever else without interference from each other.
'catapult_revision': 'e3f9ae73db5135ad998108113af7ef82a47efc51',
'catapult_revision': '563885e399ba18672cd7d009a0c0f0a996d71f6b',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling libFuzzer
# and whatever else without interference from each other.
'libfuzzer_revision': 'debe7d2d1982e540fbd6bd78604bf001753f9e74',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling devtools-frontend
# and whatever else without interference from each other.
'devtools_frontend_revision': 'a1121f966ce5590b46706befdf60e3350a5cf2d1',
'devtools_frontend_revision': '5fec567a800a98035a5c7aa02eebf93d3690e484',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling libprotobuf-mutator
# and whatever else without interference from each other.
Expand Down Expand Up @@ -354,7 +354,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
'dawn_revision': '4682ae0034e7929dbea9b064ff39f6953eec406b',
'dawn_revision': 'f296710f64b6625d204262c09463401def70cea6',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
Expand Down Expand Up @@ -716,7 +716,7 @@ deps = {
'packages': [
{
'package': 'chromium/rts/model/linux-amd64',
'version': 'vdD8aHXAya55_zVdy0rcmEfQix9y1GLancfERg2yKc8C',
'version': 'h4OErwvGMzWmTzk59jLdAUp9o00HkQ6vKZlwtDCstocC',
},
],
'dep_type': 'cipd',
Expand All @@ -727,7 +727,7 @@ deps = {
'packages': [
{
'package': 'chromium/rts/model/mac-amd64',
'version': 'yVc-vTWsYEzs3l22SOOsPdO_AWBNR3HP71lX3Q4VQQYC',
'version': 'ST_XL0WVEj5Xxvj-kAcMuyZsvgGw_VNlvbupF6-aFXUC',
},
],
'dep_type': 'cipd',
Expand All @@ -738,7 +738,7 @@ deps = {
'packages': [
{
'package': 'chromium/rts/model/windows-amd64',
'version': 'tI4WdYbciNIAG3pe4wvAouTF40XTOBKIAMEZ0h_TQT8C',
'version': 'K9BP5YhVbtP-iXTbJU0dbwRi9gaMI_w2x0OtulD3R_oC',
},
],
'dep_type': 'cipd',
Expand Down Expand Up @@ -799,7 +799,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/androidx',
'version': 'juajBfBlqvumlCoLLOxvOPlX6cPvfNhDi8XyKP4yjTEC',
'version': 'Cd5XvW44KjLwajSIYoTsODMnpNKBR--BNLPfpIDKGeAC',
},
],
'condition': 'checkout_android',
Expand Down Expand Up @@ -1018,7 +1018,7 @@ deps = {
# Tools used when building Chrome for Chrome OS. This affects both the Simple
# Chrome workflow, as well as the chromeos-chrome ebuild.
'src/third_party/chromite': {
'url': Var('chromium_git') + '/chromiumos/chromite.git' + '@' + 'fff14ebdcbb0fd75801af82d2765758efa1ec579',
'url': Var('chromium_git') + '/chromiumos/chromite.git' + '@' + '7f13e5c5ff2def048f60931a4f09bdcc0c7c3965',
'condition': 'checkout_chromeos',
},

Expand All @@ -1033,7 +1033,7 @@ deps = {

# For Linux and Chromium OS.
'src/third_party/cros_system_api': {
'url': Var('chromium_git') + '/chromiumos/platform2/system_api.git' + '@' + '738cc02fc3beb133d085f871e2534416baf5afc7',
'url': Var('chromium_git') + '/chromiumos/platform2/system_api.git' + '@' + '188fb4eba05af428a48c7ce173a3026215241850',
'condition': 'checkout_linux',
},

Expand Down Expand Up @@ -1421,7 +1421,7 @@ deps = {
},

'src/third_party/perfetto':
Var('android_git') + '/platform/external/perfetto.git' + '@' + '1357bd132733ccc23a295739e4bc432d7a53d120',
Var('android_git') + '/platform/external/perfetto.git' + '@' + 'f9abf9948a180a56a3595ec54ff9f2f5c2c9947c',

'src/third_party/perl': {
'url': Var('chromium_git') + '/chromium/deps/perl.git' + '@' + '6f3e5028eb65d0b4c5fdd792106ac4c84eee1eb3',
Expand Down Expand Up @@ -1642,7 +1642,7 @@ deps = {
Var('chromium_git') + '/external/github.com/gpuweb/cts.git' + '@' + '216e2ff413d3ed5e7695626bb55ae41575818352',

'src/third_party/webrtc':
Var('webrtc_git') + '/src.git' + '@' + '699d1a242ecd3ca819293cfa96f5dcf8f5e1b91a',
Var('webrtc_git') + '/src.git' + '@' + '63b97de330fe3d4775b9b4df8ad15c7593d58fc0',

'src/third_party/libgifcodec':
Var('skia_git') + '/libgifcodec' + '@'+ Var('libgifcodec_revision'),
Expand Down Expand Up @@ -1700,7 +1700,7 @@ deps = {
Var('chromium_git') + '/v8/v8.git' + '@' + Var('v8_revision'),

'src-internal': {
'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@d49909553bd8838195664ca9df5b36229c2582da',
'url': 'https://chrome-internal.googlesource.com/chrome/src-internal.git@c258c12674403e7c685e3462d136b29560e6b4d8',
'condition': 'checkout_src_internal',
},

Expand All @@ -1719,7 +1719,7 @@ deps = {
'packages': [
{
'package': 'chromeos_internal/apps/help_app/app',
'version': 'uwAu1UD0oDj17zqx0Af0wZnVecasHn1pBC4V6A3JBRwC',
'version': 'RcDM8Mq_LrCGiuxfQto-gkDVFbqCRy6FE8lzPeHsNEwC',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand All @@ -1730,7 +1730,7 @@ deps = {
'packages': [
{
'package': 'chromeos_internal/apps/media_app/app',
'version': 'Hm4ipUPiXd-gzWDEbyraNGipQikDIbxi1Xc70s6BwWQC',
'version': 'OEszP2fR0fctn9Qr3fnIElqnNLPxHyhTUfWfaiiLVckC',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand Down
23 changes: 12 additions & 11 deletions android_webview/browser/aw_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
#include "content/public/browser/favicon_status.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/page.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
Expand Down Expand Up @@ -1512,21 +1513,20 @@ void AwContents::RenderViewHostChanged(content::RenderViewHost* old_host,
new_host->GetWidget()->GetFrameSinkId());
}

void AwContents::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
// If this request was blocked in any way, broadcast an error.
net::Error error_code = navigation_handle->GetNetErrorCode();

bool navigation_successful_and_scheme_http_or_https =
((error_code == net::OK) &&
navigation_handle->GetURL().SchemeIsHTTPOrHTTPS());
if (navigation_successful_and_scheme_http_or_https != scheme_http_or_https_) {
scheme_http_or_https_ = navigation_successful_and_scheme_http_or_https;
void AwContents::PrimaryPageChanged(content::Page& page) {
std::string scheme = page.GetMainDocument().GetLastCommittedURL().scheme();
if (scheme_ != scheme) {
scheme_ = scheme;
AwBrowserProcess::GetInstance()
->visibility_metrics_logger()
->ClientVisibilityChanged(this);
}
}

void AwContents::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
// If this request was blocked in any way, broadcast an error.
net::Error error_code = navigation_handle->GetNetErrorCode();
if (!net::IsRequestBlockedError(error_code) &&
error_code != net::ERR_ABORTED) {
return;
Expand Down Expand Up @@ -1582,7 +1582,8 @@ VisibilityMetricsLogger::VisibilityInfo AwContents::GetVisibilityInfo() {
return VisibilityMetricsLogger::VisibilityInfo{
browser_view_renderer_.attached_to_window(),
browser_view_renderer_.view_visible(),
browser_view_renderer_.window_visible(), scheme_http_or_https_};
browser_view_renderer_.window_visible(),
VisibilityMetricsLogger::SchemeStringToEnum(scheme_)};
}

void AwContents::RendererUnresponsive(
Expand Down
3 changes: 2 additions & 1 deletion android_webview/browser/aw_contents.h
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ class AwContents : public FindHelper::Listener,
// content::WebContentsObserver overrides
void RenderViewHostChanged(content::RenderViewHost* old_host,
content::RenderViewHost* new_host) override;
void PrimaryPageChanged(content::Page& page) override;
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;

Expand Down Expand Up @@ -428,7 +429,7 @@ class AwContents : public FindHelper::Listener,
std::unique_ptr<js_injection::JsCommunicationHost> js_communication_host_;

bool view_tree_force_dark_state_ = false;
bool scheme_http_or_https_ = false;
std::string scheme_;

// GURL is supplied by the content layer as requesting frame.
// Callback is supplied by the content layer, and is invoked with the result
Expand Down
Loading