[pull] main from chromium:main #112
Merged
Commits on Dec 14, 2021
-
Revert "[Passwords] Fix assertion failure when opening password setti…
…ngs" This reverts commit 293ef66. Reason for revert: Caused PasswordSettingsTest#testManageAccountLinkSyncing() to start failing. See crbug.com/1279940 Original change's description: > [Passwords] Fix assertion failure when opening password settings > > Method SyncService.isUsingExplicitPassphrase() has the precondition that > the sync engine must have initialized, as per isEngineInitialized(). To > avoiding running into assertion failures, PasswordManagerHelper must > first rule out ongoing initialization before invoking > isUsingExplicitPassphrase(). > > Change-Id: I8f519953c6d37aa4d9d54e6b043c24054fb46b45 > Fixed: 1276532 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336879 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951464} Change-Id: Iffaaeffcfc0d0a2b6d13017abc9220d3a81529fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338974 Owners-Override: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951660}
-
Suppress flaky Pixel_WebGPUImportVideoFrame test on Intel
Flaky on bot: Win10 FYI x64 Release (Intel HD 630) Bug: 1274796 Change-Id: I53cceeebea5909fa8d6281e8880b733c0fe2ddda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339534 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Shrek Shao <shrekshao@google.com> Owners-Override: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#951664}
-
Put VEA and VEAClient mojo interfaces on the same pipe
This should eliminate races between VEA::Flush() completion callback and VEAClient::BitstreamBufferReady(). Flush should never return before all pending outputs were given to the client. This magic is called "Associated Interfaces" and it's described here https://chromium.googlesource.com/chromium/src/+/HEAD/mojo/public/cpp/bindings/README.md#Associated-Interfaces Bug: 1275474 Change-Id: Ia384c42d9ca6eb25288e19cf22271df0cc30ad9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336495 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#951666}
-
android: check for zero address earlier
The ccrev.com/948993 introduced a simpler and faster way to find the RELRO region. It had to be reverted (crbug.com/1278078) because the new logic has the additional requirement for the |load_address_| to point to a valid address of the loaded library. On not-so-rare occasion this condition is not met: when the first attempt to load the native library fails, and the |mRemoteLibInfo.mLoadAddress| is zeroed out before making the next attempt. Detect this condition and give up earlier. Also count (in UMA) the number of remaining cases where an invalid address propagates to the modern_linker_jni.cc - these should hopefully be at absolute zero. If so, re-landing the ccrev.com/948993 would be safer. Bug: 1154224 Change-Id: I9cacf240d198e22c93583192803582b0f4bdd491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338747 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951667}
-
Modify references to Origin in LockManager to use BucketId instead
As the first part of the implementation of partitioned WebLocks, modified RenderProcessHostImpl::CreateLockManager() to convert the Origin passed in to a BucketId before calling LockManager::BindReceiver() and changed all references to Origin in LockManager to use BucketId instead. Bug: 1258860 Change-Id: I75bd3d74ed5d7bbcf63a8c8c643927b9431b8580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3270364 Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Joshua Hood <jdh@chromium.org> Cr-Commit-Position: refs/heads/main@{#951672}
-
shimless: Handle abortRma success state
Abort RMA reports RMAD_ERROR_RMA_NOT_REQUIRED on success Run unit tests for shimless_rma_service Run local build and confirm that cancelling restarts Chrome. Bug: 1198187 Test: Run browser tests for Shimless* Change-Id: I2ae44440d0e9eec58b76b4e10f5e819375c6b8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321793 Reviewed-by: Gavin Williams <gavinwill@chromium.org> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Gavin Dodd <gavindodd@google.com> Cr-Commit-Position: refs/heads/main@{#951675} -
Welcome: Refactor BUILD.gn so that each source file is listed once.
This eliminates a lot of redundant code. Previously for adding a new file to the build it had to be listed 3 times, and any platform specific conditions would have to match across each reference. After this change each file is listed only once either in - web_component_files or - non_web_component_files and these lists are reused across html_to_js(), preprocess_if_expr() and ts_library() targets. Bug: 1189595 Change-Id: Iad2bbe43c95adbb63c81136922f3b7f2bd728efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330216 Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#951676}
-
Remove ’account’ from ’remove from this device’
Screenshot on https://drive.google.com/file/d/1nvpCSDtYNJ5ZlN55Oc45ii9exkFGBDoo/view?usp=sharing Fixed: 1279927 Change-Id: I7cd214497a325fcfa58b910c93db84e2e69b4df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338746 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Arthur Milchior <arthurmilchior@google.com> Auto-Submit: Arthur Milchior <arthurmilchior@google.com> Cr-Commit-Position: refs/heads/main@{#951677}
-
[Autofill] Fixed Autofill.CreditCard.SeamlessFills.
This CL fixes that Autofill.CreditCard.SeamlessFills was recorded for all and not just the autofilled fields, and that emitted incomplete fills if no credit card field at all was filled. Bug: 1275953, 1187842 Change-Id: If8f3549d5b18c81493d800ce24829f92d3d24d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329800 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#951678}
-
[cast_core] Replace chromecast:app_core target with chromecast:app.
Bug: b:210127896 Test: Local testing Change-Id: I559a46a6cbce4cb66c1160097ad36d9ff7f90b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336480 Reviewed-by: Ryan Keane <rwkeane@google.com> Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951681}
-
[cast_core] Remove CastRuntimeService::GetInstance API.
The static accessor is not required in this design, as the appropriate object can be easily retrieved. Bug: b:210127896 Test: CQ Change-Id: I574b4994f1b5986f07c969cb6367da0c08b0fb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336481 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951688}
-
Re-disable Metal WebGL on 'Mac FYI ASAN (Intel)'
Disabling Metal shader cache didn't fix the flaky crashes. Bug: 1270755 Change-Id: I5c8874fe432c5cd96c05ed297a5c95e9d7672646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338325 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#951689}
-
Revert "Reland "Reland "Mac: enable ThinLTO (without unit splitting)"""
This reverts commit bc7e870. Reason for revert: Installer is still seeing -fwhole-program-vtables Original change's description: > Reland "Reland "Mac: enable ThinLTO (without unit splitting)"" > > This reverts commit 8f1d535. > > Reason for revert: Turned off LTO for ARM installer > > Original change's description: > > Revert "Reland "Mac: enable ThinLTO (without unit splitting)"" > > > > This reverts commit af0abed. > > > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1279316 > > > > Original change's description: > > > Reland "Mac: enable ThinLTO (without unit splitting)" > > > > > > This reverts commit 397efe0. > > > > > > Reason for revert: Timeout on bot was increased > > > > > > Original change's description: > > > > Revert "Mac: enable ThinLTO (without unit splitting)" > > > > > > > > This reverts commit 810d213. > > > > > > > > Reason for revert: Suspecting causing infra failure. > > > > > > > > Original change's description: > > > > > Mac: enable ThinLTO (without unit splitting) > > > > > > > > > > Splitting is currently blocked on supporting N_INDR symbols in lld. > > > > > > > > > > Bug: 471146 > > > > > Change-Id: Iacc2288d8307fdf730d92d0bfc7f3286d0162b92 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328741 > > > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > > > Commit-Queue: Nico Weber <thakis@chromium.org> > > > > > Cr-Commit-Position: refs/heads/main@{#950412} > > > > > > > > Bug: 1279290 > > > > Change-Id: If82f13cf72eb7a42430dbda9d5af534efd77f5f6 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332866 > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > Commit-Queue: My Nguyen <myy@chromium.org> > > > > Owners-Override: My Nguyen <myy@chromium.org> > > > > Reviewed-by: Darren Shen <shend@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#950944} > > > > > > Bug: 1279290 > > > Change-Id: I42d2f45910992dcd02912a10e080d4392253b31e > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334918 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#951187} > > > > Bug: 1279290 > > Change-Id: I60ca717f12e620ecd1ea38944714feeee244e7f5 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336736 > > Auto-Submit: Leonard Grey <lgrey@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Mark Mentovai <mark@chromium.org> > > Owners-Override: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > Reviewed-by: My Nguyen <myy@chromium.org> > > Commit-Queue: My Nguyen <myy@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#951260} > > Bug: 471146 > Change-Id: Ide0a3b124736513871afa9e7be81faa611072847 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338759 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951594} Bug: 471146 Change-Id: Ia3ca62dbe13fc438414f594b5e73c2f6c47a30b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339577 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Owners-Override: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951691}
-
Make build/android presubmit checked with pylint-2.7
Changed from pylint 2.6 to 2.7. Also, removed disabled warnings because this is now pylint-2.7. Bug: 1262303 Change-Id: I277e5936f02b8a4892ab016c03f1e81a0fe41977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325707 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#951694}
-
Remove testonly=enable_weston_test
* Introduce two separate weston_test targets, one for test_ash_chrome and another for the rest and explicitly link one of them. Bug: b/199337060 Change-Id: Ib1425c65169539d67625c59361b1108b83dfedba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337683 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/main@{#951695}
-
Use relevant realm for self.reportError and self.structuredClone.
Bug: 1279558 Change-Id: Ic62fd79ffe7736a67b7058f9857c412d8d835d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338329 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#951696}
-
Fix web-exposed First Input Delay computation for desktop.
On desktop, when we click, the input event sequence would be pointerdown ,mousedown, pointerup, mouseup. The first input should be the pointerdown. But our current FID computation would regard the mousedown as the first input. And the input delay for the mousedown and pointerdown can be different. This CL is to fix the web-exposed FID by delaying reporting the mousedown until we receive a mouseup. Bug: 1159951 Change-Id: I04f32745558885c6200f779570b6975ca1f4663a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308556 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña <npm@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/main@{#951697}
-
[cast_core] Consolidate browser and renderer targets.
Remove unneeded targets and consolidate browser and renderer source code in 2 targets. Bug: b:210127896 Test: CQ Change-Id: Ia7f04c356a0581c1ba8f70d02c216c92a56a6b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337084 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951699}
-
[cast_core] Refactor CastRuntimeService and build to encpasulate bran…
…ching logic. - CastRuntimeService became a pure virtual interface. - CastRuntimeServiceImpl has the basic implementation. - cast_runtime_service_dummy.cc provides an empty impl for testing. - Targets dispatcher and service targets are consolidated under cast_runtime_service_impl Bug: b:210127896 Test: Local testing Change-Id: Icd0046912ebab1f3cb372725b6f172c6398d9a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337085 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Vigen Issahhanjan <vigeni@google.com> Cr-Commit-Position: refs/heads/main@{#951704}
-
Dictation: Swap in new bubble UI
This change removes the old prototyped UI in favor of the new views-based bubble UI. Dictation uses the accessibility private API to control the visibility and content of the bubble UI. AX-Relnotes: N/A Bug: 1252037 Change-Id: Ib1e049b1750ebe301ac767a55e5b8c32f92c1d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315517 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#951708}
-
[DragDrop] Reduce context menu header image size
Instead of hiding the header image, reduce the image size to 36dp when showing as popup. Bug: 1278877, 1261249 Change-Id: Ie91172d1accff2fb2aa9273b3b79a9c886b124b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331367 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951709}
-
[LR] Fix error handling during asset fetch
The current asset fetching helper for thumbnails and GIFs cannot actually detect fetch errors. It always returns an array of the correct size (with potentially null entries in case of errors), and the Coordinator only looks at the array size to determine whether some assets failed to fetch. This CL makes it so a null asset causes the helper to return a null array, which the Coordinator detects. This CL also fixes a bug where the helper was fetching the thumbnails a second time instead of the GIF asset. This means that the GIFs were not properly being downloaded on feature launch, but rather when they were being added to the scene for the first time. Bug: 1279935 Change-Id: I197aa52848e14cdc68c1e0f210e62ad8c245fd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339103 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by: Sophey Dong <sophey@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951711}
-
Add PredefinedColorSpace enums for HDR canvas
Add PredefinedColorSpace enums for rec2100-hlg, rec2100-pq, and srgb-linear. Add serialization as well. Bug: 1274220 Change-Id: I798d2d2f769f4303755603d60fd9f379f5233477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330816 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#951714}
-
[Harbuzz] Add missing hb-ot-color to sources list
This should hopefully fix a crash in component builds where GTK pulls in the system harfbuzz for hb_ot_color_glyph_get_layers because it was not included in our own. Change-Id: I9f326f5a5f73fdf5782b6e0e2656eaa3781ab91d Bug: 1269346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336506 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#951720}
-
[FedCM] Support AbortSignal to abort a get operation
This allows a RP to cancel a pending get, e.g. when a user clicks a different sign in button. The dialog will close when abort is called. Bug: 1272025 Change-Id: Ibcc92189f493f2b148c1d473a8a836a06a406b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318279 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951721}
-
[fuchsia] Make components_browsertests pass
This adds missing manifest fragments for this test suite and modifies test expectations due to having no system-wide font list implementation on Fuchsia. In addition, that same test is enabled on Android with the same set of expectations as on Fuchsia since it was disabled for the same reason. Bug: 1260529 Change-Id: I2f0bc79a1fb7d75fb9b7491f122363815f23ffe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339815 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Commit-Queue: Fabrice de Gans <fdegans@chromium.org> Cr-Commit-Position: refs/heads/main@{#951722}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.