[pull] main from chromium:main #125
Merged
Commits on Dec 16, 2021
-
Add depth16unorm enum to Blink
Forgot to propagate this change to Blink when finishing up this work in Dawn. Bug: 1279848 Change-Id: I5b25e66780e79d2b2e0d29bffa20fa2e864e56b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345962 Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/main@{#952582}
-
Restore TestWSSExpired on macOS
This was disabled in https://chromium-review.googlesource.com/c/chromium/src/+/2693314. With SpawnedTestServer moved to Python 3, we have TLS 1.2 available. Bug: 1248530 Change-Id: Ief9a8b6419c06cb1a9b8170ca57fc52dc3f904f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344777 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/main@{#952585}
-
Fix ChromiumPerf/mac-m1_mini_2020-perf/blink_perf.css regression
Perf test regression was reported after a CL merged. - CL commit : a3beacb - Regression Bug: https://crbug.com/1279044 - TC : blink_perf.css/PseudoClassSelectors/PseudoClassSelectors.html The regression was from the changes in the CSSSelectorParser. - CSSSelectorParser::ConsumePseudo To fix the performance regression, removed the changes of adding flags to CSSSelector, CSSSelectorParser, SelectorCheckingContext. To set the computed style flags, iterate has argument selector to check whether it contains pseudo in the argument when matching ':has'. This is the perf test result with this change. - pinpoint: https://pinpoint-dot-chromeperf.appspot.com/job/106a0b0ef20000 - result: (8,194.124 -> 8,404.958 : +2.6%) Bug: 1279044 Change-Id: If2cadf3323aac6af59bf39728d691c4f74feba25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338229 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Byungwoo Lee <blee@igalia.com> Cr-Commit-Position: refs/heads/main@{#952586}
Commits on Dec 17, 2021
-
Add kmoon to //chrome/browser/resources/pdf/OWNERS
Adds myself to the OWNERS file for the PDF viewer's JavaScript code. I've been making a lot of changes in this directory, and our team needs additional OWNERS coverage. Change-Id: Idb5512e829e7b2ad653bc8eda241847456a1ec24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346261 Auto-Submit: K. Moon <kmoon@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/main@{#952590}
-
[Fast Pair] Log the result of creating a Gatt connection.
Adds a boolean success metric to log the success or failure from creating a Gatt connection. Change-Id: Ie36b6a8c220b4f4617bab7237d027be02a4b9763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331622 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#952591}
-
media: Fix use-after-free of image to video copy FrameReadyCallback
https://crrev.com/c/3315346 introduced a fallback to ReadYUVPixelsAsync if CopyRGBATextureToVideoFrame fails, but this causes a use-after-free since the FrameReadyCallback is consumed in case of failure and cannot be reused. Morever, the fallback already happens in |blit_done_lambda| in case of failure. Bug: 1278727 Change-Id: Ibbc9fc389da52a31f67f3b3d159cf21b6a0521db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343217 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/main@{#952594}
-
[LayoutNG] Additional allow_first_tier_oof_cache_ constraints
Similar to CL:3331522, we were hitting a case where |allow_first_tier_oof_cache_| was true when handling fragmentation, because |has_block_fragmentation_| was false. To fix this, make sure that |allow_first_tier_oof_cache_| is always false when we handle fragmentation. Bug: 1280620 Change-Id: I86236f1bd21e184d19825a64c873448a90806e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345485 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952597}
-
Handle unsuccessful layout result in UpdateShapeOutsideInfoIfNeeded().
We got a kOutOfFragmentainerSpace status, and then there'll be no fragment generated. Bug: 1278880 Change-Id: Iafaa6ec72b0adf19794acca3b4b05b837f3d11f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344660 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#952598}
-
Speculatively fix TestCertDBChangedFlushesClientAuthCache
I'm not sure yet what's going on with TestWSSClientCert, but this seems the likely cause for TestCertDBChangedFlushesClientAuthCache. The network service may not necessarily have picked up the CertDatabase signal without a flush. Speculative because I was unable to reproduce the flake locally. Bug: 1279930 Change-Id: Ic77ce69f55e6a7c6fbdd82c784f6124adf5a3b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344776 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952603}
-
Revert "[GMNext] Update ThemeColorProvider to use OmniboxTheme"
This reverts commit 16fdb84. Reason for revert: Speculative fix for android-pie-x86-rel failures org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#searchEngineLogo_onTextChanged_noGlobeReplacementWhenUrlBarTextIsEmpty org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#testTemplateUrlServiceChanged org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#searchEngineLogo_isGoogleLogo org.chromium.chrome.browser.omnibox.status.StatusMediatorUnitTest#searchEngineLogo_isGoogleLogo_whenScrolled ...3 more failure(s) (7 total)... Original change's description: > [GMNext] Update ThemeColorProvider to use OmniboxTheme > > This CL updates the icon tint in some classes to follow OmniboxTheme > instead of the simple light/dark tint. It also moves OmniboxTheme out > of chrome/browser/omnibox to be able to use it in classes outside > omnibox/. > > Bug: 1233725, 1114183 > Change-Id: I479854127613ca4bf3f28bf9ad6c79b8d127b877 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307187 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Theresa Sullivan <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/main@{#952457} Bug: 1233725, 1114183, 1280789 Change-Id: I9ee6322d23794cbe961920fd2e2e7975aa316c14 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346112 Owners-Override: Justin DeWitt <dewittj@chromium.org> Auto-Submit: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952604}
-
[Code Health] Remove ListValue::GetDictionary() in chrome/browser/
Bug: 1187091 Change-Id: Ifcd49791c1ceebb6430d8fb09cfae6d281c4327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297469 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#952605}
-
[GTK] Remove log spam when calling g_type_class_unref(NULL)
This occured on GTK4 with the following log spam: [1658612:1658612:1216/155521.116133:ERROR:browser_main_loop.cc(267)] GLib-GObject: g_type_class_unref: assertion 'g_class != NULL' failed R=sky Change-Id: Ifcafcee7fc39503b2ae09c6689e49341200de72e Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346118 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952607}
-
Remove intersitial page related methods from RenderWidgetHostView
These methods were related to overlay interstitials, which have been removed, so they were dead code at this point. Bug: 1077074 Change-Id: I7eb1a6c367552430cf80915b7682d78a81ca9a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342152 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#952608}
-
Linux: Send OSCrypt raw encryption key to the Network Service
This enables NetworkService::SetEncryptionKey() for Linux. See the referenced bug for details on why this is necessary. This will call OSCrypt::GetRawEncryptionKey() in the browser process, send it to the network service via NetworkService::SetEncryptionKey() and finally call OSCrypt::SetRawEncryptionKey() in the network service. This way the network service doesn't require access to KeyStorage, implemented by third party libraries (libsecret, kwallet, etc.), which makes it more easily and reliably sandboxable. This means that starting the network service requires the encrypted key to be retrieved from the platform-specific KeyStorage. So, an os_crypt::Config must already have been set before ever starting the network service. This means modifying the BrowserMainParts of chrome and headless to initialize the config early enough. This also allows us to remove some extra code that initialized os_crypt in the network service with a config, which now is unnecessary. Bug: 1277463 Change-Id: I47c45a818fc579e094520ffbd1368af6a479b37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320484 Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/main@{#952609}
-
clang: Statically link against hermetic libxml2 on non-Windows too
Advantages: - Win and non-Win binaries use the same version of libxml2, so behavior is more similar - lld-link depends on fewer system libraries Bug: 872740 Change-Id: I14d972ba26a4ad45514ee6415226a75ea325b0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330960 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#952613}
-
AngleVulkan: support create from GMB or create with pixel data
Bug: 1264439,1280798 Change-Id: Iefbf177bb6038b8cbb394a8d3e1068c363c1b4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346060 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952615}
-
Bug: 1277748 Change-Id: I5eb78511ac3b0e38a0ba9d4c4e947edc8a10ac70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346110 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#952616}
-
[GMNext] Override android:textColorHint after applying dynamic colors
The dynamic color overlay includes android:text* attributes, so once applied, it overrides our text colors defined in the theme. This makes the hint text color (e.g. text fields) too faint for a11y. So, this CL overrides android:textColorHint once again with the intended color. Bug: 1241971 Change-Id: I5261aa970cd23d6c91c695f5bdeab8d6547bf7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331191 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952619}
-
Revert "[GMNext] Make control_highlight_color dynamic"
This reverts commit 185447e. Reason for revert: Potential culprit of crash Original change's description: > [GMNext] Make control_highlight_color dynamic > > Bug: 1228454 > Change-Id: Ibc5bdec72843ffa122c5687e4819a09a0742801b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327572 > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Theresa Sullivan <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/main@{#952223} Bug: 1228454 Change-Id: I025dfa951ffce584d066811925bbe40b15a1e747 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346404 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952620}
-
The tests were flaky due to the order of the following: PASS successfullyParsed is true See: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=fast%2Fanimation%2Frequest-animation This patch deflakes the directory by converting from js-test to testharness which no longer depends on the successfullyParsed timing. This timing difference may have started with the synchronous html parser (crbug.com/1254921). Bug: 1279124, 1278108, 1275479, 1269956, 1272058 Change-Id: I137f19de17c194640bc0443395f47f1311e4ff95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335322 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#952627}
-
The class web::FakeWebState supports settings the BrowserState returned by GetBrowserState() so the sub-class is not needed. The test was also incorrectly configuring the mock to return a pointer to a deallocated object (as it was stored in a stack allocated std::unique_ptr<T> that was destroyed by the end of the SetUp() method). Since the test do not require GetBrowserState() to return a specific value anyway, just use a web::FakeWebState and do not set the BrowserState. Bug: none Change-Id: Iad9db1661104c0bdeed52473bd24e7724d2c71e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344757 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952628}
-
[ios] Remove obsolete class ToolbarTestWebState
This is a sub-class of web::FakeWebState that only define one method set_loading_progress() which is never called. So replace usage by direct uses of web::FakeWebState and delete the obsolete code. Bug: none Change-Id: I9877674f905f4b885b61fa58cc2660b16898c7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345241 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952629}
-
Small changes to IDL to match the spec. All changes are non-breaking because the impl was already doing the right thing in spite of the IDL. These issues were discovered after my full audit of all webcodecs IDL. There is one lingering issue (EncodedVideoChunkMetadata.temporalLayerId) that is a breaking change and requires an intent to deprecate (will send shortly). Change-Id: I55da3158726a79493e46af9ed862656e655f8e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346324 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#952630}
-
[mojo] Convert AtomicFlag to use C++11 atomics
mojo::core::AtomicFlag was a lightweight wrapper around a boolean- valued atomic word; it was implemented using base::subtle's atomics. Convert from C++ atomics - they're broadly supported and are even used in mojo already. Bug: 1194917 Change-Id: If211f2e1553b8cbcbe7f9541a80b5bcea9bfd21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334956 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Venkatesh Srinivas <venkateshs@chromium.org> Cr-Commit-Position: refs/heads/main@{#952631}
-
[mojo] Convert user_message from base::subtle -> C++11 atomics
g_message_count is a counter used to track the number of messages inflight; it is used in OnMemoryDump for allocator dump data. Convert from base::subtle atomics to std::atomics, which are typed and broadly available. This removes the last user of base::subtle::Atomic* in mojo Bug: 1194917 Change-Id: Ib2c4ba4141554e57e0fc8e7f42c7dd7fb2fad4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345520 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Venkatesh Srinivas <venkateshs@chromium.org> Cr-Commit-Position: refs/heads/main@{#952635}
-
[SelectMenu] Expose selectmenu.labels
This CL exposes selectmenu.labels by marking selectmenu as a labelable element and using HTMLElement::labels. Bug: 1121840 Change-Id: Id7f20d04a340adcbe46d31b0fa1027be8f7c2531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3346106 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952640}
-
Extend all Android.WebView.DevUi.* histograms for a year
All histograms are still relevant to monitor Dev Ui usage and are beneficial for developing any new DevUi features in the future. Fixed: 1265714 Test: N/A Change-Id: I672292d66f13ca885cfa7b02914f3dbaac3100aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345681 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/main@{#952642}
-
When launch chrome with --list-apps switch, we can output open/installed web apps for each profile to a file without launching a new browser window or tab. Pass a absolute file path to --list-apps switch to specify where to output the information. We can also use a optional --profile-base-name switch together to output open/installed web apps only for a given profile. Pass the basename of the profile directory to --profile-base-name switch to specify which profile to get information. Bug: 1259516 Design-Doc: https://docs.google.com/document/d/1fzj-F_exyQxd2mkda5rt9nkI6S4nKeP74wJK5sLB5FI Change-Id: I00f73db43e3b5989850c3bfff743e9312ba5394c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3255221 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/main@{#952643}
-
[Fuchsia] Move FuchsiaMediaResourceProvider out of //media/fuchsia
FuchsiaMediaResourceProvider is used only in WebEngine. Move it to //fuchsia/engine and rename it to WebEngineMediaResourceProvider. Bug: 1271250 Change-Id: I7b617278de965e6831066575848724a68144efd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337399 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952644}
-
[SelectMenu] Add support for reset.
The reset algorithm for selectmenu elements is to go through all the option elements in the element's list of options, set their selectedness to true if the option element has a selected attribute, and false otherwise, set their dirtiness to false, and run the steps to reset the selected option for the selectmenu. To reset the default selected option: - if no option is selected, set the selection to the first non-disabled option if it exists, or null otherwise - if two or more options are selected, set the selection to the last selected option Bug: 1121840 Change-Id: I5fa981c869a75cd933e60d0f0dbc5999ff3223c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343646 Reviewed-by: Dan Clark <daniec@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952647}
-
[PA] Remove obsolete PartitionAllocEverywhereAndPCScan synthetic Finch
Change-Id: Ie5e2a94c195e9a583b386768938c24dc6951e710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338098 Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#952649}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.