[pull] main from chromium:main #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bug: 1261301 Change-Id: I4db5af0ac609c1fd3e5757b35347435c45f65103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324683 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/main@{#950666}
Bug: 1187033 Change-Id: Ia3fae8fd94fdc6343f1466da039d831efc971bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320658 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Auto-Submit: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#950667}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639148198-681ad7395814bd984961e5072af7b7695f99b593.profdata to chrome-win32-main-1639158968-a3623411bbd59aec7fe153b0fb1be440d8fb8ffa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie9e53fa338464c98b37bd6a14432b85a9ba764c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330981 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950668}
This change adds the gpu, blink, cc, v8, and viz tracing categories to all performance test page sets that inherit RenderingStory. These trace categories are specifically relevant for analyzing rendering performance. Bug: 1278501 Change-Id: I9add24abbca9a36ca5be1c6be8d6db98633a1563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328188 Auto-Submit: Justin Novosad <junov@chromium.org> Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/main@{#950669}
…ctly or indirectly call ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin." This is a reland of ef8b0e4 This CL changes the reverted CL by adding nullptr checks before dereferences of FileSystemOperationRunner, which can be become null if the corresponding renderer process terminates before the file system operation is scheduled. After consultation with FileSystemManagerImpl OWNERS, it is safe to simply discard the orphaned file system op in such cases where the requesting renderer is being terminated. Original change's description: > Refactors all FileSystemManagerImpl security checks that directly or > indirectly call ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin. > > Only the Browser UI thread has the necessary data to soundly evaluate > CanAccessDataForOrigin decisions. Therefore, the end goal is to ensure > CanAccessDataForOrigin always executes on the browser UI thread. > > Although all direct & indirect callers of CanAccessDataForOrigin will > eventually need similar refactoring, this CL is an incremental landing; > FileSystemManagerImpl was selected due to its prevalence in test results, > and refactoring will subsequently extend to other subsystems. > > Change-Id: I4eda1355cc879e6731ead32caaad585e899701db > Bug: 1266451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3238053 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Chris Bookholt <bookholt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#947355} Bug: 1266451 Change-Id: I37b9573d2fd0357561619695426219535095b22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318774 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Chris Bookholt <bookholt@chromium.org> Cr-Commit-Position: refs/heads/main@{#950670}
Share Chrome Remote Desktop detection code between system_health and rendering.desktop benchmarks, to avoid the need to explicitly use --allow-software-compositing flag while running rendering.desktop over CRD. Change-Id: I71aa62fc33e353ed60d7b53f0fc1c6a570fc1638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330547 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/main@{#950671}
…SupportTest" This reverts commit efd7df0. Reason for revert: Tests started reliably failing on android-11-x86-rel Original change's description: > [Test] Fix flaky test TosAndUmaFirstRunFragmentWithEnterpriseSupportTest > > This cl replaces the manual view checks with espresso to reduce > flakiness. > > Bug: 1275120 > Change-Id: I900cbb6c4105c6b875ab6d908eed4367aa059a16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320246 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950533} Bug: 1275120 Change-Id: Iea5670c2caf3389480ccdfdef5001a0ecd022019 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331365 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Patrick Noland <pnoland@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/main@{#950672}
The comments for PostIdleTask and PostDelayedIdleTask both indicate they
can be called from any thread, but there is a thread-check in
IdleHelper::IdleTaskRunner(), preventing idle tasks from being posted to
the main thread from background threads.
The code for these methods was *mostly* thread-safe, e.g. using
thread-safe ref counting and deferring delegate callbacks via posting a
task when necessary, but PostDelayedIdleTask was not thread-safe because
of how pending tasks were queued locally.
This CL does the following to enable idle tasks posting from multiple
threads:
- Remove the thread check in IdleHelper::IdleTaskRunner()
- Defer (via PostTask) queueing the delayed idle task if called
cross-thread
- Use WTF::CrossThreadBindOnce instead of WTF::Bind in V8IdleTaskRunner
(this fix is to enable a V8 feature, so these some v8 idle tasks will
be cross-thread)
- Add unit tests for cross-thread posting
Bug: 1276997
Change-Id: I408daa3ab737844831a0a38ce4996111204b1410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322137
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#950673}
https://chromium.googlesource.com/catapult.git/+log/6abf7c8c4c7f..70bcf59d8db3 2021-12-10 wenbinzhang@google.com [pinpoint] do not try to get commit position when hash is empty If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC ddrone@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1278382 Tbr: ddrone@google.com Change-Id: I8deb2409938569746e66ced367ecc7eb851fe964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330936 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950674}
Bug: 1263610 Change-Id: Id7a935e92ae9bc2a51696f1e4e812ccf23a406cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329662 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#950675}
Python2 didn't handle the supbprocess.check_outputs correctly because python3 changed the return type to bytes, from string encoded bytes. Change-Id: Ifa3f59e99ab5eaab31bf59897e08dd3be53af341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307752 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/main@{#950676}
Bug: 1252004 Change-Id: Ibf439502fafc0cef0cc61e56a35b26315ed95aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330968 Owners-Override: Dominique Fauteux-Chapleau <domfc@google.com> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by: Chong Gu <chonggu@google.com> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#950677}
This instruments cc code with DCHECK(IsMainThread()) and
DCHECK(IsImplThread()) to ensure methods are only called on the
appropriate thread. The enforcement is focused on Layer, LayerTreeHost,
and AnimationHost, since these are the classes that drive compositor
commit.
Adding the DCHECKs required SingleThreadProxy to be more systematically
annotated with DebugScopedSetMainThread and DebugScopedSetImplThread.
In particular:
- All Proxy method overrides now DCHECK(IsMainThread())
- All SchedulerClient method overrides now
DCHECK(!HasImplThread() || IsImplThread())
- All LayerTreeHostImplClient method overrides force the impl thread
In places where SingleThreadProxy code conceptually jumps the thread
boundary (e.g., by interleaving method calls on LayerTreeHost and
LayerTreeHostImpl), the code is annotated to force main or impl thread
as appropriate.
Bug: chromium:1255972
Change-Id: Ib7a05227e9e63e6bcb33ce2beebf53951f1d1352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312881
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#950678}
As virtual cards contain abstracted data, this CL fills obfuscated dots for credit card form fields (CC number, Exp Month/Year, CVC, etc). The main code changes were editing FieldFiller.cc with logic for returning various dot formats for Virtual Cards and implementing event handling logic to preview virtual cards. Screenshot: https://screenshot.googleplex.com/4oqWLWTt9NyzhWn.png VCN M1b Chrome Client DD: https://docs.google.com/document/d/1z_Jnjs__kpnrtg8zGxdtEXV3KQ_6oLuQI1xP379TJ4c/edit?usp=sharing&resourcekey=0-QgWKy_TxMiPEDZ0ijyThiA Change-Id: I661c40afd220e4abc3d45819a686a2f9f1e22163 Bug: b/200991167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183082 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Siyu An <siyua@chromium.org> Reviewed-by: David Jean <djean@chromium.org> Reviewed-by: Christoph Schwering <schwering@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Alexander Tekle <alexandertekle@google.com> Cr-Commit-Position: refs/heads/main@{#950679}
What: After the document is destroyed, the worklet will live until 2 seconds after, or when the outstanding operations are all completed, whichever occurs first. Why: end-of-page operations are more likely to finish. How: keep 2 types of hosts in SharedStorageWorkletHostManager: "attached" and "keep-alive". When the document is destroyed, the one in the "attached" group will be either removed, or be moved to the "keep-alive" group accordingly. The keep-alive host will be removed from its group 2 seconds after, or when the worklet's outstanding operations are all completed, whichever occurs first. Design doc: https://docs.google.com/document/d/1rH6m4SS5QsUTsh9VBGIQecs1Y0PWEF9qFBTqYRqQ7-c Bug: 1218540 Change-Id: Ied26d33c80f53498b8419d50a62b1f137d565971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244721 Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#950680}
Roll Chrome Mac PGO profile from chrome-mac-main-1639137509-752a12a20648290cd0d533cdd50037acb4be801c.profdata to chrome-mac-main-1639158968-9c4955c4f4cfe7457f24c76f8234a10f17d9496a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I99489fd2635af1a8249157730e9f352422922cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330980 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950681}
All clients of these files have already been migrated. Also fixing a few cases where some TS files where accidentally included in the generated grd file, along with the transpiled JS file. Bug: 1189595 Change-Id: I61021468df9f34d6d278342fc65f3d57683e059d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330236 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#950682}
Bug: 1278535 Change-Id: I1f2af93f9993d0f55bc6d15bd95d60a49988579c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330325 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#950683}
This was a tryjob that was doing performance tests for gvisor support. It is no longer needed, and it is potentially having problems due to the obsolete buildspec clean up from a couple days ago. Bug: n/a Change-Id: I92e60d1c2f7fe266286c79ea285cbffccc2421c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330736 Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Michael Savigny <msavigny@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#950684}
https://skia.googlesource.com/skia.git/+log/4d35c0d31d79..0f2390f7fbb4 2021-12-10 herb@google.com move SkRemoteGlyphCache.h to private 2021-12-10 johnstiles@google.com Improve debug trace generation speed by clipping the paint. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Id7f05be696a62d5a63ff66f5901d97d30efc6d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331199 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950685}
…4.1-r1 to 98-4729.0-1638787322-benchmark-98.0.4754.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icc77f3ee70e2b9ff8dc51c7040882a77cbaf2f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330618 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950686}
https://chromium.googlesource.com/angle/angle.git/+log/f7d92a32f1b2..66e1fb86e935 2021-12-10 jmadill@chromium.org Trace Tests: Ensure zillow runs on SwiftShader. 2021-12-10 abdolrashidi@google.com Update the arg types for glMultiDraw*IndirectEXT() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I590b7276987ec5989e654e49521defd8ce71cf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331203 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950687}
In addition to making it clear which fields are relevant to the test, this allows us to add new fields to StorableTrigger without having to update the test and get owner approval. Change-Id: I4a69ee86ef9b8001e05f107c7de65cb3e5c19bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330596 Auto-Submit: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/main@{#950688}
Updated a few files to support clearing the key registry if upload fails during key creation Bug: b/208997566 Change-Id: Ica136a87d33b2771a6979e7c3084686321ea8282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322206 Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Hamda Mare <hmare@google.com> Cr-Commit-Position: refs/heads/main@{#950689}
Addresses comments from crrev/r/3318749 Bug: 1198187 Change-Id: Ib5178bf71d336158aeb4723de76cf813d6840543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331258 Commit-Queue: Gavin Dodd <gavindodd@google.com> Auto-Submit: Gavin Dodd <gavindodd@google.com> Reviewed-by: Gavin Williams <gavinwill@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#950690}
As much as we believe that PCScan experiment wouldn't be biased by disabled-but-*-way-split modes of BRP experiment, there is a slight chance that it would. Adding PCScan_Effective_Fallback just in case, which ignores those modes entirely. Looking at the design and cl/414999087 (internal only), PCScan_Effective compares groups (A1+C1+E1+F1) vs. (A2+C2+E2+F2), whereas BackupRefPtr_Effective_Fallback compares only (A1+F1) vs. (A2+F2). Using BackupRefPtr_Effective_Fallback is far from ideal, because it limits the tested population to 2*14%, from 2*32%, but nice to have a fallback. [1] https://docs.google.com/document/d/1HJsFHpvi2V84suIao6WW41TLc36ZoMR6pmSanI6E7rk/edit Bug: 1278582 Change-Id: I44e6219e869cbecd7fab3e0f29a55120036b4fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329052 Reviewed-by: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Weilun Shi <sweilun@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/main@{#950691}
Add extensions::Manifest::FindIntPath but there are no callers now. Bug: 1187034 Change-Id: I543a6e8c513764be9705acc3aaeaf93e3e6cd53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320691 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Auto-Submit: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#950692}
After this, `diff -qr out/gn1 out/gn2` doesn't find any difference after running `rm -rf out/gn1 out/gn2; gn gen out/gn1; gn gen out/gn2`. I arbitrarily chose to make the paths relative to the directory containing the file. Another option would have been to make them relative to the build directory (and access that via os.getcwd() in mojom_parser.py). Both seem equally good to me. No intended behavior change. Bug: 1278777 Change-Id: I20cddd7e155110c0e2e73410564d1a70a5d777b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330578 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/main@{#950693}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: Id8528052a316a9da060872471b3a6ed5785b032f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330166 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950694}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c143d95b..8a05d7ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67496474f2952c4b0a9997f49a45bf5caea8f9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330332 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950695}
This CL implements change to add SetupFrameParams() function, which is a helper function to setup per frame parameters in |v4l2_frame_params| needed for VP9 decoding with VIDIOC_S_EXT_CTRLS ioctl call. This functionality is moved from DecodeNextFrame() function and no functionality change is intended with this change. Bug: b:202214561 TEST: v4l2_stateless_decoder --video crowd_run_256X144_fr15_bd8_8buf_l1_20210312.ivf --frames=1 on asurada Change-Id: I6e3358f414430d9287873ae07241c6d63db3ce72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322064 Reviewed-by: Miguel Casas-Sanchez <mcasas@chromium.org> Commit-Queue: Steve Cho <stevecho@chromium.org> Cr-Commit-Position: refs/heads/main@{#950696}
Prints the value of the error on failed Gatt connection. Change-Id: I8d90de878273ce4c4ea7fa69d9feaf2b5ec8b45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331187 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/main@{#950697}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7903d928a3e..41f9fb09d9c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chonggu@google.com,domfc@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: chonggu@google.com,domfc@google.com Change-Id: I944fe9e1d3de4c4a0bb8de9df793f75ceed1f067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331396 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950698}
The order of the comment lines got inverted. Change-Id: I3cde8661d0eaa43dcab6efee89f6c3faf350fca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323724 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Kevin Radtke <kradtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#950699}
shared_image_backing_ozone::ProduceOverlay can be called more than once per backing so moving the pixmap would trigger a segfault at the next run. Change-Id: I40b4ca227c2be8c8f91b295a35823bae130178d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330322 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Lucas Berthou <berlu@chromium.org> Cr-Commit-Position: refs/heads/main@{#950700}
Bug: 1276259 Change-Id: I01f86b3b4e737e7267e2ff312d12fa62a145d272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330923 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#950701}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
pull bot
pushed a commit
that referenced
this pull request
Mar 18, 2023
…1 commit) https://chromium.googlesource.com/external/github.com/chromium/content_analysis_sdk.git/+log/dc9f53c343bd..dbcaea90641f $ git log dc9f53c34..dbcaea906 --date=short --no-merges --format='%ad %ae %s' 2023-03-17 roger Use a pipe protected namespace name (#82) Created with: roll-dep src/third_party/content_analysis_sdk/src Bug: b:272773196 Change-Id: I2195377d24a35ff3c6a1ebf84aefdefe929b7918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348078 Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118812}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )