[pull] main from chromium:main #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Roll Chrome Linux PGO profile from chrome-linux-main-1639353226-638c82e86f980a18b2a0146532932c8a08737349.profdata to chrome-linux-main-1639393722-aa212daae172c79e8083ab81c95cb6a0c3b2a1f0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib6529a6f4a77c389f933f58605f7e3a88a59de98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334712 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951028}
We can't really tell for sure, before generating the layout box tree, whether an element is going to create a multicol container or not (which isn't surprising, but somehow I thought it was worth a try). This is a partial revert of CL:3320292. This part isn't really important anymore, because CL:3323072 works around the same issue, and also because LayoutNGBlockFragmentation is now enabled for testing. Note that the new test would only crash if LayoutNGBlockFragmentation is disabled (but not anymore). Bug: 1278531 Change-Id: I80e041a076541636be7c4a7e44c0ac91805efba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329901 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951029}
Otherwise UncheckedMalloc() will crash rather than returning nullptr. Bug: 1279371 Change-Id: I628efe3080d9015de37978dd7d1ec84d541d7101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334776 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951030}
Opting for changing the expectations at this stage, too, with the hope that I can switch it back on when https://crrev.com/c/3334543 lands. R=tvanderlippe@chromium.org Bug: 1278738 Change-Id: I533d20803f18b8ea8e08025a3f192dde2366114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334578 Auto-Submit: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/main@{#951031}
Uses of Value::DeepCopy() have been replaced with Value::Clone(), wrapped with base::Value::ToUniquePtrValue() when necessary. Bug: 1187012 Change-Id: I7abe4b9d9554269d9b92ec05966f906fbfcd5eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320018 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Maksim Sadym <sadym@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951032}
Moves the TextFragmentAnchor histogram definitions out of the other/ directory into the content_creation/ directory. Also extend expiration date and add chrome-shared-highlighting@ as owners Fixed: 1272660, 1272661, 1272662, 1272663, 1272664, 1272665, 1272666, 1272667, 1272668, 1272669, 1272670, 1272671, 1272672, 1272673, 1272674, 1272675, 1272676, 1272677, 1272678, 1272679 Change-Id: I3cf7dc64dcc47fd1b49752c1078d6cf00725159d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330591 Reviewed-by: Nick Burris <nburris@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951033}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/784f3c36176c..0e3067f96d33 2021-12-13 aerotwist@chromium.org Remove patchColorText from TickingFlameChart 2021-12-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-12-13 szuend@chromium.org [cleanup] Remove explicit any usage in OverlayModel.ts 2021-12-13 szuend@chromium.org [cleanup] Use 'void' for callback return types in DOMModel 2021-12-13 szuend@chromium.org [cleanup] Remove unnecessary Closure-style casts 2021-12-13 tvanderlippe@chromium.org Fix deps for ui/legacy/components/utils 2021-12-13 aerotwist@chromium.org Add caching to ThemeSupport.getComputedValue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1172300,chromium:1278738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie806e64e1cacdc7fb64765e6a7e3bcc5a1d31303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334704 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951034}
It is unused, and has a non-trivial cost in terms of code complexity. This CL removes the runtime cost of it, but leaves the code in place. It also adds an assert to make sure it is not used. Bug: 1277519 Change-Id: Icc29d89de0a509f308c94ceb8dfb858c43e69b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320218 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951035}
This CL removes duplicate uses of the NtQueryObject system call and replaces them with common functions. Bug: 1270309 Change-Id: Ie15e2547235ac8700d32c5fe2e371c95f85c0491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327958 Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/main@{#951036}
…ted. The replication was based on GetParent. Through audit this code really should be calling GetParentOrOuterDocument to ensure that a fenced frame doesn't update the stored name. BUG=1264911 Change-Id: Ica0c70f23f65b350a0f394d39f6b399c8bcb12c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330482 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951037}
This CL also adds a new flag for apk_operations.py's logcat command: --exit-on-match which takes a string and passes that into re.search to match parsed logcat messages. When a match is found, then logcat exits. This new feature allows benchmark.py to specify a log message that it can search for and exit when the app is sufficiently far along in its startup. For the initial version of this benchmark it waits until the native library is done loading and the "Successfully loaded native library" string is found in a logcat message. An emulator with API level 28 was selected to use as an install target and fast_local_dev removed as an option. This simplifies benchmark.py calls and uses a consistent set of GN args for all benchmarks (with the addition of target_cpu when the emulator is used). benchmark.py now distinguishes between incremental build-only benchmarks and incremental build & install benchmarks. Most non-python-script changes are build only. Example output: $ tools/android/build_speed/benchmark.py all_incremental Summary (using build server; not using emulator) gn args: target_os="android" use_goma=true incremental_install=true target: chrome_public_apk gn gen: 6.5s chrome_java_nosig: 30.3s avg (31.3s, 29.2s) chrome_java_sig: 48.2s avg (49.0s, 47.5s) chrome_java_res: 31.4s avg (28.5s, 34.3s) module_java_public_sig: 61.6s avg (60.7s, 62.6s) module_java_internal_nosig: 18.4s avg (18.4s, 18.5s) base_java_nosig: 22.9s avg (23.6s, 22.1s) base_java_sig: 157.5s avg (157.3s, 157.8s) $ tools/android/build_speed/benchmark.py all_incremental --use-emulator Summary (using build server; using emulator) gn args: target_os="android" use_goma=true incremental_install=true target_cpu="x86" target: chrome_public_apk gn gen: 6.2s chrome_java_nosig: 49.8s avg (49.4s, 50.1s) chrome_java_sig: 66.0s avg (64.9s, 67.0s) chrome_java_res: 48.0s avg (47.1s, 48.9s) module_java_public_sig: 79.0s avg (81.0s, 77.0s) module_java_internal_nosig: 30.9s avg (30.4s, 31.4s) base_java_nosig: 36.9s avg (36.6s, 37.2s) base_java_sig: 167.6s avg (168.0s, 167.1s) Bug: 1254718 Change-Id: I13790a4ad727c455d27da12a2509175b06f84f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328322 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/main@{#951038}
I have passed the metrics quiz. Change-Id: I3c3e682b4d40ed3a78eb438b53eca69ef532bce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330436 Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#951039}
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I13418ed3388df6561142c8da49720e86438c9888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323055 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951040}
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I178bde749230e56fe825013a7cceb2d7713efb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334996 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951041}
The TabSharingUIViews could be rewritten so that it used PrimaryPageChanged to recreate the infobars. BUG=1218946 Change-Id: I30e80d4639b3a112d497df7300e535c09e505199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330477 Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951042}
The BrowserContext is directly available from the RenderFrameHost. Just use that. Change-Id: Ic698e8e4a8d3d55ca752c2742ad1b5239440902b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330966 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951043}
This is a preparation work for aggregate attribution API to use template for reports. Bug: 1209299 Change-Id: I32409d5941029af6c0bfc920ff32b01233b1c135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330327 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#951044}
Some files were missing but they shouldn't affect the test, but ensure they are in case they are the cause for some flakiness. BUG=1264911,1278823 Change-Id: I821e75b75ea771f06a4624617291c5582d900faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330326 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951045}
Both of these may be useful for some disk cache sandboxing work. Also move HttpCache histograms out from others/ to net/, as I received a note requesting me to reduce the others/ footprint, and net/ seems appropriate for things in net/http/http_cache* Bug: 1268037 Change-Id: Idaf61c4dce1bb09b8230f9e9807b3fd3111782e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328561 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#951046}
Bug: 1279373 Change-Id: I273008d1bba1f8428fb71b72dbef3ee248aa1a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329894 Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Sean Harrison <harrisonsean@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/main@{#951047}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202112130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uwAu1UD0oDj17zqx0Af0wZnVecasHn1pBC4V6A3JBRwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Iaeed9021aa15f5fe3d37d098bd4d3160742e12f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334709 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951048}
Bug: 1279417 Change-Id: Ia5e624bf2c8dd2f39b4f2a67468e4ba2f15bc586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334941 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#951049}
https://android.googlesource.com/platform/external/perfetto.git/+log/44638d7a4268..1302b4259684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I60bbae9de6a6921e69c14091b15ea999a3f0485f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334938 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951050}
This config is currently a plain struct, capable of containing arbitrary strings and booleans. This change makes it a proper class that can only be constructed from a valid DoH URI template, exposing a boolean flag derived from that value. This arrangement is safer, and also simplifies the data model. Bug: 1200908 Change-Id: I8176aedf11d5525afdb2ad27bc2b2b56e0ed912d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3232598 Reviewed-by: Eric Orth <ericorth@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/main@{#951051}
skeleton_generator_ may be null if uspoof_open fails in IDNSpoofChecker. This CL adds null checks before dereferencing this pointer. Bug: 1278875 Change-Id: I8a3766507609fe0aeb3b56b0e016c7ec869bcf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331375 Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951052}
Blink_web_tests - There's not enough resources for blink_web_tests and the baseline bot, so set to 0 net_unittests, interactive_ui_tests, crashpad_tests set to 100 Bug: 1249985 Change-Id: I295681fa0f3fa331b9e06ef2f418ce048939074a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328849 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/main@{#951053}
Implement a history data source. It will be used across platforms for getting last visited information for page info history section. The data source returns a timestamp and the UI can use a static format function to get "Last visited X" string. In this CL, the data source is used for desktop only. It will be used on Android in a follow-up CL. A flag for the history section on Desktop is added. An entry in about flags will be done in a follow up CL. Bug: 1275042 Change-Id: Id12ad558ed2dc5db5563ecc063d896e2b346b123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299233 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/main@{#951054}
Bug: 1279339 Change-Id: Ia38e7b5571972a7b2f81ed2859b5391c2578e94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320284 Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by: Renato Silva <rrsilva@google.com> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Osama Fathy <osamafathy@google.com> Cr-Commit-Position: refs/heads/main@{#951055}
Currently, the chip icon for continue section files uses FileUtil::GetChipIconForPath if the Dark/Light mode is disabled. For the icon to look up to spec without theming, the chip icons needs to fetch from FileUtil::GetIconForPath. Bug: 1276239 Change-Id: Ibb3c466e4b2f16c76ed1e7a9f67e7eec2f075dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331255 Reviewed-by: Rachel Wong <wrong@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951056}
BrowserContext::NotifyWillBeDestroyed needs to be called before BrowserContext::ShutdownStoragePartitions(). Bug: b/209931399 Change-Id: I433cc4d72e27ccc9a33bf315f43c30d0177f0bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327606 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#951057}
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202112130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/Hm4ipUPiXd-gzWDEbyraNGipQikDIbxi1Xc70s6BwWQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I5fd96feee03ea08279157f0ce4769e6c866ea619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334708 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951058}
Bug: 1277783 Change-Id: Iaba115010ea9e313d865b4afbebb66cc9f57c626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321089 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#951059}
Adds a flag that enables or disables the WARN path in the CheckScreenShareRestriction() and CheckRunningScreenShares() methods, as the integration was not fully completed for M-98. Bug: 1279045 Change-Id: Ib47017fb6820dcd6affdf4bf2085aceb6f6f4fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329896 Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aida Zolic <aidazolic@chromium.org> Cr-Commit-Position: refs/heads/main@{#951060}
This is to allow making CUP an interface and adding mocks in https://crrev.com/c/3310643 Bug: b/203031699 Change-Id: I869e25d283835e04b03fe76232463d5b14f0aa60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329841 Reviewed-by: Luca Hunkeler <hluca@google.com> Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sergio Vila Prado <sergiovila@google.com> Cr-Commit-Position: refs/heads/main@{#951061}
Failing build: https://ci.chromium.org/ui/p/chromium/builders/ci/3pp-linux-amd64-packager/1161/overview Bug: None Change-Id: Ic586d040b150588534738b723ae2a8866ad59164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330111 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/main@{#951062}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I2716cbcdd5263205dbd3beba04fbb863c385a3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334710 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951063}
Add a new directory, and move scoped_profile_keep_alive.{cc,h} and
profile_keep_alive_types.{cc,h} into it. Give the directory its own
OWNERS file.
Update #includes of these .h files.
AX-Relnotes: n/a
Change-Id: I79024be3a29ea53d29cda6ebd171362f26f8e9b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327965
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951064}
If on windows, you can run with `api=uia` or `api=ia2`. Change-Id: I7780bf5ec063ea9223b521df16a048a24140b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3260556 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#951065}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639393722-82dcf221613d7b4d01216e6db3d83371803c5ada.profdata to chrome-win64-main-1639407500-00d9293c4ab7558a9da7eab4d58568a0a8d997b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie6e566653272803a0238d148bf53133a29fa0a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334939 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951066}
https://android.googlesource.com/platform/external/perfetto.git/+log/44638d7a4268..1302b4259684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I657633d762a685d035a2dd2024e1680617934655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334698 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951067}
CardifiedAnimatorObserver may not be destroyed if a cardified animation gets cancelled. This could happen when the app list is dismissed while dragging an app. To avoid memory leaks, transfer the ownership of all CardifiedAnimationObservers to the PagedAppsGridView. Bug: 1276658 TEST: ash_unitests reports no leaks Change-Id: I3a192d8f85627fdf370571d4f7be91f56b77d498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324985 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951068}
Follow up change for the CL https://crrev.com/c/1911347 where was broken original logic of the visited_copy usage. Bug: 981423 Change-Id: I879041fe437563683f057066d135d4468865f256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327206 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Ivan Murashov <ivan.murashov@lge.com> Cr-Commit-Position: refs/heads/main@{#951069}
Automatic update for 2021-12-13 UTC Change-Id: I2cdd5dff8d6683598d2fab16657134382f2e0e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334838 Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Cr-Commit-Position: refs/heads/main@{#951070}
This CL moves enabling thread cache after we have a big picture of what partitions are running, and which Finch flags are enabled, so we know exactly which partition should have the cache enabled (there can be only one). This improves the ordering in crrev.com/c/3320708. It left things in the in-between state, leading to enabling thread cache in two different locations and checking PCScan enabled-ness in two different locations. Bug: 1278582 Change-Id: I2da55d9e08630bb0d8dfc61f7150624eb87bca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334716 Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#951071}
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f773c1b06736..fff14ebdcbb0 2021-12-13 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-11 rchandrasekar@google.com signing: Use inclusive language texts 2021-12-11 rchandrasekar@google.com tests: Use inclusive language texts 2021-12-10 hardtmad@google.com LTS kernel pinning: pin LTS kernel version using stable tag 2021-12-10 saklein@chromium.org Build API: Documentation Updates 2021-12-10 saklein@chromium.org sysroot_lib: Add overlay properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I40be349cd023639d4f23b1f4783d7a78f6a3eca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334715 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951072}
As a result the dependency object stays valid even if the WebContents change which is the case in the UiController. Without this change when the UiController updates WebContents we could not be sure that the activity-related dependencies stayed the same. Bug: b/173103628 Change-Id: I20f349b92eb8c8833671a552f45312a1df7d4f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326941 Auto-Submit: Florian Gauger <fga@google.com> Reviewed-by: Clemens Arbesser <arbesser@google.com> Reviewed-by: Sandro Maggi <sandromaggi@google.com> Commit-Queue: Florian Gauger <fga@google.com> Cr-Commit-Position: refs/heads/main@{#951073}
Currently, we only emit values into the Avg histograms when the capacity counter value changes. However, this has the effect that non-drops in short sessions or towards the end of a longer session aren't recorded. Instead, when recording stops because the app leaves foreground or is connected to a charger and the counter value didn't change, also record an appropriate number of 0 values into the Avg histograms. Bug: 1102048 Fixed: 1279413 Change-Id: I515c6899ef52fac31532ba28fc7ef6cfd83a62bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323193 Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/main@{#951074}
This parameter can be used by callers to get informed of the result of the rotate key request. Bug: b/202431075 Change-Id: I61cda213bca6d8fc102fe453906f869fe8815545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327283 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/main@{#951075}
Bug: 1275890 Change-Id: I7c302dfe1722881efd7f2fa182e253524ba6ea33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332838 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/main@{#951076}
With the launch of CompositeAfterPaint, this function is no longer used. Selection is now updated via PaintArtifactCompositor. Bug: 1277748 Change-Id: Id16b3c38f913354e009f58d43a67ff811682f0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331496 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951077}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )