[pull] main from chromium:main #103
Merged
Commits on Dec 13, 2021
-
Always assume that non-auto 'columns' might create a multicol.
We can't really tell for sure, before generating the layout box tree, whether an element is going to create a multicol container or not (which isn't surprising, but somehow I thought it was worth a try). This is a partial revert of CL:3320292. This part isn't really important anymore, because CL:3323072 works around the same issue, and also because LayoutNGBlockFragmentation is now enabled for testing. Note that the new test would only crash if LayoutNGBlockFragmentation is disabled (but not anymore). Bug: 1278531 Change-Id: I80e041a076541636be7c4a7e44c0ac91805efba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329901 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951029}
-
Switch off console-format-style.js
Opting for changing the expectations at this stage, too, with the hope that I can switch it back on when https://crrev.com/c/3334543 lands. R=tvanderlippe@chromium.org Bug: 1278738 Change-Id: I533d20803f18b8ea8e08025a3f192dde2366114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334578 Auto-Submit: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/main@{#951031}
-
[Code Health] Remove uses of Value::DeepCopy()
Uses of Value::DeepCopy() have been replaced with Value::Clone(), wrapped with base::Value::ToUniquePtrValue() when necessary. Bug: 1187012 Change-Id: I7abe4b9d9554269d9b92ec05966f906fbfcd5eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320018 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Maksim Sadym <sadym@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/main@{#951032}
-
Move TextFragmentAnchor histograms to content_creation folder + extend.
Moves the TextFragmentAnchor histogram definitions out of the other/ directory into the content_creation/ directory. Also extend expiration date and add chrome-shared-highlighting@ as owners Fixed: 1272660, 1272661, 1272662, 1272663, 1272664, 1272665, 1272666, 1272667, 1272668, 1272669, 1272670, 1272671, 1272672, 1272673, 1272674, 1272675, 1272676, 1272677, 1272678, 1272679 Change-Id: I3cf7dc64dcc47fd1b49752c1078d6cf00725159d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330591 Reviewed-by: Nick Burris <nburris@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951033}
-
Ensure that if a fenced frame changes its name it doesn't get replica…
…ted. The replication was based on GetParent. Through audit this code really should be calling GetParentOrOuterDocument to ensure that a fenced frame doesn't update the stored name. BUG=1264911 Change-Id: Ica0c70f23f65b350a0f394d39f6b399c8bcb12c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330482 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951037}
-
Metrics: Add tsergeant@ as owner for 'chromeos' histograms
I have passed the metrics quiz. Change-Id: I3c3e682b4d40ed3a78eb438b53eca69ef532bce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330436 Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#951039}
-
[DevTools] Migrate WebIDBCallbacksImpl to use AsyncTaskContext
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I13418ed3388df6561142c8da49720e86438c9888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323055 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951040}
-
Rewrite DidFinishNavigation to PrimaryPageChanged.
The TabSharingUIViews could be rewritten so that it used PrimaryPageChanged to recreate the infobars. BUG=1218946 Change-Id: I30e80d4639b3a112d497df7300e535c09e505199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330477 Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951042}
-
Do not lookup WebContents to retrieve BrowserContext.
The BrowserContext is directly available from the RenderFrameHost. Just use that. Change-Id: Ic698e8e4a8d3d55ca752c2742ad1b5239440902b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330966 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951043}
-
[attribution_reporting] Convert AttributionReport to class
This is a preparation work for aggregate attribution API to use template for reports. Bug: 1209299 Change-Id: I32409d5941029af6c0bfc920ff32b01233b1c135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330327 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#951044}
-
Add fenced frame resource files.
Some files were missing but they shouldn't affect the test, but ensure they are in case they are the cause for some flakiness. BUG=1264911,1278823 Change-Id: I821e75b75ea771f06a4624617291c5582d900faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330326 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951045}
-
Lookalikes: Check if skeleton_generator_ is null before derefing
skeleton_generator_ may be null if uspoof_open fails in IDNSpoofChecker. This CL adds null checks before dereferencing this pointer. Bug: 1278875 Change-Id: I8a3766507609fe0aeb3b56b0e016c7ec869bcf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331375 Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951052}
-
[Autofill Assistant] Rename CUP to CUPImpl
This is to allow making CUP an interface and adding mocks in https://crrev.com/c/3310643 Bug: b/203031699 Change-Id: I869e25d283835e04b03fe76232463d5b14f0aa60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329841 Reviewed-by: Luca Hunkeler <hluca@google.com> Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sergio Vila Prado <sergiovila@google.com> Cr-Commit-Position: refs/heads/main@{#951061}
-
ax_dump_tree: support different APIs on windows
If on windows, you can run with `api=uia` or `api=ia2`. Change-Id: I7780bf5ec063ea9223b521df16a048a24140b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3260556 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#951065}
-
[PA] Enable thread cache after ConfigurePartitions
This CL moves enabling thread cache after we have a big picture of what partitions are running, and which Finch flags are enabled, so we know exactly which partition should have the cache enabled (there can be only one). This improves the ordering in crrev.com/c/3320708. It left things in the in-between state, leading to enabling thread cache in two different locations and checking PCScan enabled-ness in two different locations. Bug: 1278582 Change-Id: I2da55d9e08630bb0d8dfc61f7150624eb87bca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334716 Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#951071}
-
power: Emit zero values into avg Power.ForegroundBatteryDrain histograms
Currently, we only emit values into the Avg histograms when the capacity counter value changes. However, this has the effect that non-drops in short sessions or towards the end of a longer session aren't recorded. Instead, when recording stops because the app leaves foreground or is connected to a charger and the counter value didn't change, also record an appropriate number of 0 values into the Avg histograms. Bug: 1102048 Fixed: 1279413 Change-Id: I515c6899ef52fac31532ba28fc7ef6cfd83a62bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323193 Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by: Bo Liu <boliu@chromium.org> Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/main@{#951074}
-
Use the new added GrContextOption to control glyph padding
Bug: 1275890 Change-Id: I7c302dfe1722881efd7f2fa182e253524ba6ea33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332838 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/main@{#951076}
-
Remove LocalFrameView::UpdateCompositedSelectionIfNeeded
With the launch of CompositeAfterPaint, this function is no longer used. Selection is now updated via PaintArtifactCompositor. Bug: 1277748 Change-Id: Id16b3c38f913354e009f58d43a67ff811682f0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331496 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951077}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.