forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from chromium:main #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roll Chrome Win32 PGO profile from chrome-win32-main-1639331466-5c803cc8a9edb68d8d73980f448c8098fcce669d.profdata to chrome-win32-main-1639342255-b07c3352f531634d3e27514a3f576f233cb17a72.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I036a54499ea69fc244a11d5d90748e4397b23eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333957 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950895}
ListValue::Set() is deprecated. I will be sending small CLs to avoid merge conflicts. Bug: 1187066 Change-Id: Iafd65e8df57e6c3dfe97c0337d508e6d5af76e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327424 Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/main@{#950896}
…osition." This is a reland of 1a101a3 Changes from the original: Keeping the original method for backwards compatibility. Original change's description: > ime: Add extra arg to SetComposition to indicate the cursor position. > > Certain IMEs need to control where the cursor is in the composition. > For example, pressing the arrow keys on Zhuyin will allow the cursor > to move without disrupting the composition. This is currently not > possible, as SetComposition always places the cursor at the end. > > Add a new argument to the SetComposition Mojo API that indicates where > the index should be placed. > > Bug: b/151884011 > Change-Id: I7216015732a52c55053e4c8fee8f9f26f383d26c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301566 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#946317} Bug: b/151884011 Change-Id: I03801953b98cd9a234b99f710ebb4ecfe2b0482a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317001 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#950897}
In non-tunneled requests, we end up reporting the proxy connection's SSLInfo all the way through to the HttpStream. The reason this doesn't cause a mishap is HttpNetworkTransaction checks the URL before querying GetSSLInfo. Add a test so this doesn't regress. (Attaching to issue #1277656 to keep track of it, but it's only tangentially related.) Bug: 1277656 Change-Id: Iaaa75188971ba070e99d93050b4b820e131546c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327793 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#950898}
Bug: 1277748 Change-Id: I28a2d7c4c8b4b3640d8972a03565bb972680941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333750 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#950899}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a8fbc6abec2..7bac96e2247a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If41348830790b56a2d5ee5efbde4731acc254ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333963 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950900}
In crrev.com/c/3251184, a function parameter was introduced to optionally add grease to the brand version list. However, we were storing the result in a static variable, so all subsequent function calls would return a brand list using whatever the first call to the function passed in for enable_updated_grease_by_policy. This CL fixes the problem by removing the static const for the variable definitions. Change-Id: I25a2e87de6f8dab270c93985ee4ecd54cbaf0f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330333 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Ali Beyad <abeyad@chromium.org> Cr-Commit-Position: refs/heads/main@{#950901}
Extends support for omnibox result removal action to general search when categorical search is enabled. Previously, this action was only supported in zero state, but for productivity launcher, it should be available for general search results. The result removal dialog wording implies the result is an omnibox search, so result removal action is enabled only for omnibox search results (even though other omnibox result types may support deletion). BUG=1272361 Change-Id: Ic82a5bea702c9f45c386ca47251e585d45e7f2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321592 Reviewed-by: Tony Yeoman <tby@chromium.org> Reviewed-by: Amanda Deacon <amandadeacon@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Yulun Wu <yulunwu@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#950902}
A chrome flag "QuickDim" is added with a few variations. BUG=b:208124620 Change-Id: I5ee67e91e52c41c7793b61661d26e0abe1f79dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307171 Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Guoxing Zhao <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/main@{#950903}
This is a spiritual successor to CL:3121767 which stored a copy in the VM. This is less then ideal because it's harder to find, likely to be deleted inadvertently if the upgrade failed (which is precisely when we want it), and the user isn't informed of its presence. This CL also adds a message to the upgrade error screen telling the user where the logs have been saved. Screenshot of the new UI: Success state: https://screenshot.googleplex.com/BtXFSAYxhKugXCv Failure state (with backup): https://screenshot.googleplex.com/3jNs5iZYVT5rUDA Failure state (no backup): https://screenshot.googleplex.com/826KF26J3dirs6L Bug: 1217902 Change-Id: I3a978439bb4b4d5538fb752dc0939b1260ee9e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312456 Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Daniel Ng <danielng@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/main@{#950904}
This CL is part of MPArch tasks. TabStatsTracker already blocks subframe navigation (i.e. iframes, fenced frames..) by treating only browser-initiated navigations as user interactions or making codes run in the primary main frame only. So, this CL adds a browsertest which ensures subframe navigation doesn't affect TabStatsTracker. Bug: 1275874 Change-Id: I26b44eeda24b09a0d45a603498d47a57b8669623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308482 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Olivier Li <olivierli@chromium.org> Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> Cr-Commit-Position: refs/heads/main@{#950905}
Roll Chrome Linux PGO profile from chrome-linux-main-1639331466-e4f79369bd5d416f516dce89f9ee90edd6069a7c.profdata to chrome-linux-main-1639353226-638c82e86f980a18b2a0146532932c8a08737349.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iefbbf840612a03da0b6632b4e0232eee0b6322f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333703 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950906}
The recent raw_ptr<> rewrite revealed that a few chromeos-only headers are being compiled on non-chromeos platforms. (The rewrite was only supposed to affect Windows and Android targets, but a few ChromeOS files got included.) Fix some includes in unit test files and add a few strategic static_assert()s to ensure these headers are only compiled into ash-chrome. Bug: none Test: compiles Change-Id: Id8b943b52becafb6d7481a5b6f8e9e59941c8a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333737 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#950907}
Change-Id: I745e0cdba49d0cc32aee1aab8b97625c36165515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330338 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950908}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639321126-9de973ab1e0ff103bd9e722f065aa63cd0c11793.profdata to chrome-win64-main-1639353226-a9d90608d00434eab0b9216d0cb68fc131318d07.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia400a94e19b7dd7b2fe799e72344b33ab60e7870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333698 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950909}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: If3c13652dd94659bd7cb282d6ab174c5ab818ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333966 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950910}
https://chromium.googlesource.com/vulkan-deps.git/+log/b479308f87a5..7a5a815acb92 Changed dependencies: * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/08f87babad..d3cdb64f2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com,cwallez@google.com Change-Id: I27cc3b807590dbc7339c9c6fc7a2aaf0a0fc55a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333962 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950911}
Instead of scraping recent app suggestions out of suggestion chips, use a real display type. Bug: 1276244, 1216662 Test: updated ash_unittests Change-Id: I052c455254bf51487f4f2d45e42a24043aa142a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333736 Reviewed-by: Rachel Wong <wrong@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#950912}
Roll Chrome Mac PGO profile from chrome-mac-main-1639331466-1cd82d3d5100e1746ee551bbf411e6e3c34f5804.profdata to chrome-mac-main-1639353226-6454cf2935d1683fb37540a5ee7460372e13b58a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9bfc7e58b62a3dba089f01457275a15217f14198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333700 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#950913}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
pull bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
…3 commits) https://chromium.googlesource.com/external/github.com/chromium/content_analysis_sdk.git/+log/93f5b9cfe950..3102cb8a514a $ git log 93f5b9cfe..8d5118720 --date=short --no-merges --format='%ad %ae %s' 2023-08-17 105299435+dominiquefc Fix switch statement from last change (#100) 2023-08-17 105299435+dominiquefc Add Reason enum to ContentAnalysisRequest (#99) 2023-08-04 105299435+dominiquefc Update "Ack:" logging whitespace (#98) 2023-08-04 105299435+dominiquefc initial (#97) Created with: roll-dep src/third_party/content_analysis_sdk/src Bug: b/232967266, b/285317584 Change-Id: I8d15321576b9a9b221de26a40cf8eb58e18097bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4791106 Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1185151}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )