[pull] main from chromium:main #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7499f7d4e8b6..557423681afa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jeroendh@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jeroendh@google.com Change-Id: I0997cd42babbcf6fff2477047608ce33fa44ea0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334706 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951078}
Page scale should only be computed for the outermost main frame not fenced frame roots. BUG=1271351 Change-Id: I8d1e3aadd30c9c948e15e0bf63bde23196a9fa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330321 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951079}
Missed required parameter when adding benchmark type "incremental_build". Bug: 1254718 Change-Id: I5d550f9188e7ac958ce6d11ebc477bb7a7c70d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330348 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#951080}
No behavior change. Bug: 1066213,972075 Change-Id: Ie76801b379c84ce09adca8adca6f1589f39a2a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334498 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#951081}
Bug: 1278907 Change-Id: If16789f4e0545a91f0eb9dfdbec81785eb2f97ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330965 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#951082}
https://webrtc.googlesource.com/src.git/+log/a6b138d6b4ef..699d1a242ecd 2021-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dc7d4b7..afd5c73 (950709:950813) 2021-12-11 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-12-11T04:01:46). 2021-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fd23579..dc7d4b7 (950606:950709) 2021-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 28e5c92..fd23579 (950500:950606) 2021-12-10 cschuldt@google.com Optimize CascadedBiQuadFilter. 2021-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3e28ffc..28e5c92 (950158:950500) 2021-12-10 mbonadei@webrtc.org Relax gn check test. 2021-12-10 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-12-10T04:04:39). 2021-12-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1e240af..3e28ffc (950054:950158) 2021-12-09 hta@webrtc.org Tolerate overlong MID in channel.cc 2021-12-09 terelius@webrtc.org Disable VideoSendStreamTest.RelayToDirectRoute due to flakiness 2021-12-09 philipp.hancke@googlemail.com remove last traces of WebRTC-Audio-SendSideBwe 2021-12-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9f47779..1e240af (949821:950054) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie8024c5efb539e93ef2af5b346c1403c0cc301b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334936 Commit-Queue: Olga Sharonova <olka@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951083}
Convert the field to an atomic type and adjust accesses to match while preserving existing safety checks. This is not the last step to make Blink strings thread-safe, but it is the most potentially impactful on performance. Perf testing results and discussion are in this thread: https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/Cd483BcI3c8 Change-Id: I2c503b782f028aebbfeb733ceb8009eb00ea8210 Bug: 1083392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152354 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951084}
Spec asks for exta 6 dip padding between the continue task chips and outer edge of continue section (which makes the continue task icons better align with the section title). Bug: None Change-Id: Ied85e7f7de449a70de15f7732229f89f3aa5832c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331521 Reviewed-by: Ana Salazar <anasalazar@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#951085}
Roll Chrome Win32 PGO profile from chrome-win32-main-1639393722-9f7cf7f714044de9cb6b63434daf10bcd25530b7.profdata to chrome-win32-main-1639407500-a1802b7bf664a493b35086ae58fd679d3300265d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3c107e7aa0efbfb272f3449f45edde13bf5b4438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334940 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951086}
https://android.googlesource.com/platform/external/perfetto.git/+log/44638d7a4268..1302b4259684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie333a53dd4a03f23c505010b3ff93892bd870a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334862 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951087}
It's unclear if retry() actually sees usage in the 'real world', versus the theoretical musings it was added based on, so let's measure and see. Bug: 993536 Change-Id: I00af3d7f9e4095b9ce13a411046ea6d299d2b022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331620 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#951088}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0e3067f96d33..7f5c3ecd65d7 2021-12-13 wolfi@chromium.org Create custom component for BackForwardCacheView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1198552,chromium:1278649 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc4e591b435cb899ee9a383968bda8b8e59e3eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334976 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951089}
This CL is correcting the over-reliance on WebContents instance for some methods, which happen to be incorrect for fenced frames, and pre-rendering. Bug: 1279374 Change-Id: I82927ba1257abeefb2cafb9a899dbc6523c1618c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329855 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@igalia.com> Cr-Commit-Position: refs/heads/main@{#951090}
Problem: • Test fixture sets the testcase name as custom arg inside SetupOnMainThread function which gets setjust before the test is run and after browser is initialized. • The extension reads the custom arg set above to call appropriate javascript function. • First test explicitly loads the extension hence it runs fine without any synchronization issue. • For second and third test, the extension gets loaded automatically when the browser object is created for the test. • The test fails when extension (background script) starts running and it still can not find the custom args as these two are running on separate process (synchronization issue) Solution: Used ExtensionTestMessageListener to coordinate between C++ test and background script. The listener needs to be set before browser object is created otherwise it will not be able to receive messages from script (for 2nd and 3rd test). Initializing listener object in the setup function and clearing in teardown function. Bug: 1269641 Change-Id: I5def44203a4176ca7e179d75def6e98f4ad05933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329594 Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#951091}
https://gn.googlesource.com/gn.git/+log/fc295f3ac7ca..2e56c317bd8e 2021-12-13 digit@google.com Ensure circular dependency check output is deterministic. 2021-12-10 maaiguo@uniontech.com Display more accurate help information 2021-12-09 digit@google.com Improve Builder performance. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/gn-chromium-autoroll Please CC thakis@chromium.org,dpranke@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: 1278489 Tbr: thakis@chromium.org,dpranke@chromium.org Change-Id: Ie9296753bbcc7406cb14d738a011582bb89c5831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334981 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951092}
Bug: 1267983 Change-Id: I0822b7a133849c60f2203764ec2d23bade4f01ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334871 Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951093}
The ScopedFeatureList destructor also races with feature access on other threads. This refactors HeapProfilerControllerTest to initialize the ScopedFeatureList in the test fixture constructor and destroy it in the destructor, when no other threads are running. Parameterized tests are used to set different feature configs instead of overriding the ScopedFeatureList. Re-enables tests that were disabled due to flakes caused by this race. Bug: 1276033 Change-Id: Iceed0a19cf0634138d41e3a7ad1017016cc610f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331842 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Auto-Submit: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#951094}
Add simple tests to make sure that flex items expand when MinBlockSizeShouldEncompassIntrinsicSize returns true in the case of flex row fragmentation (for both single/multi-line). Similar to CL:3319284, the calculation of MinBlockSizeShouldEncompassIntrinsicSize() will likely need some more work. Bug: 660611 Change-Id: I868bd7aa2572924367b263d867dd21537a7fa015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322056 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951095}
Bug: 1271921 Change-Id: Ib101c630b1d2815baf8daaf723d51b0aacaa2a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330329 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/main@{#951096}
CL fixes a TODO in ExtendedDragSource::OnToplevelWindowDragCancelled() actually propagating the cancellation to ash::ToplevelWindowEventHandler class. TEST=exo_unittests (ExtendedDragSourceTest.CancelDraggingOperation) BUG=1277210 R=oshima@chromium.org Change-Id: I08fe5cdabce1b0d6d95ce3f5c5db6238850ffd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317941 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#951097}
Bug: 1187091 Change-Id: I9b17de2b708b85de5bb7ee1451689b300474aca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299948 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#951098}
Tests moved: - extension_policy_browsertest.cc - test/note_taking_on_lock_screen_policy_browsertest.cc - test/system_features_policy_browsertest.cc - test/native_messaging_policy_browsertest.cc Bug: 3318959 Change-Id: I4b71a2ec75afcd00cfd5e932b530692dc09a7c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321994 Reviewed-by: Owen Min <zmin@chromium.org> Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#951099}
This CL adds information needed to calculate AverageLag metrics to cc::EventMetrics objects. The goal is to use cc::EventMetrics for AverageLag calculation rather than ui::LatencyInfo and hopefully reduce the size of ui::LatencyInfo. The actual use of cc::EventMetrics for AverageLag calculation will happen in a follow-up CL. Bug: 1101000 Change-Id: Ib0bad215bad9f126a746148c4b01a7112e5320c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311077 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/main@{#951100}
shell-encryption and private_membership leaked some configs which disable some default warnings. In order to re-enable all these warnings for chrome/browser/* in this CL crrev.com/c/3303510, all warnings need to be fixed. This CL is fixing the comparison between two integers for them to be from the same exact type (i.e. integer). Bug: chromium:1212837, b:201763017 Change-Id: I730b2e207a8edbbfa09be6b0861fe08418f95f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320239 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/main@{#951101}
Also disables the image search URL change if on a non-desktop platform. Bug: 1168677, 1222313 Change-Id: I855e3838e344ba260b8829a2f8cc355f2c31e2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328902 Reviewed-by: Ben Goldberger <benwgold@google.com> Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/main@{#951102}
The older Intel devices that Reven supports are still on ES2, and don't support multisampling. This causes the UI to fail after logging in. Fix by checking the context capabilities to see if `max_samples > 0`, and don't call BlitFramebufferCHROMIUM in that case. BUG=b:184383677 TEST=Run reven on the HP Compaq 8000, verify that the UI works after logging in Change-Id: Ie1b05ac24370abcf761bf592d9d49fa5d5192ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318276 Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/main@{#951103}
Bug: None Change-Id: I2b34329af44c2f62206b4a9002c3e0633cee82f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335196 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951104}
The rendering issue is because dtor of AngleVulkan shared image backing always switches GL context, but not switch back when dtor is done. Fix the problem by only make current if there is not GL context current. Bug: 1278571 Change-Id: I342c1eb467ae79b0eba6eba9f17536847955bf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330903 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951105}
Adding trace categories has severely impacted several metrics due to the additional trace capture overhead. this change reduces that overhead. This change removes the cc blink and viz trace categories and adds the "benchmark" category, which is a cross-sectional category that includes only the most important high-level calls from the removed categories. Bug: 1278992 Change-Id: Idf0b70148b8836e2589eb9cfe5d5c65f4d3f71ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335058 Commit-Queue: Justin Novosad <junov@chromium.org> Auto-Submit: Justin Novosad <junov@chromium.org> Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/main@{#951106}
Behavior neutral. Creates an object to be passed to the callback instead of individual values. Fixed: 1277139 Change-Id: I32d0c71ef0fadbb3b6fdf5caa1e1e1469d6bd506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317939 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951107}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/58799ca24f08..603d9d1067d1 2021-12-13 ldionne.2@gmail.com [libc++abi][NFC] Fix comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libcxxabi-chromium Please CC thakis@chromium.org,hans@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,hans@chromium.org Change-Id: I9db254db0d29526112f263f77534f8b1b20d40be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334937 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951169}
This addresses an issue with the edit page of the "Manage sign-in data" dialog of the Security Keys settings subpage, where the "username" and "name" fields had the existing value set as a placeholder. Instead, set it as the field's value, in consistency with other settings edit dialogs. Also fix misalignment of the headers on the overview page. Fixed: 1275361,1275362 Change-Id: Iffb74c8ecf35c6369cf038b38974c370a87ee75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331516 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/main@{#951170}
Bug: 1241971 Change-Id: I69fc34f9f00ffc952c0cee6e814e3ba5cbcb7046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315652 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#951171}
This avoids reimporting stale data from Keystone's ticket store over and over, while also avoiding deleting the ticket store (useful in case of emergency rollback / recovery). Since the bit is saved in global prefs, it will be saved atomically with the product registration information. Bug: 1250524 Change-Id: Ib562136381edfb500a01c7be69a7def10f57c68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330595 Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#951172}
Set them all to the same date, to reduce email spam. Bug: 1268029 Change-Id: I4a4923b27b7e4accc506f60d5fa6eef7274cca75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334998 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Yashar Dabiran <yashard@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/main@{#951173}
Roll Chrome Mac PGO profile from chrome-mac-main-1639393722-2d03618ce8fda9f6a746ac4c40204c03180aba60.profdata to chrome-mac-main-1639418353-20f3ebb2a2ab5e472fb88129d411c7189510778e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6cb7b08aeac67a54ab1625f99cc88c286e8faf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335140 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951174}
Notify the projector controller with all recording starts and ends, regardless of whether they were initiated by the projector flow or not, and pass the boolean value to indicate whether the video recording start/end is meant for projector as an argument. Test: manual, added an unit-test Change-Id: I348d0e495e73541e017309a469a913a8a1797421 Fixed: 1275684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331039 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Yilkal Abe <yilkal@chromium.org> Commit-Queue: Connie Xu <conniekxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951175}
Roll Chrome Linux PGO profile from chrome-linux-main-1639393722-aa212daae172c79e8083ab81c95cb6a0c3b2a1f0.profdata to chrome-linux-main-1639418353-1ac5298c2b40a361254a8c3e5d8f91ecc7dd7444.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I448fac2a4e4190a6edafbbe4f6bbce56899ac37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335141 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951176}
This change adds data sampling for TME info. This info is sampled from the memory category of the health daemon. Bug: b:202319420 Change-Id: I47053e86ac8a9ee177725b10a9af51192ebc2c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324577 Reviewed-by: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Tyler Garrett <tylergarrett@chromium.org> Cr-Commit-Position: refs/heads/main@{#951177}
Now that canary checks are performed when making prefetches and now that canary checks are light-weight DNS lookups, there is little upside to sending the checks at browser startup (the canary check will almost always complete faster than the prefetch). Running canary checks at startup has two downsides: 1) The user may not be online when the browser is starting. This means the canary check will fail and the result will be cached for 24h. This seems to happen frequently (10% of canary checks fail). 2) This makes tests flaky: fake DNS rules are inserted in SetUpOnMainThread, but the canary check happening at browser startup may fail before SetUpOnMainThread is called, in which case the incorrect result may be cached. It seems preferable to just remove the startup canary checks. Bug: 1278069 Change-Id: I95fe90f8a07512fab0a208aeb9642cf0b2b9bd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331415 Reviewed-by: Max Curran <curranmax@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/main@{#951178}
Bug: 1032153 Change-Id: I59135a45d32671d70038bab17c067fbbd4da881d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330777 Reviewed-by: Max Curran <curranmax@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/main@{#951179}
Bug: None Change-Id: I25efe39545f81787c7ed3ed8449439801ead7fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331875 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/main@{#951180}
Roll Chrome Win64 PGO profile from chrome-win64-main-1639407500-00d9293c4ab7558a9da7eab4d58568a0a8d997b4.profdata to chrome-win64-main-1639418353-b85c5bb26fc53388b63ef45334bb5b09bf1e3292.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibf42ac169740bbcb6c2129aa6c1dd3ebea36413d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335159 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951181}
https://skia.googlesource.com/skia.git/+log/507884bf3d75..e4bccab4ac7c 2021-12-13 jvanverth@google.com Fix divide-by-zero in AAConvexTessellator. 2021-12-13 herb@google.com remove SK_EXPERIMENTAL_ADD_ATLAS_PADDING from Skia 2021-12-13 herb@google.com rename GrTextBlobCache to GrTextBlobRedrawCoordinator 2021-12-13 johnstiles@google.com Add method to get the suffix for a trace's slot. 2021-12-13 johnstiles@google.com Add support for stepping out from a function. 2021-12-13 johnstiles@google.com Improve the debugger code view. 2021-12-13 johnstiles@google.com Create Debugger slide for Viewer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Ia55b31edc2cec6d37c63a564123a6bf320444d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335376 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951182}
Uses of the method in chromium have already been removed. Bug: 1187066 Fixed: 1187066 Change-Id: Ia15d804cce4dd38cbd11096f0b04ecb14f52f851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330349 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#951183}
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I17d59aabedac9e8943dd67b826556374f64ee12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322612 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951184}
Native Headless mode is currently available only on Linux and Windows platforms. Support for other platforms is expected to be added later. Bug: 1278540,1278603 Change-Id: I015824a938fa2f7fa2d4eeb72d2dba32baedf0e6 Cq-Include-Trybots: luci.chromium.try:linux-headless-shell-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335254 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/main@{#951185}
This reverts commit dc28cdb. Reason for revert: This introduces a regression in start up time and does not fix the guest profile issue. Original change's description: > Reland "[OptGuide] Support models for guest profiles." > > This reverts commit 43a400e. > > Reason for revert: Fix race in browsertest to ensure the store > is initialized before registering for the model in the guest > profile. > > Original change's description: > > Revert "[OptGuide] Support models for guest profiles." > > > > This reverts commit 74d499c. > > > > Reason for revert: crbug.com/1275335 > > > > Original change's description: > > > [OptGuide] Support models for guest profiles. > > > > > > Previously, the guest profile would have a low, or no, chance of getting > > > a model downloaded for each target. Rather than re-fetch for the guest > > > profile, we should just re-use the default profile's available models. > > > > > > All the models and fetching are approved for off the record profiles > > > as they disclose no information to Google and all the existing checks > > > to validate this remain. > > > > > > Bug: 1274115 > > > Change-Id: I11fa4a1c32f07a1ebafc804b336db61e4c543121 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307130 > > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#946518} > > > > Bug: 1274115,1275335 > > Change-Id: Ia2fea9819cb2ba747edd5092a2cfd64fd22529fe > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308147 > > Auto-Submit: Darren Shen <shend@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#946756} > > Bug: 1274115,1275335 > Change-Id: Ia5771c09ed8b3b147116e52647af514173e87700 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310504 > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948823} Bug: 1274115,1275335 Change-Id: I0025edba225749c93a28bd8696303471e6e2682e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334867 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#951186}
This reverts commit 397efe0. Reason for revert: Timeout on bot was increased Original change's description: > Revert "Mac: enable ThinLTO (without unit splitting)" > > This reverts commit 810d213. > > Reason for revert: Suspecting causing infra failure. > > Original change's description: > > Mac: enable ThinLTO (without unit splitting) > > > > Splitting is currently blocked on supporting N_INDR symbols in lld. > > > > Bug: 471146 > > Change-Id: Iacc2288d8307fdf730d92d0bfc7f3286d0162b92 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328741 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#950412} > > Bug: 1279290 > Change-Id: If82f13cf72eb7a42430dbda9d5af534efd77f5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332866 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: My Nguyen <myy@chromium.org> > Owners-Override: My Nguyen <myy@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950944} Bug: 1279290 Change-Id: I42d2f45910992dcd02912a10e080d4392253b31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334918 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#951187}
This reverts commit d485b6f. Reason for revert: crbug.com/1278078 (crashing in ModernLinkerJni_nativeUseRelros) Original change's description: > android: ModernLinker: avoid dl_iterate_phdr > > According to Canary data produced by > "*.ModernLinkerIteratePhdrTime": > > 1. on Android S, iterating the libraries takes about 500ms on 95th > percentile > > 2. for iterating on pre-S the equivalent statistic measures at 180ms. > > Most likely this is due to locking around link map, and having many > libraries loaded. Haven't investigated further. > > Instead take the program headers at known offset from the load_address. > This must be near instant. > > Bug: 1154224 > Change-Id: I8b604f982a178e9b1cc0fc2f94e9062a610652f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317431 > Reviewed-by: Benoit Lize <lizeb@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948993} Bug: 1154224 Change-Id: I55a488388420e54ab1187ba628f3accda3f8b858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332082 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951188}
…side fails." This reverts commit e1f2900. Reason for revert: Bug has been fixed, so these dumps are no longer needed. Original change's description: > [discardable_memory] Call `DumpWithoutCrashing` when browser side fails. > > This CL adds 2 calls of `DumpWithoutCrashing` to help debug failures on > the browser side to allocate more discardable memory. > > Bug: 1270558 > Change-Id: I3b453808beb2f9c8d46d14e0cca3776aeaa7b223 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297472 > Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#945002} Bug: 1270558 Change-Id: I43d119e5dbd454af8d04ecbe95ef0d9be028ca65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330664 Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/main@{#951189}
ForEachRenderFrameHost assumes each RFH in render_frame_host_id_set_ can be found by FromID. However, in some cases (e.g., bfcache eviction), the subframes are destroyed via the main frame's destructor, in which case the main frame is still in the set but is no longer discoverable by FromID. This CL avoids a crash if ForEachRenderFrameHost is called in such a scenario by skipping such RenderFrameHosts. Bug: 1278952, 1265859 Change-Id: I589c24a2cb7c8ca0e923e0b2820a96fface80fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330548 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Charles Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951190}
This CL is a continuation of the work started in https://crrev.com/c/2689550. This CL is part of the feature to make Windows.Gaming.Input (WGI) turned on by default on Chromium. WGI will provide game controller support on Windows 10 desktop. The WGI also provides support for gamepad-specific Plug & Play APIs. This CL adds Windows.Gaming.Input (WGI) GetGamepadData functionality to be able to retrieve button and joystick input. Moreover, it also adds fake COM classes implementations along with tests using them. This CL does not address the issue with the Nexus (Xbox) button not being exposed. Bug: 1098876 Change-Id: Icc0008e3b7b7520d30707af601d50b564970c0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304117 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Gabriel Brito <gabrielbrito@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951191}
Change-Id: Ia9aafdbd5bcf3a589d97e818296216cfd93ebee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334920 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951192}
For each 'Frame' under FrameSequenceTracker, include a couple of details to help with diagnostics: frames expected, and frames dropped. BUG=1256879 Change-Id: Id7e994fed477d40729c4a0a6625e8173791d0abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331120 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951193}
https://android.googlesource.com/platform/external/perfetto.git/+log/1302b4259684..86b18b837a45 2021-12-13 octaviant@google.com Merge "ui: Fix incorrect trackId usage" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifc24afb5fc8a4c1ad41805310e29fb2342fc58a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335177 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951194}
Fixed: 1240798 Change-Id: I783a6ade2576221f235cce59caa79876e7193423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315779 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951195}
pull bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
https://chromium.googlesource.com/external/github.com/pytorch/cpuinfo.git/+log/b40bae277857..beb46ca03198 $ git log b40bae277..beb46ca03 --date=short --no-merges --format='%ad %ae %s' 2022-07-27 maratek Minor refactoring of iOS/Mac feature detection on ARM/ARM64 (#108) 2022-07-27 maratek Use full syntax for ADD_TEST CMake command (#107) 2022-07-27 maratek Detect Cortex-A710/-A510/-X2 cores (#109) 2022-07-26 kulin_seth Add support for Arm FHM (#102) 2022-07-25 kulinseth Use sysctls available in macOS 12 / iOS 15 for hardware feature support. (#100) 2022-07-18 keithbsmiley Add bazel support for iOS arm64 simulator (#105) 2022-07-15 kulinseth Add support for Arm I8MM (#103) 2022-07-12 kulinseth Add Arm BF16 support for Apple platforms (#104) 2022-07-12 maratek Cleanup detection of ARM BF16 extension (#98) 2022-07-12 kulinseth Update README.md to use 'macOS' and list support for Apple silicon (#99) 2022-07-07 nshulga [GHA] Add build workflow (#97) 2022-07-07 maratek Make clog compatible with Hexagon toolchain (#95) 2022-07-05 bion Always check for x86-ish with the same regex. (#93) 2022-07-05 91903944+gaborkertesz-linaro Enable win-arm64 (#82) 2022-07-04 91903944+gaborkertesz-linaro Update googlebenchmark to 1.6.1 (#86) 2022-06-17 petrhosek Define namespace prefixed alias for cpuinfo in the CMake build (#89) 2022-05-31 weiyiw Fix arm build when -Werror enabled (#91) Created with: roll-dep src/third_party/cpuinfo/src Bug: 1329774 Change-Id: I602d9631c5355ded521af4642df97cdca45cbaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3797219 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1030661}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )