[pull] main from chromium:main #104
Merged
Commits on Dec 13, 2021
-
Do not apply page scale to fenced frame roots.
Page scale should only be computed for the outermost main frame not fenced frame roots. BUG=1271351 Change-Id: I8d1e3aadd30c9c948e15e0bf63bde23196a9fa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330321 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951079}
-
Add a TODO comment for an old open bug to compare_build_artifacts.py
No behavior change. Bug: 1066213,972075 Change-Id: Ie76801b379c84ce09adca8adca6f1589f39a2a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334498 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#951081}
-
Make StringImpl::ref_count_ atomic
Convert the field to an atomic type and adjust accesses to match while preserving existing safety checks. This is not the last step to make Blink strings thread-safe, but it is the most potentially impactful on performance. Perf testing results and discussion are in this thread: https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/Cd483BcI3c8 Change-Id: I2c503b782f028aebbfeb733ceb8009eb00ea8210 Bug: 1083392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3152354 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951084}
-
[PaymentRequest] Measure usage of the retry() method
It's unclear if retry() actually sees usage in the 'real world', versus the theoretical musings it was added based on, so let's measure and see. Bug: 993536 Change-Id: I00af3d7f9e4095b9ce13a411046ea6d299d2b022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331620 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#951088}
-
[MPArch] Correct ChromePaymentRequestDelegate use of WebContents
This CL is correcting the over-reliance on WebContents instance for some methods, which happen to be incorrect for fenced frames, and pre-rendering. Bug: 1279374 Change-Id: I82927ba1257abeefb2cafb9a899dbc6523c1618c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329855 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Nick Burris <nburris@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@igalia.com> Cr-Commit-Position: refs/heads/main@{#951090}
-
Move ScopedFeatureList into test fixture to fix test flakes.
The ScopedFeatureList destructor also races with feature access on other threads. This refactors HeapProfilerControllerTest to initialize the ScopedFeatureList in the test fixture constructor and destroy it in the destructor, when no other threads are running. Parameterized tests are used to set different feature configs instead of overriding the ScopedFeatureList. Re-enables tests that were disabled due to flakes caused by this race. Bug: 1276033 Change-Id: Iceed0a19cf0634138d41e3a7ad1017016cc610f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331842 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Auto-Submit: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#951094}
-
[FlexNG] MinBlockSizeShouldEncompassIntrinsicSize flex row tests
Add simple tests to make sure that flex items expand when MinBlockSizeShouldEncompassIntrinsicSize returns true in the case of flex row fragmentation (for both single/multi-line). Similar to CL:3319284, the calculation of MinBlockSizeShouldEncompassIntrinsicSize() will likely need some more work. Bug: 660611 Change-Id: I868bd7aa2572924367b263d867dd21537a7fa015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322056 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951095}
-
Add AndroidFixedUmaSessionResumeOrder to fieldtrial_testing_config.json
Bug: 1271921 Change-Id: Ib101c630b1d2815baf8daaf723d51b0aacaa2a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330329 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/main@{#951096}
-
[exo] Handle drag 'n drop cancel in ExtendedDragSource
CL fixes a TODO in ExtendedDragSource::OnToplevelWindowDragCancelled() actually propagating the cancellation to ash::ToplevelWindowEventHandler class. TEST=exo_unittests (ExtendedDragSourceTest.CancelDraggingOperation) BUG=1277210 R=oshima@chromium.org Change-Id: I08fe5cdabce1b0d6d95ce3f5c5db6238850ffd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317941 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#951097}
-
[Code Health] Remove DictionaryValue::GetDictionary() in extensions/b/*
Bug: 1187091 Change-Id: I9b17de2b708b85de5bb7ee1451689b300474aca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299948 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#951098}
-
Only use BlitFramebufferCHROMIUM if multisampling is available
The older Intel devices that Reven supports are still on ES2, and don't support multisampling. This causes the UI to fail after logging in. Fix by checking the context capabilities to see if `max_samples > 0`, and don't call BlitFramebufferCHROMIUM in that case. BUG=b:184383677 TEST=Run reven on the HP Compaq 8000, verify that the UI works after logging in Change-Id: Ie1b05ac24370abcf761bf592d9d49fa5d5192ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318276 Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/main@{#951103}
-
[FedCM] Add yigu as FedCM owner
Bug: None Change-Id: I2b34329af44c2f62206b4a9002c3e0633cee82f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335196 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#951104}
-
Fix WebGL rendering issue with AngleVulkan shared image backing
The rendering issue is because dtor of AngleVulkan shared image backing always switches GL context, but not switch back when dtor is done. Fix the problem by only make current if there is not GL context current. Bug: 1278571 Change-Id: I342c1eb467ae79b0eba6eba9f17536847955bf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330903 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951105}
-
Reduce amount of trace data collected by rendering benchmarks
Adding trace categories has severely impacted several metrics due to the additional trace capture overhead. this change reduces that overhead. This change removes the cc blink and viz trace categories and adds the "benchmark" category, which is a cross-sectional category that includes only the most important high-level calls from the removed categories. Bug: 1278992 Change-Id: Idf0b70148b8836e2589eb9cfe5d5c65f4d3f71ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335058 Commit-Queue: Justin Novosad <junov@chromium.org> Auto-Submit: Justin Novosad <junov@chromium.org> Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/main@{#951106}
-
[CT] Update SelectAroundCaretAck value to pass an object.
Behavior neutral. Creates an object to be passed to the callback instead of individual values. Fixed: 1277139 Change-Id: I32d0c71ef0fadbb3b6fdf5caa1e1e1469d6bd506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317939 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951107}
-
Extend the expiration milestone for feed-v2-autoplay
Bug: 1278910 Change-Id: I2f5eb908c67d463c8a6857bf8527fbc91c46698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331259 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/main@{#951108}
-
Fix deprecation warning in analyze_includes.py.
Use assertEqual() instead of assertEquals(). Change-Id: I14d447d402c80146af4c8a7129dded1840a96a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331876 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#951110}
-
[fuchsia] Enable passing media tests from content_browsertests
This CL add the audio shard to the content_browsertests package and re-enable media tests that now pass. Bug: 1071095 Change-Id: I5dfea4bac8c4781b67703ccb12a8e39f62481d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333934 Auto-Submit: Benjamin Lerman <qsr@chromium.org> Reviewed-by: Fabrice de Gans <fdegans@chromium.org> Commit-Queue: Fabrice de Gans <fdegans@chromium.org> Cr-Commit-Position: refs/heads/main@{#951119}
-
Revert "Remove use of GridLayout for the payment sheet view."
This reverts commit e8e475a. Reason for revert: https://crbug.com/1279367 Original change's description: > Remove use of GridLayout for the payment sheet view. > > Bug: 1261301 > Change-Id: Icfe752ca849f1aee29a411aaa70a0385db9f63e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3300682 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948727} Bug: 1261301, 1279367 Change-Id: Ibf56c090eb5db0993a8955283a8d5d86b6cbc278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334997 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951121}
-
Update feed pull-to-refresh to be enabled by default
Bug: 1278902 Change-Id: Ie683345521884e1e60bc328715e0c79219c8dc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329669 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/main@{#951122}
-
Remove two unneeded logging statements
R=rhalavati@chromium.org Bug: none Test: none Change-Id: I0674968f39c80ef96110caa4b2b3b83a3996b1ed AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330708 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#951124}
-
[logs] Remove unused condition
This is part of our tech debt cleanup. Condition is now deprecated so we are migrating all clients off of it. Bug: fuchsia:82866 Change-Id: I260ef57393c74972e68bb01d9ff5461fc3a31e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331360 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Brian Bosak <bbosak@google.com> Cr-Commit-Position: refs/heads/main@{#951125}
-
Roll src/third_party/ffmpeg/ d151785b5..53de560ab (4 commits)
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/d151785b5b0e..53de560ab9b7 $ git log d151785b5..53de560ab --date=short --no-merges --format='%ad %ae %s' 2020-09-28 jonathan.wright aarch64: Add Armv8.5-A BTI support 2020-09-28 jonathan.wright aarch64: Use ret x<n> instead of br x<n> where possible 2021-11-16 liberato Fix deps roll 2021-11-15 liberato Experimental merge-back and DEPS roll. Created with: roll-dep src/third_party/ffmpeg Bug: 1145581 Change-Id: I36f96c1d006dcb8fbdd5cece51ad6d9701015e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329605 Auto-Submit: Jonathan Wright <jonathan.wright@arm.com> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951127}
-
StorageBuckets: Extend histogram expiry
This change extends the following histogram expiry for another year. These histograms are used for monitoring storage eviction. We expect them to continuously be used especially as we have changed eviction to be per storage bucket instead of origin, and we support creating multiple buckets per origin. - Quota.EvictedBucketAccessCount - Quota.EvictedBucketPerHour Bug: 1277113 Change-Id: I0028abacd4cb6fdc0d0dd07264cb75c3c88da5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330859 Reviewed-by: Weilun Shi <sweilun@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/main@{#951130}
-
Add print enum value to DeepScanAccessPoint
This CL adds a value to DeepScanAccessPoint so shared code that records UMAs for enterprise Connectors can be reused with the print Connector. Bug: 1273922 Change-Id: I2a29e101affaf31d53628cb6a4396dadfde4a236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321348 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/main@{#951131}
-
exo: fix pickled data handling in DragDropOperation
Current implementation uses the incorrect base::Pickle constructor when preparing offered data before starting the DND operation, leading to its "header_" class variable to be set to nullptr, causing segmentation fault when copy-assigning it, for example, as observed in the linked bug's stack trace. R=oshima@chromium.org Bug: 1271311 Change-Id: I2c5ae25d9a40b3ac1e63e89a9cc69691b9e9cba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330489 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/main@{#951135}
-
Properly close Lens and open link after LRP press
Bug: 1234532 Change-Id: I79b624112787aedb1efd3ef6978b7d034bb2fc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331543 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jason Hu <hujasonx@google.com> Cr-Commit-Position: refs/heads/main@{#951144}
-
Slimming PaintLayer: remove more pre-CAP code from PaintLayer (2)
This patch removes the following fields: has_compositing_descendant_ needs_compositing_reasons_update_ descendant_may_need_compositing_requirements_update_ PaintLayerRareData::potential_compositing_reasons_from_style PaintLayerRareData::potential_compositing_reasons_from_non_style PaintLayerRareData::compositing_reasons Bug: 1277748 Change-Id: If44087ef43bcd184bffe67ba5a4412e4725a231f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330860 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#951145}
-
DevTools: Add getPreference binding
Frontend CL: crrev.com/c/3302733 Bug: 1273058 Change-Id: Ic822246327edf1d923edcfea86f511b009b2e3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3302814 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951146}
-
ChromeVox: Remove workaround for googletts perf regression
Depends on updated tts engine https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3330835 R=akihiroota@chromium.org Bug: none Test: manually on device with dependent change Change-Id: I86f786a3d2e8fdfd69a1f2302ff0a6dec3a07a65 AX-Relnotes: fixes an issue where ChromeVox, when using Google tts, speaks haltingly or in an unnatural manner with long pauses within a paragraph of text. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330717 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#951151}
-
Revert "Disable python3 for Linux Chromium OS ASan LSan Builder."
This reverts commit 45ebbfa. Reason for revert: Builder experiences timeouts even without recipe running under python3. Original change's description: > Disable python3 for Linux Chromium OS ASan LSan Builder. > > Using python3 is causing the builder to exceed its timeout. > > Bug: 1278451, 1256388 > Change-Id: I2ad58fc1ec1cb67ca15942ec3bcfbb516730f834 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328761 > Auto-Submit: Garrett Beaty <gbeaty@google.com> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950232} Bug: 1278451, 1256388 Change-Id: Ibc2dd4d28cd519bef439a47ea58a35d631493087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335418 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/main@{#951153}
-
Add/update DIR_METADATA for sensors/battery/vibration directories in …
…WPT. Ensure all directories have wpt.notify enabled and set monorail.component and team_email accordingly. Change-Id: Idfaed1debf0765f00594ec735b20d9f65793a749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332079 Auto-Submit: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#951154}
-
Import wpt@6c002bca6b6bae78d016ec9ce77baf4a9517b720
Using wpt-import in Chromium 1baf853. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox external/wpt/css/css-sizing drott@chromium.org: external/wpt/css/css-text-decor drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts dtapuska@chromium.org: external/wpt/uievents jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/css-writing-modes nsatragno@chromium.org: external/wpt/webauthn rego@igalia.com: external/wpt/css/css-grid external/wpt/css/css-ui external/wpt/css/selectors external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/selectors4 rmcilroy@chromium.org: external/wpt/requestidlecallback NOAUTOREVERT=true No-Export: true Change-Id: I23f9acc3a440982c7ba87f7543f5ea117954fc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3333638 Reviewed-by: Kyle Ju <kyleju@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/main@{#951161}
-
Increase timeout on mac-official bot
Bug: 1279290 Change-Id: Ic4a193a87673a74c19c085dacb113243e26c459f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335099 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#951162}
-
Test outside of IDL conversions for CanvasFilter
From the discussion here (whatwg/html#6763) we need to explicitly test all possible types of inputs for filter attributes. Bug: 1201359 Change-Id: I5ef5905298a17310e4eb54c3c01ab8d6b7973737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320960 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#951163}
-
Prevent the live caption toggle from changing the title of the live c…
…aption toggle This CL prevents toggling of the live caption toggle from changing the title of the live caption toggle. Once the live caption toggle is enabled, the download progress should not be interrupted even if the toggle is quickly disabled. Bug: 1276913 Change-Id: I1797acfd8c4f729a00a729ba482981119089235b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319398 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/main@{#951165}
-
Remove unneeded framework work arounds in Android accessibility code
This CL removes some work arounds that have been part of the Android accessibility code base for some time, but no longer seem to be needed because the Android framework has patched the bugs. We remove logic to unfocus and refocus a node during scroll, and a call to postInvalidate, both of which are not needed at this point. This will result in a more performant experience because we are generating less events for AT to process. AX-Relnotes: N/A Bug: b/209635489 Change-Id: I2ce65976deee3ff4bbcb00b3ef7965c3c39288ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331370 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/main@{#951167}
-
Disable OOP-C on ChromeOS with legacy video decoder
VDA video decoder on ChromeOS relies on legacy mailboxes and is not compatible with OOP-C. Bug: 1245342 Change-Id: I315e98fdd2087d685d995dd51e4f54bbeccb2f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330479 Reviewed-by: Justin Novosad <junov@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#951168}
-
settings: fix UI issues in security keys credential management dialog
This addresses an issue with the edit page of the "Manage sign-in data" dialog of the Security Keys settings subpage, where the "username" and "name" fields had the existing value set as a placeholder. Instead, set it as the field's value, in consistency with other settings edit dialogs. Also fix misalignment of the headers on the overview page. Fixed: 1275361,1275362 Change-Id: Iffb74c8ecf35c6369cf038b38974c370a87ee75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331516 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/main@{#951170}
-
[GMNext] Make blue text dynamic except CTA/links/URLs
Bug: 1241971 Change-Id: I69fc34f9f00ffc952c0cee6e814e3ba5cbcb7046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315652 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#951171}
-
[devtools] Migrate IdleTask to use AsyncTaskContext
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I17d59aabedac9e8943dd67b826556374f64ee12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322612 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951184}
-
Reland "Mac: enable ThinLTO (without unit splitting)"
This reverts commit 397efe0. Reason for revert: Timeout on bot was increased Original change's description: > Revert "Mac: enable ThinLTO (without unit splitting)" > > This reverts commit 810d213. > > Reason for revert: Suspecting causing infra failure. > > Original change's description: > > Mac: enable ThinLTO (without unit splitting) > > > > Splitting is currently blocked on supporting N_INDR symbols in lld. > > > > Bug: 471146 > > Change-Id: Iacc2288d8307fdf730d92d0bfc7f3286d0162b92 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328741 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#950412} > > Bug: 1279290 > Change-Id: If82f13cf72eb7a42430dbda9d5af534efd77f5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332866 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: My Nguyen <myy@chromium.org> > Owners-Override: My Nguyen <myy@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950944} Bug: 1279290 Change-Id: I42d2f45910992dcd02912a10e080d4392253b31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334918 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/main@{#951187}
-
Revert "android: ModernLinker: avoid dl_iterate_phdr"
This reverts commit d485b6f. Reason for revert: crbug.com/1278078 (crashing in ModernLinkerJni_nativeUseRelros) Original change's description: > android: ModernLinker: avoid dl_iterate_phdr > > According to Canary data produced by > "*.ModernLinkerIteratePhdrTime": > > 1. on Android S, iterating the libraries takes about 500ms on 95th > percentile > > 2. for iterating on pre-S the equivalent statistic measures at 180ms. > > Most likely this is due to locking around link map, and having many > libraries loaded. Haven't investigated further. > > Instead take the program headers at known offset from the load_address. > This must be near instant. > > Bug: 1154224 > Change-Id: I8b604f982a178e9b1cc0fc2f94e9062a610652f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317431 > Reviewed-by: Benoit Lize <lizeb@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948993} Bug: 1154224 Change-Id: I55a488388420e54ab1187ba628f3accda3f8b858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332082 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951188}
-
Fix CHECK in RenderProcessHost::ForEachRenderFrameHost.
ForEachRenderFrameHost assumes each RFH in render_frame_host_id_set_ can be found by FromID. However, in some cases (e.g., bfcache eviction), the subframes are destroyed via the main frame's destructor, in which case the main frame is still in the set but is no longer discoverable by FromID. This CL avoids a crash if ForEachRenderFrameHost is called in such a scenario by skipping such RenderFrameHosts. Bug: 1278952, 1265859 Change-Id: I589c24a2cb7c8ca0e923e0b2820a96fface80fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330548 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Charles Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951190}
-
[Gamepad] Implement WgiDataFetcherWin::GetGamepadData
This CL is a continuation of the work started in https://crrev.com/c/2689550. This CL is part of the feature to make Windows.Gaming.Input (WGI) turned on by default on Chromium. WGI will provide game controller support on Windows 10 desktop. The WGI also provides support for gamepad-specific Plug & Play APIs. This CL adds Windows.Gaming.Input (WGI) GetGamepadData functionality to be able to retrieve button and joystick input. Moreover, it also adds fake COM classes implementations along with tests using them. This CL does not address the issue with the Nexus (Xbox) button not being exposed. Bug: 1098876 Change-Id: Icc0008e3b7b7520d30707af601d50b564970c0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304117 Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Gabriel Brito <gabrielbrito@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951191}
-
[cc/metrics] Add some diagnostics to FrameSequenceTracker traces.
For each 'Frame' under FrameSequenceTracker, include a couple of details to help with diagnostics: frames expected, and frames dropped. BUG=1256879 Change-Id: Id7e994fed477d40729c4a0a6625e8173791d0abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331120 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951193}
-
Port chrome-only dialog tests to WPT part 5
Fixed: 1240798 Change-Id: I783a6ade2576221f235cce59caa79876e7193423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315779 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951195}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.