[pull] main from chromium:main #82
Merged
Commits on Dec 10, 2021
-
CodeHealth: Refactor extensions::Manifest::{GetBoolean => FindBoolPath}
Bug: 1187033 Change-Id: Ia3fae8fd94fdc6343f1466da039d831efc971bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320658 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Auto-Submit: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#950667}
-
Add tracing categories to rendering performance tests
This change adds the gpu, blink, cc, v8, and viz tracing categories to all performance test page sets that inherit RenderingStory. These trace categories are specifically relevant for analyzing rendering performance. Bug: 1278501 Change-Id: I9add24abbca9a36ca5be1c6be8d6db98633a1563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328188 Auto-Submit: Justin Novosad <junov@chromium.org> Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/main@{#950669}
-
Reland "Refactors all FileSystemManagerImpl security checks that dire…
…ctly or indirectly call ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin." This is a reland of ef8b0e4 This CL changes the reverted CL by adding nullptr checks before dereferences of FileSystemOperationRunner, which can be become null if the corresponding renderer process terminates before the file system operation is scheduled. After consultation with FileSystemManagerImpl OWNERS, it is safe to simply discard the orphaned file system op in such cases where the requesting renderer is being terminated. Original change's description: > Refactors all FileSystemManagerImpl security checks that directly or > indirectly call ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin. > > Only the Browser UI thread has the necessary data to soundly evaluate > CanAccessDataForOrigin decisions. Therefore, the end goal is to ensure > CanAccessDataForOrigin always executes on the browser UI thread. > > Although all direct & indirect callers of CanAccessDataForOrigin will > eventually need similar refactoring, this CL is an incremental landing; > FileSystemManagerImpl was selected due to its prevalence in test results, > and refactoring will subsequently extend to other subsystems. > > Change-Id: I4eda1355cc879e6731ead32caaad585e899701db > Bug: 1266451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3238053 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Chris Bookholt <bookholt@chromium.org> > Cr-Commit-Position: refs/heads/main@{#947355} Bug: 1266451 Change-Id: I37b9573d2fd0357561619695426219535095b22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318774 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Chris Bookholt <bookholt@chromium.org> Cr-Commit-Position: refs/heads/main@{#950670}
-
[Perf] Handle CRD in rendering.desktop
Share Chrome Remote Desktop detection code between system_health and rendering.desktop benchmarks, to avoid the need to explicitly use --allow-software-compositing flag while running rendering.desktop over CRD. Change-Id: I71aa62fc33e353ed60d7b53f0fc1c6a570fc1638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330547 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/main@{#950671}
-
Revert "[Test] Fix flaky test TosAndUmaFirstRunFragmentWithEnterprise…
…SupportTest" This reverts commit efd7df0. Reason for revert: Tests started reliably failing on android-11-x86-rel Original change's description: > [Test] Fix flaky test TosAndUmaFirstRunFragmentWithEnterpriseSupportTest > > This cl replaces the manual view checks with espresso to reduce > flakiness. > > Bug: 1275120 > Change-Id: I900cbb6c4105c6b875ab6d908eed4367aa059a16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320246 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/main@{#950533} Bug: 1275120 Change-Id: Iea5670c2caf3389480ccdfdef5001a0ecd022019 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331365 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Patrick Noland <pnoland@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/main@{#950672}
-
[scheduler] Allow idle tasks to be posted from any thread
The comments for PostIdleTask and PostDelayedIdleTask both indicate they can be called from any thread, but there is a thread-check in IdleHelper::IdleTaskRunner(), preventing idle tasks from being posted to the main thread from background threads. The code for these methods was *mostly* thread-safe, e.g. using thread-safe ref counting and deferring delegate callbacks via posting a task when necessary, but PostDelayedIdleTask was not thread-safe because of how pending tasks were queued locally. This CL does the following to enable idle tasks posting from multiple threads: - Remove the thread check in IdleHelper::IdleTaskRunner() - Defer (via PostTask) queueing the delayed idle task if called cross-thread - Use WTF::CrossThreadBindOnce instead of WTF::Bind in V8IdleTaskRunner (this fix is to enable a V8 feature, so these some v8 idle tasks will be cross-thread) - Add unit tests for cross-thread posting Bug: 1276997 Change-Id: I408daa3ab737844831a0a38ce4996111204b1410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322137 Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/main@{#950673} -
Settings: Migrate people_page/ tests to TypeScript, part 1.
Bug: 1263610 Change-Id: Id7a935e92ae9bc2a51696f1e4e812ccf23a406cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329662 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#950675}
-
[Sheriff] Add missing HRESULT type to upgrade_util_win
Bug: 1252004 Change-Id: Ibf439502fafc0cef0cc61e56a35b26315ed95aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330968 Owners-Override: Dominique Fauteux-Chapleau <domfc@google.com> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by: Chong Gu <chonggu@google.com> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#950677}
-
Add thread enforcement to cc types via DCHECK
This instruments cc code with DCHECK(IsMainThread()) and DCHECK(IsImplThread()) to ensure methods are only called on the appropriate thread. The enforcement is focused on Layer, LayerTreeHost, and AnimationHost, since these are the classes that drive compositor commit. Adding the DCHECKs required SingleThreadProxy to be more systematically annotated with DebugScopedSetMainThread and DebugScopedSetImplThread. In particular: - All Proxy method overrides now DCHECK(IsMainThread()) - All SchedulerClient method overrides now DCHECK(!HasImplThread() || IsImplThread()) - All LayerTreeHostImplClient method overrides force the impl thread In places where SingleThreadProxy code conceptually jumps the thread boundary (e.g., by interleaving method calls on LayerTreeHost and LayerTreeHostImpl), the code is annotated to force main or impl thread as appropriate. Bug: chromium:1255972 Change-Id: Ib7a05227e9e63e6bcb33ce2beebf53951f1d1352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312881 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/main@{#950678} -
[shared storage] Support keep-alive after document is destroyed
What: After the document is destroyed, the worklet will live until 2 seconds after, or when the outstanding operations are all completed, whichever occurs first. Why: end-of-page operations are more likely to finish. How: keep 2 types of hosts in SharedStorageWorkletHostManager: "attached" and "keep-alive". When the document is destroyed, the one in the "attached" group will be either removed, or be moved to the "keep-alive" group accordingly. The keep-alive host will be removed from its group 2 seconds after, or when the worklet's outstanding operations are all completed, whichever occurs first. Design doc: https://docs.google.com/document/d/1rH6m4SS5QsUTsh9VBGIQecs1Y0PWEF9qFBTqYRqQ7-c Bug: 1218540 Change-Id: Ied26d33c80f53498b8419d50a62b1f137d565971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244721 Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/main@{#950680}
-
WebUI: Convert some MWB shared files to TypeScript.
All clients of these files have already been migrated. Also fixing a few cases where some TS files where accidentally included in the generated grd file, along with the transpiled JS file. Bug: 1189595 Change-Id: I61021468df9f34d6d278342fc65f3d57683e059d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330236 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#950682}
-
Change id and text to accomplish recent site change
Bug: 1278535 Change-Id: I1f2af93f9993d0f55bc6d15bd95d60a49988579c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330325 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#950683}
-
[reclient] Remove linux-rel-reclient experimental tryjob.
This was a tryjob that was doing performance tests for gvisor support. It is no longer needed, and it is potentially having problems due to the obsolete buildspec clean up from a couple days ago. Bug: n/a Change-Id: I92e60d1c2f7fe266286c79ea285cbffccc2421c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330736 Reviewed-by: Haiyang Pan <hypan@google.com> Commit-Queue: Michael Savigny <msavigny@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#950684}
-
shimless: minor cleanup in firmware update page
Addresses comments from crrev/r/3318749 Bug: 1198187 Change-Id: Ib5178bf71d336158aeb4723de76cf813d6840543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331258 Commit-Queue: Gavin Dodd <gavindodd@google.com> Auto-Submit: Gavin Dodd <gavindodd@google.com> Reviewed-by: Gavin Williams <gavinwill@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/main@{#950690}
-
[PCScan] Add PCScan_Effective_Fallback synthetic Finch
As much as we believe that PCScan experiment wouldn't be biased by disabled-but-*-way-split modes of BRP experiment, there is a slight chance that it would. Adding PCScan_Effective_Fallback just in case, which ignores those modes entirely. Looking at the design and cl/414999087 (internal only), PCScan_Effective compares groups (A1+C1+E1+F1) vs. (A2+C2+E2+F2), whereas BackupRefPtr_Effective_Fallback compares only (A1+F1) vs. (A2+F2). Using BackupRefPtr_Effective_Fallback is far from ideal, because it limits the tested population to 2*14%, from 2*32%, but nice to have a fallback. [1] https://docs.google.com/document/d/1HJsFHpvi2V84suIao6WW41TLc36ZoMR6pmSanI6E7rk/edit Bug: 1278582 Change-Id: I44e6219e869cbecd7fab3e0f29a55120036b4fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329052 Reviewed-by: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Weilun Shi <sweilun@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/main@{#950691}
-
CodeHealth: Remove extensions::Manifest::GetInteger
Add extensions::Manifest::FindIntPath but there are no callers now. Bug: 1187034 Change-Id: I543a6e8c513764be9705acc3aaeaf93e3e6cd53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320691 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Auto-Submit: Li-Yu Yu <aaronyu@google.com> Cr-Commit-Position: refs/heads/main@{#950692}
-
Put relative paths in mojom .build_metadata files
After this, `diff -qr out/gn1 out/gn2` doesn't find any difference after running `rm -rf out/gn1 out/gn2; gn gen out/gn1; gn gen out/gn2`. I arbitrarily chose to make the paths relative to the directory containing the file. Another option would have been to make them relative to the build directory (and access that via os.getcwd() in mojom_parser.py). Both seem equally good to me. No intended behavior change. Bug: 1278777 Change-Id: I20cddd7e155110c0e2e73410564d1a70a5d777b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330578 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/main@{#950693}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.