[pull] main from chromium:main #108
Merged
Commits on Dec 14, 2021
-
Reland "Enable C++17 on linux (including in CFI builds)"
This is a reland of c8494f8 The reland updates the lacros toolchain to https://reviews.llvm.org/D115015 so that CFI works with C++17 there too now. Original change's description: > Enable C++17 on linux (including in CFI builds) > > The prerequisite rolled in in > https://chromium-review.googlesource.com/c/chromium/src/+/3315436 > > With this, all platforms use -std=c++17. > Please don't rely on that yet though: > - it's not yet clear that this is going to stick > - we'll send out guidelines on how we'll adopt C++17 features > > Bug: 1273966,752720 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng > Change-Id: Icda9a95b159b8ae6fd1f74095fea7913343d210a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308459 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/main@{#948345} Bug: 1273966,752720,1276731 Change-Id: Iaf61c355a0a183905c34d14dfb22d034b01807ea Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: luci.chrome.try:lacros-amd64-generic-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3316556 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951375}
-
Optimization: Parse the stream to assign temporalID.
On Windows, we should parse the temporal SVC stream to get temproalID, instead of relying on an external state machine. This CL aims to increase code robustness. Bug: 1203743 Change-Id: I6925a71f4a4b3d27db2d14082918446cdf1114a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314901 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#951378}
-
CCA: Migrate i18n_string.js and views/crop_document.js to TypeScript
Bug: b:172340451 Test: tsc compiles Test: tast run <ip> camera.CCAUISmoke* camera.CCAUIStress* camera.CCAUIDocumentScanning* Change-Id: Ic5a6735f86405fe5a5ca84f73ea463404f59c331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295290 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951379}
-
Roll src/third_party/cros_system_api/ 48bb7e747..725259a4b (12 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/48bb7e7474f0..738cc02fc3be $ git log 48bb7e747..738cc02fc --date=short --no-merges --format='%ad %ae %s' 2021-11-30 jthies typecd: Send notification on invalid dp cable 2021-11-18 genechang system_api: rmad: Add proto for state transition in sensor calibration 2021-11-21 charleszhao hps: Add average filter and tristate. Created with: roll-dep src/third_party/cros_system_api Bug: 206145370 Change-Id: I8c8263ddc8ea0527f1af698eda5a34ade9e71778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331438 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Jameson Thies <jthies@google.com> Commit-Queue: Jameson Thies <jthies@google.com> Cr-Commit-Position: refs/heads/main@{#951382}
-
Revert "Reland "desk_templates: Add a browsertest for launching ARC a…
…pps."" This reverts commit 1bc19c7. Reason for revert: Causing test failures of: DesksTemplatesClientArcTest.NativeUILaunchTemplateWithArcApp https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/26838/overview Original change's description: > Reland "desk_templates: Add a browsertest for launching ARC apps." > > This is a reland of 1e46619 > > Original change's description: > > desk_templates: Add a browsertest for launching ARC apps. > > > > While adding, saw two crashses, one regarding the app icon size and the > > other with the cpu usage. > > > > I cleared the first one by adding test resources for 28 and 56 dp. In > > desks templates, we show a preview that consists of app icons of size > > 28, so the test tries to fetch those sizes. > > > > The second one was handled by clearing the probe service when stopping > > CPU usage count. > > > > Test: added > > Change-Id: Ib60961913e992df8f08be0311099c20e88e745ee > > Fixed: 1251403 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319378 > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Jeremy Chinsen <chinsenj@chromium.org> > > Reviewed-by: Yury Khmel <khmel@chromium.org> > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#950300} > > Change-Id: I446bf159aeb345588dde2b681104a70ac239385b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331655 > Reviewed-by: Jeremy Chinsen <chinsenj@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951287} Change-Id: I03569dcd47c9248e2bc23d13747d56764eb489ed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336810 Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Owners-Override: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951383}
-
Revert "What's New: Fix session restore case"
This reverts commit 4cb01cb. Reason for revert: Suspicious about causing test failures of: SessionRestoreTest.RestoreAllBrowsers https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/2442/overview Original change's description: > What's New: Fix session restore case > > https://chromium-review.googlesource.com/c/chromium/src/+/3275312 > changed the What's New logic for M98 to only open a tab if the > page exists for a given milestone. However, it missed the case of > session restore, where the startup tabs aren't opened by the startup > browser creator and are instead passed to session restore. This CL > updates the session restore logic to match the startup browser > creator logic, so that no What's New tabs are opened unless there is > a page corresponding to the current milestone. > > Bug: 1271106 > Change-Id: Ibc47ffd21aef42a18a80627d76f7f7fc67ed80cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331237 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951356} Bug: 1271106 Change-Id: I8e5ad5d2ca702235ea2e7ac129917df7ccfbc15b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337645 Owners-Override: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951387}
-
Rebaseline-cl tool migration to ResultDB - '--test-name-file' option …
…works. Listing the tests in files or positional args works. Continuing to work on autocomputation in a separate CL. This is Flag protected with '--resultDB' to not block the current rebaseline flow during the migration work. Bug: 1213998 Change-Id: Iba79cdf4f6e5a931ca8283e50ff52de94a995323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3313503 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Preethi Mohan <preethim@google.com> Cr-Commit-Position: refs/heads/main@{#951391}
-
sheriff: Disable failing WPTs of css/css-masking/
Bug: 626703 Change-Id: I33b96922631084a30904e297655477378ad2787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337376 Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Owners-Override: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#951394}
-
[FenceFrame] Restrict WebUI mojo binding to outermost main frame
It restricts the use of WebUI related functionality to only the outermost main frame by replacing all instances of `GetParent` from the WebUI code with `GetParentOrOuterDocument` method. `GetParentOrOuterDocument` determines whether a frame is the outermost main frame of a tab boundary. Bug: 1248452 Change-Id: Ib0b8e1619cfbf250d6dd5afd513d8fcbf0f4577d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211907 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/main@{#951395}
-
media: Update MEDIA_MOJO_EXPORT
Define it using COMPONENT_EXPORT which is recommended. Change-Id: I79c407d3de532c4b3cd082a78076a711e9a56f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337087 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951396}
-
media: Rename MF_INITIALIZER_EXPORT to MF_UTIL_EXPORT
This export has been used in places outside mf_initializer.h. So update the name to reflect the current state. Also use COMPONENT_EXPORT to define MF_UTIL_EXPORT which is the new recommended way. Change-Id: Ic654f3c80006bb008008abd8e5ad36eade05c6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336872 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#951397}
-
CCA: Migrate geometry.js to TypeScript
Bug: b:172340451 Test: tsc compiles Change-Id: I00dfcaffa4f8b7301641bcb816a8609a01365b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3295295 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951398}
-
[mparch] Update NavigatingFrameType to FrameType
This CL renames NavigatingFrameType to FrameType and moves the code for the decision of the frame type to FrameTreeNode. It handles shadow-dom based FFs as kSubframe to keep consistency with the other methods such as NH::GetParent. This is a follow-up of https://crrev.com/c/3229285 Bug: 1267506 Change-Id: I17baf85009e2d17bca3c2b597827ed3d06a6fd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301351 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Owners-Override: Alexander Timin <altimin@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/main@{#951399}
-
ARC ime_mojom_traits.{cc|h} somehow had a separate build target, rather than being part of the mojom target (like other traits files). This CL fixes that by making those two files part of //ash/components/arc/mojom target, and removing the separate traits targets. Bug: b:206686476 Test: CI. It fixes a build issue in crrev.com/c/3330797 Change-Id: Ie66fdd11ebd823e2832be3fd5bb79275827be9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336596 Auto-Submit: Yao Li <yaohuali@google.com> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951403} -
CrOS: Migrate chrome://power to JS modules.
As part of the migration also: - Added type-checking (with Closure) and fix newly found errors. - Replaced chrome.send/CallJavascriptFunctionUnsafe with sendWithPromise/ResolveJavascriptCallback Bug: 1173575 Change-Id: I3e36088a28f2670f07f987c24647e53fe16d527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334564 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#951407}
-
Introduce LayoutNGView, behind a runtime feature flag.
This will be needed by LayoutNG printing. Because LayoutView() / LayoutNGView() doesn't take an Element parameter, but rather a Document, we have to change the constructors for all LayoutObject classes that are inherited by LayoutNGMixin. There should be quite a few issues to fix before we can enable this, but for now, just fix the bare minimum to be able to get Chrome to show its startup page without crashing, and also work with most / some (I tested a couple, and they worked) sites. Bug: 1121942 Change-Id: I593b60d3fbceb7e2991347674ae13ac50860b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330276 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951409}
-
Extend enable-unsafe-webgpu flag to M101
WebGPU is still at its origin trial till M101. extend this flag to M101 will help unblock current WebGPU devs for their local development Bug: 1279617 Change-Id: I58905a05300c6c34d17f286deb874c121e9c595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337397 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951412}
-
media/gpu/vaapi: make VA-API lock configurable
All threads in GPU process acquire a common lock whenever calling VA-API functions, because VA-API didn't ensure thread safety. The statement of thread safety has been added since libva 2.10.0 [1]. However, the thread-safety of libva depends on backend implementation. This CL introduces a feature switch |kGlobalVaapiLock| to control whether VaapiWrapper should run without a global lock should be used in VaapiWrapper when the backend implementation is thread-safe and |enforce_sequence_affinity_| is true. Current default value of the switch is ENABLED, this CL doesn't change the lock behavior in VA-API. Instead of removing the locks at once, we are going to experiment disabling the lock via a finch experiment with the switch. The benefits are: - It will reduce the latency as avoiding cpu lock - It will reduce the gpu power as converging jobs for gpu parallel execution - It will optimize the throughput for gpu which has multiple hw decoder/encoder instances Intel iHD driver is thread safe, allowing parallel VA-API calls. [1] intel/libva#347 Bug: 1123429, b:182008564 Co-Authored-By: hiroh@chromium.org Change-Id: I7da8a787d7d48b394921056da64eaa84ebec1377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139873 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951415}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.