PHP backports for WP 6.6

[ellatrix]

We'd like to start backporting the necessary PHP code as soon as possible to catch issues early so that it doesn't block the package release process.

• Guide: Back-merging code to WordPress Core.
• If an item does not need backporting, or was already backported, please strike it out.
• Please open a new Core Trac ticket for each PR and link it next to the citation in this issue.
• For ease of cross-linking and tracking, you can submit your PRs to WordPress/wordpress-develop. Refer to docs on how to fork the repository and create a PR. Link any backport PR next to the citation in this issue.
• Try to limit PRs to one feature to make reviewing easier and the commit history clear. See why.
• Once your backport PR is up, add it to the WordPress 6.6 Editor Tasks project board so people can review it.
• If items belong together, please make a nested list where each item is still a checkbox.
• This issue will be updated every once in a while as we we approach Beta 1, with new lines for any new PHP changes. Last update: 2024-06-03.

Thank you!

---

📁 lib

📁 compat

📁 wordpress-6.6

• small-typo-change #61178 - @shail-mehta | Trac ticket | Core backport PR
  Should be handled in the next item.
• Allow view access of template rest endpoint to anyone with the edit_post capability #60317 +
  • small-typo-change #61178 - @fabiankaegy | Trac ticket | Core backport PR
• [Data Views] User patterns: Use excerpt as description #60549 - @carolinan | Trac ticket | Core backport PR
• Fix PHP notice triggered by 'gutenberg_update_initial_settings' #60862 - @Mamaduka | Trac ticket | Core backport PR
  See next item.
• Display settings 'label' defined by the 'register_setting' method #59243 - @Mamaduka | Trac ticket | Core backport PR
• Add null check to prevent errors in get_block_template filter #60491 - okmttdhr @ellatrix | Trac ticket | Core backport PR
  Handled below.
• Patterns: guard for unknown pattern in server-side resolver #60464 - @ellatrix | Trac ticket | Core backport PR
  Handled below.
• Templates perf: resolve patterns server side #60349 - @ellatrix | Trac ticket | Core backport PR
  • Patterns: guard for unknown pattern in server-side resolver #60464
  • Add null check to prevent errors in get_block_template filter #60491
  • Templates: only resolve patterns for REST API endpoints #61757
• Return an empty object when no fallback templates are found (wp/v2/templates/lookup) #60925 - @creativecoder | Trac ticket | Core backport PR
• Templates API: Fix template files query by post-type #61244 - @Mamaduka | Trac ticket | Core backport PR
• Background image: add support for relative theme path URLs in top-level theme.json styles #61271 - @ramonjd | Trac ticket | Core backport PR
• Output post classes in the editor #60642 - @huubl | Trac ticket | Core backport PR
  - [ ] Site Logo: Add setting labels via the 'register_setting' method #61351 - @Mamaduka | Trac ticket | Core backport PR
  Auto synced
• Quality: fix php warning error #61321 - @t-hamano | Trac ticket | Core backport PR

📁 wordpress-6.5

• Classic Theme: Expose new Patterns page and remove Template Parts submenu #61080 - @t-hamano | Trac ticket | Core backport PR

📁 wordpress-6.4

• Documentation: Fix @todo tags to follow standards in WordPress comments. #60148 - @interdevel | Trac ticket | Core backport PR
  See Documentation: Fix @todo tags to follow standards in WordPress comments. #60148 (comment).

---

📁 block-supports

📄 layout.php

• Fix responsive column span logic on the front end. #60976 - @tellthemachines | Trac ticket | Core backport PR
  See below.
• Apply negative margins for alignfull children of blocks with custom padding set #60716 - @richtabor | Trac ticket | Core backport PR
• Add a Row control to grid layout in manual mode. #60652 - @tellthemachines | Trac ticket | Core backport PR
  Note: this one is due for 6.7.
• Documentation: Fix @todo tags to follow standards in WordPress comments. #60148 - @interdevel | Trac ticket | Core backport PR
  See Documentation: Fix @todo tags to follow standards in WordPress comments. #60148 (comment).
• Add Column Start and Row Start controls to Grid children #59483 - @noisysocks | Trac ticket | Core backport PR
  Note: this one is due for 6.7.
  - [ ] Format PHP inline comments correctly #59452 - @tellthemachines | Trac ticket | Core backport PR
  See below.
• Refactor responsive logic for grid column spans. #59057 - @tellthemachines | Trac ticket | Core backport PR
• Add support for column and row span in grid children. #58539 - @tellthemachines | Trac ticket | Core backport PR
• Check child layout exists before generating classname. #61392 - @tellthemachines | Trac ticket | Core backport PR

📄 elements.php

• Elements: Deprecate old block support filter callbacks #59538 - @aaronrobertshaw | Trac ticket | Core backport PR
• Elements: Merge element style and classname generation to single filter #59535 - @aaronrobertshaw | Trac ticket | Core backport PR
• Generate element classnames from element-specific data #59533 - @tellthemachines | Trac ticket | Core backport PR
  Note: this was superseded by Elements: Merge element style and classname generation to single filter #59535

📄 typography.php

- [ ] #59531 - @t-hamano | Trac ticket | Core backport PR
See below.

• Fluid typography: pass theme.json settings to override merged theme data #58362 - @ramonjd | Trac ticket | Core backport PR

📄 background.php

- [ ] #59889 - @ramonjd | Trac ticket | Core backport PR
See below.
- [ ] #59354 - @ramonjd | Trac ticket | Core backport PR
See below.
- [ ] #61387 - @ramonjd | Trac ticket | Core backport PR
See below.

📄 shadow.php

• Shadow support enable skip serialization for dynamic blocks #59887 - @colinduwe | Trac ticket | Core backport PR

📄 duotone.php

• Add filter for duotone to account for gutenberg_restore_image_outer_container in classic themes #59764 - @ajlende | Trac ticket | Core backport PR

📄 block-style-variations.php

• Block Styles: Extend block style variations as mechanism for achieving section styling #57908 - @aaronrobertshaw | Trac ticket | Core backport PR

---

📁 experimental

📄 editor-settings.php

• Experiment: Add full page client-side navigation experiment setting #59707 - @SantosGuillamot | Trac ticket | Core backport PR
  Kept as an experiment.
• DataViews: make the experiment about custom views #60813 - @oandregal
  No need to backport as it's Gutenberg-only code.
• Add Grid interactivity #59052 - @noisysocks | Trac ticket | Core backport PR
  Adding an experimental flag, no need to backport.
• Add toggle for grid types and stabilise Grid block variation. #59051 - @tellthemachines | Trac ticket | Core backport PR

📄 kses.php

• Add support for column and row span in grid children. #58539 - @tellthemachines | Trac ticket | Core backport PR

📄 blocks.php

• Block Styles: Add extended version of register block style functions #61029 - @aaronrobertshaw | Trac ticket | Core backport PR

---

📄 class-wp-theme-json-gutenberg.php

• Global Styles: Add scoping of feature level selectors for custom block style variations #61033 - @aaronrobertshaw | Trac ticket | Core backport PR
• Global Styles: Update utils for scoping CSS selectors #61026 - @aaronrobertshaw | Trac ticket | Core backport PR
• Theme JSON: Extract util to get valid block style variations #61030 - @aaronrobertshaw | Trac ticket | Core backport PR
• Add defaultFontSizes theme.json (theme.json v3) #58409 - @ajlende | Trac ticket | Core backport PR
• Try: Add new textAlign block support #59531 - @t-hamano | Trac ticket | Core backport PR
  • Fix: Enable Text Align UI to be controlled correctly with theme.json #61182 - @t-hamano | Trac ticket | Core backport PR
• Global styles: background UI controls #59454 - @ramonjd | Trac ticket | Core backport PR
• Global styles: output :root selector for CSS custom properties #42084 - @ramonjd | Trac ticket | Core backport PR
• Background block supports: move block support defaults to gutenberg_render_background_support and revert gutenberg_get_background_support_styles #59889 - @ramonjd | Trac ticket | Core backport PR
• Global styles: force root min-height of 100% for backgrounds #59809 - @ramonjd | Trac ticket | Core backport PR
• Theme JSON: remove unused vars in layout class #59938 - @ramonjd | Trac ticket | Core backport PR
• Fluid typography: pass theme.json settings to override merged theme data #58362 - @ramonjd | Trac ticket | Core backport PR
• Global styles: add background image to top-level theme.json styles #59354 - @ramonjd | Trac ticket | Core backport PR
• Format PHP inline comments correctly #59452 - @tellthemachines | Trac ticket | Core backport PR
• Enqueue block custom CSS only when block renders on the page. #58991 +
  • Added @return after @global in php doc #60611 - @tellthemachines | Trac ticket | Core backport PR NOTE: these changes aren't stable enough to go into core this cycle so let's leave them for 6.7.
• Theme JSON: Check for null values to cater for blockGap #59258 - @ramonjd | Trac ticket | Core backport PR
• Add aspect ratio presets support via theme.json #47271 - @fabiankaegy | Trac ticket | Core backport PR
• Background images: remove required "file" prop #61387 - @ramonjd | Trac ticket | Core backport PR
• Background images: remove lingering "file" prop #61469 - @ramonjd | Trac ticket | Core backport PR
• Styles: try wrapping with :root to fix reset styles #61638 - @tellthemachines | Trac ticket | Core backport PR
  • Try reducing specificity of global styles selectors only. #60106 - @tellthemachines | Trac ticket | Core backport PR
  • Try reducing specificity of layout style selectors #60228 - @tellthemachines | Trac ticket | Core backport PR
  • Reduce specificity of global styles body margin reset rule. #61340 - @tellthemachines | Trac ticket | Core backport PR

---

📄 class-wp-theme-json-data-gutenberg.php

• Remove additional call to WP_Theme_JSON_Gutenberg::__construct #61262 - @kt-12 | Trac ticket | Core backport PR

---

📄 class-wp-rest-global-styles-controller-gutenberg.php

• Workflows: test to check for label and skip backport changelog #61808 - @ramonjd | Trac ticket | Core backport PR

---

📄 class-wp-theme-json-schema-gutenberg.php

• Fix WP versions for theme.json v3 migration in inline docs #61328 - @ajlende | Trac ticket | Core backport PR

---

📄 global-styles-and-settings.php

• Added @return after @global in php doc #60611 - @shail-mehta | Trac ticket | Core backport PR
  Should be handled with Enqueue block custom CSS only when block renders on the page. #58991.

---

📄 interactivity-api.php

• Interactivity API: Include preact/debug when SCRIPT_DEBUG is enabled #60514 - @DAreRodz | Trac ticket | Core backport PR

---

📄 class-wp-duotone-gutenberg.php

• Add filter for duotone to account for gutenberg_restore_image_outer_container in classic themes #59764 - @ajlende | Trac ticket | Core backport PR
  See above

---

📄 blocks.php

• Fix enqueuing block theme styles when separate asset loading is enabled. #60098 - @tellthemachines | Trac ticket | Core backport PR Note: this was a Gutenberg-only fix, no need to sync to core.
• Add featured image to Media & Text block #51491 - @carolinan | Trac ticket | Core backport PR
  Automatically synced
• Add block class name to the list block #56469 - @carolinan | Trac ticket | Core backport PR
  Automatically synced

---

📄 client-assets.php

• Added @global to PHP Docs Comments #59725 - @shail-mehta | Trac ticket | Core backport PR
  GB only code.
• React: Upgrade to the new JSX transform  #61692 - @youknowriad | Trac ticket | Core backport PR

---

📁 phpunit

• Theme JSON Tests: Refactor base styles to a static variable #58975 - @scruffian | Trac ticket | Core backport PR
  NOT URGENT
• Shadow: add unit tests for shadow support #60063 - @madhusudhand | Trac ticket | Core backport PR
  Has item above.

The rest is tracked in items above, not sure why these are duplicated.

• Global Styles: Add scoping of feature level selectors for custom block style variations #61033 - @aaronrobertshaw | Trac ticket | Core backport PR
• Elements: Deprecate old block support filter callbacks #59538 - @aaronrobertshaw | Trac ticket | Core backport PR
• Try reducing specificity of layout style selectors #60228 - @tellthemachines | Trac ticket | Core backport PR
• Try reducing specificity of global styles selectors only. #60106 - @tellthemachines | Trac ticket | Core backport PR
• Global styles: output :root selector for CSS custom properties #42084 - @ramonjd | Trac ticket | Core backport PR
• Background block supports: move block support defaults to gutenberg_render_background_support and revert gutenberg_get_background_support_styles #59889 - @ramonjd | Trac ticket | Core backport PR
• Global styles: force root min-height of 100% for backgrounds #59809 - @ramonjd | Trac ticket | Core backport PR
• Fluid typography: pass theme.json settings to override merged theme data #58362 - @ramonjd | Trac ticket | Core backport PR
• Elements: Merge element style and classname generation to single filter #59535 - @aaronrobertshaw | Trac ticket | Core backport PR
• Global styles: add background image to top-level theme.json styles #59354 - @ramonjd | Trac ticket | Core backport PR
• Theme JSON: Check for null values to cater for blockGap #59258 - @ramonjd | Trac ticket | Core backport PR
• Add support for column and row span in grid children. #58539 - @tellthemachines | Trac ticket | Core backport PR
• Navigation Block: Add test coverage to check that post content is not removed #60189 - @ockham | Trac ticket | Core backport PR
• Remove Gutenberg font face tests #59402 - @matiasbenedetto | Trac ticket | Core backport PR
  These were removed because they are now part of core.
• Style engine: rename at_rule to rules_groups and update test/docs #58922 - @ramonjd | Trac ticket | Core backport PR
• Background images: remove required "file" prop #61387 - @ramonjd | Trac ticket | Core backport PR
• Global Styles: Add block-level Text Alignment UI #61717 - @t-hamano | Trac ticket | Core backport PR

---

📁 packages

📁 style-engine

📄 class-wp-style-engine-css-rule.php

• Style engine: rename at_rule to rules_groups and update test/docs #58922 - @ramonjd | Trac ticket | Core backport PR

---

People

• @shail-mehta
• @fabiankaegy
• @carolinan
• @Mamaduka
• @ellatrix
• @interdevel
• @tellthemachines
• @richtabor
• @noisysocks
• @aaronrobertshaw
• @t-hamano
• @ramonjd
• @colinduwe
• @ajlende
• @SantosGuillamot
• @oandregal
• @DAreRodz
• @ockham
• @scruffian
• @matiasbenedetto
• @youknowriad

[Mamaduka]

I already have a backport ticket for my items. I'll try to finalize it this week. Ticket - https://core.trac.wordpress.org/ticket/61023.

[oandregal]

I've marked #60813 as done and left a comment: this is gutenberg-only code that doesn't need to be backported.

[colinduwe]

Here's the backport ticket for shadow.php
https://core.trac.wordpress.org/ticket/60784

[tellthemachines]

I have a draft in progress for the style engine changes; updated the description with the link.

At this point it's unlikely that #59483 and #60652 will be added to core. I've left them on the list so we know they weren't missed but crossed them out with a note.

Also, I think everything inside editor-settings.php can safely be ignored? It's all related to adding and removing Gutenberg experiments.

[aaronrobertshaw]

There's a single backport (WordPress/wordpress-develop#6214) to cover both #59535 & #59538 for the elements block support.

[t-hamano]

I added #61080 to the list.

[aaronrobertshaw]

Backports are now available for:

• Global Styles: Add scoping of feature level selectors for custom block style variations #61033
• Global Styles: Update utils for scoping CSS selectors #61026
• Theme JSON: Extract util to get valid block style variations #61030

Ticket and backport PR links have been added to this issue's description.

[tellthemachines]

Draft for grid column and row spans here, still needs adding tests.

[fabiankaegy]

I added #47271 to the list

[petitphp]

PR Block editor: localize search suggestions' post type in LinkControl component is ready to be merged.

Associated backport is available : Trac ticket | Core backport PR

[scruffian]

Added a PR and a ticket for the theme JSON changes.

[scruffian]

Added a PR and a trac ticket for the Duotone backport.

[joemcgill]

Not sure where this belongs, necessarily, but #61262 is being applied to Core in https://core.trac.wordpress.org/ticket/61112.

[aaronrobertshaw]

Added a PR and trac ticket for extension to block style registration.

[ellatrix]

Updated the issue with the latest PRs until today.

[t-hamano]

Just a question; Should we add the gutenberg-merge keyword to the core ticket? I couldn't find any documentation about this label.

Similar question on Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1716533231110759?thread_ts=1716367176.433729&cid=C02QB2JS7

[tellthemachines]

@t-hamano yes the Trac ticket should have the gutenberg-merge keyword. It's not in the dropdown but there's an option to add keywords manually. It's been in use for maybe a year or two now, but unsure if it was ever documented - the processes around merging GB to Core keep evolving so documentation tends to quickly become outdated 😅

[aaronrobertshaw]

There's a new backport PR available to cover all the global styles CSS specificity changes from the following Gutenberg PRs:

• Try reducing specificity of global styles selectors only. #60106
• Try reducing specificity of layout style selectors #60228
• Reduce specificity of global styles body margin reset rule. #61340
• Styles: try wrapping with :root to fix reset styles #61638

I've updated the issue description acordingly.

[tellthemachines]

👀 I see that #60716 hasn't been done yet, I'll put up a quick PR for that one!

Edit: done in WordPress/wordpress-develop#6664

[aaronrobertshaw]

Added a PR and Ticket for section styles backport.

[ellatrix]

All backports for Beta 1 are done. In time, I'll create a new (smaller) issues with any new backports for Beta 2.