Reduce specificity of global styles body margin reset rule. #61340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
May 3, 2024
There was a problem hiding this comment.
Great catch, I didn't realise that you could even set root margin spacing since we don't have a control for it in global styles! But editing the theme.json manually and adding the margin rules works nicely with this PR applied in both the post and site editors and on the site frontend.
LGTM! ✨
ramonjd
approved these changes
May 3, 2024
tellthemachines
added
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/18.3 branch to get it included in the next release: 46c1ecb |
pbking
pushed a commit
that referenced
this pull request
May 7, 2024
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
pbking
removed
the
Backport to Gutenberg RC
|
@tellthemachines, I think this change caused a regression for non-iframed editors reported here: #61565 and #61582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #60106, which reduced the specificity of global styles rules generated from theme.json and user settings. Because any base styles defined in theme.json are now output under
:where(body), thebodyrule that resets margin to 0 will override any margins defined in theme.json.This PR reduces the specificity of the body margin reset (it still overrides user agent styles at zero specificity) so it doesn't interfere with theme-defined styles.
Props to @dsas for bringing this to my attention!
Testing Instructions
style.spacing.margin, e.g."top": "20px", "bottom": "20px"Testing Instructions for Keyboard
Screenshots or screencast