Global Styles: Update utils for scoping CSS selectors #61026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
aaronrobertshaw
requested review from
tellthemachines and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ac51ff2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8812471906
|
youknowriad
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Kind of unrelated but I thought about this when reading this PR: The style generation is getting more and more complex, same for theme.json but I think our documentation their doesn't follow yet.
For contributors, we should be explaining how the style generation work... and the different decisions. I'd love it if we add a page dedicated to that to the architecture docs https://developer.wordpress.org/block-editor/explanations/architecture/
|
Thanks for the review @youknowriad 👍
For the most part, the "Styles in the editor" page within the architecture docs seem to cover a lot around style generation. Reading through it, there are a few inaccuracies as well e.g. the second noted limitation on global styles not being able to target some styles to inner nodes etc. I can give those docs a freshen-up when I get to add details around block style variations. Updating this documentation has been added to the Section Styling tracking issue. |
|
Backport for the PHP changes here is available in: WordPress/wordpress-develop#6478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Note: The changes in this PR are being split out from #57908 to make that more manageable
What?
Adds early returns for existing utils that scope CSS selectors to make them more robust and ready for extended block style variations in #57908.
This PR also adds a new util for scoping a collection of feature selectors.
Why?
Testing Instructions
npm run test:unit packages/block-editor/src/components/global-styles/test/utils