Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty object when no fallback templates are found (wp/v2/templates/lookup) #6420

Conversation

creativecoder
Copy link

@creativecoder creativecoder commented Apr 20, 2024

Modifies the wp/v2/templates/fallback endpoint to return a 404 error when no templates are found.

Testing Instructions

  • Activate a classic theme, such as twentyeleven
  • Add a theme.json file to the theme with minimal content (e.g. { "version": 2 })
  • Load a page in the editor
  • You should see a request to /wp-json/wp/v2/templates/lookup respond with an empty object in the browser network tab
  • There should not be any PHP warnings in the error log

Trac ticket: https://core.trac.wordpress.org/ticket/60909
Gutenberg PR: WordPress/gutenberg#60925


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props grantmkin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@creativecoder creativecoder changed the title Return a 404 error when no fallback templates are found (wp/v2/templates/lookup) Return empty object when no fallback templates are found (wp/v2/templates/lookup) May 1, 2024
@creativecoder creativecoder force-pushed the fix/rest-api-template-lookup-php-warnings branch from 3b9816e to 423bf51 Compare May 1, 2024 02:00
@aaronjorbin
Copy link
Member

Thanks! Merged in https://core.trac.wordpress.org/changeset/58079.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants