Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background images: remove lingering "file" prop #61469

Merged
merged 2 commits into from
May 8, 2024

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented May 8, 2024

What?

This PR is a follow up to #61387 - I missed a reference to source in the theme json class in INDIRECT_PROPERTIES_METADATA. Whoops!

The changes were first added in #59454.

The deleted line is not yet in Core, and the changes are already reflected in the latest 6.6 backport PR:

Why?

Janitorial

How?

DELETE

Testing Instructions

The CI tests should pass.

If you're feeling up to it, you could test that there are no regressions to site wide background images in the side editor/frontend.

Here is some test json!

{
	"$schema": "../../schemas/json/theme.json",
	"version": 2,
	"settings": {
		"appearanceTools": true
	},
	"styles": {
		"background": {
			"backgroundImage": {
				"url": "https://images.pexels.com/photos/22484288/pexels-photo-22484288/free-photo-of-the-circular-stone-terraces-of-the-inca-ruins.jpeg?auto=compress&cs=tinysrgb&w=1260&h=750&dpr=2"
			},
			"backgroundSize": "contain"
		}
	}
}

@ramonjd ramonjd added the [Type] Code Quality Issues or PRs that relate to code quality label May 8, 2024
@ramonjd ramonjd requested a review from andrewserong May 8, 2024 03:12
@ramonjd ramonjd self-assigned this May 8, 2024
Copy link

github-actions bot commented May 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

✅ site wide background images are still output in the post and site editors
✅ site wide background images are still output on the site front end
✅ if I manually add a source key to the backgroundImage object, it doesn't affect anything (just in case anyone already has a key added there)

image

LGTM! 🎉

@ramonjd ramonjd merged commit 58480c3 into trunk May 8, 2024
67 checks passed
@ramonjd ramonjd deleted the update/remove-source-prop branch May 8, 2024 04:26
@github-actions github-actions bot added this to the Gutenberg 18.4 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants