Background images: remove required "file" prop #61387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
andrewserong
reviewed
May 6, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced May 6, 2024
Merged
|
Size Change: -22 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thanks for the follow-up! For completeness-sake, and to carry on some of the conversations on related PRs, I like the idea of the explicit source key, but I'm very much in favour of defaulting to an implicit source of file (or url), and deferring optionally including the source key in follow-ups when needed.
For now, I think this approach will make it much simpler for folks building out theme.json files manually 👍
Testing well, and the code change LGTM! 🎉
|
Just noticed this has the |
ramonjd
removed
the
Backport to WP 6.7 Beta/RC
Oh, I got excited, an expected 6.6 to be prepped already. Removed 😆 |
This was referenced May 8, 2024
ramonjd
added a commit
that referenced
this pull request
May 8, 2024
ramonjd
added a commit
that referenced
this pull request
May 8, 2024
* Follow up to #61387 - I missed a source prop Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
May 26, 2024
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
What?
Removes the required "file" prop from background block supports.
Related:
Why?
"File" described a path to an image file. This should be the default so theme developers don't need to add the prop to use images in theme.json
Testing Instructions
There should be no regressions.
Here is some test HTML!