Negative margins for alignfull children of blocks with custom padding. #6664
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
I tested using the instructions over in WordPress/gutenberg#60716
Things are working for me as described!
| 'spacing' => $block_spacing, | ||
| ) | ||
| ); | ||
| if ( isset( $block_spacing ) ) { |
There was a problem hiding this comment.
Does this change deserve a @since?
There was a problem hiding this comment.
Hmm yeah that's a good question. Guess it's better to add one than not!
tellthemachines
force-pushed
the
fix/alignfull-margins
branch
from
95bfa77 to
38241c5
Compare
|
Committed in r58243. |
Trac ticket: https://core.trac.wordpress.org/ticket/61313
Syncs change from WordPress/gutenberg#60716.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.