-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme JSON: Check for null values to cater for blockGap #6169
Theme JSON: Check for null values to cater for blockGap #6169
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
/** | ||
* Tests that the theme.json file is correctly parsed and the variables are resolved. | ||
* | ||
* @ticket 58588 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ticket was committed in 6.3
why we mention it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I added it because it wasn't there when the test was originally added.
It was just for the sake of completeness. I guess it's not really related to this PR and can be removed. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests passed for me and this matches the original PR.
I left two nits.
@youknowriad I think this one is ready once the nits are addressed. |
384607c
to
31b09d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad LGTM
Syncs changes from
When resolving theme.json preset variables, add a check to make sure the value is not empty before we run it through
strpos()
andpreg_match_all()
.Run the tests:
npm run test:php -- --filter Tests_Theme_wpThemeJson
Trac ticket: https://core.trac.wordpress.org/ticket/60613
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.