Quality: fix php warning error #61321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
May 2, 2024
Mamaduka
approved these changes
May 2, 2024
t-hamano
added
the
props-bot
github-actions
bot
removed
the
props-bot
|
This one is not super urgent, but we'll need a backport PR for this. |
|
This code doesn't exist in core because it's a hook for the Gutenberg plugin to override the core menu, so I don't think a backport is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #61080
Props to @Mamaduka for discovering the problem with [this comment]
What?
This PR fixes a warning about undefined $submenu global variable.
Why?
I was initially unable to reproduce this issue in the dashboard. However, for example, I noticed that this warning log is recorded when entering a keyword on the plugin page, that is, when an Ajax request is made.
I'm a little unsure, but I suspect that $submenu will be undefined in certain situations.
Testing Instructions